GNU bug report logs - #46754
28.0.50; Various map.el fixes and improvements

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: nicolas petton <nicolas <at> petton.fr>, 46754-done <at> debbugs.gnu.org
Subject: bug#46754: 28.0.50; Various map.el fixes and improvements
Date: Sat, 06 Mar 2021 17:52:16 +0000

tags 46754 fixed
close 46754 28.1
quit

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> WDYT?
>
> Looks fine to me.  I wouldn't advertise the default `map-insert`
> implementation too much (especially not saying "it works for arrays and
> hash-tables"), since its performance makes it undesirable (and it is
> not specific to hash-tables nor arrays).
>
>> -In the base definition, MAP can be an alist, hash-table, or array."
>> +In the base definition, MAP can be a list, hash-table, or array."
>
> A list isn't a map, so I think it would be better to write "alist/plist" or
> somesuch to avoid giving the impression that lists can be treated as
> maps in general.

Thanks, both points make sense, and I think I addressed them, so I'm
closing this report.

Various map.el improvements
d925121b1e 2021-03-06 16:00:52 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d925121b1e1cdf953705a5da43f8092f2a6e1d8c

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.