From unknown Sat Jun 21 12:33:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46745: 28.0.50; [PATCH] Specify the Emacs version of new vc-dir faces Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2021 09:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 46745@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16141585936857 (code B ref -1); Wed, 24 Feb 2021 09:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Feb 2021 09:23:13 +0000 Received: from localhost ([127.0.0.1]:33313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEqO0-0001mX-Su for submit@debbugs.gnu.org; Wed, 24 Feb 2021 04:23:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:51114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEqNz-0001mQ-Nl for submit@debbugs.gnu.org; Wed, 24 Feb 2021 04:23:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEqNx-00021x-T9 for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2021 04:23:11 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:58295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEqNr-0002Lk-Ph for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2021 04:23:09 -0500 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 95B44200007 for ; Wed, 24 Feb 2021 09:22:58 +0000 (UTC) From: Protesilaos Stavrou Date: Wed, 24 Feb 2021 11:22:55 +0200 Message-ID: <87v9ahq0pc.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=217.70.178.232; envelope-from=info@protesilaos.com; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Dear maintainers, The attached patch renders explicit the version of Emacs in which the new vc-dir faces were introduced. I had contributed those faces a few days ago, but forgot to specify the ':version' property---mea culpa! All the best, Protesilaos -- Protesilaos Stavrou protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Specify-the-Emacs-version-of-new-vc-dir-faces.patch >From 7b5ef8219408a6efe64ed331cde303dd7101e4fd Mon Sep 17 00:00:00 2001 Message-Id: <7b5ef8219408a6efe64ed331cde303dd7101e4fd.1614158325.git.info@protesilaos.com> From: Protesilaos Stavrou Date: Wed, 24 Feb 2021 11:18:38 +0200 Subject: [PATCH] Specify the Emacs version of new vc-dir faces * vc-dir.el (vc-dir-header): (vc-dir-header-value): (vc-dir-directory): (vc-dir-file): (vc-dir-mark-indicator): (vc-dir-status-warning): (vc-dir-status-edited): (vc-dir-status-up-to-date): (vc-dir-status-ignored): Add version 28.1. --- lisp/vc/vc-dir.el | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el index a416474e16..46fbf44861 100644 --- a/lisp/vc/vc-dir.el +++ b/lisp/vc/vc-dir.el @@ -56,39 +56,48 @@ vc-dir-mode-hook (defface vc-dir-header '((t :inherit font-lock-type-face)) "Face for headers in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") (defface vc-dir-header-value '((t :inherit font-lock-variable-name-face)) "Face for header values in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") (defface vc-dir-directory '((t :inherit font-lock-comment-delimiter-face)) "Face for directories in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") (defface vc-dir-file '((t :inherit font-lock-function-name-face)) "Face for files in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") (defface vc-dir-mark-indicator '((t :inherit font-lock-type-face)) "Face for mark indicators in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") (defface vc-dir-status-warning '((t :inherit font-lock-warning-face)) "Face for warning status in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") (defface vc-dir-status-edited '((t :inherit font-lock-variable-name-face)) "Face for edited status in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") (defface vc-dir-status-up-to-date '((t :inherit font-lock-builtin-face)) "Face for up-to-date status in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") (defface vc-dir-status-ignored '((t :inherit shadow)) "Face for ignored or empty values in VC-dir buffers." - :group 'vc) + :group 'vc + :version "28.1") ;; Used to store information for the files displayed in the directory buffer. ;; Each item displayed corresponds to one of these defstructs. -- 2.30.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 24 09:06:01 2021 Received: (at control) by debbugs.gnu.org; 24 Feb 2021 14:06:01 +0000 Received: from localhost ([127.0.0.1]:33928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEunh-0002hz-1B for submit@debbugs.gnu.org; Wed, 24 Feb 2021 09:06:01 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:51949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEune-0002he-Vn for control@debbugs.gnu.org; Wed, 24 Feb 2021 09:05:59 -0500 Received: by mail-wm1-f54.google.com with SMTP id j187so1900948wmj.1 for ; Wed, 24 Feb 2021 06:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ORP8qu3g6oGugfOsNVBbrD1cJ8ELN5I5cFP1akxlS4c=; b=Ajtjzsgv/ZtNP+c1o9witlhR9goYtiXIsNA8OPnKmileU/nsbrcjgobiKqdC2t5lRU ir1ZO3UtbtcCKEDgI4Lz+0yRqBaWwDqV9JjW8hQElUZZUFWK6TmDcVzRpfbzA9jZAVNP SrN9x41CaFmDyJmDTiHMGElrgJubydC2vu7f4lMqoxRt91nhVEJRcMzGQbic5vHxQbOl wU6T4v7VvKk7NkXXlyXjlnDcMfcYYEg8KnsNjU/hZrw2pbrmYPhPVp1Q1JdsSB7eBWa+ l/K34dCEqIDCd4lNTU+5u04/DhWYux6CiHpfqCEGBXnLzHUBj4LIayYLtc3bWnK0kTLe ktzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ORP8qu3g6oGugfOsNVBbrD1cJ8ELN5I5cFP1akxlS4c=; b=JZCaiz5ILewjQZDCpomD42muH0iat4VVn/9y0UZVZ3c2wBsYb8S8cD3u7fYYY0BB3G RMAQ6AkSMkp2QQhlsTRIhpRZANPwSPjhE6o9WQVglc/p6qxYFFtIEhaBiFf1ke/YvpLX OdcynU4shrZ3djgVrOJtwmniL9RKo82GBrq6+z6QGUdD8SLgkBnW5s3BWbNM5ZQlNAZW 4XljxmpJ2wo/MFFLKgPgS9v7H5RFa3BkidbTwIZbb0oasAGrzy1ulrXIrE8krYbgY+mO mGJTAcPqyR0oTpZDlatAW3Kf95iJYsY9V5w6IpDJCw9Qesk7enOf9Y9h9f1SrdxLouey WeyQ== X-Gm-Message-State: AOAM531wpqc3sszKG0qYuISxmcqGBjWt6zKvdvljX16wx+MrgzEOYm8w mOl6oO/Ge4MAMc2+G69R/9R42g== X-Google-Smtp-Source: ABdhPJyKUaPS6Z0jP8uj01QDtkOUHzdx1ADD0XoZoeOP/1qxOTPzWcW8GMweUhGhMoy6weV9ddpQkg== X-Received: by 2002:a1c:1d42:: with SMTP id d63mr3872950wmd.26.1614175553183; Wed, 24 Feb 2021 06:05:53 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id t23sm3292599wmn.13.2021.02.24.06.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 06:05:52 -0800 (PST) From: "Basil L. Contovounesios" To: Protesilaos Stavrou Subject: Re: bug#46745: 28.0.50; [PATCH] Specify the Emacs version of new vc-dir faces References: <87v9ahq0pc.fsf@protesilaos.com> Date: Wed, 24 Feb 2021 14:05:51 +0000 In-Reply-To: <87v9ahq0pc.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Wed, 24 Feb 2021 11:22:55 +0200") Message-ID: <8735xlef28.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 46745-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 46745 fixed close 46745 28.1 quit Protesilaos Stavrou writes: > The attached patch renders explicit the version of Emacs in which the > new vc-dir faces were introduced. I had contributed those faces a few > days ago, but forgot to specify the ':version' property---mea culpa! Thanks, and no worries, it happens all the time here ;). Pushed with a couple of tweaks to the log message to reference the bug#number and remove redundant colons (see CONTRIBUTE and (info "(standards) Change Logs")). Specify the Emacs version of new vc-dir faces 91b37381ea 2021-02-24 13:45:12 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=91b37381eaa8db64965249b5a3a377c51d0afa1b -- Basil From unknown Sat Jun 21 12:33:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46745: 28.0.50; [PATCH] Specify the Emacs version of new vc-dir faces Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Feb 2021 05:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: "Basil L. Contovounesios" Cc: 46745-done@debbugs.gnu.org Received: via spool by 46745-done@debbugs.gnu.org id=D46745.161423248210377 (code D ref 46745); Thu, 25 Feb 2021 05:55:01 +0000 Received: (at 46745-done) by debbugs.gnu.org; 25 Feb 2021 05:54:42 +0000 Received: from localhost ([127.0.0.1]:36428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lF9bm-0002hI-08 for submit@debbugs.gnu.org; Thu, 25 Feb 2021 00:54:42 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lF9bk-0002h5-Ud for 46745-done@debbugs.gnu.org; Thu, 25 Feb 2021 00:54:41 -0500 X-Originating-IP: 94.46.225.161 Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 8CC7820009; Thu, 25 Feb 2021 05:54:33 +0000 (UTC) From: Protesilaos Stavrou References: <87v9ahq0pc.fsf@protesilaos.com> <8735xlef28.fsf@tcd.ie> Date: Thu, 25 Feb 2021 07:54:31 +0200 In-Reply-To: <8735xlef28.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 24 Feb 2021 14:05:51 +0000") Message-ID: <87r1l4n148.fsf@protesilaos.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-02-24, 14:05 +0000, "Basil L. Contovounesios" wrote: > tags 46745 fixed > close 46745 28.1 > quit > > Protesilaos Stavrou writes: > >> The attached patch renders explicit the version of Emacs in which the >> new vc-dir faces were introduced. I had contributed those faces a few >> days ago, but forgot to specify the ':version' property---mea culpa! > > Thanks, and no worries, it happens all the time here ;). > > Pushed with a couple of tweaks to the log message to > reference the bug#number and remove redundant colons > (see CONTRIBUTE and (info "(standards) Change Logs")). > > Specify the Emacs version of new vc-dir faces > 91b37381ea 2021-02-24 13:45:12 +0000 > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=91b37381eaa8db64965249b5a3a377c51d0afa1b I see. Thank you! I used 'log-edit-generate-changelog-from-diff' and gave too much trust to its output... -- Protesilaos Stavrou protesilaos.com