GNU bug report logs - #46722
test-map-into fails

Previous Next

Package: emacs;

Reported by: Glenn Morris <rgm <at> gnu.org>

Date: Tue, 23 Feb 2021 16:23:01 UTC

Severity: normal

Merged with 53365

Found in versions 27.2, 28.0.50, 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: dick <dick.r.chiang <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, smonnier <smonnier <at> iro.umontreal.ca>, Stefan Kangas <stefan <at> marxist.se>, contovob <at> tcd.ie, 46722 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: bug#46722: test-map-into fails
Date: Wed, 05 Jan 2022 13:35:42 -0500
> Also in same function, `method-cache` buys you nothing, so getting rid of
> it along with `with-memoization` and `(require subr-x)` is a not
> insubstantial win.

The benefit of the `cl--generic-dispatchers` cache is probably
negligible in terms of performance, indeed.  Its main purpose is to try
and avoid loading the byte-compiler (e.g. most crucially, it saves us
from *pre*loading the byte-compiler).

The benefit of the `method-cache` OTOH should be very significant since
without it we'd have to recompute the effective method at every call.
This said, I have not measured it.


        Stefan





This bug report was last modified 3 years and 123 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.