From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 11:22:44 2021 Received: (at submit) by debbugs.gnu.org; 23 Feb 2021 16:22:44 +0000 Received: from localhost ([127.0.0.1]:60309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEaSS-0005zk-6U for submit@debbugs.gnu.org; Tue, 23 Feb 2021 11:22:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEaSQ-0005zX-NN for submit@debbugs.gnu.org; Tue, 23 Feb 2021 11:22:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47469) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEaSL-0003MJ-Im for submit@debbugs.gnu.org; Tue, 23 Feb 2021 11:22:37 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1lEaSI-0001mv-Lk; Tue, 23 Feb 2021 11:22:34 -0500 From: Glenn Morris To: submit@debbugs.gnu.org Subject: test-map-into fails X-Spook: ASIS bank KLM Decapitated Extreme weather secure S Box X-Ran: l0+qzUH/LhDrp}0dLw}v;/W/`Zy+als-kjeb\*rg@mm"^`AW9EItEGBu#c)%P$P?B4+MtT X-Hue: brightcyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 23 Feb 2021 11:22:34 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Package: emacs Version: 28.0.50 Something between 8d5dfaf and efe42c2 (inclusive) causes test-map-into to reliably fail on hydra.nixos.org. We can't be more specific since intermediate revisions don't build. So far I could not reproduce the issue. Ref eg https://hydra.nixos.org/build/137474120 (cl-no-applicable-method map-into ((a . 1) (b . 2)) (hash-table :test equal)) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 11:33:53 2021 Received: (at 46722) by debbugs.gnu.org; 23 Feb 2021 16:33:53 +0000 Received: from localhost ([127.0.0.1]:60330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEadF-0006Hn-11 for submit@debbugs.gnu.org; Tue, 23 Feb 2021 11:33:53 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:43954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEadC-0006HY-17 for 46722@debbugs.gnu.org; Tue, 23 Feb 2021 11:33:51 -0500 Received: by mail-wr1-f51.google.com with SMTP id w11so543698wrr.10 for <46722@debbugs.gnu.org>; Tue, 23 Feb 2021 08:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=h/i8x7OuwPB+8c724EuTKE4D0co2iMLYRDbY/4U5S9I=; b=Z1kyErafwsyKQT4AOJC28ldwu8IthIznku4GE4conaL/8nIjrwlh/yNDPttZQgsjaZ VDPpE3pYEo3CdU5vvSNbE27jD+nZtaaogCDA61oBpBazS7L1RIrBwqKzj8/OpIgmeP/k E3S1+rsmf/4uh8SInl1AgMTV8ApBGd9UMwdZjH9Eecd5blol5FG+gHHNmtT97XRx7QLY Lr3Ye/zZWwJGLYeX3eXhosmif7i0/eheYxp1bSrjE4uB/r2JGkHN66dcJEpsr3ohNxuv YTUMeLfqsaG6l5cGxzfKjQRw580L/7UKLkB279EKm1Vcs07Hu3Xm+eSYu0JasXcD/Tx2 drSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=h/i8x7OuwPB+8c724EuTKE4D0co2iMLYRDbY/4U5S9I=; b=jYVCb9yy7NUaO3p0+vg03HH6nisBlFfrPzi2zoxM8H+3Bo7wZLhh1upQqpZwRCgQFy +dArnoGn2FGVL9G35Z/NtE2a87PVJjbjFm34LwBDgHBrmKC56N8EMyMQ2yReCrTRa9sy Tx50p72alBUQEsD++R3ukVFw24hN0jZ3lgIaHeEUFryUeKjaPJpc0RomkvACve77po8+ JpHYLV91bRKVJvX1VQOM0kzpz/O9dlvbqzP6cqIfOcsrivzLH6JCedgsP2bM883ZKJgs oOlmCxX8zMoP35UI+s4ELR5cj/tDvy+aM7l40qnGyRI3EtcmZz+RntOi4yxX/PwMroL8 u8/Q== X-Gm-Message-State: AOAM5312fTcgsglEZ8/PyfA7Zu2qGUmVCVEfxgUMB9PybTzoRbbnkJ1c Q+VTMPJRyfHsy3XLO4XMwokMuQ== X-Google-Smtp-Source: ABdhPJwlqXM75D4rPHz6556ZMttfEs364ZQdA4tILvE3iaFjEzmf/BJsDUe4+iGNgO2c2DWc+/2mDw== X-Received: by 2002:a5d:628c:: with SMTP id k12mr26958685wru.316.1614098024133; Tue, 23 Feb 2021 08:33:44 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id v18sm3427726wml.45.2021.02.23.08.33.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 08:33:43 -0800 (PST) From: "Basil L. Contovounesios" To: Glenn Morris Subject: Re: bug#46722: test-map-into fails References: Date: Tue, 23 Feb 2021 16:33:42 +0000 In-Reply-To: (Glenn Morris's message of "Tue, 23 Feb 2021 11:22:34 -0500") Message-ID: <87pn0qu4k9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46722 Cc: Stefan Monnier , 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > Something between 8d5dfaf and efe42c2 (inclusive) causes test-map-into > to reliably fail on hydra.nixos.org. We can't be more specific since > intermediate revisions don't build. So far I could not reproduce the issue. > > Ref eg https://hydra.nixos.org/build/137474120 > > (cl-no-applicable-method map-into ((a . 1) (b . 2)) (hash-table :test equal)) FWIW, I've been working on map.el and map-tests.el since yesterday, and I occasionally run into this heisenerror locally maybe once in every 50 runs of 'make test/map-tests RET'. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 12:06:20 2021 Received: (at 46722) by debbugs.gnu.org; 23 Feb 2021 17:06:20 +0000 Received: from localhost ([127.0.0.1]:60359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEb8e-0000j7-Hg for submit@debbugs.gnu.org; Tue, 23 Feb 2021 12:06:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEb8c-0000it-JR for 46722@debbugs.gnu.org; Tue, 23 Feb 2021 12:06:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48072) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEb8W-0006Gv-SL; Tue, 23 Feb 2021 12:06:12 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1lEb8V-0001sA-6o; Tue, 23 Feb 2021 12:06:11 -0500 From: Glenn Morris To: "Basil L. Contovounesios" Subject: Re: bug#46722: test-map-into fails References: <87pn0qu4k9.fsf@tcd.ie> X-Spook: NTT Narcos DERA ISN MD4 FSF Mitigation covert video X-Ran: b.@2nV!b@%KBGtIY%M+(.T_Pz3fI3bt9&R%f X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 23 Feb 2021 12:06:11 -0500 In-Reply-To: <87pn0qu4k9.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 23 Feb 2021 16:33:42 +0000") Message-ID: <9wv9air9x8.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46722 Cc: Stefan Monnier , 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks. Locally I got 3/100 such failures. (I wish the Emacs test suite was less flaky. Eg in https://hydra.nixos.org/build/137475263 we have dired-test-bug27243-02 failing as well, apropos of nothing.) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 12:30:24 2021 Received: (at 46722) by debbugs.gnu.org; 23 Feb 2021 17:30:24 +0000 Received: from localhost ([127.0.0.1]:60397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEbVv-0001Jn-SH for submit@debbugs.gnu.org; Tue, 23 Feb 2021 12:30:24 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEbVt-0001JX-RM for 46722@debbugs.gnu.org; Tue, 23 Feb 2021 12:30:22 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D7DF5440FF7; Tue, 23 Feb 2021 12:30:15 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1EDF4440FF2; Tue, 23 Feb 2021 12:30:14 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614101414; bh=PYzqrQP5VYYksbh7RpWCTL65E6Ex9UItbc2kgb7asKA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oFOdc86tlbu7gEHSnm0lyMguAtGomnffzRzD2oMEZkr6yMPkAMkijyT3Ek165oGJD VEePcs4C/SlM1myA1kRRl2/l5OZpou5J9w6uaiLVYyJA/MIMC8jh17ZQ4W4KLF5skm PzmUowFuhlVBVVk5io/Y7WF9G79K2JeQAX25KyKCKsHafRiyvcW1U70H2cA+oI7D38 qEa0pHovsu0YqBPX9gbKEQI8FPZjnKA/aNOoVurL3P+8c6ukpt/5GRyv0lwVUm1np4 0i4pWng+PRX3Pv2X4rwKj017kWFOyfq7ReeyxgH3j6yGk1JrSzUpjuSJx0p5UDpTRA LKxDlUI9JS+ew== Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E0E70120384; Tue, 23 Feb 2021 12:30:13 -0500 (EST) From: Stefan Monnier To: "Basil L. Contovounesios" Subject: Re: bug#46722: test-map-into fails Message-ID: References: <87pn0qu4k9.fsf@tcd.ie> Date: Tue, 23 Feb 2021 12:30:12 -0500 In-Reply-To: <87pn0qu4k9.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 23 Feb 2021 16:33:42 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Something between 8d5dfaf and efe42c2 (inclusive) causes test-map-into >> to reliably fail on hydra.nixos.org. We can't be more specific since >> intermediate revisions don't build. So far I could not reproduce the issue. >> >> Ref eg https://hydra.nixos.org/build/137474120 >> >> (cl-no-applicable-method map-into ((a . 1) (b . 2)) (hash-table :test equal)) > > FWIW, I've been working on map.el and map-tests.el since yesterday, and > I occasionally run into this heisenerror locally maybe once in every 50 > runs of 'make test/map-tests RET'. This kind of code is supposed to be fully deterministic, so it's quite worrisome. It sounds/smells like memory corruption or some other bug in the memory management. If you could come up with a reasonably simple code (in the sense that it doesn't take too long to run) to reproduce this problem with a high probability, maybe we can start adding some tracing to try and figure out what's going on. IOW, try and write a loop that runs the problematic code a couple hundred times, so that one of those should fail. Then try and cut down the code as much as possible, verifying along the way that the problem didn't disappear. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 15:59:30 2021 Received: (at 46722) by debbugs.gnu.org; 23 Feb 2021 20:59:31 +0000 Received: from localhost ([127.0.0.1]:60746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEemI-00006v-La for submit@debbugs.gnu.org; Tue, 23 Feb 2021 15:59:30 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:52176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEemH-00006i-4A for 46722@debbugs.gnu.org; Tue, 23 Feb 2021 15:59:29 -0500 Received: by mail-wm1-f45.google.com with SMTP id j187so21393wmj.1 for <46722@debbugs.gnu.org>; Tue, 23 Feb 2021 12:59:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZyCMnQxwishCXLCGDYFdA663cUUwht1gXia6kvX7hKM=; b=al5d47sf3dIswCypu8ZKAryhnfofurOSbGsrGWAU+4jedmuCHR+fJLuDDBZ0doM/sJ ImGbJw21RAtEg0JaUlRlwo+jWvW+2tk5aqIQh7uNxSOHC7RE5R3ka1zkAMsNkbNZLF1n rwq+A4LC5BEjWgX6BIK6JwUeaH3tT5f08ACMUXw+w34WbAMq1lucGXwgW6M4GDBsCWkD lECNuu1sFAsxigeDlrVKXvRiA4eu2++x1llfjtxI79ngR82B1D1uwwyDSo04/zEPyHhJ uSFghrEdISekl9EJS0hVHSd8rbhn9nJGwkMttutUt/p3PwOCA/X7IOcKyOdUl2r1Rubq B0Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ZyCMnQxwishCXLCGDYFdA663cUUwht1gXia6kvX7hKM=; b=X4uSL0z2WUznM12YGwnh+YvTFiciMVhCLP4WijIRx1reuEgVvZklUH26ANKaC6qpSV gAhmLPKcWZzYtDZ7TBPp47DyeJCoOG3Wo4WXFsXZXa8iMr3+RCqkLLPDeKf8sOCOg8ms UnxlzQfw85IcLMmq3H1zy2ieM69v18sYBHRJ5BA+aHvgZNroxqaM03xq7wj2d3VLF/LI GMtV95UPH72eOBAdASEQkvVHKg2MJJ4m5y23ecu4z542oHrWvm/80eDd7CkTLO7ISTTG RlXKQ/6OcvmugI8FJMYXhfRV+y9TbKKPpJT2GDTA+xAoIp1sc8O700n+e/3MmKxShXOx kC/g== X-Gm-Message-State: AOAM5322RdAZa7x8l+ydalypnVvLX0elWS0eCmMW7zzLcsDPKXBp6Zym CBiQWWNzcb3NuUTGeWhmYuzyJ3iVcHmwqQ== X-Google-Smtp-Source: ABdhPJyTRHVQooMM2YlMpFDbvGp0E2EuWGBA+nJs5u84czAXScTo8+PX7S2/YyJZ/qkVU5AKbveWWA== X-Received: by 2002:a1c:c906:: with SMTP id f6mr555710wmb.128.1614113963164; Tue, 23 Feb 2021 12:59:23 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id 4sm4415772wma.0.2021.02.23.12.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 12:59:05 -0800 (PST) From: "Basil L. Contovounesios" To: Stefan Monnier Subject: Re: bug#46722: test-map-into fails References: <87pn0qu4k9.fsf@tcd.ie> Date: Tue, 23 Feb 2021 20:58:52 +0000 In-Reply-To: (Stefan Monnier's message of "Tue, 23 Feb 2021 12:30:12 -0500") Message-ID: <87blcaqz5f.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46722 Cc: 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Monnier writes: > This kind of code is supposed to be fully deterministic, so it's quite > worrisome. It sounds/smells like memory corruption or some other bug in > the memory management. > > If you could come up with a reasonably simple code (in the sense that it > doesn't take too long to run) to reproduce this problem with a high > probability, maybe we can start adding some tracing to try and figure > out what's going on. > > IOW, try and write a loop that runs the problematic code a couple > hundred times, so that one of those should fail. Then try and cut down > the code as much as possible, verifying along the way that the problem > didn't disappear. Here's the simplest repro I could find: ;;; foo.el -*- lexical-binding: t -*- (require 'map) (map-into () '(hash-table)) ;;; foo.el ends here followed by: emacs -Q -batch -f batch-byte-compile foo.el while emacs -Q -batch -l foo.elc; do :; done which barfs the attached after a few seconds. The same happens with: (map-into () '(hash-table :test eq)) (map-into () '(hash-table :test eql)) (map-into () '(hash-table :test equal)) but not with: (map-into () 'hash-table) so maybe the heisenbug lies with cl-defmethod's treatment of 'head'? Let me know if you'd like me to run anything else. Thanks, -- Basil --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=backtrace.el Content-Transfer-Encoding: quoted-printable Debugger entered--Lisp error: (cl-no-applicable-method map-into nil (hash-t= able)) signal(cl-no-applicable-method (map-into nil (hash-table))) cl-no-applicable-method(#s(cl--generic :name map-into :dispatches ((1 #s(= cl--generic-generalizer :name cl--generic-eql-generalizer :priority 100 :ta= gcode-function #f(compiled-function (name &rest _) #) :specializers-function #f(compiled-function (tag &rest _) #)) #s(cl--generic-generalizer :name cl--generic-head-= generalizer :priority 80 :tagcode-function #f(compiled-function (name &rest= _) #) :specializers-function #f(compiled-funct= ion (tag &rest _) #)) #s(cl--generic-generaliz= er :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compile= d-function (name &rest _) #) :specializers-fu= nction #f(compiled-function (tag &rest _) #)))= (0 #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 = :tagcode-function #f(compiled-function (name &rest _) #) :specializers-function #f(compiled-function (tag &rest _) #)))) :method-table (#s(cl--generic-method :special= izers (t (head hash-table)) :qualifiers nil :uses-cnm nil :function #f(comp= iled-function (map type) "Convert MAP into a hash-table.\nTYPE is a list wh= ere the car is `hash-table' and the cdr are the\nkeyword-args forwarded to = `make-hash-table'.\n\nExample:\n (map-into '((1 . 3)) '(hash-table :test= eql))" #)) #s(cl--generic-method :specializers= (t (eql hash-table)) :qualifiers nil :uses-cnm nil :function #f(compiled-f= unction (map type) "Convert MAP into a hash-table." #)) #s(cl--generic-method :specializers (t (eql plist)) :qualifiers n= il :uses-cnm nil :function #f(compiled-function (map type) #)) #s(cl--generic-method :specializers (t (eql alist)) :qualif= iers nil :uses-cnm nil :function #f(compiled-function (map type) #)) #s(cl--generic-method :specializers (t (eql list)) := qualifiers nil :uses-cnm nil :function #f(compiled-function (map type) #))) :options nil) nil (hash-table)) apply(cl-no-applicable-method #s(cl--generic :name map-into :dispatches (= (1 #s(cl--generic-generalizer :name cl--generic-eql-generalizer :priority 1= 00 :tagcode-function #f(compiled-function (name &rest _) #) :specializers-function #f(compiled-function (tag &rest _) #<= bytecode -0xc2b468c2856371a>)) #s(cl--generic-generalizer :name cl--generic= -head-generalizer :priority 80 :tagcode-function #f(compiled-function (name= &rest _) #) :specializers-function #f(compiled= -function (tag &rest _) #)) #s(cl--generic-gen= eralizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(c= ompiled-function (name &rest _) #) :specializ= ers-function #f(compiled-function (tag &rest _) #))) (0 #s(cl--generic-generalizer :name cl--generic-t-generalizer :prior= ity 0 :tagcode-function #f(compiled-function (name &rest _) #) :specializers-function #f(compiled-function (tag &rest _)= #)))) :method-table (#s(cl--generic-method :s= pecializers (t (head hash-table)) :qualifiers nil :uses-cnm nil :function #= f(compiled-function (map type) "Convert MAP into a hash-table.\nTYPE is a l= ist where the car is `hash-table' and the cdr are the\nkeyword-args forward= ed to `make-hash-table'.\n\nExample:\n (map-into '((1 . 3)) '(hash-table= :test eql))" #)) #s(cl--generic-method :specia= lizers (t (eql hash-table)) :qualifiers nil :uses-cnm nil :function #f(comp= iled-function (map type) "Convert MAP into a hash-table." #)) #s(cl--generic-method :specializers (t (eql plist)) :qualif= iers nil :uses-cnm nil :function #f(compiled-function (map type) #)) #s(cl--generic-method :specializers (t (eql alist)) := qualifiers nil :uses-cnm nil :function #f(compiled-function (map type) #)) #s(cl--generic-method :specializers (t (eql li= st)) :qualifiers nil :uses-cnm nil :function #f(compiled-function (map type= ) #))) :options nil) (nil (hash-table))) #f(compiled-function (&rest args) #)(nil (ha= sh-table)) apply(#f(compiled-function (&rest args) #) n= il (hash-table) nil) map-into(nil (hash-table)) byte-code("\300\301!\210\302\303\304\"\207" [require map map-into nil (ha= sh-table)] 3) load("/tmp/foo.elc" nil t) command-line-1(("-l" "foo.elc")) command-line() normal-top-level() --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 17:51:10 2021 Received: (at 46722) by debbugs.gnu.org; 23 Feb 2021 22:51:10 +0000 Received: from localhost ([127.0.0.1]:60870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEgWM-0002zG-A0 for submit@debbugs.gnu.org; Tue, 23 Feb 2021 17:51:10 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:34755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEgWJ-0002yo-CG for 46722@debbugs.gnu.org; Tue, 23 Feb 2021 17:51:09 -0500 Received: by mail-wm1-f52.google.com with SMTP id o10so2369314wmc.1 for <46722@debbugs.gnu.org>; Tue, 23 Feb 2021 14:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=51gNH6nziwKQBUqTCH9n9vtl2VyQB6nGVHJ59CCYzAk=; b=E04HNMNtvXDXAAcPlmTCkqigjSNkJbT0iZ8cOnLn689FobCSuvw5Ub1W2uJJZzHJ8R jvZuSXZxsQgGSFCMYbnNeHYDWAJrv5SEehxFCp30Wuq2X7U7VmO/p5kQ8R/7fxj1yF6F 4yru8p+pZPrPA5jYQOb3qxxiMGHYC9/ioOxbaRDcNlXx1ZukyMlvAmm1rYQBWV1wroCU nxnedCuxAv4q9QImuOXGQpEqgKpTDvrPIxkCGlPoYHtw5F8oNM2OCvvKsTVqtR5q+J7C Kz1CVrM68ypJEsGPbhzEwKTaPiBJZTHsoeM6qkdnGE5Xmh4hUy+fVnZGamzAy+iMzBWz iqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=51gNH6nziwKQBUqTCH9n9vtl2VyQB6nGVHJ59CCYzAk=; b=s7H8pgQe7D8lcSwlpTwMcok+UQ1MQlFjfWYGodVGax9VEmpZQDcdb0zzuz8t1yX3nJ 8hLom2DFks35nN6Q6OwIYotR1bInkb/O5vD5JItFhvpCZ69OdhnlfxeEIhCTWb/z5rvB X+kKVPEBZ2/12YbedWWVB1C2d9AkO71xFafFbJiEY5CJyFBqwplRzIqrjlxqQp3tustq r8vVK74hK7B55ADFKx5eye62JYGOLVofgtwVxaLjId8NmfS94vz7faVamcNZmK4Tf2Pm OdyvxYV/C2Coc9sqCtAdX40dN9z9U+UGD7xP2PMIK+ZTynaCsWof7nwkVxAJWpfq1/46 unrw== X-Gm-Message-State: AOAM530pdsif7E7ExdATCD7wfkhtFGR6rq98/cExNe/7JiO4nSXHwGf0 ljRV/PVRdJghdX8KXJkgWb91+A== X-Google-Smtp-Source: ABdhPJxq9Jsf72Lbnhr5HByztmUyNGXhmg2/iNLnFYIVwYWynQl2wiKwVtNZ/uXT8naA4gjjBpYpGA== X-Received: by 2002:a05:600c:19cf:: with SMTP id u15mr839113wmq.139.1614120661433; Tue, 23 Feb 2021 14:51:01 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id b6sm193132wrq.56.2021.02.23.14.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 14:51:00 -0800 (PST) From: "Basil L. Contovounesios" To: Stefan Monnier Subject: Re: bug#46722: test-map-into fails References: <87pn0qu4k9.fsf@tcd.ie> <87blcaqz5f.fsf@tcd.ie> Date: Tue, 23 Feb 2021 22:50:59 +0000 In-Reply-To: <87blcaqz5f.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 23 Feb 2021 20:58:52 +0000") Message-ID: <87mtvupfe4.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46722 Cc: 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Here's the simplest repro I could find: > > ;;; foo.el -*- lexical-binding: t -*- > (require 'map) > (map-into () '(hash-table)) > ;;; foo.el ends here > > followed by: > > emacs -Q -batch -f batch-byte-compile foo.el > while emacs -Q -batch -l foo.elc; do :; done > > which barfs the attached after a few seconds. > > The same happens with: > > (map-into () '(hash-table :test eq)) > (map-into () '(hash-table :test eql)) > (map-into () '(hash-table :test equal)) > > but not with: > > (map-into () 'hash-table) > > so maybe the heisenbug lies with cl-defmethod's treatment of 'head'? For some reason looping in Lisp doesn't fail though: ;;; foo.el -*- lexical-binding: t -*- (require 'map) (while (map-into () '(hash-table))) ;;; foo.el ends here when run as: emacs -Q -batch -f batch-byte-compile foo.el emacs -Q -batch -l foo.elc I actually forgot I left this running in the background for over an hour because compilation-finish-functions never ran. The same happens if I change '-batch -l' to '-script'. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 12:06:11 2021 Received: (at 46722) by debbugs.gnu.org; 4 Apr 2021 16:06:12 +0000 Received: from localhost ([127.0.0.1]:36336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT5GN-00063u-E7 for submit@debbugs.gnu.org; Sun, 04 Apr 2021 12:06:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT5GL-00063g-La for 46722@debbugs.gnu.org; Sun, 04 Apr 2021 12:06:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42138) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT5GG-00050q-F4 for 46722@debbugs.gnu.org; Sun, 04 Apr 2021 12:06:04 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1lT5G4-00044Z-H7; Sun, 04 Apr 2021 12:05:58 -0400 From: Glenn Morris To: 46722@debbugs.gnu.org Subject: Re: bug#46722: test-map-into fails References: X-Spook: SONANGOL CSE SWS THAAD Al Qaeda Arabian Peninsula X-Ran: aj6%[\k0<-)~&pl0g#zLX=NO*F,.oOXOkJE{L%9e1[dn53RiB%I>];}'[%qu^j+QQaND6x X-Hue: white X-Attribution: GM Date: Sun, 04 Apr 2021 12:05:51 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 23 Feb 2021 11:22:34 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46722 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I've also now seen this failure on the emacs-27 branch, so my initial comments about revisions are incorrect. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 04 12:07:06 2021 Received: (at control) by debbugs.gnu.org; 4 Apr 2021 16:07:06 +0000 Received: from localhost ([127.0.0.1]:36340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT5HG-00065T-0D for submit@debbugs.gnu.org; Sun, 04 Apr 2021 12:07:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lT5HE-00064s-3q for control@debbugs.gnu.org; Sun, 04 Apr 2021 12:07:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42181) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lT5H8-0005Rf-V9 for control@debbugs.gnu.org; Sun, 04 Apr 2021 12:06:58 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1lT5H8-0006fn-8T for control@debbugs.gnu.org; Sun, 04 Apr 2021 12:06:58 -0400 Subject: control message for bug 46722 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sun, 04 Apr 2021 12:06:58 -0400 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) found 46722 27.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 17 03:47:26 2021 Received: (at 46722) by debbugs.gnu.org; 17 Nov 2021 08:47:26 +0000 Received: from localhost ([127.0.0.1]:60093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnGbC-00039n-MF for submit@debbugs.gnu.org; Wed, 17 Nov 2021 03:47:26 -0500 Received: from mail-pj1-f48.google.com ([209.85.216.48]:34581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnGb8-000398-D6 for 46722@debbugs.gnu.org; Wed, 17 Nov 2021 03:47:19 -0500 Received: by mail-pj1-f48.google.com with SMTP id j5-20020a17090a318500b001a6c749e697so3960462pjb.1 for <46722@debbugs.gnu.org>; Wed, 17 Nov 2021 00:47:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=yEQcs9RXVqV9V7UjerEFI3nq8s9l+4nKrWIl6ExOq/I=; b=InisDQKfNlIdHItkfP6YoCK8NnZMeLQa38AuOfAdNsRTMszVR28xBia0KRYxTnCoeE 7kGcpwMAP9zbEXn4ph6KGVLbnFvl3uAXxdNeHXB/25t5NiL8PlPTQQYvuZH6qu5EFfbz j01sUWElhMPPsbFu92cjwXfy2QVuCHNg7YHlvy2aXQHr0rzt1MVksq7kmcYZc7fLlXEK /EY1fi9rUNflPdS5OQ+0GeA72bccY4wcXXSwf+ZuBT8eOYp+wbEUjhGsulOYqnvxBwmq lXkaGaBtL1O1K7nzVh/J1x+bfp/0X/7+rViFd63afJTGsiwjTBi9Tx5OlGwn0wn2hSo3 8edQ== X-Gm-Message-State: AOAM532WJJR2vl3QriSovIpH7+DSXaid+a9GqZU/5cWu2duLOLB6vkOj gsJ+zIiwoJr7nmibBFTlCMiIVJjl2CiZKcVQvEs= X-Google-Smtp-Source: ABdhPJwfFLRT7hY68+Mc59II++PpANGsbcGfh3stBddBrj1/vJYbgj8vLTqZeRS+nDzPftzxQSMRnZ78xVa0OMWt2tM= X-Received: by 2002:a17:902:b20a:b0:143:7add:5ab7 with SMTP id t10-20020a170902b20a00b001437add5ab7mr52447749plr.71.1637138832575; Wed, 17 Nov 2021 00:47:12 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 17 Nov 2021 00:47:11 -0800 From: Stefan Kangas In-Reply-To: (Glenn Morris's message of "Tue, 23 Feb 2021 11:22:34 -0500") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Wed, 17 Nov 2021 00:47:11 -0800 Message-ID: Subject: Re: bug#46722: test-map-into fails To: Glenn Morris Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 46722 Cc: 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) found 46722 29.0.50 thanks Glenn Morris writes: > Package: emacs > Version: 28.0.50 > > Something between 8d5dfaf and efe42c2 (inclusive) causes test-map-into > to reliably fail on hydra.nixos.org. We can't be more specific since > intermediate revisions don't build. So far I could not reproduce the issue. > > Ref eg https://hydra.nixos.org/build/137474120 > > (cl-no-applicable-method map-into ((a . 1) (b . 2)) (hash-table :test equal)) Here's a similar intermittent failure. I got it once (this morning), while running the automatic merges: Test test-map-merge backtrace: signal(cl-no-applicable-method (map-into (a 1) (hash-table :test equ apply(signal (cl-no-applicable-method (map-into (a 1) (hash-table :t #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-map-merge :documentation "Test ` ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/map-tests command-line() normal-top-level() Test test-map-merge condition: (cl-no-applicable-method map-into (a 1) (hash-table :test equal)) FAILED 28/51 test-map-merge (0.000101 sec) Test test-map-merge-empty backtrace: signal(cl-no-applicable-method (map-into nil (hash-table :test equal cl-no-applicable-method(#s(cl--generic :name map-into :dispatches (( apply(cl-no-applicable-method #s(cl--generic :name map-into :dispatc #f(compiled-function (&rest args) #)(nil apply(#f(compiled-function (&rest args) #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-map-merge-empty :documentation " ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/map-tests command-line() normal-top-level() Test test-map-merge-empty condition: (cl-no-applicable-method map-into nil (hash-table :test equal)) FAILED 29/51 test-map-merge-empty (0.000099 sec) Test test-map-merge-with backtrace: signal(cl-no-applicable-method (map-into ((1 . 2)) (hash-table :test apply(signal (cl-no-applicable-method (map-into ((1 . 2)) (hash-tabl #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-map-merge-with :documentation ni ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/map-tests command-line() normal-top-level() Test test-map-merge-with condition: (cl-no-applicable-method map-into ((1 . 2)) (hash-table :test equal)) FAILED 30/51 test-map-merge-with (0.000090 sec) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 13:20:46 2021 Received: (at 46722) by debbugs.gnu.org; 29 Nov 2021 18:20:46 +0000 Received: from localhost ([127.0.0.1]:39311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrlGg-0005RG-4X for submit@debbugs.gnu.org; Mon, 29 Nov 2021 13:20:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrlGe-0005R3-5B for 46722@debbugs.gnu.org; Mon, 29 Nov 2021 13:20:44 -0500 Received: from [2001:470:142:3::e] (port=54972 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrlGY-0002D2-UY; Mon, 29 Nov 2021 13:20:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fOZdwAeb6eoxuvKatgEF2/keiUA+h5pUAg25bhJwELA=; b=Y9XgrQe73Nm9ajPdymHd ESvs61pne+3yfqB66+y8gwd6qI1c9hfFSfroiicV0Y4bpGouvp9cv/Opo/rgqTI31N6OknL+xIpM3 9apCTM+Z6uz/cfokudQz3YVilhx9wXQ5K6cO7m2IqWOoHjsbj+M0kOdUeKvfPjBtJRFla1Y7Tv+nt qqPLSEzWkOrGYswH0Eeyhsv33261QKsIVDfOl6EN4DjUOW/CWJcpSK5Ybpb/ST/PnHhx3MmXHhWvq pf5c+GYt+aeyf+mm0D9bdEJ19Oe3tTrKIcEXE8XHcl1d6mHWJS2loBV4vyBc5bjRllBpTms2CqagX IzlHhEJ+FCiFlA==; Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mrlGY-000564-US; Mon, 29 Nov 2021 13:20:38 -0500 From: Glenn Morris To: 46722@debbugs.gnu.org Subject: Re: bug#46722: test-map-into fails References: X-Spook: Cops Storm quiche FEMA TDM. SUKLO Quarnantine Fusion X-Ran: 7.vxnw3JfQQ]8vDv$_%}{`6[qhz#)h\F0^({JMOs7Lw^6w|u<^022KA&&w:u\wuSs|~7`L X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 29 Nov 2021 13:20:38 -0500 In-Reply-To: (Stefan Kangas's message of "Wed, 17 Nov 2021 00:47:11 -0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) It occurred for 8 builds in a row from https://hydra.nixos.org/build/159053152 to https://hydra.nixos.org/build/159054038 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 13:27:15 2021 Received: (at 46722) by debbugs.gnu.org; 29 Nov 2021 18:27:15 +0000 Received: from localhost ([127.0.0.1]:39341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrlMw-0005eF-PH for submit@debbugs.gnu.org; Mon, 29 Nov 2021 13:27:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrlMu-0005dz-N0 for 46722@debbugs.gnu.org; Mon, 29 Nov 2021 13:27:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fMZi+8/6pXfM9cVZO/GK7vCiUDO6OpJRPo1F/duitH4=; b=ryqdZ3dqzIzYIkzdFu8gvI19ev WBWkSOH9zG+SkWrswHWfnU71vcq8rWK0AoD73ndz035HSFtyGaQOET1j3yYV2ObW+mmYJL4/tXjzG J1VzVYQn6YudZx9xyJX1d3lxAFgTohcUjVm7TYMYwPTW1kiKPLCNHUM+s/20p1KE8Wrc=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrlMh-0007Fm-2a; Mon, 29 Nov 2021 19:27:02 +0100 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#46722: test-map-into fails References: X-Now-Playing: Mia Doi Todd's _Ten Views of Music Life_: "My Fisherman (SunEye Remix)" Date: Mon, 29 Nov 2021 19:26:58 +0100 In-Reply-To: (Glenn Morris's message of "Mon, 29 Nov 2021 13:20:38 -0500") Message-ID: <871r2yu8b1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: > It occurred for 8 builds in a row from > https://hydra.nixos.org/build/159053152 > to > https://hydra.nixos.org/build/159054038 Hm... very odd: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Stefan Kangas , 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Glenn Morris writes: > It occurred for 8 builds in a row from > https://hydra.nixos.org/build/159053152 > to > https://hydra.nixos.org/build/159054038 Hm... very odd: Test test-map-into backtrace: signal(cl-no-applicable-method (map-into ((a . 1) (b . 2)) (hash-table :test equal))) cl-no-applicable-method(#s(cl--generic :name map-into :dispatches ((1 #s(cl--generic-generalizer :name cl--generic-eql-generalizer :priority 100 :ta apply(cl-no-applicable-method #s(cl--generic :name map-into :dispatches ((1 #s(cl--generic-generalizer :name cl--generic-eql-generalizer :priority 1 #f(compiled-function (&rest args) #)(((a . 1) (b . 2)) (hash-table :test equal)) apply(#f(compiled-function (&rest args) #) ((a . 1) (b . 2)) (hash-table :test equal) nil) map-into(((a . 1) (b . 2)) (hash-table :test equal)) Is there anything particular with the Emacs build on Hydra? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 13:40:54 2021 Received: (at 46722) by debbugs.gnu.org; 29 Nov 2021 18:40:54 +0000 Received: from localhost ([127.0.0.1]:39351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrlaA-0008Bi-BK for submit@debbugs.gnu.org; Mon, 29 Nov 2021 13:40:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrla9-0008BV-5F for 46722@debbugs.gnu.org; Mon, 29 Nov 2021 13:40:53 -0500 Received: from [2001:470:142:3::e] (port=55634 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrlZy-0004mO-Ps; Mon, 29 Nov 2021 13:40:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=9IxMgW7IXb7VLvyedadWveswK+61pg3Ng4wXDZ9NBac=; b=SW9NWYq16p0DK9J5vugy xsqKNxB5/qDX0bQV8PWphq+bWXJDcAwi0XbpOrkIkehxxOZsEEqw26CUe/p/GYUgvA3+q2EPvBRDL k7bKN8oxe5Yb8il49o9OZ/hmj9Nq99ra/1Xu/IH0TKrO51ZOfCvDzYAKa2qXfP9D/5R/kQDnuzcgu TBciX+ql6OC9jc29lC5/jyvYxeBNG3iIulr6o2lbzGe6PL1Aaun0Q4LEYLrNyMR+uiQPNYzSib/qv ips+mp4GvzISj3/6JsPmYYm2EyeLNDW/3yiSDJ5R8xoJpPkJ5sYw7J6J2mGlEu1E6fF6E9tqZANsn Veo+gMfRhyFLaA==; Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mrlZx-000724-He; Mon, 29 Nov 2021 13:40:41 -0500 From: Glenn Morris To: Lars Ingebrigtsen Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> X-Spook: BfV NSA Audiotel Oscor Erosion IW Putin Suicide bomber X-Ran: OCIZn`sUZW8swO`y|3q`^{n-,K`se/ (Lars Ingebrigtsen's message of "Mon, 29 Nov 2021 19:26:58 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Stefan Kangas , 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen wrote: > Is there anything particular with the Emacs build on Hydra? Not really. It's a Nix build that anyone can click the button to reproduce, with some set-up effort. (Actions -> Reproduce locally). (And 3 people have in this report said they sometimes see the same problems on non-Hydra systems.) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 04 17:21:38 2022 Received: (at 46722) by debbugs.gnu.org; 4 Jan 2022 22:21:38 +0000 Received: from localhost ([127.0.0.1]:38961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4sBV-00032G-LE for submit@debbugs.gnu.org; Tue, 04 Jan 2022 17:21:38 -0500 Received: from mail-qk1-f173.google.com ([209.85.222.173]:34429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4rnM-0002R4-VL for 46722@debbugs.gnu.org; Tue, 04 Jan 2022 16:56:42 -0500 Received: by mail-qk1-f173.google.com with SMTP id b85so36335108qkc.1 for <46722@debbugs.gnu.org>; Tue, 04 Jan 2022 13:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9MrwubVl4SGWt4REOvIAtVCEMGxa6jp9OYE9YRiD80g=; b=jV4oBnipTna9W+FIBPvnEpODpuUX/yaiKsjaAbJzMBLloFomhb3p9Ya6FrUhntQOCr 7lPdefnlpFU/x6+zOna7pwlI+wKG62QoEvZPDl5+8+w12rsKQwT6WaGdkiZDfNor7wWn QnckuMF2DIKZodi68+uM2m0v4kOvaWVpzeZSnrLTciga5KGJMag61PtijjkKpzXD04Q5 rjV10GzQFE1ks3ORVoN9P4tsKAXkad05GpyM7v98Zfnv1ByXA0zIvZO0oz16GuN8MamO NykwoN5g87nQDZxDhqndenX0/m1OAq6bf7xLoRuBP8wkoN7OfyjN0Xqg7P+MNziatDek DeQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9MrwubVl4SGWt4REOvIAtVCEMGxa6jp9OYE9YRiD80g=; b=jKejb+3ckLedNnhvzxZYtBIMJGV+uXwOSlHztmWNloKORiKMNblLgQGj0qYjxjqum+ 6gT8ViWxL9EopBcbTF0T+rHQQ4ffx+6eTkaxGvWlw9FQMPQYIrOWIfNf0+TMqxTMgoUL aBnbJSE4XJue+A3oMjtiScd18zC2HxSKhE12KwcVcUkMr3eurX+DF9X8Z8R2hCLTXGTk jXBZSYRxRmFhmfKxTXhrCSqqh94cRktsk062gpPvgxXVRfDWI3hcdyMv0OSUYBp7P2CD iT7wJlUYUt+e9YpQpPGduVt14x9QcbX/XUuJs+G3km80N4/GZUmOvjwde03tQ+9r570v WTiw== X-Gm-Message-State: AOAM533WYhwHBM7aPtE2T93FCZXihKJCGmX5BWlFmuZ7g3dKzGnGvLEM IlGUv6yAmtgag6uuk0Kw74bdlcRP0j0= X-Google-Smtp-Source: ABdhPJyWFq4U5pAV0Uqpp/JfQH+fGUrGRbeoXlEtlD2i5xtQ10qrgm4FpNciUSNIqFxmo/w3zMhv/g== X-Received: by 2002:a05:620a:400f:: with SMTP id h15mr37744029qko.226.1641333395341; Tue, 04 Jan 2022 13:56:35 -0800 (PST) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id u7sm34258937qkp.17.2022.01.04.13.56.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Jan 2022 13:56:34 -0800 (PST) From: dick To: Glenn Morris Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> Date: Tue, 04 Jan 2022 16:56:34 -0500 In-Reply-To: (Glenn Morris's message of "Mon, 29 Nov 2021 13:40:41 -0500") Message-ID: <87czl7w4fh.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46722 X-Mailman-Approved-At: Tue, 04 Jan 2022 17:21:37 -0500 Cc: contovob@tcd.ie, Lars Ingebrigtsen , smonnier , Stefan Kangas , 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) You can't do, (funcall (funcall (backquote (lambda (arg) (lambda () arg))) t)) which is what `cl--generic-get-dispatcher` tries to do. You need an apply-partially somewhere in there. Also in same function, `method-cache` buys you nothing, so getting rid of it along with `with-memoization` and `(require subr-x)` is a not insubstantial win. Fixing may or may not put the kibosh on the heisen-flap. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 10:17:29 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 15:17:29 +0000 Received: from localhost ([127.0.0.1]:41440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n582b-0006mP-8G for submit@debbugs.gnu.org; Wed, 05 Jan 2022 10:17:29 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n582Z-0006mB-Oi for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 10:17:28 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D17E610013B; Wed, 5 Jan 2022 10:17:21 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7D9111002E3; Wed, 5 Jan 2022 10:17:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641395840; bh=wETTDl+cD0/IJtXkEtztN49t1Ozylh2kfnknJy9cam4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Y9+7pSWZBQHXXk9rsEzRr/cc80jRjxc6QlAVS3I6VnG5baiaEuZk+PQwaxYc1oWHu e9Wr1s0wNubimpxmjIl9eZYnr+UjRJH9eQrMchb4F3aWiZFkSw8LahLufH1yjN6YpU UEZqigZa/LvhvnXG7HwKwOs+ZdxY38nJHyqTrRy6hgcqOEa/heMmXVuu3KvRQhY+hh wioK83ylRCpxwjgcd4sSmZE0wTlyUwlkwNXAWb0arOO53UCtK2Vo3KNtEPQw6zIV+S /NYC33xKiVGrrsGKNg5VML69PeCrOBjaNSCZRHKWsXWNKei/JoNV2sWKbblqpIhkyq emkEgwciCgLYQ== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 417E212025D; Wed, 5 Jan 2022 10:17:20 -0500 (EST) From: Stefan Monnier To: dick Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> Date: Wed, 05 Jan 2022 10:17:19 -0500 In-Reply-To: <87czl7w4fh.fsf@dick> (dick's message of "Tue, 04 Jan 2022 16:56:34 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , smonnier , Stefan Kangas , contovob@tcd.ie, 46722@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > You can't do, > > (funcall > (funcall > (backquote > (lambda (arg) > (lambda () arg))) > t)) > > which is what `cl--generic-get-dispatcher` tries to do. Is it? Where does `cl--generic-get-dispatcher` do that? Oh, you mean we don't guarantee that we use static scoping? I think I see what mean. Does the patch below help? Stefan diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el index 983694204df..686a2375971 100644 --- a/lisp/emacs-lisp/cl-generic.el +++ b/lisp/emacs-lisp/cl-generic.el @@ -644,7 +644,8 @@ cl--generic-get-dispatcher ;; FIXME: For generic functions with a single method (or with 2 methods, ;; one of which always matches), using a tagcode + hash-table is ;; overkill: better just use a `cl-typep' test. - (byte-compile + (funcall + (lambda (exp) (let ((lexical-binding t)) (byte-compile exp))) `(lambda (generic dispatches-left methods) ;; FIXME: We should find a way to expand `with-memoize' once ;; and forall so we don't need `subr-x' when we get here. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 10:55:56 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 15:55:56 +0000 Received: from localhost ([127.0.0.1]:41522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n58dn-0007r8-Rv for submit@debbugs.gnu.org; Wed, 05 Jan 2022 10:55:56 -0500 Received: from mail-qv1-f41.google.com ([209.85.219.41]:33371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n56rB-0004LR-5S for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 09:01:45 -0500 Received: by mail-qv1-f41.google.com with SMTP id kk22so37622061qvb.0 for <46722@debbugs.gnu.org>; Wed, 05 Jan 2022 06:01:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KweeSmoz5OdGv+0RptcB+sp1Jy7on06cEBYnDyU3XCM=; b=o5q+9Uhb5BK3wwh60VGZB7wB6Jw3ZMeDj7dA4nSD5N26jZ5BRZwz8hUVpKP7cgNVmf 0/O7hHf1SBowKTXNFaREW5NaT75/YDfTHqudjjYMf0BOqBez44exQfUpgzP8NQpmwbnE mCMCKFRtxhMO8v9azMwHRbN9/7qXwFQyrMmFMu6SIFubhbAwhfGA8R9675UBmXaQb7Rl z31YukfHnOivY/7A5f9wnkp8mi/uQkQLm7PdQxduub81m3qaEfdJz5Dm72juVsO6EW+0 Eo/UZ/ItgrYCvKVRKnaZXRMg+q8bNEu6Ip0Qa871BBZsPNtMfz+iCvvPhLdSodR6P2Dw sDnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KweeSmoz5OdGv+0RptcB+sp1Jy7on06cEBYnDyU3XCM=; b=7MKNEvpRNgYwkgL7I39Qul0qky7w930dlT1D4bcsy5QmibVnD9xXJWFZq87ShCJ75T Mc4AVankDimt5oXWZMsVduPB1s7StKex9PqIyUz4IaiFdV2MVvh+NbmAQDKu+suZB1RZ FXMAvDZtNAvwrrnHAFKSwYRodYJmUha9lOYb4Tf+zXPz+/i6o6LCrV/7ii6t6d5LM74o l6rfSnGezIF8n+U5DOcDAjoNfmiciX4VuXcHEfPeVqCgomw6qDfr92kUXgOyYkewjsKm y0DNeS/1cAaEqiP4T/UoselhMDcLhraw5iQ7ZH7pwQLOOI/R1IAS1vfq9TKbMLsfDLtP S41w== X-Gm-Message-State: AOAM530v/iOZ23yz0En4Nqve1sJuCeeiwhggPDDKgrXtrvVrGIUcxuZZ cxvlR3cOrHnZsIH54sDPYCs= X-Google-Smtp-Source: ABdhPJxfV4kuKMr5qBsGm1CTAFL7sJHVPuzGBEWHnbBf+U2JzI6iz6XirJusN+iJXajRb5q3QegSTg== X-Received: by 2002:a05:6214:c2d:: with SMTP id a13mr50099049qvd.28.1641391291610; Wed, 05 Jan 2022 06:01:31 -0800 (PST) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id l10sm31197329qtk.18.2022.01.05.06.01.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jan 2022 06:01:30 -0800 (PST) From: dick To: Glenn Morris Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> Date: Wed, 05 Jan 2022 09:01:29 -0500 In-Reply-To: <87czl7w4fh.fsf@dick> (dick's message of "Tue, 04 Jan 2022 16:56:34 -0500") Message-ID: <87a6gawabq.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46722 X-Mailman-Approved-At: Wed, 05 Jan 2022 10:55:52 -0500 Cc: contovob@tcd.ie, Lars Ingebrigtsen , Stefan Kangas , smonnier , 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) For unclear reasons, the hash-table `cl--generic-dispatchers` keyed off raw, unburnished defstructs returns values for non-existent keys. I normalized its key to a signature string, and, for i in {1..300} ; do src/emacs -Q -batch -f batch-byte-compile foo.el ; src/emacs -Q -batch -l foo.elc ; done ; where foo.el is (map-into nil '(hash-table)) ran without incident. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 11:21:17 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 16:21:17 +0000 Received: from localhost ([127.0.0.1]:41587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n592K-0002NW-IA for submit@debbugs.gnu.org; Wed, 05 Jan 2022 11:21:17 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:39908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n58mO-0001uE-LP for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 11:04:48 -0500 Received: by mail-qt1-f179.google.com with SMTP id bp39so37719057qtb.6 for <46722@debbugs.gnu.org>; Wed, 05 Jan 2022 08:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OcS9m3DRXp0PnTS25MXt50wpQ/SojDiyVNzhNofVIPE=; b=VU8UxarztDobqMdmP9N8pAsoT4cozs/I69l17AyrK+xjRF6b+J9lflhxP+sOeN8T9u h3g1ejkhaUkMCiuyWq1800rZieR6z8Pgb1li/i3HIZJZ+XzJYpmb2YUbmy56SkRXrV81 tu6oAJ48TQL2VQf6FY7Ig6vH5SSihsdU1zGryox4A5YZRb7QgdGFIvIecFNwE+g3w741 lRSYfY4OV/D6eWdO23+4K0RH2nWoioYfmL88lUl9/6wACrzBdGT5yM1rlVEfZj1f1m0g 9TNLvZ2FHPsyNejanlfueSsLSJ9tJJqTCbRR+KMyha5/tF+kEG1dX9NNHOIao9UfBhVI nlCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OcS9m3DRXp0PnTS25MXt50wpQ/SojDiyVNzhNofVIPE=; b=gL5FdphnB7fZ2NLj2JeSqt+DmA2+hZsSs2YcpbW+1jJKsUf6dYG1qaOB5CHwAQ4XUH K0kd0nrAZ2cLNTozVM4eyfrpCpo4BzJ6CqW8308HYluzopfBrjkzjLS9x9rycqNt6aqL qmfrUqjyeOmFzAGMteTN3ObSYA1yFePYNWo4x+8JUUSlanuvU1x42DwGR7AYNHoxXKn2 fsfyQ60lO5GhuXgnS8Tvf76pmr2/FOUN/r9bNZrkqAoK+UJKIPxPRmI5ExXgNWeaGpD7 mnUFT25zfzffFnYTCYKiZ5orGOPj3r/+Aj5GZF38rW6Ik7IUS6InEfpJ4RMh1v8jA19z /pmw== X-Gm-Message-State: AOAM532Y8BYONVk7JwY4WgRt+oofposx4Wch+1uN7raDBPrJJG17FUk9 nNIqkuPKUh6Ceqn87Zkznrk= X-Google-Smtp-Source: ABdhPJzKGzXJiXz01qX5F24aCpp7tKrRy3R8dvBeLFifE1unQUg238OiJuXykWwYBXL2+TjqOMyl6Q== X-Received: by 2002:a05:622a:308:: with SMTP id q8mr48007220qtw.463.1641398683152; Wed, 05 Jan 2022 08:04:43 -0800 (PST) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id v4sm33448122qkp.118.2022.01.05.08.04.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jan 2022 08:04:42 -0800 (PST) From: dick To: Stefan Monnier Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> Date: Wed, 05 Jan 2022 11:04:41 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 05 Jan 2022 10:17:19 -0500") Message-ID: <875yqyw4me.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 46722 X-Mailman-Approved-At: Wed, 05 Jan 2022 11:21:14 -0500 Cc: 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Does the patch below help? I don't see why it would if this doesn't work: (let ((lexical-binding t)) (funcall (funcall (backquote (lambda (arg) (lambda () arg))) t))) But clearly `byte-compile` allows things that the interpreter doesn't, otherwise it'd never have worked for so long. While I remain leery of the fast and loose scoping here, it was but a red herring. The problem lies with the hashing behavior of `cl--generic-dispatchers`. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 11:32:16 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 16:32:16 +0000 Received: from localhost ([127.0.0.1]:41597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n59Cx-0002iK-OJ for submit@debbugs.gnu.org; Wed, 05 Jan 2022 11:32:16 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n59Cv-0002i0-V6 for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 11:32:14 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4A25510028A; Wed, 5 Jan 2022 11:32:08 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CE62A10013B; Wed, 5 Jan 2022 11:32:06 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641400326; bh=fb8QXy+CZkhKm++bYzjARCeWdls9kcHvZfSbzcaw1M4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=f5sGxrd2c5/poEwTLjigjVdP6NC9SNAYxSE4EZmNnz+XFZtdf0zgaB53ikSUi6ZjX Gex7kS996N+ap+YqBqsS+ZW3TNl+WN/0qW/gPPjg5G1DrlGJYPDjy+yUrdqn9b/tUS CqOv8HczUeOjzRuJ6B7k3ukoGc0+9NCnS4Z0PYgY//s0G4OJ2WxtH/UXDz/07izNey +c7BruQ8kJi+/UaMWhzFQ5tZRAp+I3w2UU1GwBgyJRFWmtIjyvcGXIV8B70p9ADAE3 Znm513UBcnZAJnTvAB9a8f7sfDYYcwBB3TMNAqoR0vJYep/OFgQGmYJ7hftI9n8/l2 kJNez8LPXEEJQ== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 890E212019C; Wed, 5 Jan 2022 11:32:06 -0500 (EST) From: Stefan Monnier To: dick Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> Date: Wed, 05 Jan 2022 11:31:59 -0500 In-Reply-To: <87a6gawabq.fsf@dick> (dick's message of "Wed, 05 Jan 2022 09:01:29 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.488 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: contovob@tcd.ie, Glenn Morris , Lars Ingebrigtsen , Stefan Kangas , 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Dick, dick [2022-01-05 09:01:29] wrote: > For unclear reasons, the hash-table `cl--generic-dispatchers` keyed off > raw, unburnished defstructs returns values for non-existent keys. Hmm... I don't understand what this means concretely. I'm aware that `cl--generic-dispatchers` can be fiddly (IIRC because there can be functions in the key), but I still can't figure out what scenario you're describing nor how it can happen to return values for non-existent keys. Could you say a bit more, ideally with something like a trace or a test case? [...time passes...] > I normalized its key to a signature string, and, > > for i in {1..300} ; do src/emacs -Q -batch -f batch-byte-compile foo.el > ; src/emacs -Q -batch -l foo.elc ; done ; Oh I think I see what you mean. I can now reproduce the problem locally as well, and with the foo.el below I get two different traces: (trace-function 'cl--generic-get-dispatcher) (require 'map) (condition-case nil (progn (map-into nil '(hash-table)) (with-current-buffer "*trace-output*" (write-region nil nil "~/tmp/trace-good.eld"))) (error (with-current-buffer "*trace-output*" (write-region nil nil "~/tmp/trace-bad.eld") (message "ERROR!!")))) the two backtraces only differ on the last line. The good trace (slightly cleaned up for legibility) ends with: ====================================================================== 1 -> (cl--generic-get-dispatcher (1 #s(cl--generic-generalizer cl--generic-eql-generalizer 100 #[385 "" [gethash (cl--generic-eql-used)] 5] #[385 "" [eql] 4]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 #2="\300\207" [nil] 3 #1#] #[385 #2# [(t)] 3]))) 1 <- cl--generic-get-dispatcher: #[771 "" [make-hash-table :test eql make-closure #[642 "" [V0 V1 V2 V3 cl--generic-eql-used apply gethash cl--generic-cache-miss 1 append #[385 "" [eql] 4] #[385 "\300\207" [(t)] 3] nil puthash] 15]] 10] ====================================================================== 1 -> (cl--generic-get-dispatcher (1 #s(cl--generic-generalizer cl--generic-eql-generalizer 100 #[385 "" [gethash (cl--generic-eql-used)] 5] #[385 "" [eql] 4]) #s(cl--generic-generalizer cl--generic-head-generalizer 80 #[385 "" [gethash car-safe (cl--generic-head-used)] 5] #[385 "" [head] 4]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 #3="\300\207" [nil] 3] #[385 #3# [(t)] 3]))) 1 <- cl--generic-get-dispatcher: #[771 "" [make-hash-table :test eql make-closure #[642 "" [V0 V1 V2 V3 cl--generic-eql-used cl--generic-head-used apply gethash cl--generic-cache-miss 1 append #[385 "" [eql] 4] #[385 "" [head] 4] #[385 "\300\207" [(t)] 3] nil puthash] 16]] 10] whereas in the bad trace, the last returned value is identical to the previous one (i.e. somehow the `head` dispatcher is absent from the returned function). Hmm.... Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 11:38:15 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 16:38:15 +0000 Received: from localhost ([127.0.0.1]:41609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n59Il-0002sR-0O for submit@debbugs.gnu.org; Wed, 05 Jan 2022 11:38:15 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n59Ij-0002sA-3x for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 11:38:13 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 980DB100979; Wed, 5 Jan 2022 11:38:07 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4C64610018E; Wed, 5 Jan 2022 11:38:06 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641400686; bh=xcxv5GRRKsmd/hACbfFkrOUePbvlJCVDbiGR648Ey7A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PrsAfO1LPJf+V43xOY9cmMJ8kNKcPnGrGEHxc0kTQG0VGuV4mEeTvmfbI9hJiA//g Ite8QPSzwhfTMWMA/yiVk8z15+2/9TbZnrujz8lHOJD/AUbjFmOsH4vo0LwIeSvAbE A+G9+HpaPNz807YwNUnovjW4XhBzXOFpMvikgShrO7v4jwoIt9QAOX+NTEZlBxibCZ 3NXZo1wAnJ3+xj1c06x9+gGDMthHUSW8B3eJsT3jcKf/Ms+T+kLxn0mGho2Q4xDX49 OYGoECzZ02v9f7zvwIH5G80TgXfpG6PXg8Ab1+cjJozd/j65lticzPV4Hvawj790Vq NKqCyFah1h5Gg== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0AF981202C1; Wed, 5 Jan 2022 11:38:06 -0500 (EST) From: Stefan Monnier To: dick Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <875yqyw4me.fsf@dick> Date: Wed, 05 Jan 2022 11:38:03 -0500 In-Reply-To: <875yqyw4me.fsf@dick> (dick's message of "Wed, 05 Jan 2022 11:04:41 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Does the patch below help? No, it doesn't because I see now that we already fixed this bug by binding `lexical-binding` (just a bit further above). > I don't see why it would if this doesn't work: > > (let ((lexical-binding t)) > (funcall > (funcall > (backquote > (lambda (arg) > (lambda () arg))) > t))) The effect of `lexical-binding` is different from what you think. It applies to the moment a sexp passes from being "data" to the moment it is labeled as "code", not to the moment the code is executed (otherwise we couldn't compile the code of functions ahead of time, not knowing which value of `lexical-binding` would be active when the code will be executed). > While I remain leery of the fast and loose scoping here, it was but a red > herring. Indeed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 12:51:25 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 17:51:26 +0000 Received: from localhost ([127.0.0.1]:41702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5ARZ-00077Z-OL for submit@debbugs.gnu.org; Wed, 05 Jan 2022 12:51:25 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5ARY-00077K-Bl for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 12:51:24 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5630280552; Wed, 5 Jan 2022 12:51:18 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D4C178044E; Wed, 5 Jan 2022 12:51:16 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641405076; bh=MCliOC1M+0D6hI8PKQ6bL/iYlagBNNcOAycKB5RJrB8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Nus0OXoL9WavLOyaSXgqJLByKqkElm+Q387Z1iieVSJR77LYHWSMRjIFP+Y8XvgfT wLF/SfQa1J0EDPVaBAIC8KzjwxbWAkWWNNarXiB1sL+u104vWri2txziL5VeFBhqqc oi5Z75cxsGO5EeQ0SWpqVfGi7zUdGRf5o4xD/diUhzGrfDIRZMjlyml6yqDpGrPrMl TtbCWq9F2j/UopVgPoM8VVIAM6dRUM/RIuIPNK1zaVR0J4bz9now7G9MW7WaptNZY0 aJ7kUrB7hwmEPLqt82CQfVi5HgEcsT89+qbkDD6axJNBzAqQAwSqMhfAnpiBDc0OpF w191Tm1YNX1HA== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8FF24120493; Wed, 5 Jan 2022 12:51:16 -0500 (EST) From: Stefan Monnier To: dick Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> Date: Wed, 05 Jan 2022 12:51:09 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 05 Jan 2022 11:31:59 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: contovob@tcd.ie, Glenn Morris , Lars Ingebrigtsen , Stefan Kangas , 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I think I tracked it down. The patch below should fix it. Boy do I hate side effects! Could others confirm that it fixes the problem for them as well? Eli, do you think this is appropriate for `emacs-28`? OT1H this bug probably has been with us since Emacs-25, but OTOH the patch should be very safe. Stefan PS: We don't need the `copy-sequence` when we do the actual `gethash`, we only need it if that `gethash` returns nil and we end up putting a new entry in the hash-table, but avoiding those extra `copy-sequence` requires manually macroexpanding `with-memoization`, so I favored keeping the patch as short as possible. diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el index 983694204df..5090e060372 100644 --- a/lisp/emacs-lisp/cl-generic.el +++ b/lisp/emacs-lisp/cl-generic.el @@ -604,7 +604,9 @@ cl--generic-dispatchers (defun cl--generic-get-dispatcher (dispatch) (with-memoization - (gethash dispatch cl--generic-dispatchers) + ;; We need `copy-sequence` here because this `dispatch' object might be + ;; modified by side-effect in `cl-generic-define-method' (bug#46722). + (gethash (copy-sequence dispatch) cl--generic-dispatchers) ;; (message "cl--generic-get-dispatcher (%S)" dispatch) (let* ((dispatch-arg (car dispatch)) (generalizers (cdr dispatch)) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 13:07:49 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 18:07:49 +0000 Received: from localhost ([127.0.0.1]:41714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5AhR-0007WZ-Cq for submit@debbugs.gnu.org; Wed, 05 Jan 2022 13:07:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5AhN-0007WJ-OG for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 13:07:47 -0500 Received: from [2001:470:142:3::e] (port=48546 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5AhI-0002oe-8e; Wed, 05 Jan 2022 13:07:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=m4E/rHj4VeCm3k/TwvyLfBh67GDyWFitMIVv4d0w5Os=; b=mbTTLNlIa7CH 6Wppq816onWVYW/nSDt85M/cbuyr2B2NsDMlkVevHkKHa6Ts+D8BMpnVJ/R9JTF/hNJHIwCIJ9Xng zgV83+POnIIIm5p3LsNaK23awgow3OmvmLmYbfiMtDuC/LynGZiiwJIsF5tUxvOR2ZL5qYODQlPCU E/oofdSHdGf9ZJPcwyXCFXkxfMQpQej1iNbNdFmIpc5NMJSRwdclin+OHcmJvU9EgD+7BHV0kCcpH 6PiMY5XY0qf5BlwgVQv07QH4/TcTrxJgNg5722wRkNkWMQ1IdSpkixDWSau6jc0qM6ZQGyOm+mUgo Tf3gzEGHyC4tVwioY1c4zw==; Received: from [87.69.77.57] (port=3813 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5AhI-00072I-7J; Wed, 05 Jan 2022 13:07:40 -0500 Date: Wed, 05 Jan 2022 20:07:50 +0200 Message-Id: <83a6ga9hu1.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: rgm@gnu.org, stefan@marxist.se, contovob@tcd.ie, dick.r.chiang@gmail.com, 46722@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: contovob@tcd.ie, Glenn Morris , > Lars Ingebrigtsen , Stefan Kangas , > 46722@debbugs.gnu.org > Date: Wed, 05 Jan 2022 12:51:09 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I think I tracked it down. > > The patch below should fix it. Boy do I hate side effects! > Could others confirm that it fixes the problem for them as well? > > Eli, do you think this is appropriate for `emacs-28`? > OT1H this bug probably has been with us since Emacs-25, but OTOH the > patch should be very safe. Is it? how so? copy-sequence is not a trivial operation, at least not with arbitrary data structures. And we nowadays use generics a lot, so this could potentially affect gobs of code. So I'd rather we didn't install this on the release branch. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 13:24:50 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 18:24:50 +0000 Received: from localhost ([127.0.0.1]:41742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Axu-0007vt-3q for submit@debbugs.gnu.org; Wed, 05 Jan 2022 13:24:50 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Axs-0007vg-I1 for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 13:24:48 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9B1BE441D2C; Wed, 5 Jan 2022 13:24:42 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 42813441D29; Wed, 5 Jan 2022 13:24:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641407081; bh=eIeCQbBLJXOIIENAZTd0ZZuLROGUMPJOGHntLbJeVlE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=i+QeR9zfnG53kxh4Cg7QHDWK7rEOiSaYZYo0CaIVAZHkqvgUorCxdM1RtIh6RuOUb 14nvHbkOoAgyyh9Lm9usBuiTh+qEkPx+XcVmLyMM2XFxmHDNsDnDhaHaewe+jzIvAd bL/FfwNNUc6wiK637B+e4Vv3ZopmvD7WNq8WSeoD15nwL3I42uAeYpOK2gNYRMbdqh 4Y7BDWDP9+OUybR0eqw9xtgllA8q/W44cGkpz6yA1G5FiRif05e2jJHqYPfyaBRteP IQbrz62vV+Z8YVCX9fwBoA2vj4n9LRF5NtCPXiG7T1Mn3yPxjB3mMUsLwF/kYxKoGY PmD/4JHf6WUJA== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 02AD81201B2; Wed, 5 Jan 2022 13:24:40 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> Date: Wed, 05 Jan 2022 13:24:40 -0500 In-Reply-To: <83a6ga9hu1.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Jan 2022 20:07:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: rgm@gnu.org, stefan@marxist.se, contovob@tcd.ie, dick.r.chiang@gmail.com, 46722@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Is it? how so? copy-sequence is not a trivial operation, at least not > with arbitrary data structures. This is used on the `key` argument of `gethash/puthash` on a hash-table defined to use `:test #'equal`. And it is used on a value which is defined to be a list. For this reason, I think it is very safe. The reason why the current code only misfires "rarely" is that in most cases, when we change by side-effect an object that's a key in an `equal` hashtable, the result is a hashtable where this entry can't be found (because its hash doesn't match any more), so we end up luckily not making use of this (now broken) entry. So the underlying bug only appears if either the hash-table is rehashed or the new `sxhash-equal` value happens to the same as the old one. > And we nowadays use generics a lot, so this could potentially affect > gobs of code. So I'd rather we didn't install this on the > release branch. Fine by me, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 13:35:52 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 18:35:53 +0000 Received: from localhost ([127.0.0.1]:41754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5B8a-0008Fv-Oa for submit@debbugs.gnu.org; Wed, 05 Jan 2022 13:35:52 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5B8Z-0008Fj-BE for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 13:35:51 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9891D10028A; Wed, 5 Jan 2022 13:35:45 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4535910013B; Wed, 5 Jan 2022 13:35:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641407744; bh=TfO9Wn9BUgqZfxfPL35DknUBD6BFDug07WCxLQNiUxE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=clTf+HSsB+bMWtCLHDojCd6Y9rp5xc9/nYT0BXsJTRk+FCYyIhtRF3DcufeTYmN3m QG9CDTlv7LhWZs2xh3xjUVoppvPYZMO4NGW3b1dj8xsCdxx38JbgpzD7LdtX1xbZC/ jvC7vNRCCe82x1bequZffMDf2k+yGT7EfJZa+z1uK6Gnam3VXP5KWVveaPtrStFjw6 mraTjmmzh7NsB2zwPN/IpQPfO7v7CuzZi1+gngBLt7EkgNw1RDz76l7x8axCmfomvv iS/qcYjwWvETJhCLuGtolL4xy9WbOuIXpmveBze975Epvc9J/3/lW2kLacaTDaIPuE P5PL7jbewwK2w== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 001DC1204D7; Wed, 5 Jan 2022 13:35:43 -0500 (EST) From: Stefan Monnier To: dick Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> Date: Wed, 05 Jan 2022 13:35:42 -0500 In-Reply-To: <87czl7w4fh.fsf@dick> (dick's message of "Tue, 04 Jan 2022 16:56:34 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , smonnier , Stefan Kangas , contovob@tcd.ie, 46722@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Also in same function, `method-cache` buys you nothing, so getting rid of > it along with `with-memoization` and `(require subr-x)` is a not > insubstantial win. The benefit of the `cl--generic-dispatchers` cache is probably negligible in terms of performance, indeed. Its main purpose is to try and avoid loading the byte-compiler (e.g. most crucially, it saves us from *pre*loading the byte-compiler). The benefit of the `method-cache` OTOH should be very significant since without it we'd have to recompute the effective method at every call. This said, I have not measured it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 14:07:39 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 19:07:39 +0000 Received: from localhost ([127.0.0.1]:41825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5BdK-0002rh-9Q for submit@debbugs.gnu.org; Wed, 05 Jan 2022 14:07:39 -0500 Received: from mail-qk1-f172.google.com ([209.85.222.172]:45648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5BVE-0000SB-4u for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 13:59:17 -0500 Received: by mail-qk1-f172.google.com with SMTP id e25so325025qkl.12 for <46722@debbugs.gnu.org>; Wed, 05 Jan 2022 10:59:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5iMfTcCh8MJN6AcVkP7o8M7thCL/7FDc/pL66VDhXqw=; b=XWLOTOmFAzAJy5jVjuKV0mzzwOorN78BWcqD+0C+F0/+isUMcX5/w+XsJSscJBr4Ph shnx/OEq1i2zT+Yy5fSpDh7Md+GeEIet0yt5tPLGSynYidl22aeCNdhbpZdNBv0re2YY SSHGbYVTsRZOFUdqK5ex8rsbJwhOaV7AyFsDlHP2wsvo09Nta96P9b3NHKIP2QXq9tPa jBtZw35dRwhk4eS8/jYbIlH9gOXNtI2j2f5WXizmvqlvywY3QdLE97Ay5F/0K8tRZV3i gvwRGzeWtXvdMtD84yywws65WsyQIUwVbmLCHrOq6Q7sZxzzwfdYremQCg2yW/j4XUXo jImQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5iMfTcCh8MJN6AcVkP7o8M7thCL/7FDc/pL66VDhXqw=; b=PXw2yul4YB31flqo75xSGroOHe5Vkhe626GY2cZiGLYRogXEXbimGq2gD/hPxqSf8q lCgLj6P9nyzf8e7RA0c5JLMahygPqxE/1YuRAiyLIUYQOuk56r7IEE1WEdVeou24EYX1 PSd2FvpQk2BJ7Yn1B/GTcFZZdXUeKIiAg8vUeZ+G1FU34sJYLr707rGQ+J0tCyU/8SKB daIVPKlwWOUBSAPOc4zSbL3FpCEYVB9VaNXgQjykEc0RRG1ox5UD1jPQFl2eOxzaYDEK zKF/eXZX5Cbo6Xc6dgi3LCC3rqfL0oSV06MDRHoOpRaQSRYjNbbVO2ryixk7rZ0T6mm6 0beA== X-Gm-Message-State: AOAM530c6p7b4bm654KkA7Dj0iogSfLKoOXJirZznxPpcfIOg+4ckEuG Cw9jaqKitG+jUzGCObN6Rgc= X-Google-Smtp-Source: ABdhPJw5q8BuMay7YNkighlsztgbLfZZdGHwV0q7cVvm+4rocaQYXLYF6/wLovq1y7GxEBdBHgytmQ== X-Received: by 2002:a05:620a:e0e:: with SMTP id y14mr38546992qkm.760.1641409150501; Wed, 05 Jan 2022 10:59:10 -0800 (PST) Received: from localhost (pool-96-232-253-158.nycmny.fios.verizon.net. [96.232.253.158]) by smtp.gmail.com with ESMTPSA id bm21sm632552qkb.86.2022.01.05.10.59.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jan 2022 10:59:10 -0800 (PST) From: dick To: Stefan Monnier Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> Date: Wed, 05 Jan 2022 13:59:09 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 05 Jan 2022 13:35:42 -0500") Message-ID: <87bl0quhz6.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46722 X-Mailman-Approved-At: Wed, 05 Jan 2022 14:07:37 -0500 Cc: 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > So the underlying bug only appears if either the hash-table is rehashed > or the new `sxhash-equal` value happens to the same as the old one. I can't say I understand this, but I'm contented if map-tests.el stops flapping. > The benefit of the `method-cache` OTOH should be very significant > since without it we'd have to recompute the effective method at every > call. I don't get it. This assumes `method-cache` persists between successive calls to the byte-compiled closure... but `method-cache` is clearly let'ted. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 14:17:32 2022 Received: (at 46722) by debbugs.gnu.org; 5 Jan 2022 19:17:32 +0000 Received: from localhost ([127.0.0.1]:41891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Bmt-00056I-H9 for submit@debbugs.gnu.org; Wed, 05 Jan 2022 14:17:32 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Bmq-00051r-Q4 for 46722@debbugs.gnu.org; Wed, 05 Jan 2022 14:17:29 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C9C52441D75; Wed, 5 Jan 2022 14:17:22 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3C4DF440780; Wed, 5 Jan 2022 14:17:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641410241; bh=D079Nsg3YVlN4PbbA7tuj0nvnQUdVr3rj0imm7mA2Kw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gXiuTp5zSxyGdOQuyLBfgXNG/4VptHWoJIOzuAhN5n8kuBLGLoeQ8Y1UN6K3Gq3Az uql19g8wW9XzwIiN5TDn1GadSg1oXhPpbkNnDQAaNI8yew87RihpKFD7rJ38wGJzLf pBgdE5dnnVr4oNhODJaIpueLIrJGA+hAV0wYzb+oTQ8OeuYogiwMc0qrq7RohR3H22 RqfqXNTzP49iHxTfHKnJHp9f5ZafF95Zfqcu9q/f1Sq6nDEg6KN2w/3w8cLtND82Jj 6KF+UrpDH7TqldHn1OSKjCfk1ZfGq4r63i7cFihNAu2cZTjkoFXfwGCikszDIHSzVK GfQNPqjCF1cwQ== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0953412033F; Wed, 5 Jan 2022 14:17:21 -0500 (EST) From: Stefan Monnier To: dick Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87bl0quhz6.fsf@dick> Date: Wed, 05 Jan 2022 14:17:19 -0500 In-Reply-To: <87bl0quhz6.fsf@dick> (dick's message of "Wed, 05 Jan 2022 13:59:09 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: 46722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> So the underlying bug only appears if either the hash-table is rehashed >> or the new `sxhash-equal` value happens to the same as the old one. > I can't say I understand this, but I'm contented if map-tests.el stops fl= apping. Basically, here's what happens: On one call, `dispatch` is of the form (1 # #) because the arg n=B01 has methods that use `eql` and `t`. So an entry for it is placed in bucket 7 of the hash-table (say) with the corresponding "eq + t dispatch function". Now, this very `dispatch` object is also stored in the generic function metadata. And later on, some new `cl-defmethod` is executed which means the arg n=B01 now also has methods that use `head`, so this object is modified (by setcdr) to (1 # # #). Since it's the very same object, it means that the hash table now has a mapping from (1 # # #) to the "eq + t dispatch function", which is wrong and the core of problem. Luckily for us, this problem has not bitten us very often because, the hash of (1 # # #) is not the same as the hash of (1 # #) so our (now incorrect) entry (still placed in bucket 7) will simply never be found by `gethash` because gethash will look for it in another bucket. >> The benefit of the `method-cache` OTOH should be very significant >> since without it we'd have to recompute the effective method at every >> call. > > I don't get it. This assumes `method-cache` persists between successive > calls to the byte-compiled closure... but `method-cache` is clearly let't= ed. It does persist: the byte-compiled closure is a "dispatcher builder". The function we store in the `symbol-function` slot of generic functions, is the (lambda (,@fixedargs &rest args) ...) function *returned* by this function. This inner function has the method cache in its captured environment which is why it persists between calls. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 14:23:50 2022 Received: (at 46722) by debbugs.gnu.org; 13 Jan 2022 19:23:50 +0000 Received: from localhost ([127.0.0.1]:34624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n85hO-0005yA-30 for submit@debbugs.gnu.org; Thu, 13 Jan 2022 14:23:50 -0500 Received: from mail-ot1-f49.google.com ([209.85.210.49]:38616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n85hI-0005xl-M7 for 46722@debbugs.gnu.org; Thu, 13 Jan 2022 14:23:48 -0500 Received: by mail-ot1-f49.google.com with SMTP id g1-20020a9d6481000000b00592d01f2b6eso3398142otl.5 for <46722@debbugs.gnu.org>; Thu, 13 Jan 2022 11:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6THbI0OozX88tIPnOxzx6YHK/aFv1jxKcrTYAVLKmfQ=; b=haDLNaR0qupihNWfSR667Rva6HzweGwIWxMMp9kW2JYLHsNHoZQE2tGPvnLoKbmPEW MFWZzrKK1TE2QhI8Yd1XmvOshOmA0H9R13yfcJXGSf1jLrIKpTjGp4wKVa3UFxpQS6iJ /yMIMcWZMa32ZnjMXBgrYg18f2nhHNE4EUGzKVlu/UfhFPSIW70dmXR4j1MCJ50LpgL+ YHROSGEJlrfoCyk9O2motGm6fbrPv9toLUvWhvAyROfIuWql1P6Lh6gWw84g+eEZJ4nh aevgLeowfVKJE3BjUYeo2OnbmKf+/2Pb7LgwW8Feh5JUdN+QrsK/HeE+LwOGUG2WiEDq ebaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6THbI0OozX88tIPnOxzx6YHK/aFv1jxKcrTYAVLKmfQ=; b=mq63ND5cuy9sL3QPO6UPTUsWXo9KeoBaUsj42caVl4eWcnPC8Z++xUkDNN1kC43ljy emzFraqyF/5GT7CI9BBuox0cwBtaJynu1cJDjD7V1HTvG8mO90FcC+Q2K0qIPeH0BD/U G6OITyP8sAXip7HvIHpITm7Rz2JjWjeU6yZo1L1Bi8WNBJ1LNEh6Tk427iCRVXB3FI0o i814z3M75H+UXXqxg2z0Uxg8pkqGPoCz2b9oGKMpuponKPfxIO/dBgh/zpeaiHoTFURT GzxEeVkfc307K5t1rxl/NJ+6CntHL1PIJIQRIQqz40BD2jC70AkNbRqo0sQeJbupcwRV ndMA== X-Gm-Message-State: AOAM530Z726G+QTSHNGHx+6IdlH/ezIKBYHE1Eeb67+seXeqiWNO/jji Fp9tHL56mGtBvLzT/XW8RXAV1ekh7D3vFTt2peo= X-Google-Smtp-Source: ABdhPJzwH/IjBhem6wL+qLYBmVrNlBiQGq/occO8UtCDeM+wgU+3eQ+jVyTpaY/oC4fBCuOZfG5W1kdZ4xhrr3y0t7Y= X-Received: by 2002:a9d:53c6:: with SMTP id i6mr4169723oth.96.1642101818914; Thu, 13 Jan 2022 11:23:38 -0800 (PST) MIME-Version: 1.0 References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> In-Reply-To: From: Philipp Stephani Date: Thu, 13 Jan 2022 20:23:28 +0100 Message-ID: Subject: Re: bug#46722: test-map-into fails To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , Stefan Kangas , "Basil L. Contovounesios" , dick.r.chiang@gmail.com, 46722@debbugs.gnu.org, Eli Zaretskii , Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Mi., 5. Jan. 2022 um 19:25 Uhr schrieb Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors : > > And we nowadays use generics a lot, so this could potentially affect > > gobs of code. So I'd rather we didn't install this on the > > release branch. > > Fine by me, Should the affected tests (these map tests, but I think I have a similar case with the bindat tests) be marked as unstable in the meantime? From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 15:40:33 2022 Received: (at 46722) by debbugs.gnu.org; 13 Jan 2022 20:40:34 +0000 Received: from localhost ([127.0.0.1]:34697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86td-000218-Is for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:40:33 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86tb-00020q-Mz for 46722@debbugs.gnu.org; Thu, 13 Jan 2022 15:40:32 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 46B541001A5; Thu, 13 Jan 2022 15:40:26 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A4E9D100178; Thu, 13 Jan 2022 15:40:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642106424; bh=Z3jbN2kdYBD8po8OE8PXAbsbbfSIrkd/ypZv8mfp9G0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=b3RX0INTgiuUBvXDkAF1m9iy82XACKCmhFwqtdBkRoU60Jv6RuEk1VBB43wwRp6fA O/HVWj5QCNbS8mDz2bdKidg5I6iQN9PuxY5HdbIWnNLwxUvuLHFZNOH+1+v+Sl6vXd KNjlEyrQSc3AdrKjID722xdtqxPFLQepV8PK0H7Ti0rrohJKvKp+ZhTwccgdZqdp2m y2NlaUX1g1eXaidQSAqxy/CGHu3Vo25peoHqp1afU4HPVnMLbW3x7oZgN7sbSxQq+l 3P1k9h+XbB5R9mtBsJdeplV74CaY12b6f72AcFiCu4+t52G9ve8ZcF9tK0yfOQwUlM dfTzJQflR9qfw== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 513741203CD; Thu, 13 Jan 2022 15:40:24 -0500 (EST) From: Stefan Monnier To: Philipp Stephani Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> Date: Thu, 13 Jan 2022 15:40:23 -0500 In-Reply-To: (Philipp Stephani's message of "Thu, 13 Jan 2022 20:23:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , Stefan Kangas , "Basil L. Contovounesios" , dick.r.chiang@gmail.com, 46722@debbugs.gnu.org, Eli Zaretskii , Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp Stephani [2022-01-13 20:23:28] wrote: > Am Mi., 5. Jan. 2022 um 19:25 Uhr schrieb Stefan Monnier via Bug > reports for GNU Emacs, the Swiss army knife of text editors > : >> > And we nowadays use generics a lot, so this could potentially affect >> > gobs of code. So I'd rather we didn't install this on the >> > release branch. >> Fine by me, > Should the affected tests (these map tests, but I think I have a > similar case with the bindat tests) be marked as unstable in the > meantime? By "in the meantime" I assume you mean something like "on the release branch", right (since the problem is supposedly fixed in `master`)? Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 15:45:50 2022 Received: (at 46722) by debbugs.gnu.org; 13 Jan 2022 20:45:50 +0000 Received: from localhost ([127.0.0.1]:34701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86yk-0002AX-8N for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:45:50 -0500 Received: from mail-ot1-f52.google.com ([209.85.210.52]:46929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86yf-0002AB-G1 for 46722@debbugs.gnu.org; Thu, 13 Jan 2022 15:45:48 -0500 Received: by mail-ot1-f52.google.com with SMTP id t4-20020a05683022e400b00591aaf48277so7712529otc.13 for <46722@debbugs.gnu.org>; Thu, 13 Jan 2022 12:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KmpNCkLnJ07L+DgX+nCsme8sCi8Q11+OCXg7i2vHfdc=; b=lJV2e1Daxdhc3AaRra3zUXdPY4p9Dx6gPJHJ18SO/vO1QCZQoEjwzctLQdOuMOJ9xZ riRgl3t6sIVsUfSTqP4i8h0ZN0C0SW8IbI+Qk9IUf09x6dNcb4IX4uckzE/Ij5yzUzzs 5kacxYh5eU6btKPneaguZW3n4nr1as/ot5XqyXtzehxZXhRwG6Dw5xMilvP4F70Cp+ci K9vCOi+Z6wxuzg6yCo4hjs0RLGg0y2+R2DG3oAIoGaSZREqEew2qiz2f2E6Q0k3QZ1DU +hsZs1gwG2DVNvLaO447u5aaPO+P9JM/jQz12rKnS6F4RdabJVRGv2w5x3REO1Y09PcY DQpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KmpNCkLnJ07L+DgX+nCsme8sCi8Q11+OCXg7i2vHfdc=; b=8A5JjKQqYmFhvcLAuvVUa+ivr3TffDZsUdiuFn8h7KdChCI3JrifOCyDnZjzO2n2BN yyvOJ/wIvB6i7zhpnTDihmBDk9vcW+6frFoevAGCj0kvIjXoh+TK7sfwnwillo4NEFTu DhH3JWHAg9CjcQCVHXFh3RiNz8mpQiiBoa2nHUO62Bt2nInucBEdLRAdhfSZXYi0lf3w Zb1GH8HHWuR/jrTKNuXN8BzWQ96GsEY2+D3/vOiFzgOk+fk5OCAzk1kHKKbhuhtL05xp NHepU/9ffXeD7QSA3VZ+qwh4rEiLNRQJ2n62D3AYmHzuHMhIC+mgt+LOu61S5eETXCm3 ZCzA== X-Gm-Message-State: AOAM530cYn6tt13HC7V2cRUK15M01X//934vKapkpXfoB218fpuxxRaP wN0K5Aje3i63Ic0DcHB9VWGwWtZW4pD39HM7QfI= X-Google-Smtp-Source: ABdhPJzzEc9Xv5oueCQUyO+JfKDmMB1PFhbNj8DSaHrnSaJvzeO4eklRpA6Jf2N92hpejjteoSowUiaCZV8fZT98kZ8= X-Received: by 2002:a05:6830:1e61:: with SMTP id m1mr4248407otr.224.1642106739894; Thu, 13 Jan 2022 12:45:39 -0800 (PST) MIME-Version: 1.0 References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> In-Reply-To: From: Philipp Stephani Date: Thu, 13 Jan 2022 21:45:28 +0100 Message-ID: Subject: Re: bug#46722: test-map-into fails To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , Stefan Kangas , "Basil L. Contovounesios" , dick.r.chiang@gmail.com, 46722@debbugs.gnu.org, Eli Zaretskii , Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Do., 13. Jan. 2022 um 21:40 Uhr schrieb Stefan Monnier : > > Philipp Stephani [2022-01-13 20:23:28] wrote: > > Am Mi., 5. Jan. 2022 um 19:25 Uhr schrieb Stefan Monnier via Bug > > reports for GNU Emacs, the Swiss army knife of text editors > > : > >> > And we nowadays use generics a lot, so this could potentially affect > >> > gobs of code. So I'd rather we didn't install this on the > >> > release branch. > >> Fine by me, > > Should the affected tests (these map tests, but I think I have a > > similar case with the bindat tests) be marked as unstable in the > > meantime? > > By "in the meantime" I assume you mean something like "on the release > branch", right (since the problem is supposedly fixed in `master`)? > Yes From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 02:40:22 2022 Received: (at 46722) by debbugs.gnu.org; 14 Jan 2022 07:40:22 +0000 Received: from localhost ([127.0.0.1]:35326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8HCA-0000wg-3k for submit@debbugs.gnu.org; Fri, 14 Jan 2022 02:40:22 -0500 Received: from quimby.gnus.org ([95.216.78.240]:34126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8HC8-0000wS-LR for 46722@debbugs.gnu.org; Fri, 14 Jan 2022 02:40:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NcTExKwse99GhQmw9ELslaUuINeaJ8hZx2JU9h22tUo=; b=bCjNAs9QvsAPuVG6e/kW/FBTh2 fc06ydo+Zn5r7hrNdZEM1+KI2z3KYRNgJp75NhzLBQxf85Swf1xFmE9s8zbOfrKRpamH/j8YxZNrp 7sKUElJV664nmJp2Kdnd1Q9ZN9q2yfifiZU4lM0dBafGpz9LndhLkMEhf2r1DGxk2ZEE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8HBy-0001Lg-Oq; Fri, 14 Jan 2022 08:40:13 +0100 From: Lars Ingebrigtsen To: Philipp Stephani Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> X-Now-Playing: Various's _I Wanna Be Kate: The Songs of Kate Bush_: "Suspended In Gaffa (2020 Remaster)" Date: Fri, 14 Jan 2022 08:40:10 +0100 In-Reply-To: (Philipp Stephani's message of "Thu, 13 Jan 2022 21:45:28 +0100") Message-ID: <87pmouu5np.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: >> By "in the meantime" I assume you mean something like "on the release >> branch", right (since the problem is supposedly fixed in `master`)? > > Yes Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , Stefan Kangas , "Basil L. Contovounesios" , Stefan Monnier , 46722@debbugs.gnu.org, Eli Zaretskii , dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp Stephani writes: >> By "in the meantime" I assume you mean something like "on the release >> branch", right (since the problem is supposedly fixed in `master`)? > > Yes Now done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 14 07:02:33 2022 Received: (at 46722) by debbugs.gnu.org; 14 Jan 2022 12:02:33 +0000 Received: from localhost ([127.0.0.1]:35787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8LHt-0001U9-5I for submit@debbugs.gnu.org; Fri, 14 Jan 2022 07:02:33 -0500 Received: from mail-ot1-f42.google.com ([209.85.210.42]:38704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8LHr-0001Ts-DH for 46722@debbugs.gnu.org; Fri, 14 Jan 2022 07:02:31 -0500 Received: by mail-ot1-f42.google.com with SMTP id g1-20020a9d6481000000b00592d01f2b6eso5701648otl.5 for <46722@debbugs.gnu.org>; Fri, 14 Jan 2022 04:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gzogjmOMyOho89J38qAzoLlx3ri4q59fTIZoFT1JBEk=; b=MPLP+5jQGVcjBS+AXjERF57xy4p/KfLhvqxG1nSnYhu+kUqyi1dURSVxARiFBiCSru QT8KbBjTaZw+eM0dA/LL/AwsDJHMcmizjJ6MMdY8t8OjaXh5sI84QGXqux/T4HMxModj MRsTSQO3tGDEfzzGQJOzZpapveNZ5rd57q7uxYCEnVLU8GaNfQJqBlaAKNwcd2iUGIBi k/jBCcEX5UIiQMr4+re9WTZax1p3wM1wGP/PNZsX4VQ9wfXFokbmpmxYD4zTerqLoNbJ 4wxN0557B+C/0AsQnJz+8qQyr+w0FgNrYomVPETg6vHr7CJL0M76rYE6VJY8devbrIRH ZRLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gzogjmOMyOho89J38qAzoLlx3ri4q59fTIZoFT1JBEk=; b=zpIaXEBenV+QA0CZ0WMIy6oDAu9Zv5St4/ciAcos5paZVNsi05Ge2qfOTNrrMysdRU EPFuwIj3k5kJn55lITYdYWp8tvfjZWNJZFbFqHMctOZMgrWcWKZmwXPMwBslavXclK9X VE7uz+STY14SwLMVVhwjDtyFOipi4EU0KljKGTU6EF2ugRhk2UgxSYal6Gi54dlh7C+h BJHnoT2YCQLc39JoxXySmvwiEy4BP8mT7u/Yl1cZW7TEZsTL+ygCRoANthpy6HCZ76rv Yta6l62WpihdzpCfZAv6O1VYLQ2aBdv6Tkg49rd/TZ1QRrj7/9GOScKL4wYeabhXr1uf hmzw== X-Gm-Message-State: AOAM532aoeRkA6IfMahPfPSzzTfyn6bGJKrjhHtWJJTDHTlDpEbNGRUp qiAsHJGUInz7TcZz67yqFP8n4SQKkElDkU5e3RA= X-Google-Smtp-Source: ABdhPJw07z0nVwlklQf4H4bZNkoy6Qw2naXgzh8I3n7PAAejNkik9rGByN3cTuuQR7KdlpEOAFTDNXD788yryM7Rags= X-Received: by 2002:a05:6830:1e61:: with SMTP id m1mr6317654otr.224.1642161745691; Fri, 14 Jan 2022 04:02:25 -0800 (PST) MIME-Version: 1.0 References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> <87pmouu5np.fsf@gnus.org> In-Reply-To: <87pmouu5np.fsf@gnus.org> From: Philipp Stephani Date: Fri, 14 Jan 2022 13:02:14 +0100 Message-ID: Subject: Re: bug#46722: test-map-into fails To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , Stefan Kangas , "Basil L. Contovounesios" , Stefan Monnier , 46722@debbugs.gnu.org, Eli Zaretskii , dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Fr., 14. Jan. 2022 um 08:40 Uhr schrieb Lars Ingebrigtsen : > > Philipp Stephani writes: > > >> By "in the meantime" I assume you mean something like "on the release > >> branch", right (since the problem is supposedly fixed in `master`)? > > > > Yes > > Now done. > Thanks. In my case I also got flaky results for test-map-merge-empty, test-map-into-hash-test, test-map-merge-with, and test-map-merge, as well as the bindat tests (they already fail at loading/byte-compilation time with (cl-no-applicable-method bindat--type unpack (dest-ip ip) (src-ip ip) (dest-port uint 16) (src-port uint 16))); any objection to marking them (or even all affected tests) as unstable, too? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 03:01:40 2022 Received: (at 46722) by debbugs.gnu.org; 15 Jan 2022 08:01:40 +0000 Received: from localhost ([127.0.0.1]:38873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8e0K-00052a-5f for submit@debbugs.gnu.org; Sat, 15 Jan 2022 03:01:40 -0500 Received: from quimby.gnus.org ([95.216.78.240]:46150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8e0J-00052O-5K for 46722@debbugs.gnu.org; Sat, 15 Jan 2022 03:01:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5LH4sT1yAKOfMAjcudSe99UPBtscFjleKZqQVD7Mk48=; b=d+P84A/s9f7XNCzXCddNh7h/qL 1B5vBII0Gzu7hWS1NMizM6ClYbctsz0WgyRL6fIVPSyWyCbKsxY+kh6X2e0NLeja4ceyk9QDCTl1N zOqTZFlOeok7D2N6bCOMMXxnhvPPRl7DCGCCf9lD4HwE+JtyGgF2OFAcHUmxGgu8QdQM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8e09-0002Qf-0G; Sat, 15 Jan 2022 09:01:31 +0100 From: Lars Ingebrigtsen To: Philipp Stephani Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> <87pmouu5np.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEX16t2UXz5VNytR MSfWlGD////m+Z8KAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YBDwc6ESOcg9cAAAGmSURBVDjLdZTb ldwgEEQ1Pg7A1eoEGpyAwAGAhvxjcjWPmdGulg8diUv1G23bT+sRguH72rZf2VeMKaYc3qsM8LED +FPbVOScwuf6ACRk8QZwaQ1ul2e+AGjb55ErELTnPcgh3gKY5Xvwd7v1kXDcOz+qafcRXyB0YPWo h3iqF4BoNSNhZf5YdtqJlhureAEhVQep+S4/3wptDlAYVaL3V1SGilMJMPr2AiogKCi9JmkByxCK tLTy7ImsssdsvQn6e3v2jrxAMqNX4+cV0Kr6EGjZnqm3/wKApmVnGqvnKfY6AVFRxyzIBdRkkBA4 eXPgOjiosA7GiP1xMJwwkwMCizw5Qc/J9jmr4l2IHQTXJBnVdN8cbwd8cw1m/aO3bZjqLcj/9nDA EHaXTuddcpzpAKpEl8aloIS7LHCtonsP95H6TZNgWhWtMZ/KnUIQ1r2rqmcvGQb4uJKl+tPbSYCv QOycpl62MEzRk4N1zUU8KEwnBKwpmydrR8RP1m7KeNZz5hWUKXcwNlkOsG/vMPxfMoaadrSId9zC jIqmAlXVFctW+fGv9B9uV6ECSnYrMwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMS0xNVQwNzo1 ODoxNyswMDowMB4v7YEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDEtMTVUMDc6NTg6MTcrMDA6 MDBvclU9AAAAAElFTkSuQmCC X-Now-Playing: Joni Mitchell's _Archives: The Early Years (3)_: "Intro To Song To A Seagull (Live at The 2nd Fret, Philadelphia, PA, 3-17-1967)" Date: Sat, 15 Jan 2022 09:01:26 +0100 In-Reply-To: (Philipp Stephani's message of "Fri, 14 Jan 2022 13:02:14 +0100") Message-ID: <8735lpo2ax.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp Stephani writes: > Thanks. In my case I also got flaky results for test-map-merge-empty, > test-map-into-hash-test, test-map-merge-with, and test-map-merge, as > well as the bindat tests (they already fail at > loadin [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , Stefan Kangas , "Basil L. Contovounesios" , Stefan Monnier , 46722@debbugs.gnu.org, Eli Zaretskii , dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp Stephani writes: > Thanks. In my case I also got flaky results for test-map-merge-empty, > test-map-into-hash-test, test-map-merge-with, and test-map-merge, as > well as the bindat tests (they already fail at > loading/byte-compilation time with (cl-no-applicable-method > bindat--type unpack (dest-ip ip) (src-ip ip) (dest-port uint 16) > (src-port uint 16))); any objection to marking them (or even all > affected tests) as unstable, too? Marking the other test-map* functions as unstable (on the release branch) should be fine. Are the bindat tests also failing because of the map problems, or is that unrelated? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 06:47:51 2022 Received: (at 46722) by debbugs.gnu.org; 15 Jan 2022 11:47:51 +0000 Received: from localhost ([127.0.0.1]:39283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8hXD-0006Gz-I0 for submit@debbugs.gnu.org; Sat, 15 Jan 2022 06:47:51 -0500 Received: from mail-ot1-f41.google.com ([209.85.210.41]:45055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8hXC-0006GG-Bz for 46722@debbugs.gnu.org; Sat, 15 Jan 2022 06:47:50 -0500 Received: by mail-ot1-f41.google.com with SMTP id w19-20020a056830061300b0058f1dd48932so13317046oti.11 for <46722@debbugs.gnu.org>; Sat, 15 Jan 2022 03:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QBfRpJ1GLtFpIWGlFvwp5n1T90CxquVkNqzttwnyF+Q=; b=gOACTrtIqpDeM1HJU0Wj9XYigIMsvq+qBE8OfFBWOXe1yPBHCnc36f/X6i3jBgIP9T OaRWLQY6SrGpVBfh+qxLV0MImvAZA8clJj04n1NITHNhQ6UbO0bZE5Fh2H3VHygQGMfd dDEMsZLsdLuDSATxt8Rwth+lMq3Pq2bzkSdr2rawmyk9t0I3a9RNlJiS/1ELD8czJ0m6 SJtLM3j/x+VDn9rPywNk6yh3AQrtNhI+Ap5H48QJZGQbcaTit3936WR5BWE3wLGgh0El qS5l5J74RVpruMZfyeTOS5tCN6EvOTpyXASmJZivflc6fpEAoC0QZBffkj9MPY9cK+jO yEdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QBfRpJ1GLtFpIWGlFvwp5n1T90CxquVkNqzttwnyF+Q=; b=Wwdlspj44pHJuyNlNI9clVrMVhqyl93HypDDWS82KxmOiblSuXb/pifvLJtE/1IlxD l4DvZicQgbqJHzSypoJ8tiNXt3jk7SZ+HJEFre/UtzYjKEJDEw6LfHyDs2+Yl6TLJGpK 4V+NJaxfzOTOpHpotAUzOe6aFwPJg4YIq049bgLtwUgCFj5BpPUjSMsA36U7EVOnfAsh Dc27h+rhs95dUyp8iTzAlP1qd4tFNX/ixqAw5CTErr97j6grpTD4l/QsSGzFy6Sm3SGN 7ony1UY8iHjnyh1HxD29kwUp3QajBoKq2qkur5FmnXsEVVnScBvjeKjD6Jz9bmDY/dPo vUJA== X-Gm-Message-State: AOAM533lPy9G8syJ67uXsU2fROdLJ9SUpqiBlc0tayhBMILewpeHzDiJ sCimD7gxFcRAR8veBJQyuH2SkPiRxMieKEm2BsE= X-Google-Smtp-Source: ABdhPJxx1OIxR2CpzjjyYWM+qX51w3ha0BeEShilInHO3yt8V86MR4JOXyKEPEg5BkrT4G0zEjmk+9jMUEDYlCRvmEU= X-Received: by 2002:a9d:69d2:: with SMTP id v18mr6095845oto.264.1642247264696; Sat, 15 Jan 2022 03:47:44 -0800 (PST) MIME-Version: 1.0 References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> <87pmouu5np.fsf@gnus.org> <8735lpo2ax.fsf@gnus.org> In-Reply-To: <8735lpo2ax.fsf@gnus.org> From: Philipp Stephani Date: Sat, 15 Jan 2022 12:47:33 +0100 Message-ID: Subject: Re: bug#46722: test-map-into fails To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , Stefan Kangas , "Basil L. Contovounesios" , Stefan Monnier , 46722@debbugs.gnu.org, Eli Zaretskii , dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Am Sa., 15. Jan. 2022 um 09:01 Uhr schrieb Lars Ingebrigtsen : > > Philipp Stephani writes: > > > Thanks. In my case I also got flaky results for test-map-merge-empty, > > test-map-into-hash-test, test-map-merge-with, and test-map-merge, as > > well as the bindat tests (they already fail at > > loading/byte-compilation time with (cl-no-applicable-method > > bindat--type unpack (dest-ip ip) (src-ip ip) (dest-port uint 16) > > (src-port uint 16))); any objection to marking them (or even all > > affected tests) as unstable, too? > > Marking the other test-map* functions as unstable (on the release > branch) should be fine. OK, I've now done that with commit 2dcb1bc47485791177917bfbd8fba95d69454135. At least in my experiments only the four ones that I marked are unstable. > > Are the bindat tests also failing because of the map problems, or is > that unrelated? It's at least the same symptom ("No applicable method", but only sometimes), so I guess it's also the same root cause (the cl-generic cache thingy discussed in this thread). In this case the problem already appears when expanding the bindat-type macro (i.e. when loading or byte-compiling the file), so we'd need to exclude bindat-tests from the test suite altogether on the release branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 10:16:59 2022 Received: (at 46722) by debbugs.gnu.org; 15 Jan 2022 15:16:59 +0000 Received: from localhost ([127.0.0.1]:41509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8knb-0004hT-H7 for submit@debbugs.gnu.org; Sat, 15 Jan 2022 10:16:59 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8knZ-0004hD-FS for 46722@debbugs.gnu.org; Sat, 15 Jan 2022 10:16:57 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AEC061001AC; Sat, 15 Jan 2022 10:16:51 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A8159100120; Sat, 15 Jan 2022 10:16:49 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642259809; bh=Awb/z/L+Qiz94ALm1lFIhqXMrURuNHqD8t7LfxQCOFI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bhIb3sn395dDUY7tIVSkM3bzjIUSYJ4tLc1SR48PrMBfQIBvmpa+iYy0esV8ujKq5 QoX7tGl9W/HlC/+E4N3oDrHxjMrTclNNP9nPjsMMLoz+QO/V5zxYtkIeEMEPUCmBAi 0SBLymZe/f24wUdAFX1TYNo5nEF1UyJYdX7cA9FI8Kx0O15kV3z0bbsROTq35nTW/x LJ06XBzUNqH2sn0dIKncHV86xD+1Syfr+8Wi0YsYUM6hhldP7RDg9CqvrU91JmzHgd oEV2cj1HfW8TJ4BPbLQcrg2+mC1QhgzDG6wmJBmioKs5IdAryyP1GDP+0wptDS04aW IPrhhFCut1aQw== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2EEC21201BB; Sat, 15 Jan 2022 10:16:49 -0500 (EST) From: Stefan Monnier To: Philipp Stephani Subject: Re: bug#46722: test-map-into fails Message-ID: References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> <87pmouu5np.fsf@gnus.org> <8735lpo2ax.fsf@gnus.org> Date: Sat, 15 Jan 2022 10:16:48 -0500 In-Reply-To: (Philipp Stephani's message of "Sat, 15 Jan 2022 12:47:33 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: Glenn Morris , Stefan Kangas , "Basil L. Contovounesios" , dick.r.chiang@gmail.com, 46722@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) FWIW, I think installing the cl-generic patch into `emacs-28` would be a much better option. In my view it's "super safe" and it fixes a nasty bug that can affect a lot of code (as we're witnessing here with those test problems). It admittedly doesn't fix a regression. For reference the patch is just: diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el index 983694204df..5090e060372 100644 --- a/lisp/emacs-lisp/cl-generic.el +++ b/lisp/emacs-lisp/cl-generic.el @@ -604,7 +604,9 @@ cl--generic-dispatchers (defun cl--generic-get-dispatcher (dispatch) (with-memoization - (gethash dispatch cl--generic-dispatchers) + ;; We need `copy-sequence` here because this `dispatch' object might be + ;; modified by side-effect in `cl-generic-define-method' (bug#46722). + (gethash (copy-sequence dispatch) cl--generic-dispatchers) ;; (message "cl--generic-get-dispatcher (%S)" dispatch) (let* ((dispatch-arg (car dispatch)) (generalizers (cdr dispatch)) It's already the second time I say it, so I promise it's the last time I insist here. I can live with either choice, but I'm sure Emacs-28 will be better off with the patch than without. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 10:55:45 2022 Received: (at 46722) by debbugs.gnu.org; 15 Jan 2022 15:55:45 +0000 Received: from localhost ([127.0.0.1]:41571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8lP2-0005m5-WA for submit@debbugs.gnu.org; Sat, 15 Jan 2022 10:55:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8lP1-0005lr-8D for 46722@debbugs.gnu.org; Sat, 15 Jan 2022 10:55:40 -0500 Received: from [2001:470:142:3::e] (port=60304 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8lOu-00021h-HJ; Sat, 15 Jan 2022 10:55:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BBWdeMKOhHBTYEnFDg0losecl+hQPrWCz7CGvguv7Io=; b=guQTkdqExiWJ O2mR7qgBuOJskMXnMeld0uS9V3HR1L4rhGWomU+TnFgLFdQbbDN5Lf3yq9KjBxYVRJAdw63/tiDID vZD4ykSvn+Mrgx5oXTkOC6bYFF7jesP0DjKFLgw7kIB6AJLHizFN4y2KqW1NbnPb5wTaMqoKnQVHO RVTjeEzFCFdswcW7WdS9Tn7pjN6a0jz4filfRjL7PvnTZ0OKTKV3EC/DGp9mbGYa2w4UTyWbRed5Q YFGJLX/xo/+qWb1wt/GtKafEeyj6Bt1G72MMs+SmMC+CK8m8BCScTciIYYSBAtUdFyh5Z5gw+xwDn aZk5bYKPx3+U0dus9WNwSQ==; Received: from [87.69.77.57] (port=4421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8lOj-0007T0-SJ; Sat, 15 Jan 2022 10:55:30 -0500 Date: Sat, 15 Jan 2022 17:55:01 +0200 Message-Id: <83tue5yox6.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sat, 15 Jan 2022 10:16:48 -0500) Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> <87pmouu5np.fsf@gnus.org> <8735lpo2ax.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: rgm@gnu.org, stefan@marxist.se, contovob@tcd.ie, p.stephani2@gmail.com, dick.r.chiang@gmail.com, 46722@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > From: Stefan Monnier > Cc: Lars Ingebrigtsen , Eli Zaretskii , > Glenn Morris , Stefan Kangas , "Basil > L. Contovounesios" , dick.r.chiang@gmail.com, > 46722@debbugs.gnu.org > Date: Sat, 15 Jan 2022 10:16:48 -0500 > > It's already the second time I say it, so I promise it's the last time > I insist here. I can live with either choice, but I'm sure Emacs-28 will > be better off with the patch than without. My opinion is up-thread, so I guess it's up to Lars now. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 19 11:46:12 2022 Received: (at control) by debbugs.gnu.org; 19 Jan 2022 16:46:12 +0000 Received: from localhost ([127.0.0.1]:55353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAE67-0008Fm-Oc for submit@debbugs.gnu.org; Wed, 19 Jan 2022 11:46:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAE61-0008Ex-Mq for control@debbugs.gnu.org; Wed, 19 Jan 2022 11:46:10 -0500 Received: from [2001:470:142:3::e] (port=42462 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAE5r-0005tn-4V for control@debbugs.gnu.org; Wed, 19 Jan 2022 11:45:59 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1nAE5A-0003VQ-Ud for control@debbugs.gnu.org; Wed, 19 Jan 2022 11:45:55 -0500 Subject: control message for bug 46722 To: X-Mailer: mail (GNU Mailutils 3.4) Message-Id: From: Glenn Morris Date: Wed, 19 Jan 2022 11:45:12 -0500 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) # 61f8f7f68f close 46722 29.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 19 11:47:48 2022 Received: (at control) by debbugs.gnu.org; 19 Jan 2022 16:47:48 +0000 Received: from localhost ([127.0.0.1]:55361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAE7g-0008KA-By for submit@debbugs.gnu.org; Wed, 19 Jan 2022 11:47:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAE7f-0008JT-2K for control@debbugs.gnu.org; Wed, 19 Jan 2022 11:47:47 -0500 Received: from [2001:470:142:3::e] (port=42494 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAE7Z-00067W-PO for control@debbugs.gnu.org; Wed, 19 Jan 2022 11:47:41 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1nAE7a-0001gD-6m for control@debbugs.gnu.org; Wed, 19 Jan 2022 11:47:42 -0500 Subject: control message for bug 53365 To: X-Mailer: mail (GNU Mailutils 3.4) Message-Id: From: Glenn Morris Date: Wed, 19 Jan 2022 11:47:42 -0500 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 46722 53365 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 07:50:09 2022 Received: (at 46722) by debbugs.gnu.org; 20 Jan 2022 12:50:09 +0000 Received: from localhost ([127.0.0.1]:56625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAWtE-00024x-PH for submit@debbugs.gnu.org; Thu, 20 Jan 2022 07:50:08 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAWtC-00024G-HF for 46722@debbugs.gnu.org; Thu, 20 Jan 2022 07:50:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kuHp+UcVg680a3Kpi8+WFcPoEILFA2svG2zglsyp6hw=; b=kiN7GYeGA3rflNpBqaTDz5M+i2 bs43e1osRAGz0uxKCUZa3gZpYbaNxotKDrqraEMK1g4sYFAdgV9PqSmrc5JJsk1U7wdEXZH0fBV7P w9r+ZKROrgrH7IAY1+GGcVK/jexY5TCRoDYfIbVUZ6Ze4NekADqjT6pc0hKS4ZEgc4s8=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAWt2-0005hY-1p; Thu, 20 Jan 2022 13:49:58 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#46722: test-map-into fails References: <871r2yu8b1.fsf@gnus.org> <87czl7w4fh.fsf@dick> <87a6gawabq.fsf@dick> <83a6ga9hu1.fsf@gnu.org> <87pmouu5np.fsf@gnus.org> <8735lpo2ax.fsf@gnus.org> <83tue5yox6.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEXYvrCyd2Q2HiP/ ///sZlnNAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YBFAwsHiT2FO4AAAF2SURBVCjPPZLNauMwFIWP SpRFVhlwAs3TyAV7MSsVfA3xuilET9G+QQaqQL3KYmTq+5RzJGfijfX5nPvjq4uVBRxWMA4dHsct LHpVHVRnvj6x0cdzwZOmcxoGLUqrx+n6XeAD63GMGt8zfOHl/fuqaVps/cDDnI7nwATrkugUbmvC Sz4nrxeTE/Ac5Zc2ZrHN4jazNRpZR1W8/bHm8ImD6igdzsAh28ZrPIkQPmhrJg3JAcFREbY/XayZ PSHmX0oib5Y2GQoc+dN7laAaYi8r5BgK7QKt5pBW2uiyciU0somu4gxGdvcsv8WZMiomSINkWwqZ 5hMbxNNXAf2Twcoywdj47QOk8Rb1AjMss+3+ww45JpTZmnw7tYRSytaLwpFO6oyvYOSQm7vxs8Gr DKlcVL7K3QJU4Gnr5zsY1H4/s7u/QMWwbq8EDs52qLs+KzfuQg2R/m7jdqwJwwIURfQOwLYyxvlq ZeBY575DLGnhXJe3zG+p/QPmJduKBeYB6wAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMS0yMFQx Mjo0NDozMCswMDowMOv8P8sAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDEtMjBUMTI6NDQ6MzAr MDA6MDCaoYd3AAAAAElFTkSuQmCC X-Now-Playing: Cristina's _Cristina_: "(Temporarily) Yours" Date: Thu, 20 Jan 2022 13:49:55 +0100 In-Reply-To: <83tue5yox6.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jan 2022 17:55:01 +0200") Message-ID: <87bl061si4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> It's already the second time I say it, so I promise it's the last time >> I insist here. I can live with either choice, but I'm sure Emacs-28 will >> be better off with the patch than without. > > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46722 Cc: rgm@gnu.org, stefan@marxist.se, contovob@tcd.ie, p.stephani2@gmail.com, Stefan Monnier , 46722@debbugs.gnu.org, dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> It's already the second time I say it, so I promise it's the last time >> I insist here. I can live with either choice, but I'm sure Emacs-28 will >> be better off with the patch than without. > > My opinion is up-thread, so I guess it's up to Lars now. I agree with Eli. And since this is fixed in Emacs 29 (and the tests marked in Emacs 28), I'm therefore closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 20 07:50:16 2022 Received: (at control) by debbugs.gnu.org; 20 Jan 2022 12:50:16 +0000 Received: from localhost ([127.0.0.1]:56628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAWtM-00025O-10 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 07:50:16 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAWtL-000257-4F for control@debbugs.gnu.org; Thu, 20 Jan 2022 07:50:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Nx9Mg46jVM5V4zib9Jx7TGraQl6596St7MocK3aCwm4=; b=LAt0CCjIvyhjMWkdX/W849XQFq pVPDNscjr5QgC4BtzGpLGYTEpsP5gDLEYrKwRdLqoj2ga6SdNRrWer+ANObi62PxExc4GN02HcTM6 +b43ArY4nKqOZCFKx6Gna1qE4WodZZRa4yWLJgmOfh421UuP1Yo/PbkJctQk9BEfFrLQ=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAWtD-0005hm-69 for control@debbugs.gnu.org; Thu, 20 Jan 2022 13:50:09 +0100 Date: Thu, 20 Jan 2022 13:50:06 +0100 Message-Id: <87a6fq1sht.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #46722 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 46722 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 46722 29.1 quit From unknown Sat Jun 21 03:29:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Feb 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator