From unknown Mon Aug 18 02:31:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#46717 <46717@debbugs.gnu.org> To: bug#46717 <46717@debbugs.gnu.org> Subject: Status: [PATCH 0/2] r-haven: Unvendor readstat Reply-To: bug#46717 <46717@debbugs.gnu.org> Date: Mon, 18 Aug 2025 09:31:24 +0000 retitle 46717 [PATCH 0/2] r-haven: Unvendor readstat reassign 46717 guix-patches submitter 46717 Lars-Dominik Braun severity 46717 normal tag 46717 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 08:05:06 2021 Received: (at submit) by debbugs.gnu.org; 23 Feb 2021 13:05:06 +0000 Received: from localhost ([127.0.0.1]:58518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXNC-0002vc-5E for submit@debbugs.gnu.org; Tue, 23 Feb 2021 08:05:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:38694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXN9-0002vR-BB for submit@debbugs.gnu.org; Tue, 23 Feb 2021 08:05:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEXN9-0005D8-6R for guix-patches@gnu.org; Tue, 23 Feb 2021 08:05:03 -0500 Received: from mout-p-202.mailbox.org ([2001:67c:2050::465:202]:24826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1lEXN6-0006Y2-B0 for guix-patches@gnu.org; Tue, 23 Feb 2021 08:05:02 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4DlK5b3dWPzQlSj for ; Tue, 23 Feb 2021 14:04:51 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1614085489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fXHdr5SWpzVATyOSTv3M9fVkiilfpPdgmlxFmlosaqA=; b=lV5NXuy0dzr96Btu/gmN1ttPZP2pUj6MRg9IbSQA0a+np0NFGv7PyjtUI9YR24Vf9xwZbi rHn4n9Z1B+fGReoCMCGGr08GAqs3ixAIpin/e50h60j8YRHKuiyl+DAmOHv3zLzAErIfIN Cwupp65YHa1oddHJjAttPvlUNdb9j/t1szbFG5G8bFr/z+FVBgrnscYzGV1pf8JAsAzN93 aRqtu41JGZjKSikf1Di2ASdrMTOuW+u7AmXV36x9ehxYqJmRcfiOlnJdlz18mmKWTUhSWc tYBLE8y/nQZuqJrPmWeZo8KpZtdrgaZVHQeEz8NG8pAb0jG3hG1It8CP0+5+eA== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id FtFcpIqmfxYM for ; Tue, 23 Feb 2021 14:04:47 +0100 (CET) Date: Tue, 23 Feb 2021 14:04:46 +0100 From: Lars-Dominik Braun To: guix-patches@gnu.org Subject: [PATCH 0/2] r-haven: Unvendor readstat Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -6.70 / 15.00 / 15.00 X-Rspamd-Queue-Id: 2985C186C X-Rspamd-UID: bce00b Received-SPF: pass client-ip=2001:67c:2050::465:202; envelope-from=lars@6xq.net; helo=mout-p-202.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I rebuilt all packages depending on r-haven and tried loading example files using r-haven’s read_* functions. There are no apparent modifications to the vendored source, based on a look at https://github.com/tidyverse/haven/commits/v2.3.1/src/readstat but it’s not quite clear which version they are using. Probably a git snapshot. Lars-Dominik Braun (2): gnu: Add readstat. gnu: r-haven: Unvendor readstat. gnu/packages/cran.scm | 19 +++++++++++++++++-- gnu/packages/statistics.scm | 28 ++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+), 2 deletions(-) -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 08:07:03 2021 Received: (at 46717) by debbugs.gnu.org; 23 Feb 2021 13:07:03 +0000 Received: from localhost ([127.0.0.1]:58524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXP5-0002z6-Iz for submit@debbugs.gnu.org; Tue, 23 Feb 2021 08:07:03 -0500 Received: from mout-p-101.mailbox.org ([80.241.56.151]:46504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXP4-0002yT-19 for 46717@debbugs.gnu.org; Tue, 23 Feb 2021 08:07:02 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4DlK8004thzQlY0 for <46717@debbugs.gnu.org>; Tue, 23 Feb 2021 14:06:56 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1614085613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=fAtjDyfewvq+c1a4N2OiQcX6leHFe7fkm08uTih6ezA=; b=WcXYMb9LuumFKDVUh1a9IyvTrVAIXVTMA34VZEtdROSMpeQiIKHfqwWxdvMFHNVK3bpvlA aEScnnWrlPFiWt9BHVJeJ8abwY1WDch6zSKyeuBvNtm/WvjhqFrMqBg6cGOcAnrFYBpSF/ ZCYXscPzWLgfqBuxWMfPmTww1y5gCLx9sgIw8G4xIJ7YzkxrFMDkNf6vneFMRyYpPH7jkH 5M09XwM/hhG0UmAjxGHtFPDZeY+toMr3lFTbHbCVniRa0i2rdQxI+hh0XJQjE5uNGZMN1M nuztocwvgFsqz3doV03wm/tHug48TJWc1W6ZdGEQrdSu/Zn4aenjHFlI7WnePA== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id ti-uecAJAEnA for <46717@debbugs.gnu.org>; Tue, 23 Feb 2021 14:06:52 +0100 (CET) Date: Tue, 23 Feb 2021 14:06:51 +0100 From: Lars-Dominik Braun To: 46717@debbugs.gnu.org Subject: [PATCH 1/2] gnu: Add readstat. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-MBO-SPAM-Probability: X-Rspamd-Score: -6.71 / 15.00 / 15.00 X-Rspamd-Queue-Id: BBE6C183D X-Rspamd-UID: 962516 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46717 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/statistics.scm (readstat): New variable. --- gnu/packages/statistics.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm index 3821c86da9..be30fa712c 100644 --- a/gnu/packages/statistics.scm +++ b/gnu/packages/statistics.scm @@ -5904,3 +5904,31 @@ Java package that provides routines for various statistical distributions.") is designed to support editing of scripts and interaction with various statistical analysis programs such as R, Julia, and JAGS.") (license license:gpl3+)))) + +(define-public readstat + (package + (name "readstat") + (version "1.1.5") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/WizardMac/ReadStat.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "00sdmaq0qzp6kyv53fpfi6jf3iv4pd0ap0gmw3mbfip52bbnl55w")))) + (build-system gnu-build-system) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("gettext" ,gnu-gettext) + ("libtool" ,libtool))) + (inputs + `(("zlib" ,zlib))) ; libz + (synopsis "Convert SAS, Stata, and SPSS files") + (description "Command-line tool and C library for reading files from +popular stats packages like SAS, Stata and SPSS.") + (home-page "https://github.com/WizardMac/ReadStat") + (license license:expat))) + -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 08:07:30 2021 Received: (at 46717) by debbugs.gnu.org; 23 Feb 2021 13:07:30 +0000 Received: from localhost ([127.0.0.1]:58528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXPV-0002zr-TS for submit@debbugs.gnu.org; Tue, 23 Feb 2021 08:07:30 -0500 Received: from mout-p-201.mailbox.org ([80.241.56.171]:52638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEXPR-0002zb-7y for 46717@debbugs.gnu.org; Tue, 23 Feb 2021 08:07:28 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4DlK8R2VZrzQlRp for <46717@debbugs.gnu.org>; Tue, 23 Feb 2021 14:07:19 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1614085637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ICBprWzcTGfvHw1aOihn91KMUDHfTWXszeDmy9JQGNw=; b=aAUxFl1rkPFOGc8wxeJpsNhvYnwhl1125W190q36F/yL76ASezGE8G0W1f+KZgialXyrZh PnzQX6Sgs4AirxgR+eXHoWFGRDnBnKtTEI0eA6zLLMDNpeWuF8S1D3ghrO6X1RJHginqC2 2sy5CyDoSuXPw8UkryEMmttcbiAIt+GGfbv1/Ly/+JdMwqr49J07fkMOzKQe1mkfVjElUD XZngPk02+B98CTT3gRODnUjRqvbjDlh/ACfPAlPTYDE04IyMg4ICRuZsuQD1rLxYpVN/xu /CL7Iv/GAgphtNuavpF8sX0fZiepI1r0AxY74jD6N52e8ahh165Tov1jK6ojbw== Received: from smtp2.mailbox.org ([80.241.60.241]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id qlCWfSIX5HQ7 for <46717@debbugs.gnu.org>; Tue, 23 Feb 2021 14:07:16 +0100 (CET) Date: Tue, 23 Feb 2021 14:07:14 +0100 From: Lars-Dominik Braun To: 46717@debbugs.gnu.org Subject: [PATCH 2/2] gnu: r-haven: Unvendor readstat. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -4.86 / 15.00 / 15.00 X-Rspamd-Queue-Id: 605DC17B4 X-Rspamd-UID: 448a9a X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46717 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/cran.scm (r-haven) [snippet]: Remove bundled readstat. [arguments]: Patch Makevars to use system readstat. [inputs]: Replace zlib with readstat. --- gnu/packages/cran.scm | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index 4a88cf1677..d675b7e37a 100644 --- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -2309,10 +2309,25 @@ including functions for geolocation and routing.") (uri (cran-uri "haven" version)) (sha256 (base32 - "03cypgqhdkrfbfpl1yx2wb7flczrbak1w654wkicmd5ajwr9zvkf")))) + "03cypgqhdkrfbfpl1yx2wb7flczrbak1w654wkicmd5ajwr9zvkf")) + (modules '((guix build utils))) + (snippet + '(begin + ;; unvendor readstat + (delete-file-recursively "src/readstat") + #t)))) (build-system r-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'unbundle-readstat + (lambda _ + ;; Not required, since we’re not building readstat. + (substitute* "src/Makevars" + (("-lz") "-lreadstat")) + #t))))) (inputs - `(("zlib" ,zlib))) + `(("readstat" ,readstat))) (native-inputs `(("r-knitr" ,r-knitr))) (propagated-inputs -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 02 14:32:13 2021 Received: (at 46717-done) by debbugs.gnu.org; 2 Mar 2021 19:32:13 +0000 Received: from localhost ([127.0.0.1]:54208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHAkf-0002wl-LO for submit@debbugs.gnu.org; Tue, 02 Mar 2021 14:32:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHAke-0002wX-2r for 46717-done@debbugs.gnu.org; Tue, 02 Mar 2021 14:32:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46448) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHAkY-0004pG-8T; Tue, 02 Mar 2021 14:32:06 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59504 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lHAkX-0006yB-Nr; Tue, 02 Mar 2021 14:32:06 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Lars-Dominik Braun Subject: Re: bug#46717: [PATCH 0/2] r-haven: Unvendor readstat References: Date: Tue, 02 Mar 2021 20:32:03 +0100 In-Reply-To: (Lars-Dominik Braun's message of "Tue, 23 Feb 2021 14:04:46 +0100") Message-ID: <87im69uzbg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46717-done Cc: 46717-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Lars-Dominik Braun skribis: > I rebuilt all packages depending on r-haven and tried loading example > files using r-haven=E2=80=99s read_* functions. There are no apparent > modifications to the vendored source, based on a look at > https://github.com/tidyverse/haven/commits/v2.3.1/src/readstat > but it=E2=80=99s not quite clear which version they are using. Probably a= git > snapshot. > > Lars-Dominik Braun (2): > gnu: Add readstat. > gnu: r-haven: Unvendor readstat. Applied both, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 05 06:57:23 2021 Received: (at 46717-done) by debbugs.gnu.org; 5 Mar 2021 11:57:23 +0000 Received: from localhost ([127.0.0.1]:33058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lI958-0004n7-Rd for submit@debbugs.gnu.org; Fri, 05 Mar 2021 06:57:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lI956-0004mt-IE for 46717-done@debbugs.gnu.org; Fri, 05 Mar 2021 06:57:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34590) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lI950-0003yT-LO; Fri, 05 Mar 2021 06:57:14 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40200 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lI94z-0002oP-Hl; Fri, 05 Mar 2021 06:57:13 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Lars-Dominik Braun Subject: Re: bug#46717: [PATCH 0/2] r-haven: Unvendor readstat References: Date: Fri, 05 Mar 2021 12:57:11 +0100 In-Reply-To: (Lars-Dominik Braun's message of "Tue, 23 Feb 2021 14:04:46 +0100") Message-ID: <87a6rhlso8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46717-done Cc: 46717-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Lars-Dominik Braun skribis: > I rebuilt all packages depending on r-haven and tried loading example > files using r-haven=E2=80=99s read_* functions. There are no apparent > modifications to the vendored source, based on a look at > https://github.com/tidyverse/haven/commits/v2.3.1/src/readstat > but it=E2=80=99s not quite clear which version they are using. Probably a= git > snapshot. > > Lars-Dominik Braun (2): > gnu: Add readstat. > gnu: r-haven: Unvendor readstat. LGTM! Pushed a couple of days ago as 2075b83b2dbd9896e2e69070e3363f3d43fbe133. Ludo=E2=80=99. From unknown Mon Aug 18 02:31:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 Apr 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator