GNU bug report logs - #46715
[PATCH] guix import: Fixing detection of Fortran files.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46715: closed ([PATCH] guix import: Fixing detection of
 Fortran files.)
Date: Mon, 01 Mar 2021 21:48:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 01 Mar 2021 22:47:46 +0100
with message-id <8735xebl6l.fsf <at> elephly.net>
and subject line Re: [PATCH] guix import: Fixing detection of Fortran files.
has caused the debbugs.gnu.org bug report #46715,
regarding [PATCH] guix import: Fixing detection of Fortran files.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46715: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46715
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Cc: rekado <at> elephly.net, Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Subject: [PATCH] guix import: Fixing detection of Fortran files.
Date: Tue, 23 Feb 2021 12:00:21 +0100

This fixes a bug whereby Guix importer considers files like .f.*
being Fortran's files.

(find-files dir "\\.f(90|95)?")

would consider a lot of files with an extension starting with f
being a Fortran file. The right way is to consider only files
ending with .f90 or .f95.

*guix/import/cran.scm: changing pattern of the detection for
Fortran's files to .f(90|95)$.

Co-authored-by: Ricardo Wurmus <rekado <at> elephly.net>
---
 guix/import/cran.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/cran.scm b/guix/import/cran.scm
index e8caf080fd..dbc858cb84 100644
--- a/guix/import/cran.scm
+++ b/guix/import/cran.scm
@@ -361,7 +361,7 @@ empty list when the FIELD cannot be found."
 
 (define (directory-needs-fortran? dir)
   "Check if the directory DIR contains Fortran source files."
-  (match (find-files dir "\\.f(90|95)?")
+  (match (find-files dir "\\.f(90|95)$")
     (() #f)
     (_ #t)))
 
-- 
2.30.1

[Message part 3 (message/rfc822, inline)]

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Cc: 46715-done <at> debbugs.gnu.org
Subject: Re: [PATCH] guix import: Fixing detection of Fortran files.
Date: Mon, 01 Mar 2021 22:47:46 +0100

Hi Mădălin,

Thanks!  I applied this with a few changes in the commit message.
(Commit 35814292b6.)

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.