From unknown Sat Aug 16 21:58:33 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#46715] [PATCH] guix import: Fixing detection of Fortran files. Resent-From: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 23 Feb 2021 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46715 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46715@debbugs.gnu.org Cc: rekado@elephly.net, =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.161407807222930 (code B ref -1); Tue, 23 Feb 2021 11:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Feb 2021 11:01:12 +0000 Received: from localhost ([127.0.0.1]:58404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEVRI-0005xm-8h for submit@debbugs.gnu.org; Tue, 23 Feb 2021 06:01:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:57216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEVRH-0005xf-10 for submit@debbugs.gnu.org; Tue, 23 Feb 2021 06:01:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEVRF-0001aB-1V for guix-patches@gnu.org; Tue, 23 Feb 2021 06:01:09 -0500 Received: from c2062.mx.srv.dfn.de ([194.95.238.172]:55511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEVR5-0001KW-Lf for guix-patches@gnu.org; Tue, 23 Feb 2021 06:01:08 -0500 Received: from localhost (localhost [127.0.0.1]) by c2062.mx.srv.dfn.de (Postfix) with ESMTP id 32DE63000EB; Tue, 23 Feb 2021 12:00:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mdc-berlin.de; h= content-type:content-type:content-transfer-encoding:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=mdc; t=1614078040; x=1615892441; bh=R8FYyaKaXr0R1+biXX0bpF38b3NuBgmbTjmFzFw6NMM=; b=cZoUHJ3IE5KT EoI0wLAEeMIEvfeOYNKS8gVbZ3SxKQ1lEF//TIsQltNryBmbDfwYsydU0led/RCm BSXPcVGR0TvxtB7l+0T9bhreNzJ4Zsoxxg2lD4z2Uxy8PgHkxPkjteI6NImVlo+A qCR4KnP4YeI54HVObwSn98GYmpL2kuM= Received: from c2062.mx.srv.dfn.de ([127.0.0.1]) by localhost (mgw4-erl.srv.dfn.de [127.0.0.1]) (amavisd-new, port 20134) with ESMTP id XoPfAml8l4_U; Tue, 23 Feb 2021 12:00:40 +0100 (CET) Received: from SW-IT-P-EX4.mdc-berlin.net (mgw4.mdc-berlin.de [141.80.113.62]) by c2062.mx.srv.dfn.de (Postfix) with ESMTPS; Tue, 23 Feb 2021 12:00:40 +0100 (CET) Received: from Guix-Ubuntu18.04 (141.80.113.106) by SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2176.2; Tue, 23 Feb 2021 12:00:40 +0100 From: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= Date: Tue, 23 Feb 2021 12:00:21 +0100 Message-ID: <20210223110021.10765-1-madalinionel.patrascu@mdc-berlin.de> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [141.80.113.106] X-ClientProxiedBy: SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) To SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1012-25990.007 X-TM-AS-Result: No-10--4.868900-8.000000 X-TMASE-MatchedRID: p9rK+f8v5s/cQGiuGEM19JxVZzZr7+O7qb0OUk+lIL0/HwRyaRVM1ShJ cLlF3Y99vibj7bFSyvObHAuQ1dUnuWJZXQNDzktSamOGWbsSIFcGchEhVwJY31B3AZ+9IiUHDv9 dUeWenmF87P7JbZZzfjF/NHLpWiF5LJutez2dKWfi8zVgXoAltsYlDcGKIsCCC24oEZ6SpSk6XE E7Yhw4FgaVvygv4Mgenek0A5/LKMVDTk5AXvXcXLHUx6SmTFH3Ryvh4Lj5tSDKvGGj0XuWRAePF rIjBe3L2/OhR1B7NBEzwJVbQJxVX7dKECLo/klXhRFX0MbNzemQ4JrfEHpLweZmgnjb/yyM1RkH asLA4hI= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.868900-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1012-25990.007 X-TM-SNTS-SMTP: 44D166D7CC553D3C3CA0139216E4CB85C1382458DC23D38CB2D467481D26447C2000:F Received-SPF: pass client-ip=194.95.238.172; envelope-from=MadalinIonel.Patrascu@mdc-berlin.de; helo=c2062.mx.srv.dfn.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This fixes a bug whereby Guix importer considers files like .f.* being Fortran's files. (find-files dir "\\.f(90|95)?") would consider a lot of files with an extension starting with f being a Fortran file. The right way is to consider only files ending with .f90 or .f95. *guix/import/cran.scm: changing pattern of the detection for Fortran's files to .f(90|95)$. Co-authored-by: Ricardo Wurmus --- guix/import/cran.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/cran.scm b/guix/import/cran.scm index e8caf080fd..dbc858cb84 100644 --- a/guix/import/cran.scm +++ b/guix/import/cran.scm @@ -361,7 +361,7 @@ empty list when the FIELD cannot be found." (define (directory-needs-fortran? dir) "Check if the directory DIR contains Fortran source files." - (match (find-files dir "\\.f(90|95)?") + (match (find-files dir "\\.f(90|95)$") (() #f) (_ #t))) -- 2.30.1 From unknown Sat Aug 16 21:58:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= Subject: bug#46715: closed (Re: [PATCH] guix import: Fixing detection of Fortran files.) Message-ID: References: <8735xebl6l.fsf@elephly.net> <20210223110021.10765-1-madalinionel.patrascu@mdc-berlin.de> X-Gnu-PR-Message: they-closed 46715 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 46715@debbugs.gnu.org Date: Mon, 01 Mar 2021 21:48:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1614635282-6676-1" This is a multi-part message in MIME format... ------------=_1614635282-6676-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #46715: [PATCH] guix import: Fixing detection of Fortran files. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 46715@debbugs.gnu.org. --=20 46715: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D46715 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1614635282-6676-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 46715-done) by debbugs.gnu.org; 1 Mar 2021 21:47:58 +0000 Received: from localhost ([127.0.0.1]:51069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGqOT-0001jP-NH for submit@debbugs.gnu.org; Mon, 01 Mar 2021 16:47:57 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGqOR-0001jG-V9 for 46715-done@debbugs.gnu.org; Mon, 01 Mar 2021 16:47:56 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1614635271; cv=none; d=zohomail.com; s=zohoarc; b=VOplngwShiAxfJXRh7PdJ5CXcVnkct1aIu6BWCh7QGwoTmt/WxES8YBPS/+3cRRHfR1cSIi04oAhQF7SMEd3QNMRt1zjaRWePkswP1+MLzaz97id1w7D2ASWs3saDSZPYFV/mM8MHlRN91a3rkJyLvIBx3R8nT+ZDXMD5eEoNHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614635271; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wJh/wNMXdr7/QHajzHkVsynFGlV/a1PJmQc6piRir5Q=; b=ExZ65eTeMDH+XhX915n3ozlBavIhwYeO5TYFnwz6xAGVeGki7pg7FeqJkqhrHfzfkjEQ5O7VJ9yvzgy4RDogkbN3g9L/oJxQ24l2+L4LcCSZsO9BF9GtlVo3bxZAimZCJWId97IWd2pev+N8ZARhUStHbOxhl8iC4RtVvPjfFVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1614635271; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=wJh/wNMXdr7/QHajzHkVsynFGlV/a1PJmQc6piRir5Q=; b=a8Kj5MzZ9Cy8nWw2MrFT5L1EhDGc5zBZ3bDicypqa1yID4BaI2GHyCeqvR82Dk9V GIxLmR2Jio1QXbz7B2QUhvmNxCIBJSSiCkQ2Lp/ErcWxbxhDVRiEQ483P9G2Kz/Slkf pmoVk2rdRP81Q2b0YnDXr+3j/Wf95a7vIDVgBJm0= Received: from localhost (p54ad4d5d.dip0.t-ipconnect.de [84.173.77.93]) by mx.zohomail.com with SMTPS id 1614635269152327.85900674713366; Mon, 1 Mar 2021 13:47:49 -0800 (PST) References: <20210223110021.10765-1-madalinionel.patrascu@mdc-berlin.de> User-agent: mu4e 1.4.14; emacs 27.1 From: Ricardo Wurmus To: =?utf-8?B?TcSDZMSDbGlu?= Ionel =?utf-8?Q?Patra=C8=99cu?= Subject: Re: [PATCH] guix import: Fixing detection of Fortran files. In-reply-to: <20210223110021.10765-1-madalinionel.patrascu@mdc-berlin.de> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Mon, 01 Mar 2021 22:47:46 +0100 Message-ID: <8735xebl6l.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46715-done Cc: 46715-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi M=C4=83d=C4=83lin, Thanks! I applied this with a few changes in the commit message. (Commit 35814292b6.) --=20 Ricardo ------------=_1614635282-6676-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Feb 2021 11:01:12 +0000 Received: from localhost ([127.0.0.1]:58404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEVRI-0005xm-8h for submit@debbugs.gnu.org; Tue, 23 Feb 2021 06:01:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:57216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEVRH-0005xf-10 for submit@debbugs.gnu.org; Tue, 23 Feb 2021 06:01:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEVRF-0001aB-1V for guix-patches@gnu.org; Tue, 23 Feb 2021 06:01:09 -0500 Received: from c2062.mx.srv.dfn.de ([194.95.238.172]:55511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEVR5-0001KW-Lf for guix-patches@gnu.org; Tue, 23 Feb 2021 06:01:08 -0500 Received: from localhost (localhost [127.0.0.1]) by c2062.mx.srv.dfn.de (Postfix) with ESMTP id 32DE63000EB; Tue, 23 Feb 2021 12:00:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mdc-berlin.de; h= content-type:content-type:content-transfer-encoding:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=mdc; t=1614078040; x=1615892441; bh=R8FYyaKaXr0R1+biXX0bpF38b3NuBgmbTjmFzFw6NMM=; b=cZoUHJ3IE5KT EoI0wLAEeMIEvfeOYNKS8gVbZ3SxKQ1lEF//TIsQltNryBmbDfwYsydU0led/RCm BSXPcVGR0TvxtB7l+0T9bhreNzJ4Zsoxxg2lD4z2Uxy8PgHkxPkjteI6NImVlo+A qCR4KnP4YeI54HVObwSn98GYmpL2kuM= Received: from c2062.mx.srv.dfn.de ([127.0.0.1]) by localhost (mgw4-erl.srv.dfn.de [127.0.0.1]) (amavisd-new, port 20134) with ESMTP id XoPfAml8l4_U; Tue, 23 Feb 2021 12:00:40 +0100 (CET) Received: from SW-IT-P-EX4.mdc-berlin.net (mgw4.mdc-berlin.de [141.80.113.62]) by c2062.mx.srv.dfn.de (Postfix) with ESMTPS; Tue, 23 Feb 2021 12:00:40 +0100 (CET) Received: from Guix-Ubuntu18.04 (141.80.113.106) by SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2176.2; Tue, 23 Feb 2021 12:00:40 +0100 From: =?UTF-8?q?M=C4=83d=C4=83lin=20Ionel=20Patra=C8=99cu?= To: Subject: [PATCH] guix import: Fixing detection of Fortran files. Date: Tue, 23 Feb 2021 12:00:21 +0100 Message-ID: <20210223110021.10765-1-madalinionel.patrascu@mdc-berlin.de> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [141.80.113.106] X-ClientProxiedBy: SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) To SW-IT-P-EX4.mdc-berlin.net (141.80.113.62) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1012-25990.007 X-TM-AS-Result: No-10--4.868900-8.000000 X-TMASE-MatchedRID: p9rK+f8v5s/cQGiuGEM19JxVZzZr7+O7qb0OUk+lIL0/HwRyaRVM1ShJ cLlF3Y99vibj7bFSyvObHAuQ1dUnuWJZXQNDzktSamOGWbsSIFcGchEhVwJY31B3AZ+9IiUHDv9 dUeWenmF87P7JbZZzfjF/NHLpWiF5LJutez2dKWfi8zVgXoAltsYlDcGKIsCCC24oEZ6SpSk6XE E7Yhw4FgaVvygv4Mgenek0A5/LKMVDTk5AXvXcXLHUx6SmTFH3Ryvh4Lj5tSDKvGGj0XuWRAePF rIjBe3L2/OhR1B7NBEzwJVbQJxVX7dKECLo/klXhRFX0MbNzemQ4JrfEHpLweZmgnjb/yyM1RkH asLA4hI= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.868900-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1012-25990.007 X-TM-SNTS-SMTP: 44D166D7CC553D3C3CA0139216E4CB85C1382458DC23D38CB2D467481D26447C2000:F Received-SPF: pass client-ip=194.95.238.172; envelope-from=MadalinIonel.Patrascu@mdc-berlin.de; helo=c2062.mx.srv.dfn.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: rekado@elephly.net, =?UTF-8?q?M=C4=83d=C4=83lin=20Ionel=20Patra=C8=99cu?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This fixes a bug whereby Guix importer considers files like .f.* being Fortran's files. (find-files dir "\\.f(90|95)?") would consider a lot of files with an extension starting with f being a Fortran file. The right way is to consider only files ending with .f90 or .f95. *guix/import/cran.scm: changing pattern of the detection for Fortran's files to .f(90|95)$. Co-authored-by: Ricardo Wurmus --- guix/import/cran.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/cran.scm b/guix/import/cran.scm index e8caf080fd..dbc858cb84 100644 --- a/guix/import/cran.scm +++ b/guix/import/cran.scm @@ -361,7 +361,7 @@ empty list when the FIELD cannot be found." (define (directory-needs-fortran? dir) "Check if the directory DIR contains Fortran source files." - (match (find-files dir "\\.f(90|95)?") + (match (find-files dir "\\.f(90|95)$") (() #f) (_ #t))) -- 2.30.1 ------------=_1614635282-6676-1--