From unknown Fri Aug 15 15:34:43 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4671: `read-passwd' does not recognize keypad enter key Reply-To: Michael Ernst , 4671@debbugs.gnu.org Resent-From: Michael Ernst Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 08 Oct 2009 05:40:09 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4671 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125498022830694 (code B ref -1); Thu, 08 Oct 2009 05:40:09 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 8 Oct 2009 05:37:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n985b6J1030690 for ; Wed, 7 Oct 2009 22:37:07 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvlgX-0002x1-Uw for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2009 01:37:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvlgR-0002uG-Na for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2009 01:37:04 -0400 Received: from [199.232.76.173] (port=41049 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvlgR-0002u7-FJ for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2009 01:36:59 -0400 Received: from mail-pz0-f181.google.com ([209.85.222.181]:49209) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvlgR-0006l1-3Z for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2009 01:36:59 -0400 Received: by pzk11 with SMTP id 11so3945544pzk.14 for ; Wed, 07 Oct 2009 22:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:message-id:to:subject :from:mime-version:content-type:content-transfer-encoding; bh=jO5oY08w0Qp2zYkvBhAm3VE3B8PtFtzvofCVkZ2dn0s=; b=ugLrFtkNBwHsT4Xb/XDDX8IdovO8YxHa/6TTtNb2n45pjR5BL3017zRy68p6pB/SgJ v0hY6id8W2JKBp1tGHahDEjWf6Ae98cB6RF5i4wZX600T/eBrU41eSEU8fXMve9a4ykR J0rjTMNsEWNN/+vZOsEB9GCdPhtnXW7/6+MDc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:message-id:to:subject:from:mime-version:content-type :content-transfer-encoding; b=pAVD/D8QVgZwkxhcPEsFkYbLbvL6URhz/4jFsY8qAaK42KdwFXuohUgLzkXFrZtwy6 zpwipYYb0c0iaZMUIGTX7mKbAVXZ592XtTeN7NnIov8/9bm7DS7SqxqJ3cZU2/PvgiRf HxVfIizqZI+PpbpthPJiMfnt+pGevzR47qACM= Received: by 10.115.113.4 with SMTP id q4mr1556165wam.54.1254980217596; Wed, 07 Oct 2009 22:36:57 -0700 (PDT) Received: from localhost (godwit.cs.washington.edu [128.208.2.154]) by mx.google.com with ESMTPS id 20sm1823155pzk.9.2009.10.07.22.36.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 07 Oct 2009 22:36:56 -0700 (PDT) Date: Wed, 07 Oct 2009 22:36:47 -0700 (PDT) Message-Id: <20091007.223647.58496705.michael.ernst@gmail.com> To: bug-gnu-emacs@gnu.org From: Michael Ernst Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) My Kinesis keyboard's "enter" key is read by Emacs as kp-enter. As a result, the enter key does not terminate a password as read by `read-passwd'. This patch corrects that problem. -Michael Ernst Changelog entry: 2009-10-08 Michael Ernst * subr.el (read-passwd): Add 'kp-enter to stop-keys. --- /homes/gws/mernst/bin/src/emacs-22/Linux-i686/emacs/lisp/subr.el 2009-10-01 10:47:42.000000000 -0700 +++ - 2009-10-07 22:31:51.839795567 -0700 @@ -1940,7 +1940,7 @@ (echo-keystrokes 0) (cursor-in-echo-area t) (message-log-max nil) - (stop-keys (list 'return ?\r ?\n ?\e)) + (stop-keys (list 'return ?\r ?\n ?\e 'kp-enter)) (rubout-keys (list 'backspace ?\b ?\177))) (add-text-properties 0 (length prompt) minibuffer-prompt-properties prompt) From unknown Fri Aug 15 15:34:43 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4671: `read-passwd' does not recognize keypad enter key Reply-To: Stefan Monnier , 4671@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 09 Oct 2009 19:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4671 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125511635330793 (code B ref -1); Fri, 09 Oct 2009 19:30:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 9 Oct 2009 19:25:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n99JPpvj030789 for ; Fri, 9 Oct 2009 12:25:52 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MwL67-0002i0-2E for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 15:25:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MwL62-0002hW-Kj for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 15:25:50 -0400 Received: from [199.232.76.173] (port=51517 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MwL62-0002hT-ET for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 15:25:46 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:37394) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MwL62-00084B-0Z for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 15:25:46 -0400 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n99JPcec017704; Fri, 9 Oct 2009 15:25:38 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id A21033A1AC; Fri, 9 Oct 2009 15:25:38 -0400 (EDT) From: Stefan Monnier To: Michael Ernst Cc: 4671@debbugs.gnu.org, bug-gnu-emacs@gnu.org Message-ID: References: <20091007.223647.58496705.michael.ernst@gmail.com> Date: Fri, 09 Oct 2009 15:25:38 -0400 In-Reply-To: <20091007.223647.58496705.michael.ernst@gmail.com> (Michael Ernst's message of "Wed, 07 Oct 2009 22:36:47 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3381=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) > My Kinesis keyboard's "enter" key is read by Emacs as kp-enter. Which version of Emacs is that? I've installed a few weeks ago a patch that makes read-passwd use the read-key rather than read-char, so AFAIK such problems should have been fixed. Stefan From unknown Fri Aug 15 15:34:43 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4671: `read-passwd' does not recognize keypad enter key Reply-To: Michael Ernst , 4671@debbugs.gnu.org Resent-From: Michael Ernst Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 13 Oct 2009 23:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4671 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4671-submit@emacsbugs.donarmstrong.com id=B4671.12554763404788 (code B ref 4671); Tue, 13 Oct 2009 23:30:04 +0000 Received: (at 4671) by emacsbugs.donarmstrong.com; 13 Oct 2009 23:25:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-pz0-f182.google.com (mail-pz0-f182.google.com [209.85.222.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9DNPcRW004783 for <4671@emacsbugs.donarmstrong.com>; Tue, 13 Oct 2009 16:25:39 -0700 Received: by pzk12 with SMTP id 12so5810550pzk.13 for <4671@emacsbugs.donarmstrong.com>; Tue, 13 Oct 2009 16:25:33 -0700 (PDT) Received: by 10.114.162.5 with SMTP id k5mr9861629wae.10.1255476332717; Tue, 13 Oct 2009 16:25:32 -0700 (PDT) Received: from localhost ([76.75.8.40]) by mx.google.com with ESMTPS id 22sm102882pzk.10.2009.10.13.16.25.31 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 13 Oct 2009 16:25:32 -0700 (PDT) Date: Tue, 13 Oct 2009 16:25:29 -0700 (PDT) Message-Id: <20091013.162529.220163955.mernst@cs.washington.edu> To: monnier@IRO.UMontreal.CA Cc: 4671@debbugs.gnu.org, bug-gnu-emacs@gnu.org From: Michael Ernst In-Reply-To: References: <20091007.223647.58496705.michael.ernst@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit > Which version of Emacs is that? > I've installed a few weeks ago a patch that makes read-passwd use the > read-key rather than read-char, so AFAIK such problems should have > been fixed. My patch was against the latest CVS version. (I would have mentioned the version otherwise, but I should have mentioned it even then; sorry for the omission.) I noticed the problem in Debian's emacs-snapshot package: GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.16.1) of 2009-07-31 on lansones, modified by Debian -Michael Ernst From unknown Fri Aug 15 15:34:43 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4671: `read-passwd' does not recognize keypad enter key Reply-To: Stefan Monnier , 4671@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Wed, 14 Oct 2009 03:05:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4671 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12554890043711 (code B ref -1); Wed, 14 Oct 2009 03:05:07 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Oct 2009 02:56:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9E2ugcl003703 for ; Tue, 13 Oct 2009 19:56:43 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mxu2c-0005RP-CZ for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2009 22:56:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mxu2X-0005Qx-Uf for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2009 22:56:41 -0400 Received: from [199.232.76.173] (port=46203 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mxu2X-0005Qu-Ou for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2009 22:56:37 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:63017 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mxu2X-0004jx-E6 for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2009 22:56:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUEAJ/a1EpMCqsb/2dsb2JhbACBUdc6hC0Eh2qCeA X-IronPort-AV: E=Sophos;i="4.44,555,1249272000"; d="scan'208";a="47523672" Received: from 76-10-171-27.dsl.teksavvy.com (HELO ceviche.home) ([76.10.171.27]) by ironport2-out.pppoe.ca with ESMTP; 13 Oct 2009 22:56:36 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 497CBB40B9; Tue, 13 Oct 2009 22:56:36 -0400 (EDT) From: Stefan Monnier To: Michael Ernst Cc: 4671@debbugs.gnu.org, bug-gnu-emacs@gnu.org Message-ID: References: <20091007.223647.58496705.michael.ernst@gmail.com> <20091013.162529.220163955.mernst@cs.washington.edu> Date: Tue, 13 Oct 2009 22:56:35 -0400 In-Reply-To: <20091013.162529.220163955.mernst@cs.washington.edu> (Michael Ernst's message of "Tue, 13 Oct 2009 16:25:29 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. >> Which version of Emacs is that? >> I've installed a few weeks ago a patch that makes read-passwd use the >> read-key rather than read-char, so AFAIK such problems should have >> been fixed. > My patch was against the latest CVS version. (I would have mentioned the > version otherwise, but I should have mentioned it even then; sorry for the > omission.) That's very odd. What does M-: (read-key) RET return? What about C-h k ? Stefan From unknown Fri Aug 15 15:34:43 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4671: `read-passwd' does not recognize keypad enter key Reply-To: Michael Ernst , 4671@debbugs.gnu.org Resent-From: Michael Ernst Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 16 Oct 2009 04:55:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4671 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125566862532286 (code B ref -1); Fri, 16 Oct 2009 04:55:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 16 Oct 2009 04:50:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9G4oNw6032281 for ; Thu, 15 Oct 2009 21:50:24 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myelj-0007t3-7X for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 00:50:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myele-0007pk-7V for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 00:50:22 -0400 Received: from [199.232.76.173] (port=55891 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myeld-0007pc-Pa for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 00:50:17 -0400 Received: from mail-pz0-f192.google.com ([209.85.222.192]:37496) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Myeld-00015C-DI for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2009 00:50:17 -0400 Received: by pzk30 with SMTP id 30so1442334pzk.24 for ; Thu, 15 Oct 2009 21:50:14 -0700 (PDT) Received: by 10.114.9.16 with SMTP id 16mr1076823wai.114.1255668613697; Thu, 15 Oct 2009 21:50:13 -0700 (PDT) Received: from localhost (c-98-225-51-137.hsd1.wa.comcast.net [98.225.51.137]) by mx.google.com with ESMTPS id 22sm1851448pzk.14.2009.10.15.21.50.12 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 15 Oct 2009 21:50:13 -0700 (PDT) Date: Thu, 15 Oct 2009 21:50:06 -0700 (PDT) Message-Id: <20091015.215006.20751303.mernst@cs.washington.edu> To: monnier@iro.umontreal.ca Cc: 4671@debbugs.gnu.org, bug-gnu-emacs@gnu.org From: Michael Ernst In-Reply-To: References: <20091013.162529.220163955.mernst@cs.washington.edu> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Stefan- As I mentioned, I am running the Ubuntu emacs-snapshot version (but I submitted a patch against the CVS version, assuming the two wouldn't be much different). Perhaps the explanation is that it had not yet incorporated your latest patch. In any event, my version does not have the `read-key' function. I'll re-submit if the problem persists in the next official Emacs release. -Mike From cyd@stupidchicken.com Sat Oct 17 20:45:16 2009 Received: (at control) by emacsbugs.donarmstrong.com; 18 Oct 2009 03:45:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po43.its.yale.edu (pantheon-po43.its.yale.edu [130.132.50.104]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9I3jE16005940 for ; Sat, 17 Oct 2009 20:45:15 -0700 Received: from furry (adsl-99-69-50-113.dsl.wlfrct.sbcglobal.net [99.69.50.113]) (authenticated bits=0) by pantheon-po43.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n9I3j8lX021592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 17 Oct 2009 23:45:09 -0400 Received: by furry (Postfix, from userid 1000) id 3F53EC070; Sat, 17 Oct 2009 23:45:08 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 4671 Date: Sat, 17 Oct 2009 23:45:08 -0400 Message-ID: <87vdid8iwr.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) close 4671 thanks