GNU bug report logs - #4671
`read-passwd' does not recognize keypad enter key

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4671 in the body.
You can then email your comments to 4671 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Michael Ernst <michael.ernst <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: `read-passwd' does not recognize keypad enter key
Date: Wed, 07 Oct 2009 22:36:47 -0700 (PDT)

My Kinesis keyboard's "enter" key is read by Emacs as kp-enter.  As a
result, the enter key does not terminate a password as read by
`read-passwd'.  This patch corrects that problem.

                    -Michael Ernst

Changelog entry:

2009-10-08  Michael Ernst  <mernst <at> alum.mit.edu>

	* subr.el (read-passwd): Add 'kp-enter to stop-keys.


--- /homes/gws/mernst/bin/src/emacs-22/Linux-i686/emacs/lisp/subr.el	2009-10-01 10:47:42.000000000 -0700
+++ -	2009-10-07 22:31:51.839795567 -0700
@@ -1940,7 +1940,7 @@
 	    (echo-keystrokes 0)
 	    (cursor-in-echo-area t)
 	    (message-log-max nil)
-	    (stop-keys (list 'return ?\r ?\n ?\e))
+	    (stop-keys (list 'return ?\r ?\n ?\e 'kp-enter))
 	    (rubout-keys (list 'backspace ?\b ?\177)))
 	(add-text-properties 0 (length prompt)
 			     minibuffer-prompt-properties prompt)

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Michael Ernst <michael.ernst <at> gmail.com>
Cc: 4671 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4671: `read-passwd' does not recognize keypad enter key
Date: Fri, 09 Oct 2009 15:25:38 -0400

> My Kinesis keyboard's "enter" key is read by Emacs as kp-enter.

Which version of Emacs is that?
I've installed a few weeks ago a patch that makes read-passwd use the
read-key rather than read-char, so AFAIK such problems should have
been fixed.


        Stefan

Message #20 received at 4671 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Michael Ernst <mernst <at> cs.washington.edu>
To: monnier <at> IRO.UMontreal.CA
Cc: 4671 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4671: `read-passwd' does not recognize keypad enter key
Date: Tue, 13 Oct 2009 16:25:29 -0700 (PDT)

> Which version of Emacs is that?
> I've installed a few weeks ago a patch that makes read-passwd use the
> read-key rather than read-char, so AFAIK such problems should have
> been fixed.

My patch was against the latest CVS version.  (I would have mentioned the
version otherwise, but I should have mentioned it even then; sorry for the
omission.)

I noticed the problem in Debian's emacs-snapshot package:

GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.16.1) of 2009-07-31 on lansones, modified by Debian

                    -Michael Ernst

Message #30 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Ernst <mernst <at> cs.washington.edu>
Cc: 4671 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4671: `read-passwd' does not recognize keypad enter key
Date: Tue, 13 Oct 2009 22:56:35 -0400

>> Which version of Emacs is that?
>> I've installed a few weeks ago a patch that makes read-passwd use the
>> read-key rather than read-char, so AFAIK such problems should have
>> been fixed.

> My patch was against the latest CVS version.  (I would have mentioned the
> version otherwise, but I should have mentioned it even then; sorry for the
> omission.)

That's very odd.  What does M-: (read-key) RET <kp-enter> return?
What about C-h k <kp-enter> ?


        Stefan

Message #40 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Michael Ernst <mernst <at> cs.washington.edu>
To: monnier <at> iro.umontreal.ca
Cc: 4671 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4671: `read-passwd' does not recognize keypad enter key
Date: Thu, 15 Oct 2009 21:50:06 -0700 (PDT)

Stefan-

As I mentioned, I am running the Ubuntu emacs-snapshot version (but I
submitted a patch against the CVS version, assuming the two wouldn't be
much different).  Perhaps the explanation is that it had not yet
incorporated your latest patch.  In any event, my version does not have the
`read-key' function.  I'll re-submit if the problem persists in the next
official Emacs release.

                    -Mike

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.