GNU bug report logs - #46686
[PATCH] gnu: add libucl

Previous Next

Full log

Message #8 received at 46686 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: qblade <qblade <at> protonmail.com>
Cc: 46686 <at> debbugs.gnu.org
Subject: Re: bug#46686: [PATCH] gnu: add libucl
Date: Sat, 06 Mar 2021 11:32:51 +0100

Hi,

qblade <qblade <at> protonmail.com> skribis:

> From aae95593f1cfd48c50578bec83927c870afc6bce Mon Sep 17 00:00:00 2001
> From: qblade <qblade <at> protonmail.com>
> Date: Sun, 21 Feb 2021 06:48:18 +0000
> Subject: [PATCH] gnu: add libucl
>
> * gnu/packages/config-lang.scm (libucl): New variable.

Thanks for the patch!  It looks good to me, modulo the minor issues
below.

>  gnu/packages/config-lang.scm | 54 ++++++++++++++++++++++++++++++++++++

Could you perhaps find another file to add it to, so we don’t have a
module for a single package?  That said, I don’t have a good suggestion,
since ‘iniparser’ for instance is in samba.scm.

> +    (synopsis "Universal configuration language")
> +    (description "Universal configuration language.
> +fully compatible with JSON format and is able to parse json files")

Could you reword the description with full sentences, along the lines of:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Make sure to capitalize acronyms like JSON.

TIA,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.