GNU bug report logs - #46671
[PATCH] gnu: renpy-build-system: Quote data directory.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46671: closed ([PATCH] gnu: renpy-build-system: Quote data
 directory.)
Date: Wed, 24 Feb 2021 00:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 24 Feb 2021 01:11:30 +0100
with message-id <45e1cc0e3926a6745f18f88c89e2f8067f651495.camel <at> student.tugraz.at>
and subject line Re: [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory.
has caused the debbugs.gnu.org bug report #46671,
regarding [PATCH] gnu: renpy-build-system: Quote data directory.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46671: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46671
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: renpy-build-system: Quote data directory.
Date: Sun, 21 Feb 2021 00:58:27 +0100

This prevents generated launchers and desktop files from inadvertently
crashing if the directory name contains a space.

* gnu/build/renpy-build-system.scm (install, install-desktop-file): Use ~s
to format data directory.
---
 guix/build/renpy-build-system.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/guix/build/renpy-build-system.scm b/guix/build/renpy-build-system.scm
index 464fc97b13..66683971c5 100644
--- a/guix/build/renpy-build-system.scm
+++ b/guix/build/renpy-build-system.scm
@@ -57,7 +57,7 @@
       (delete-file (string-append data "/renpy-build.json"))
       (call-with-output-file launcher
         (lambda (port)
-          (format port "#!~a~%~a ~a \"$@\""
+          (format port "#!~a~%~a ~s \"$@\""
                   (which "bash")
                   (which "renpy")
                   data)))
@@ -77,8 +77,9 @@
      (string-append out "/share/applications/" executable-name ".desktop")
      #:name (assoc-ref json-dump "name")
      #:generic-name (assoc-ref build "display_name")
-     #:exec (string-append (which "renpy") " "
-                           out "/share/renpy/" directory-name)
+     #:exec (format #f "~a ~s"
+                    (which "renpy")
+                    (string-append out "/share/renpy/" directory-name))
      #:categories '("Game" "Visual Novel")))
   #t)
 
-- 
2.30.1

[Message part 3 (message/rfc822, inline)]

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Leo Famulari <leo <at> famulari.name>
Cc: 46671-done <at> debbugs.gnu.org
Subject: Re: [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory.
Date: Wed, 24 Feb 2021 01:11:30 +0100

Am Samstag, den 20.02.2021, 19:39 -0500 schrieb Leo Famulari:
> On Sun, Feb 21, 2021 at 12:58:27AM +0100, Leo Prikler wrote:
> > This prevents generated launchers and desktop files from
> > inadvertently
> > crashing if the directory name contains a space.
> > 
> > * gnu/build/renpy-build-system.scm (install, install-desktop-file): 
> > Use ~s
> > to format data directory.
> 
> s/gnu/guix
> 
> Otherwise LGTM if it fixes the problem for you.
I hope not too many packages are troubled by spaces in their directory
names, but it's better to be safe than to be sorry.

Pushed!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.