From unknown Fri Sep 12 18:17:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Feb 2021 00:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46671 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46671@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16138670379647 (code B ref -1); Sun, 21 Feb 2021 00:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2021 00:23:57 +0000 Received: from localhost ([127.0.0.1]:53161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDcXU-0002VX-Uh for submit@debbugs.gnu.org; Sat, 20 Feb 2021 19:23:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:48726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDcXS-0002VP-95 for submit@debbugs.gnu.org; Sat, 20 Feb 2021 19:23:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDcXR-0004pl-Pp for guix-patches@gnu.org; Sat, 20 Feb 2021 19:23:54 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:24321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDcXO-0006sC-Bg for guix-patches@gnu.org; Sat, 20 Feb 2021 19:23:53 -0500 Received: from localhost.localdomain (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DjmJH1pbRz1LBSW for ; Sun, 21 Feb 2021 01:23:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DjmJH1pbRz1LBSW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1613867023; bh=EKuy/RG4IYRGlOaqPDUfE9VIS6OYJYkI5HtUZaSdPZg=; h=From:To:Subject:Date:From; b=PgJYy0Tp4WjwObkf1iCHH+KDaSnuB/On1zAgp1zt02qBYsghgbcFnhWOnGlmFsA0f Yfd5kIejcOHwe5aY/hQieqFs1NQPUD5DhX4gfWP+Bln1e0TMu+N1dm69jWrtkYemar hPTIB6hMWXZsATD8DxQPBjdE3BFTSZobpx+x3rms= From: Leo Prikler Date: Sun, 21 Feb 2021 00:58:27 +0100 Message-Id: <20210220235826.24017-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This prevents generated launchers and desktop files from inadvertently crashing if the directory name contains a space. * gnu/build/renpy-build-system.scm (install, install-desktop-file): Use ~s to format data directory. --- guix/build/renpy-build-system.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/guix/build/renpy-build-system.scm b/guix/build/renpy-build-system.scm index 464fc97b13..66683971c5 100644 --- a/guix/build/renpy-build-system.scm +++ b/guix/build/renpy-build-system.scm @@ -57,7 +57,7 @@ (delete-file (string-append data "/renpy-build.json")) (call-with-output-file launcher (lambda (port) - (format port "#!~a~%~a ~a \"$@\"" + (format port "#!~a~%~a ~s \"$@\"" (which "bash") (which "renpy") data))) @@ -77,8 +77,9 @@ (string-append out "/share/applications/" executable-name ".desktop") #:name (assoc-ref json-dump "name") #:generic-name (assoc-ref build "display_name") - #:exec (string-append (which "renpy") " " - out "/share/renpy/" directory-name) + #:exec (format #f "~a ~s" + (which "renpy") + (string-append out "/share/renpy/" directory-name)) #:categories '("Game" "Visual Novel"))) #t) -- 2.30.1 From unknown Fri Sep 12 18:17:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Feb 2021 00:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46671 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 46671@debbugs.gnu.org Received: via spool by 46671-submit@debbugs.gnu.org id=B46671.161386798711391 (code B ref 46671); Sun, 21 Feb 2021 00:40:01 +0000 Received: (at 46671) by debbugs.gnu.org; 21 Feb 2021 00:39:47 +0000 Received: from localhost ([127.0.0.1]:53233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDcmp-0002xf-CT for submit@debbugs.gnu.org; Sat, 20 Feb 2021 19:39:47 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:38773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDcmd-0002xI-6w for 46671@debbugs.gnu.org; Sat, 20 Feb 2021 19:39:46 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 576F02CE; Sat, 20 Feb 2021 19:39:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 20 Feb 2021 19:39:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=zcBSWDjvUJQNeyI2EZPwHFQc cAiijNjTxA6JglUVKRU=; b=ASW1R01EAZwmovvam8M+RzawKpL8KRmZJfs0i54j xlXLmnjgG8YSkOk+D1vqelKGb9W3L6Ymng8PlYsoZLdTh+LXncTvQaMoZZow5zQR OvB/xU/Nj93ic7qQNPxKuEPpmgIQyGwOF1KJisGtHOBf3Zwzg+zvwI8dnh1xY6D4 o6s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zcBSWD jvUJQNeyI2EZPwHFQccAiijNjTxA6JglUVKRU=; b=KcXTIj0gLY+7S7Jx+j+6HP CLdaDhto7r/NQnXQSVKbkIITGZPV7nEM2b9hSHQ59q/5zgWskBatQmPtPsPQbxLb Om2OaBbepXmHmgCe9w3Kp+zFyCCVt2MLQGQSSYDXn+HRNLfDuMboNnv/M1sv3At9 y3poeDNsmoiYxu60Ry/JKdGDHwKivwp9xKMfOfN3yI5m6/rgTCEE7rL9pu915BsZ bKHqNq03KGEs+w5ptpNohDlAIPuLpfMfT4IaN3Z9Pw5Qa4m1AjIbzbq4duRyYLQh KTLLmkU3I03YSk0VDl0ooYQdgqN9Ou2CCN+hfAFzH+WowbsU18oyIIXcDwvdREUA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjeelgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcuhfgr mhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvg hrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheffvefg necukfhppeeiledruddvtddrledvrddvtdeknecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (ool-45785cd0.dyn.optonline.net [69.120.92.208]) by mail.messagingengine.com (Postfix) with ESMTPA id C3B651080057; Sat, 20 Feb 2021 19:39:27 -0500 (EST) Date: Sat, 20 Feb 2021 19:39:26 -0500 From: Leo Famulari Message-ID: References: <20210220235826.24017-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210220235826.24017-1-leo.prikler@student.tugraz.at> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Feb 21, 2021 at 12:58:27AM +0100, Leo Prikler wrote: > This prevents generated launchers and desktop files from inadvertently > crashing if the directory name contains a space. > > * gnu/build/renpy-build-system.scm (install, install-desktop-file): Use ~s > to format data directory. s/gnu/guix Otherwise LGTM if it fixes the problem for you. From unknown Fri Sep 12 18:17:20 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Prikler Subject: bug#46671: closed (Re: [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory.) Message-ID: References: <45e1cc0e3926a6745f18f88c89e2f8067f651495.camel@student.tugraz.at> <20210220235826.24017-1-leo.prikler@student.tugraz.at> X-Gnu-PR-Message: they-closed 46671 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 46671@debbugs.gnu.org Date: Wed, 24 Feb 2021 00:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1614125522-19031-1" This is a multi-part message in MIME format... ------------=_1614125522-19031-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #46671: [PATCH] gnu: renpy-build-system: Quote data directory. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 46671@debbugs.gnu.org. --=20 46671: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D46671 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1614125522-19031-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 46671-done) by debbugs.gnu.org; 24 Feb 2021 00:11:37 +0000 Received: from localhost ([127.0.0.1]:60957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEhmC-0004w4-Hi for submit@debbugs.gnu.org; Tue, 23 Feb 2021 19:11:36 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:42046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lEhmA-0004vw-Oa for 46671-done@debbugs.gnu.org; Tue, 23 Feb 2021 19:11:35 -0500 Received: from nijino.local (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Dlbtq49VTz1LLyW; Wed, 24 Feb 2021 01:11:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4Dlbtq49VTz1LLyW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1614125491; bh=aF8rgGm63HZHmj0uOhGzesp6NVjasiQsnj8LLktnTKg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=WvFe2sfnABaDKSTtSCZ3vPdxT+rLVVRCiAJqapMqqnt5gU9UgSzTcah3uAoPo77Pw dL8znrrZtJ7sblpS4jGgNG3JLJW91WaOe99fnFb0wF9t4ZPZQGrOIS2+IyEQfAsveO 4G6haZsmtq23UDpHb/na21xGQMh4VxzO/LTmq/xI= Message-ID: <45e1cc0e3926a6745f18f88c89e2f8067f651495.camel@student.tugraz.at> Subject: Re: [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory. From: Leo Prikler To: Leo Famulari Date: Wed, 24 Feb 2021 01:11:30 +0100 In-Reply-To: References: <20210220235826.24017-1-leo.prikler@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46671-done Cc: 46671-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Samstag, den 20.02.2021, 19:39 -0500 schrieb Leo Famulari: > On Sun, Feb 21, 2021 at 12:58:27AM +0100, Leo Prikler wrote: > > This prevents generated launchers and desktop files from > > inadvertently > > crashing if the directory name contains a space. > > > > * gnu/build/renpy-build-system.scm (install, install-desktop-file): > > Use ~s > > to format data directory. > > s/gnu/guix > > Otherwise LGTM if it fixes the problem for you. I hope not too many packages are troubled by spaces in their directory names, but it's better to be safe than to be sorry. Pushed! ------------=_1614125522-19031-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Feb 2021 00:23:57 +0000 Received: from localhost ([127.0.0.1]:53161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDcXU-0002VX-Uh for submit@debbugs.gnu.org; Sat, 20 Feb 2021 19:23:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:48726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDcXS-0002VP-95 for submit@debbugs.gnu.org; Sat, 20 Feb 2021 19:23:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDcXR-0004pl-Pp for guix-patches@gnu.org; Sat, 20 Feb 2021 19:23:54 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:24321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDcXO-0006sC-Bg for guix-patches@gnu.org; Sat, 20 Feb 2021 19:23:53 -0500 Received: from localhost.localdomain (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DjmJH1pbRz1LBSW for ; Sun, 21 Feb 2021 01:23:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4DjmJH1pbRz1LBSW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1613867023; bh=EKuy/RG4IYRGlOaqPDUfE9VIS6OYJYkI5HtUZaSdPZg=; h=From:To:Subject:Date:From; b=PgJYy0Tp4WjwObkf1iCHH+KDaSnuB/On1zAgp1zt02qBYsghgbcFnhWOnGlmFsA0f Yfd5kIejcOHwe5aY/hQieqFs1NQPUD5DhX4gfWP+Bln1e0TMu+N1dm69jWrtkYemar hPTIB6hMWXZsATD8DxQPBjdE3BFTSZobpx+x3rms= From: Leo Prikler To: guix-patches@gnu.org Subject: [PATCH] gnu: renpy-build-system: Quote data directory. Date: Sun, 21 Feb 2021 00:58:27 +0100 Message-Id: <20210220235826.24017-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This prevents generated launchers and desktop files from inadvertently crashing if the directory name contains a space. * gnu/build/renpy-build-system.scm (install, install-desktop-file): Use ~s to format data directory. --- guix/build/renpy-build-system.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/guix/build/renpy-build-system.scm b/guix/build/renpy-build-system.scm index 464fc97b13..66683971c5 100644 --- a/guix/build/renpy-build-system.scm +++ b/guix/build/renpy-build-system.scm @@ -57,7 +57,7 @@ (delete-file (string-append data "/renpy-build.json")) (call-with-output-file launcher (lambda (port) - (format port "#!~a~%~a ~a \"$@\"" + (format port "#!~a~%~a ~s \"$@\"" (which "bash") (which "renpy") data))) @@ -77,8 +77,9 @@ (string-append out "/share/applications/" executable-name ".desktop") #:name (assoc-ref json-dump "name") #:generic-name (assoc-ref build "display_name") - #:exec (string-append (which "renpy") " " - out "/share/renpy/" directory-name) + #:exec (format #f "~a ~s" + (which "renpy") + (string-append out "/share/renpy/" directory-name)) #:categories '("Game" "Visual Novel"))) #t) -- 2.30.1 ------------=_1614125522-19031-1--