GNU bug report logs - #46670
28.0.50; [feature/native-comp] possible miscompilation affecting lsp-mode

Previous Next

Package: emacs;

Reported by: Mauricio Collares <mauricio <at> collares.org>

Date: Sun, 21 Feb 2021 00:14:02 UTC

Severity: normal

Found in version 28.0.50

Done: Andrea Corallo <akrl <at> sdf.org>

Bug is archived. No further changes may be made.

Full log


Message #65 received at 46670 <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> gmail.com>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 46670 <at> debbugs.gnu.org, Mauricio Collares <mauricio <at> collares.org>
Subject: Re: bug#46670: 28.0.50; [feature/native-comp] possible miscompilation
 affecting lsp-mode
Date: Wed, 24 Feb 2021 04:31:56 +0000
On Tue, Feb 23, 2021 at 11:36 PM Andrea Corallo <akrl <at> sdf.org> wrote:
> Pip Cet <pipcet <at> gmail.com> writes:
>
> > On Mon, Feb 22, 2021 at 1:12 PM Andrea Corallo <akrl <at> sdf.org> wrote:
> >> We'll probably see other bugs in this area cause is tricky, is important
> >> we build the best coverage we can for this in the testsuite.
> >
> > Is this one of them, or am I confused?
>
> What's suspitions with that?  At present I'm admittedly quite done but
> it looks okay to me.

We're emitting

(assume ,lhs (and ,lhs ,rhs))

even when NEGATED is t.

> BTW applying the patch and running comp-tests.el I get 39 regressions.

That's expected, because we need to replace the incorrect assume by
correct ones to actually get to the same level of optimization.




This bug report was last modified 4 years and 168 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.