GNU bug report logs - #46668
[PATCH]: tests: do not hard code HTTP ports

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxime Devos <maximedevos <at> telenet.be>
Subject: bug#46668: closed (Re: bug#46668: [PATCH]: tests: do not hard
 code HTTP ports)
Date: Sat, 06 Mar 2021 10:25:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#46668: [PATCH]: tests: do not hard code HTTP ports

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 46668 <at> debbugs.gnu.org.

-- 
46668: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46668
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 46668-done <at> debbugs.gnu.org
Subject: Re: bug#46668: [PATCH]: tests: do not hard code HTTP ports
Date: Sat, 06 Mar 2021 11:23:53 +0100

Hi Maxime,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> On Tue, 2021-03-02 at 22:29 +0100, Ludovic Courtès wrote:
>> 
>> [...]
>> It’s a tad confusing that the second ‘with-http-server’ is now nested;
>> it shouldn’t change the semantics though, so it’s okay.
>> 
>> Anyway, you’re welcome to push to ‘master’ if “make check” agrees.  :-)
>
> I do not have commit access, and I haven't applied for commit access either,
> so you will have to push it yourself.

Oops, my bad; applied now, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH]: tests: do not hard code HTTP ports
Date: Sat, 20 Feb 2021 23:00:30 +0100

[Message part 4 (text/plain, inline)]

Hi Guix,

I encountered a ‘Cannot listen to port: is bound’ error
or something like that when testing some changes to the
substituter.  I'm not sure yet what the cause is, but this
patch should eliminate some potential trouble, by not
hard-coding ports in tests that require a temporary http
server, and instead automatically assigning a free port.

Greetings,
Maxime

[0001-tests-do-not-hard-code-HTTP-ports.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.