From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 20 06:42:42 2021 Received: (at submit) by debbugs.gnu.org; 20 Feb 2021 11:42:42 +0000 Received: from localhost ([127.0.0.1]:51136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDQeo-0002qH-DS for submit@debbugs.gnu.org; Sat, 20 Feb 2021 06:42:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:42736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDQei-0002q6-U1 for submit@debbugs.gnu.org; Sat, 20 Feb 2021 06:42:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDQei-0007xP-M5 for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2021 06:42:36 -0500 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:55201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDQeg-0004c7-3F for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2021 06:42:36 -0500 Received: by mail-pj1-x1030.google.com with SMTP id cx11so3152940pjb.4 for ; Sat, 20 Feb 2021 03:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=042RW3y9VWfqTBPkme1hLlbBXZ9E6qeWp2AkiwspVlI=; b=PVxIdB+2EvAuoGwg5X+giUUVl3t5HIZMr7USqHYGoUeT+21IpVXKMfd6CL/qDLJZ0S IK2aJ1wQnMtjgbN1AocA9kutXN0N1hQ5VtbJ8oa7cu6pQc27ej1l2EIQdnWOM+quPMUW uUJ+q27nVyMb1YXc9HUzZrkAgYcoW0uki3bU1JHROberFJDrTGq+8L6IAU1OsllYVIxW l1SRNT8GrrXjGvOsOzhMWFeV7K2U+/RmbCnQntef6DoQQRuJILvw/zagQ5YYM/sQrUHe XEFhHh4eKCCdjuHVZ1cV7e5OSGVC3pLmitF8y9/vuf2jL4pq7br6iPXj9eIpp4YPQHm4 xATQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=042RW3y9VWfqTBPkme1hLlbBXZ9E6qeWp2AkiwspVlI=; b=h1KLN65yf7cOxchUf8/+74w4zaHg+qAJGsJWAK8azsajOhwVIjxlq9j3sXrL/AVKZu Hz8g0GHnszvYA2e6xvhwH5xCJUjgZfuUg5F+Jxk/R0OG/DQJrS5BvCxbXe9Vz9R0W39C ClnxsMUJWYC8Sa+SVuq7PDSq4vojtjiEDhQzDFzvL9a9XZTMnDvs4SiebWZWsV+x7oNx S34QifbvES9qzF1MU0mE8V8BCkwKrbzr7UYAE+TO5LuK5ZneGnM9B1RYc6oNX4eq4Hvo G3XB9cBo+o5RUdT39OrNA3I26jTI/ciBw6P4+Ejoyp2x8c2PrtXv8lnDROBLr6vsG0Dk n6KA== X-Gm-Message-State: AOAM531LYzhXMjtak7DIn19aUk13dZxMi/5+mWA1UxgX+ZFgG2bbM6vV fj69rTR7FE2gwv3h5fDj/u/ftYcDnPAuqszW3sODTZLIk2iSAw== X-Google-Smtp-Source: ABdhPJyne7PPCoDavchngY5+VmplIxerl+gEeSKquv9eU/Sedw3dW4mcCHdaO5r3b1undJIq/ZaKhIHPG+jyTNGw33o= X-Received: by 2002:a17:90a:9909:: with SMTP id b9mr13083279pjp.46.1613821352085; Sat, 20 Feb 2021 03:42:32 -0800 (PST) MIME-Version: 1.0 From: Julian Scheid Date: Sun, 21 Feb 2021 00:42:20 +1300 Message-ID: Subject: [PATCH] cl-extra: Fix docstring retrieval To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000006cb2ed05bbc31092" Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=julians37@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --0000000000006cb2ed05bbc31092 Content-Type: multipart/alternative; boundary="0000000000006cb2eb05bbc31090" --0000000000006cb2eb05bbc31090 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Given (require 'cl-macs) (cl-defstruct foobar (baz nil :documentation "an important piece of information")) Now, (describe-symbol 'foobar-baz) will include "an important piece of information". However, (describe-symbol 'foobar) will not: Name Type Default =E2=80=94=E2=80=94=E2=80=94=E2=80=94 =E2=80=94=E2=80=94=E2=80=94=E2=80=94 = =E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94 baz t nil ... even though the intention to include it can be seen by looking for the string ':documentation' in `cl--describe-class-slots`. This is because `cl--describe-class-slots` accidentally uses `alist-get` instead of `plist-get`. With the attached patch, (describe-symbol 'foobar) works as intended: Name Type Default Doc =E2=80=94=E2=80=94=E2=80=94=E2=80=94 =E2=80=94=E2=80=94=E2=80=94=E2=80=94 = =E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94 =E2=80=94= =E2=80=94=E2=80=94 baz t nil an important piece of information Note: `cl--describe-class-slot' (a different function) appears to have the same bug, but I have no idea how one would go about adding class slots to a struct and therefore no way of testing any changes to this other function. Could it be a code path that is never executed anyway? I decided to leave it alone, this patch should be an improvement regardless. --0000000000006cb2eb05bbc31090 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Given

=C2=A0 (require 'cl-macs)
=C2=A0 (cl-d= efstruct foobar
=C2=A0 =C2=A0 (baz nil :documentation "an important= piece of information"))

Now, (describe-symbol 'foobar-baz)= will include "an important piece of
information".

Howe= ver, (describe-symbol 'foobar) will not:

Name Type Default
= =E2=80=94=E2=80=94=E2=80=94=E2=80=94 =E2=80=94=E2=80=94=E2=80=94=E2=80=94 = =E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94
baz t n= il

... even though the intention to include it can be seen by lookin= g for
the string ':documentation' in `cl--describe-class-slots`.=

This is because `cl--describe-class-slots` accidentally uses
`al= ist-get` instead of `plist-get`.

With the attached patch, (describe-= symbol 'foobar) works as intended:

Name Type Default Doc
= =E2=80=94=E2=80=94=E2=80=94=E2=80=94 =E2=80=94=E2=80=94=E2=80=94=E2=80=94 = =E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94 =E2=80=94= =E2=80=94=E2=80=94
baz t nil an important piece of information

N= ote: `cl--describe-class-slot' (a different function) appears to havethe same bug, but I have no idea how one would go about adding class
s= lots to a struct and therefore no way of testing any changes to this
oth= er function.

Could it be a code path that is never executed anyway?= =C2=A0 I decided to
leave it alone, this patch should be an improvement = regardless.
--0000000000006cb2eb05bbc31090-- --0000000000006cb2ed05bbc31092 Content-Type: application/octet-stream; name="cl--describe-class-slots_plist-get.patch" Content-Disposition: attachment; filename="cl--describe-class-slots_plist-get.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kldnf36t0 RnJvbSBkOWI2NzA1MmE1OTVkMDNmMjI4YzYxZDA1YjA5MDZlYTc0YjBlZTRlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdWxpYW4gU2NoZWlkIDxqdWxpYW5zMzdAZ21haWwuY29tPgpE YXRlOiBTdW4sIDIxIEZlYiAyMDIxIDAwOjE1OjUyICsxMzAwClN1YmplY3Q6IFtQQVRDSF0gY2wt ZXh0cmE6IEZpeCBkb2NzdHJpbmcgcmV0cmlldmFsCgoqIGxpc3AvZW1hY3MtbGlzcC9jbC1leHRy YS5lbCAoY2wtLWRlc2NyaWJlLWNsYXNzLXNsb3RzKTogRml4CiAgZG9jc3RyaW5nIHJldHJpZXZh bC4KLS0tCiBsaXNwL2VtYWNzLWxpc3AvY2wtZXh0cmEuZWwgfCA0ICsrLS0KIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9l bWFjcy1saXNwL2NsLWV4dHJhLmVsIGIvbGlzcC9lbWFjcy1saXNwL2NsLWV4dHJhLmVsCmluZGV4 IDI4Y2U2YjExNWEuLjg0MTk5YzE2MTIgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9jbC1l eHRyYS5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvY2wtZXh0cmEuZWwKQEAgLTg5OCw4ICs4OTgs OCBAQCBjbC0tZGVzY3JpYmUtY2xhc3Mtc2xvdHMKICAgICAgICAgICAgICAgIChsaXN0IChjbC1w cmluMS10by1zdHJpbmcgKGNsLS1zbG90LWRlc2NyaXB0b3ItbmFtZSBzbG90KSkKICAgICAgICAg ICAgICAgICAgICAgIChjbC1wcmluMS10by1zdHJpbmcgKGNsLS1zbG90LWRlc2NyaXB0b3ItdHlw ZSBzbG90KSkKICAgICAgICAgICAgICAgICAgICAgIChjbC1wcmluMS10by1zdHJpbmcgKGNsLS1z bG90LWRlc2NyaXB0b3ItaW5pdGZvcm0gc2xvdCkpCi0gICAgICAgICAgICAgICAgICAgICAobGV0 ICgoZG9jIChhbGlzdC1nZXQgOmRvY3VtZW50YXRpb24KLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoY2wtLXNsb3QtZGVzY3JpcHRvci1wcm9wcyBzbG90KSkpKQor ICAgICAgICAgICAgICAgICAgICAgKGxldCAoKGRvYyAocGxpc3QtZ2V0IChjbC0tc2xvdC1kZXNj cmlwdG9yLXByb3BzIHNsb3QpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgOmRvY3VtZW50YXRpb24pKSkKICAgICAgICAgICAgICAgICAgICAgICAgKGlmIChub3Qg ZG9jKSAiIgogICAgICAgICAgICAgICAgICAgICAgICAgIChzZXRxIGhhcy1kb2MgdCkKICAgICAg ICAgICAgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMgZG9jKSkpKSkKLS0g CjIuMzAuMQoK --0000000000006cb2ed05bbc31092-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 10:06:50 2021 Received: (at 46662) by debbugs.gnu.org; 22 Feb 2021 15:06:50 +0000 Received: from localhost ([127.0.0.1]:57068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lECnS-0003ie-Dv for submit@debbugs.gnu.org; Mon, 22 Feb 2021 10:06:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lECnQ-0003iO-KU for 46662@debbugs.gnu.org; Mon, 22 Feb 2021 10:06:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=k5MfYGNQrEPBgsY2AYGRHvVBzelGtwBqq5UN2i7dUAY=; b=ee1RrrvWgM5aenShoQVMOIDn0T Feop78i53dUd7pD9Ql8lMHGvqUEdYasarzIHjELMsNnh6BE7u26R/uoyoCrJVeomx1wfOYMzxwxOv ra/G4Hlb08/rP0TYNKA3bXJBAguUm8VnK4oOfrTteISdRtzWiVscDfzNhq8RpWTgalTw=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lECnC-0006Mq-Hc; Mon, 22 Feb 2021 16:06:42 +0100 From: Lars Ingebrigtsen To: Julian Scheid Subject: Re: bug#46662: [PATCH] cl-extra: Fix docstring retrieval References: X-Now-Playing: Hugo Largo's _Turtle Song_: "Turtle Song" Date: Mon, 22 Feb 2021 16:06:32 +0100 In-Reply-To: (Julian Scheid's message of "Sun, 21 Feb 2021 00:42:20 +1300") Message-ID: <87o8gcjg5j.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Julian Scheid writes: > With the attached patch, (describe-symbol 'foobar) works as intended: > > Name Type Default Doc > ———— ———— ——————— ——— > baz t nil an important piece of informat [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46662 Cc: 46662@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Julian Scheid writes: > With the attached patch, (describe-symbol 'foobar) works as intended: > > Name Type Default Doc > =E2=80=94=E2=80=94=E2=80=94=E2=80=94 =E2=80=94=E2=80=94=E2=80=94=E2=80=94= =E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94=E2=80=94 =E2=80=94= =E2=80=94=E2=80=94 > baz t nil an important piece of information Thanks; applied to Emacs 28. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 22 10:06:56 2021 Received: (at control) by debbugs.gnu.org; 22 Feb 2021 15:06:57 +0000 Received: from localhost ([127.0.0.1]:57071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lECnY-0003iw-Lv for submit@debbugs.gnu.org; Mon, 22 Feb 2021 10:06:56 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lECnX-0003id-1J for control@debbugs.gnu.org; Mon, 22 Feb 2021 10:06:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4ZEgKrZPpmnjTaDUL3K/R9CrhFzEVxCo9iAkUaqrwbU=; b=iuF4u66hzm+xubWl3td2wZdedv VaN261ECSBU+S3YvwDQ/lPDYjagIaRv+qewHPb+5AEut4bNzPFV4/HSUQt13wzt9HL8g4fGZFXKXa fLuC+snpc1T4KKG44DEX9x3DLrKiLH2XXhnceIJLWg8LIOQlib2LxKL6mg6RA/rPjjvM=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lECnO-0006Mx-U8 for control@debbugs.gnu.org; Mon, 22 Feb 2021 16:06:49 +0100 Date: Mon, 22 Feb 2021 16:06:45 +0100 Message-Id: <87mtvwjg56.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #46662 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 46662 fixed close 46662 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 46662 fixed close 46662 28.1 quit From unknown Thu Sep 11 19:19:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 23 Mar 2021 11:24:50 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator