From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 46641@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16137575737775 (code B ref -1); Fri, 19 Feb 2021 18:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Feb 2021 17:59:33 +0000 Received: from localhost ([127.0.0.1]:50337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDA3w-00021K-Jw for submit@debbugs.gnu.org; Fri, 19 Feb 2021 12:59:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDA3v-000219-IK for submit@debbugs.gnu.org; Fri, 19 Feb 2021 12:59:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54824) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDA3o-0003Hn-Gi for submit@debbugs.gnu.org; Fri, 19 Feb 2021 12:59:25 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1lDA3d-0005Jb-RK; Fri, 19 Feb 2021 12:59:17 -0500 From: Glenn Morris X-Attribution: GM Date: Fri, 19 Feb 2021 12:59:13 -0500 Message-ID: <4lpn0wndla.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Package: emacs Version: 27.1 Some process-tests fail if the system has no network connection. I don't know what the appropriate skip-unless condition to test for network access is. Ref: https://bugs.debian.org/982969 From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 11:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161390593114319 (code B ref 46641); Sun, 21 Feb 2021 11:13:02 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 11:12:11 +0000 Received: from localhost ([127.0.0.1]:53609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDmep-0003it-0b for submit@debbugs.gnu.org; Sun, 21 Feb 2021 06:12:11 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:43583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDmek-0003iL-3V for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 06:12:10 -0500 Received: by mail-wr1-f53.google.com with SMTP id n8so15886709wrm.10 for <46641@debbugs.gnu.org>; Sun, 21 Feb 2021 03:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=0j59cSDbdW+OdwMoTRN3sj5UnXvlA3MwCN0y2yOkmiE=; b=sfZvNWSoK8r2bKvDXHtoUfiXVT+fMN/8/HAS5eIJIhefLO3ofCE7GZiNB3mkz65H72 DEnMm4sXHLKEkusCpLje6duDoRXwDcSCMqvSabF0eZYtMwyksJB/9BvG+gPiJubZHKKS /gThIJkBzDSaxmNGt4Jn0Gr6715k80ciY14zMbxli0hhyDIBy46g25hxTWbBVUjHR26m ERFKuDxIKsgdmqhfEwhdXu5MTCPuleZWE1ar+mcQp9qNh38EZxcdnVKYgziASHplU9Kf LW0ZG3I7iLFV3yQi5gDbAFxNiMYH3GENmz0QcBBTZlFd1PdGl5BI4+Lk4fx9Tt6paArh MF4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=0j59cSDbdW+OdwMoTRN3sj5UnXvlA3MwCN0y2yOkmiE=; b=UEy9AW4CtPPe9uOjjM8E7WC2T7le5jSiTxWmydZOQN6swxeuwmEQ8uV9ntaMyVKS1b C1CZXrya17iX2wGlvt2Jxex1hx5sn4gIuONTd4NL3OWt3oaMbHRJZQFlxgOZmWukgbiS e3nEh1pMXOFnz6e4mzyGEy+1xcDitDxknKyI/hWqzQTQbOJpdwDhjHZ5a9cySk2EEIE/ UP7GQ48R9LR0UvBApCBb0TAhUDI8/75IIcHbTOvZrQzBcwT//IqZBvrJN+eN4+Z3JsNe Ii9yGiz60visgatRorYGbah61OxI+WZrIUd6ZJhs9KNDMDtU9fx9vBDnwYwOTlGXqsrp 6QNw== X-Gm-Message-State: AOAM5331Pm4ErnaTfyZxZzcvVdTPe882ktpPdalbkRbqMQlWULbN424A qu+SHAZOr/47CKXjxuEj2cKC542UiWEMbw== X-Google-Smtp-Source: ABdhPJyVMaox9jrgxfqGfx5+aDhCvZRiWXRil6SHmOjs8Ez8de4ZkqMXH4Pyys0Ih+aXEhzmwvmMrw== X-Received: by 2002:adf:e484:: with SMTP id i4mr16911244wrm.358.1613905919663; Sun, 21 Feb 2021 03:11:59 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:2154:6435:5293:4d19]) by smtp.gmail.com with ESMTPSA id w11sm1716932wru.3.2021.02.21.03.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 03:11:59 -0800 (PST) From: Robert Pluim References: <4lpn0wndla.fsf@fencepost.gnu.org> Date: Sun, 21 Feb 2021 12:11:58 +0100 In-Reply-To: <4lpn0wndla.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 19 Feb 2021 12:59:13 -0500") Message-ID: <871rd9smip.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 19 Feb 2021 12:59:13 -0500, Glenn Morris said: Glenn> Package: emacs Glenn> Version: 27.1 Glenn> Some process-tests fail if the system has no network connection. Glenn> I don't know what the appropriate skip-unless condition to test = for Glenn> network access is. Glenn> Ref: https://bugs.debian.org/982969 So Debian deliberately cripple their test environment, run the network tests for an editor which can do network access, and we have to adapt our tests? I am not amused. I guess we could wrap them all in (skip-unless (dns-query "google.com")) instead of the getenv "EMACS_HYDRA_CI" stuff, assuming Debian don=CA=BCt complain about that as well. Robert PS And since when did 'does not pass all tests' become 'fails to build from source'? From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Glenn Morris , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161391488212945 (code B ref 46641); Sun, 21 Feb 2021 13:42:01 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 13:41:22 +0000 Received: from localhost ([127.0.0.1]:53704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDozC-0003Mj-Cd for submit@debbugs.gnu.org; Sun, 21 Feb 2021 08:41:22 -0500 Received: from quimby.gnus.org ([95.216.78.240]:35704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDozB-0003MW-I6 for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 08:41:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QKMRFZLSg52SG7sR4eMTcZPpXm8IPtutwKOsy1Vul8M=; b=jKGux+zYYMEiKXcRYJUpZN9pbD zLlNW+2S91ckQp0mexNzLQjcG5x4tYZaF24KLhgK5I51tJWWcJxwxHZCCwKD9RRL13k5lZ9cRtVgz 1ahmsnQG6E2l0s2jI8L6I6O8Nf3L5nR4+YO22kuELW+hJFEqzHRqrsjJ03MvQLvEtFOg=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDoz2-0008VU-S9; Sun, 21 Feb 2021 14:41:15 +0100 From: Lars Ingebrigtsen References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXv4c/BtaeJgHdW UUv///8yXQ++AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UCFQ0GEaNowHsAAAGkSURBVDjLXVOLFcMg CARdAM0Cigsksv9uBVFjw2sT4/HxDgQkWPauzAIXoJgpI3aCYlv6wAKx9atH5tYqCzexVe9sgDTO 7elcxX79ynLxUzQVdw5Xy5wSM+tf/TgXQC7wb+wvZPoA8zvKnedOhUBNhukBMZkHU7jVFfWTrdLK glBj13c7I4pXiY+7vBGEZdcAnBHiuRK8iqVh80MgllVsPGlTCWU40wSS5wlSNIKm/1eIZfhApnEO 1S2xBX7aFYQly/Axf+V+H+G2OwlaLlxAdD5pSTTkmQz/0jsPTw4ZPoYzrGn9UHDEBTribWvL+Q7X 0V6smGmxul4ghUe73eaR0Iu3fp6NVI84glD7gy9j2sSCSBkk0oiqWz0HtlVY/QVvtbWW1hC4DJcK WbFOgKgeco23Z3cyx8XawNgKe2UAvnyS8qDBIi2JNJWuaaiiRUdOnBkZkRC+VnVa3EXnzC+FF692 13CfzP+7M/j3pIR2o+Zs6+CmCaRzNHbxHBIvtUuU0uwI8pxOCgQ2HhkcsI7Q8tKhhUsB624sKDek GT5AB3S8uPwAvKgswflmujsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDItMjFUMTM6MDY6MTcr MDA6MDAxgsZ6AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAyLTIxVDEzOjA2OjE3KzAwOjAwQN9+ xgAAAABJRU5ErkJggg== X-Now-Playing: Ishmael Ensemble's _Blue Note Re:imagined (1)_: "Search For Peace" Date: Sun, 21 Feb 2021 14:41:11 +0100 In-Reply-To: <871rd9smip.fsf@gmail.com> (Robert Pluim's message of "Sun, 21 Feb 2021 12:11:58 +0100") Message-ID: <87k0r1k07c.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > Glenn> Some process-tests fail if the system has no network connection. > Glenn> I don't know what the appropriate skip-unless condition to test for > Glenn> network access is. > > Glenn> Ref: https [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Glenn> Some process-tests fail if the system has no network connection. > Glenn> I don't know what the appropriate skip-unless condition to test for > Glenn> network access is. > > Glenn> Ref: https://bugs.debian.org/982969 > > So Debian deliberately cripple their test environment, run the network > tests for an editor which can do network access, and we have to adapt > our tests? I am not amused. > > I guess we could wrap them all in > > (skip-unless (dns-query "google.com")) It'd be nice if Emacs did have a predicate for "is there any network here?" But I don't know what that would look like. That is, there's a difference between having a local network (i.e., 127.0.0.1), and being on the Internet. But if any of our tests require Emacs to be on a functioning internet connection, they should indeed be guarded by something like the `skip-unless' you propose. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Philipp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Glenn Morris , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161391826117995 (code B ref 46641); Sun, 21 Feb 2021 14:38:02 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 14:37:41 +0000 Received: from localhost ([127.0.0.1]:53731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDprg-0004gA-2A for submit@debbugs.gnu.org; Sun, 21 Feb 2021 09:37:41 -0500 Received: from mail-ej1-f50.google.com ([209.85.218.50]:46041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDpra-0004ft-Jf for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 09:37:38 -0500 Received: by mail-ej1-f50.google.com with SMTP id n13so24851453ejx.12 for <46641@debbugs.gnu.org>; Sun, 21 Feb 2021 06:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2OpGxjw65JiOnJoYofnw9cWg1N9m9kZBtE4/wlof1Jw=; b=oXrlGymT7kkzoD/HCOpom7r2UHx9OhHs+t/sEds60z046npTIH4oJI7euNvqEM7ln8 H8Gi5h/epxubH2IPS6BOlWOdmi7qLPaN+RU65cGm1Gyx70EFQ5Yp+N/Yji0WJgndHkn/ W8Q9h8D4v0PYZniM+akoRnjsqSdTc9tGdkvUIYUbmWNeArIGzP+x5AWsYvZrCy3P7egG GKemP3VpTMvSakNzxSWco39oqR641AoR7fSqFfXu1QcwXIy/6xn7+Y7vz5YGKvrdR8T3 N8jsf7GQFep+VekqB67fmY0+XNzcs1YnikALu/rMYdgsq26pk4BsQHPibvK3ul6xY3sE IanQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2OpGxjw65JiOnJoYofnw9cWg1N9m9kZBtE4/wlof1Jw=; b=uGSkWcgRp3f2v86wyXFFKuTVHEMntygCvEXzH1G9Cizjw6JfP5ewI7sy6iYZL6YVOU K4iLqJotpf2Wq+hNl2OA1h28UhHyNM/6KPcREG0hXNUFEX9VClZOFn6ruBrrs1OO2OSM gSYr8YOkMZo8PRGovtRxrnfkpsxBSJsIwswFPnGdKhU1vztTe9uqoo0jYqIwWG5H+XH1 73N/7vEJVQapBTpQeFGdG9s7hrKrWgO9D+6y/h7q2nMTOmO/nOQScc5f0y4sRGjhs6Ac 0JsC9Ym4k7riMyMdsDBzPeQLwVBv2cYU7B4slrkgtfjrgdGcNrqfAJmkL0rrWSaBL27C YW6A== X-Gm-Message-State: AOAM533qG421IKQKQrL/vs9FjhPJSdRkgSqvxfKoiHm7FxPJtHXy+/eV rK9IXzHbUEntj2DIpPbfO28= X-Google-Smtp-Source: ABdhPJzgKlmU+xzSaayE2yak2W/LDJlf8aLJ5Y1uQXFUIUMLaAaEFmRSXDC+n3aeg4QgiUYlldjuUA== X-Received: by 2002:a17:906:bc4f:: with SMTP id s15mr13810810ejv.154.1613918248494; Sun, 21 Feb 2021 06:37:28 -0800 (PST) Received: from philipps-mbp.fritz.box ([46.128.208.19]) by smtp.gmail.com with ESMTPSA id r11sm9637386edt.58.2021.02.21.06.37.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Feb 2021 06:37:27 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) From: Philipp In-Reply-To: <871rd9smip.fsf@gmail.com> Date: Sun, 21 Feb 2021 15:37:27 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) > Am 21.02.2021 um 12:11 schrieb Robert Pluim : >=20 >>>>>> On Fri, 19 Feb 2021 12:59:13 -0500, Glenn Morris = said: >=20 > Glenn> Package: emacs > Glenn> Version: 27.1 >=20 > Glenn> Some process-tests fail if the system has no network = connection. > Glenn> I don't know what the appropriate skip-unless condition to = test for > Glenn> network access is. >=20 > Glenn> Ref: https://bugs.debian.org/982969 >=20 > So Debian deliberately cripple their test environment, run the network > tests for an editor which can do network access, and we have to adapt > our tests? I am not amused. This is pretty common for CI systems. Accessing the network is a = security risk, and in addition tends to make tests unreproducible.= From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Philipp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Glenn Morris , Robert Pluim , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161391841518231 (code B ref 46641); Sun, 21 Feb 2021 14:41:01 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 14:40:15 +0000 Received: from localhost ([127.0.0.1]:53735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDpuB-0004jy-AD for submit@debbugs.gnu.org; Sun, 21 Feb 2021 09:40:15 -0500 Received: from mail-ed1-f53.google.com ([209.85.208.53]:40733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDpu8-0004je-ES for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 09:40:14 -0500 Received: by mail-ed1-f53.google.com with SMTP id q10so18680174edt.7 for <46641@debbugs.gnu.org>; Sun, 21 Feb 2021 06:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=qk5OEdgqza3nKjvbFdpRn7E0/ljx2r7unZv8TVH8wIQ=; b=FLqPe8DOYdQ0z8rjIw4vD7re2VdvHN6b1XXXu9qd5PPT/Tvm7rlCi5vRvh2TJNYmBi 9s3Sof1LQD7KChIm4CHKSWKH0nBsQGNxHBnTta232mA8xiW2pEWcMZY+2NxKaGRjaKro YCeiyH3kD+iWE1agyu5vem7Av0hUmMrnAdMSgZxVXhqpz00H5C6nlLSWpl7gbJnO3XE3 LAPeVcNlB3wdo8qDrj9s4yrnZx6uQm/D4GP/u3KGyxpegQoYsYDDAfhadKW8fSZ2rNQU YFJO5HhbC0ekeWVTV3I9zT+IIVrgL+IeGyLKXpxir9OdZW0C4IYZeMA+c7sGKCAGxfgv f9Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=qk5OEdgqza3nKjvbFdpRn7E0/ljx2r7unZv8TVH8wIQ=; b=qjMat+U1vBDgsxwYZA0c7QvxdSoxAmGR2cEanNuzy/DBq8QT9ZBUybxVt6W8U6qKIM MgKOkBRpLL9bj9JR8J8T9M3urGXTHks8gREWVXXRqzpqcIBVBoOT36x8llhHZmvVwOCE OnlO7chBuvt3nSAijtTJCkAJhfGTd+VrICLnRD0ALDSDYTFXCY3L7O7w7gmagB2ZvgTC 17WiEm+b+eL6yhK5aoAOQp8M1RYQu7ffiVXdBCmQZ60J6Wm7UMA3vPpzbHyOEnaCfnn3 M90N7ZQyoWinR+DLysM2CSc1XPHFoC8LwqPMl6cqmv7zciVJaIAcMcymS9P6fJTrPBRn K00A== X-Gm-Message-State: AOAM530fVc7RE6bBlmaAx8j9weUB1EJo2liwzTVvu5jw3E33Y1PEUf+z 6XJ4R1BqDudQC3FYB3MmZ7s= X-Google-Smtp-Source: ABdhPJxqlwf5YGQgEaHhe2ldWZP9LVoof30cSCCAlhW22NN49EFXTpfMJWYlsRU+xC4kdS9olJ6Njw== X-Received: by 2002:a05:6402:1118:: with SMTP id u24mr18491757edv.386.1613918406603; Sun, 21 Feb 2021 06:40:06 -0800 (PST) Received: from philipps-mbp.fritz.box ([46.128.208.19]) by smtp.gmail.com with ESMTPSA id c1sm8546447eja.81.2021.02.21.06.40.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Feb 2021 06:40:06 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) From: Philipp In-Reply-To: <87k0r1k07c.fsf@gnus.org> Date: Sun, 21 Feb 2021 15:40:05 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> <87k0r1k07c.fsf@gnus.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) > Am 21.02.2021 um 14:41 schrieb Lars Ingebrigtsen : >=20 > Robert Pluim writes: >=20 >> Glenn> Some process-tests fail if the system has no network = connection. >> Glenn> I don't know what the appropriate skip-unless condition to = test for >> Glenn> network access is. >>=20 >> Glenn> Ref: https://bugs.debian.org/982969 >>=20 >> So Debian deliberately cripple their test environment, run the = network >> tests for an editor which can do network access, and we have to adapt >> our tests? I am not amused. >>=20 >> I guess we could wrap them all in >>=20 >> (skip-unless (dns-query "google.com")) >=20 > It'd be nice if Emacs did have a predicate for "is there any network > here?" This isn=E2=80=99t a yes/no question. For example, it=E2=80=99s often a = good idea to put tests into a network namespace that only has a loopback = interface. In that case, there=E2=80=99s some network (the loopback = interface), but that still doesn=E2=80=99t allow Internet access. From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Glenn Morris , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161392436431048 (code B ref 46641); Sun, 21 Feb 2021 16:20:02 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 16:19:24 +0000 Received: from localhost ([127.0.0.1]:54646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDrS8-00084i-2J for submit@debbugs.gnu.org; Sun, 21 Feb 2021 11:19:24 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:40473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDrS4-00084R-P3 for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 11:19:22 -0500 Received: by mail-wr1-f41.google.com with SMTP id v14so16525288wro.7 for <46641@debbugs.gnu.org>; Sun, 21 Feb 2021 08:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=xpFj9hn8YW4+Bx9ijrmckxEZoelTVC5Iaqh0+JOK8pw=; b=f72JBIlAEKL80qT4m8Xb4ym6+IQ7JRf14m3blkoPyWTKKx2dgTjdj1VtfjFd9m+n7N QYn2xYrQGp8OQzg4huCattZUfrnjWIDSF1CxTxhzMgxN5333OvvQ3mcVuh3cIsxSNRCH ZD8Lg4wqfEnz8t3rTMEESc5Okm49nRkFVaOgVL1bQ7VJddpkxSLD/P4AyWA44XImmr2k 8POmC5ZU6CDE6JvmwYBq/vkn7npYGOpb64HeIvsuv+O8Z84eCyl2Y730xldRMJSe0r0T n2II7dwYsmkBbBVgihWh7ByVUqxo1yVSd5k+9s/bHDehc7IgKP33jWW8BGVM1ulqo0pR qNJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=xpFj9hn8YW4+Bx9ijrmckxEZoelTVC5Iaqh0+JOK8pw=; b=QfipFhlwIjeBzdPMrphEl9UP7Z6SbzTZQxMm4F5yUZ5f8wu5vGGnC1SpdLkgep2DzA gSL2NlbxVOY67FjvVvi5kFfuLAHYoZQ1PXJFtG6Xkr91oivcVxofZRbQ0bIJ6e/oE/jm ntYOBTDPQdBKoKYy/cuxGKnq9iSyQF1+W/kXpUtEcYdad47qPWUMH7gxXisbZZ30GkJ2 CBnVLyVJ9bLHZC/6CSvY4scN0SC4Din9vc9arwgrGWEOHSAJx59eMKJnj22IBP0SfY0h RSupFWM9hbqrUVpIVsfeWEsTomLrRWYHtZwcTH99/llBNEDgJJU7bSQJjcsl9Pc7xf5W 9quw== X-Gm-Message-State: AOAM532mreqZQIk/gf3BSe6DFhw1pLqFFgWedHDLDeW4R0dstqGccg+0 fUet38Sr19W+bIXJC6zrzOnDabAicDNftA== X-Google-Smtp-Source: ABdhPJxlyAV8U+nVAxdls8BasFpHmZGZLFf3HxQYkWyYGNpE5TutZQSqbzisdWO75t6PdjtgIs/rlw== X-Received: by 2002:a05:6000:1081:: with SMTP id y1mr4136740wrw.177.1613924354317; Sun, 21 Feb 2021 08:19:14 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:2154:6435:5293:4d19]) by smtp.gmail.com with ESMTPSA id c62sm23396472wme.16.2021.02.21.08.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 08:19:13 -0800 (PST) From: Robert Pluim References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> <87k0r1k07c.fsf@gnus.org> Date: Sun, 21 Feb 2021 17:19:12 +0100 In-Reply-To: <87k0r1k07c.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 21 Feb 2021 14:41:11 +0100") Message-ID: <87pn0tqtq7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sun, 21 Feb 2021 14:41:11 +0100, Lars Ingebrigtsen said: >> I guess we could wrap them all in >> >> (skip-unless (dns-query "google.com")) Lars> It'd be nice if Emacs did have a predicate for "is there any network Lars> here?" But I don't know what that would look like. That is, there's a Lars> difference between having a local network (i.e., 127.0.0.1), and being Lars> on the Internet. Lars> But if any of our tests require Emacs to be on a functioning internet Lars> connection, they should indeed be guarded by something like the Lars> `skip-unless' you propose. Well, the tests in question are asking 'does emacs have a correctly functioning internet connection', so making that a prerequisite for the test seems kind of redundant, but we can do it. But first: disabling my network connection causes dns-query to hang, so something like this is needed, I think (we can skip the first hunk if you want): diff --git a/lisp/net/dns.el b/lisp/net/dns.el index 2045d4dfca..598ceebab8 100644 --- a/lisp/net/dns.el +++ b/lisp/net/dns.el @@ -332,7 +332,7 @@ dns-set-servers (setq dns-servers (nreverse dns-servers)))) (when (executable-find "nslookup") (with-temp-buffer - (call-process "nslookup" nil t nil "localhost") + (call-process "nslookup" nil t nil "-retry=0" "-timeout=2" "localhost") (goto-char (point-min)) (when (re-search-forward "^Address:[ \t]*\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\|[[:xdigit:]:]*\\)" nil t) @@ -496,15 +496,17 @@ dns-query "Query a DNS server for NAME of TYPE. If FULL, return the entire record returned. If REVERSE, look up an IP address." - (let ((result nil)) - (dns-query-asynchronous - name - (lambda (response) - (setq result (list response))) - type full reverse) - ;; Loop until we get the callback. - (while (not result) - (sleep-for 0.01)) + (let ((result nil) + (query-started + (dns-query-asynchronous + name + (lambda (response) + (setq result (list response))) + type full reverse))) + (if query-started + ;; Loop until we get the callback. + (while (not result) + (sleep-for 0.01))) (car result))) (provide 'dns) From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philipp Cc: Glenn Morris , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161392448731342 (code B ref 46641); Sun, 21 Feb 2021 16:22:02 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 16:21:27 +0000 Received: from localhost ([127.0.0.1]:54656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDrU6-00089S-Pt for submit@debbugs.gnu.org; Sun, 21 Feb 2021 11:21:27 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:34409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDrU5-00089C-1M for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 11:21:25 -0500 Received: by mail-wr1-f53.google.com with SMTP id n4so16572722wrx.1 for <46641@debbugs.gnu.org>; Sun, 21 Feb 2021 08:21:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=EKeP/M8LTSVKNkD4/jm2x/8jTqoM1vVXchDcIjJ32e4=; b=fs4i9AxyQBNyJr3j6mtDBQmeVoRU129hUE0vn4rgdtn09ZRlN9GXXNKnJ9nPTFjBQX +94fnGqnp6rvWnwzQZwjE282dmLi0apYN4ce7HRfDqpmX0KhPUS5sjszbg5bxf8pCcfs ml5WXaVJgJ82wpBHt9Dp8tampFupuBPIoYj92wBvSoKASR1C/XSo6/cWpPo8ZOg67yUF H+oEwjKGjODku2V4D8l1G2asxuESJyTpffl4uX34bn1xT4CkInfP7BSy94/+lNlzY1QD rm1Lv3f7sIfwy07gdI8z7cEqZKhXlRrWQ7Ro7SrmuEzJSiuSGOQ6ShduZwYvc+5fCnWs K6VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=EKeP/M8LTSVKNkD4/jm2x/8jTqoM1vVXchDcIjJ32e4=; b=e2OiN2sd7s+dDU7d4Q3QZBjYdLvAMJ3wZxCeEtoiEhQnYveszFSWE5DSoKzPVpdi46 mGlihcdvUvHpxdCmW/vqqIIGZ6TIKHwy+Gs8TvFpWPP7ps8KjFUdQNq0GahS9EnBHG6k 3dA6KVnvcyMZ/uJtQzzyhVts1DCp7MIqufzJu1l0AONH8oI8u9EmJteXhauRz6MIG6VA wBO9vYmktsIitpLHUZyHKdA/xzsMGUVSNrw6qheJ5eApKzB0/QhtNBVE0f+qiBM5CgvQ Ik77I2WPoCvkZGc7eO7LG5LF/p7vBFk4saS4ktMgf6u6NYxlMBbTTT6TQfEEHLjqdIez zAFw== X-Gm-Message-State: AOAM533BwPnwoZXVNMGK0OTsoYW7fKAsjAJmy4w9knviMpdMYUBdsmMe 2SoIcoW3mvK4PgnjvBvG/T39siT6GIV3XQ== X-Google-Smtp-Source: ABdhPJz7aLcae+NoMu1uPiSeXiIN/zv89yF5YVhXuwno1K7G+a9eqSTOuuZJ8W8hgEXSGokhEwcR/Q== X-Received: by 2002:adf:81f7:: with SMTP id 110mr17887934wra.35.1613924479106; Sun, 21 Feb 2021 08:21:19 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:2154:6435:5293:4d19]) by smtp.gmail.com with ESMTPSA id 6sm31678779wra.63.2021.02.21.08.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 08:21:18 -0800 (PST) From: Robert Pluim References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> Date: Sun, 21 Feb 2021 17:21:17 +0100 In-Reply-To: (Philipp's message of "Sun, 21 Feb 2021 15:37:27 +0100") Message-ID: <87lfbhqtmq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sun, 21 Feb 2021 15:37:27 +0100, Philipp s= aid: Philipp> This is pretty common for CI systems. Accessing the network i= s a Philipp> security risk, and in addition tends to make tests unreproduci= ble. I can give you the second one, but in what way is eg doing a DNS lookup a 'security risk'? We=CA=BCre not talking about setting up a listening server on a public IP here. Robert From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Glenn Morris , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.16139259461219 (code B ref 46641); Sun, 21 Feb 2021 16:46:02 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 16:45:46 +0000 Received: from localhost ([127.0.0.1]:54679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDrre-0000Jb-0S for submit@debbugs.gnu.org; Sun, 21 Feb 2021 11:45:46 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:33502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDrra-0000JL-OY for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 11:45:44 -0500 Received: by mail-wr1-f43.google.com with SMTP id 7so16607849wrz.0 for <46641@debbugs.gnu.org>; Sun, 21 Feb 2021 08:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=CGEkmY4Fsu6F94GbvfCo71/gUBTo5MHWMU18RGt1tiA=; b=EB4VKrfB8rMQKK46X/Uaodd/Zq7KHLXEWOx0IAxSxuVC1Z9u9o2snU3Z9bBcfmURKw qvXTV59xxad/Zj31//S6p0p8brmSh1llbwpPyJ5lXEanplW5RpAIBXKlNcHSUxNobbPi ERa0/wtRak0eWe6ywpg9Vy4i6zQzuEErNrW3i8dQEOYK2bUCv5F41R69RqXI1JcFd7Cp TNrXoA0piTJxIy539qDRsWF9fgFfsT3104e0Rpkmo6zErh2Nv5qK3Nj9hyKw6CRcy6DU NsQVdpblpES5tqd/IyairuI7f88+zA+5yzxJM3nYmiWAnEd8rPIt7W3oD7cMM8cuAiah /Iew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=CGEkmY4Fsu6F94GbvfCo71/gUBTo5MHWMU18RGt1tiA=; b=lJOVXEMR9x/56V4U7M/TTmBObmiwKBESuAFg9YROxaUqkX44yLAwpmLEK0lGMeKos+ W7sLF8HWTj9ba8YBC80hSheC3ywWGHPS9vD7GsZt3tuL1/tVqAToQzHKbW9Vh+AqQhzZ qflPQhR2dLbLFayRWgh8+Gxk7Zw9Z3U8qsTfy0ANVcP1gf5KyQjZ/DfnyZBy6+qJVMLb ZTyc37Yp3eMErbrRxgLWoxgsiD0n0hBWZryido46MLZfAM0twq2eIyyAh/9HLibVbL59 Ln22K96oMQBvsiNTK9QaUWAfVVmPz+YKbcC4lLzD8+RhiG/yGs4BHlrTepteGiNaMNeL oXYw== X-Gm-Message-State: AOAM532RCHwdryDsap/pd91nhMbRL9zUXrE+f5tAy03b8/iaodkMm7JB 7I3zvihwGFG3Z8jQzXFIJhsf0Wwn9igBVA== X-Google-Smtp-Source: ABdhPJx+/k+GCGcj0l/FJDSMS25sTVjj9Rq0nZIorrus1YMTQPw5oYTtrIfzfG0Yzd0VIl5qSkQ9aw== X-Received: by 2002:a5d:6a4f:: with SMTP id t15mr1172259wrw.219.1613925936456; Sun, 21 Feb 2021 08:45:36 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:2154:6435:5293:4d19]) by smtp.gmail.com with ESMTPSA id h17sm17279064wrw.74.2021.02.21.08.45.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 08:45:35 -0800 (PST) From: Robert Pluim References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> <87k0r1k07c.fsf@gnus.org> <87pn0tqtq7.fsf@gmail.com> Date: Sun, 21 Feb 2021 17:45:29 +0100 In-Reply-To: <87pn0tqtq7.fsf@gmail.com> (Robert Pluim's message of "Sun, 21 Feb 2021 17:19:12 +0100") Message-ID: <87blcdgyja.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sun, 21 Feb 2021 17:19:12 +0100, Robert Pluim said: Robert> Well, the tests in question are asking 'does emacs have a correctly Robert> functioning internet connection', so making that a prerequisite for Robert> the test seems kind of redundant, but we can do it. But first: Robert> disabling my network connection causes dns-query to hang, so something Robert> like this is needed, I think (we can skip the first hunk if you want): Ah, the wonders of running diff when you haven't tested the result from a clean emacs. This one actually works. diff --git a/lisp/net/dns.el b/lisp/net/dns.el index 2045d4dfca..3ae7469798 100644 --- a/lisp/net/dns.el +++ b/lisp/net/dns.el @@ -332,7 +332,7 @@ dns-set-servers (setq dns-servers (nreverse dns-servers)))) (when (executable-find "nslookup") (with-temp-buffer - (call-process "nslookup" nil t nil "localhost") + (call-process "nslookup" nil t nil "-retry=0" "-timeout=2" "localhost") (goto-char (point-min)) (when (re-search-forward "^Address:[ \t]*\\([0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+\\|[[:xdigit:]:]*\\)" nil t) @@ -496,15 +496,17 @@ dns-query "Query a DNS server for NAME of TYPE. If FULL, return the entire record returned. If REVERSE, look up an IP address." - (let ((result nil)) - (dns-query-asynchronous - name - (lambda (response) - (setq result (list response))) - type full reverse) - ;; Loop until we get the callback. - (while (not result) - (sleep-for 0.01)) + (let* ((result nil) + (query-started + (dns-query-asynchronous + name + (lambda (response) + (setq result (list response))) + type full reverse))) + (if query-started + ;; Loop until we get the callback. + (while (not result) + (sleep-for 0.01))) (car result))) (provide 'dns) From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Glenn Morris , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161393236911167 (code B ref 46641); Sun, 21 Feb 2021 18:33:02 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 18:32:49 +0000 Received: from localhost ([127.0.0.1]:54826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDtXF-0002u3-9F for submit@debbugs.gnu.org; Sun, 21 Feb 2021 13:32:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:38548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDtXA-0002tm-7r for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 13:32:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PRfeeoir3izPdBlMVpWqESFAb1t6LSFmyugok68JHmA=; b=EUdMEYs52Ax0ig5iYTeiTuQa+a 85j0ICc+KlY/IxEon6y4BTXouZUbBWpWT9gwR1NcpwRp6f5kQTskHHCTQVyJRoVFnGvmEM+jaLnzL upmS03gGgvvBAf3n1BiWCg6NyA2Qf3kA+oB3uoY6Ta+eJfljBN32xeAynpdP9QTGc/d8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDtWt-0003Aa-Di; Sun, 21 Feb 2021 19:32:37 +0100 From: Lars Ingebrigtsen References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> <87k0r1k07c.fsf@gnus.org> <87pn0tqtq7.fsf@gmail.com> <87blcdgyja.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUoKE8rMm4RERs4 TJpCU5xPZK9zhMH9/f6eqNLU2On///8u7hf8AAAAAWJLR0QKaND0VgAAAAd0SU1FB+UCFRIKOS0S w8AAAAGySURBVDjLrZDvcdswDMUhZwExzAAyu0B5ZCYg+D1XA96AWkH1APV5BGfbAqQkS4n7re9O //DDewAFUNXBXv3y/Aq+NjQN8F/V/wt0DXWPnm7D6tXvV25tnQEjZ+m/zzCdMQZenbBurWut6SCg 147WPAtM745rj4bP3UcjSXNVAnsB1hvpfpGkjaFvDivxZknq5miR/+lUjxHGVmAlRSUvxtdvGzyY EIKX6uDci631xWFD8ta74eCO3vo2xBsP3oaYEqhlEHNFNgQDMQTENmNI8rEIQor44dpW4g1xBQHj rwZ+YLASq+UUJCpmshFfJQoOb4hSxkwEMoGZMbMQ90YVJAwJMEcmpswfbnivdRmKEoVZLFlMbPQu JKHeFfBOKUsuISz9Vc2jUwkK6uRVREgpcyaY/iBtguiEpLsgTNNd7I8o5JOMyCcB0+V2LWU2ZKSo DaRA9TnWyZRzisTvjAsQ35U3262Oy+XzzpvFuc24XbeLreC3vJ55LFyWQ85A489l3P+ZecZ9FD0D 0/067j3rupebxD0DGlfENJYz6y4bUI94bnl7oCYev0c1U3kOBAlR11/41e+AKsLnSwAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMS0wMi0yMVQxODoxMDo1NyswMDowMJ6R2KQAAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjEtMDItMjFUMTg6MTA6NTcrMDA6MDDvzGAYAAAAAElFTkSuQmCC X-Now-Playing: Ryuichi Sakamoto's _Hidari Ude No Yume (2)_: "Saru No Ie (instrumental mix)" Date: Sun, 21 Feb 2021 19:32:25 +0100 In-Reply-To: <87blcdgyja.fsf@gmail.com> (Robert Pluim's message of "Sun, 21 Feb 2021 17:45:29 +0100") Message-ID: <87mtvxgtl2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > Ah, the wonders of running diff when you haven't tested the result > from a clean emacs. This one actually works. Haven't tested the patch, but it makes sense to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Ah, the wonders of running diff when you haven't tested the result > from a clean emacs. This one actually works. Haven't tested the patch, but it makes sense to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Philipp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 19:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Glenn Morris , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161393646817353 (code B ref 46641); Sun, 21 Feb 2021 19:42:01 +0000 Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 19:41:08 +0000 Received: from localhost ([127.0.0.1]:54902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDubL-0004Vp-KA for submit@debbugs.gnu.org; Sun, 21 Feb 2021 14:41:07 -0500 Received: from mail-ed1-f41.google.com ([209.85.208.41]:46984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDubK-0004VP-Qn for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 14:41:07 -0500 Received: by mail-ed1-f41.google.com with SMTP id v22so19216663edx.13 for <46641@debbugs.gnu.org>; Sun, 21 Feb 2021 11:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Z19q5Ex2fol8yrbEpLg5Hfo161AMv3y3jRklAsXTWB0=; b=idYoSgL7Upyegr/PaYQcWf7Q9cOWlEpAjoBdMUr4wkGWzEE6wV00sNRQeHEixAG2F7 sO2RiYesc7ZB+RwecaP331h9XH8CUJJUOqs9/eoHAkbg2Ikq0jVLNIKAk1PFi99NIIFw VVoUfE2me16H1euYumi5yPMdD9G7Pc3SL6XrhvuH38l1atc6lREFxznk+nFB3M57veEK Q+JqxgKdbz4keQ83RjfcrhrP4tqRSfpoiU/J59qYq7KbMY0HJzO5NcJZ8U8fgOu47O0F rEwEiPk5ZDE8svkEGCGm0hVMKh3IUlsLJy9WATZQI50Jd2T/nrkZpwwv3UHIHfVzNjIk +GVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Z19q5Ex2fol8yrbEpLg5Hfo161AMv3y3jRklAsXTWB0=; b=aSLBGvO4+wnMAocX/VR9PLmjE1XYKgL5DsYcGYNBTZKlG9LGbJTqjheX+x32nCl+s4 T0Iy/8uTnmn+uvrY37uhx1nW/EFuuhQ9DAbc+kUVK+68Ha7GdyMblWWqhTog2GvOO6oy 59fHLYFMBS2TG42pJD+QLaCVvfJH7ILrp1efl+qogmtMjJWSLX/v3lGQH4Q7hfhUBvnd x+vDX8RLkO38lD0emqvNzU5Yadmw+fk4W3vylnnufDm7OeCc/N1T7wyx4qImfe6JvPqP 4TggcOJLoy1cg5S9veNC0FGxS5OVdOzmSKJjbsBp/m4mbSSHAqdz94IrtjkZ9LTQGUjL a8Vw== X-Gm-Message-State: AOAM532GPaIgRgVe5YO+BuqkfOPKC7XVJYR7fP4BabWQ3iDnSkPkCfkR 8PnpM2ljkFNOvrlvbkyYdzc= X-Google-Smtp-Source: ABdhPJw8fqmibWdfsLuOwEuOH1u5GnnbUYn3ZgXTuQ05Zv438U9bNtp15KHK8wwOWvkfcBSlC4X1Hg== X-Received: by 2002:a50:e0c3:: with SMTP id j3mr19932541edl.32.1613936460955; Sun, 21 Feb 2021 11:41:00 -0800 (PST) Received: from philipps-mbp.fritz.box ([46.128.208.19]) by smtp.gmail.com with ESMTPSA id z19sm10912340edr.69.2021.02.21.11.41.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Feb 2021 11:41:00 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) From: Philipp In-Reply-To: <87lfbhqtmq.fsf@gmail.com> Date: Sun, 21 Feb 2021 20:40:59 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> <87lfbhqtmq.fsf@gmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) > Am 21.02.2021 um 17:21 schrieb Robert Pluim : >=20 >>>>>> On Sun, 21 Feb 2021 15:37:27 +0100, Philipp = said: >=20 > Philipp> This is pretty common for CI systems. Accessing the = network is a > Philipp> security risk, and in addition tends to make tests = unreproducible. >=20 > I can give you the second one, but in what way is eg doing a DNS = lookup a > 'security risk'? We=CA=BCre not talking about setting up a listening = server > on a public IP here. A CI system will typically run arbitrary code that=E2=80=99s not under = the control of the CI system itself. Therefore, the CI system needs to = prevent any malicious behavior of the system under test. Since the code = being tested is opaque, the CI system can=E2=80=99t really decide = whether it=E2=80=99s malicious or not, so it has to conservatively = assume that any network access is malicious. While it might be possible = to prevent more specific behavior (like creating a listening socket), = that tends to be more complex, so the simpler and safer =E2=80=9Eno = network at all=E2=80=9C tends to be a reasonable choice.= From unknown Thu Sep 11 11:26:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46641: process-tests assume network connection Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Feb 2021 14:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: Glenn Morris , 46641@debbugs.gnu.org Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.16140053993492 (code B ref 46641); Mon, 22 Feb 2021 14:50:02 +0000 Received: (at 46641) by debbugs.gnu.org; 22 Feb 2021 14:49:59 +0000 Received: from localhost ([127.0.0.1]:56054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lECX8-0000uB-Vy for submit@debbugs.gnu.org; Mon, 22 Feb 2021 09:49:59 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:52017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lECX6-0000tq-O7; Mon, 22 Feb 2021 09:49:57 -0500 Received: by mail-wm1-f42.google.com with SMTP id o82so13815803wme.1; Mon, 22 Feb 2021 06:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=m46C5PVYJ9C5nLF0UntS7sy3TLdD3dqbq5WgjOjXMLI=; b=SmerQBNHVkgpa15hn9KbMLF/YgXXMJHqsC7CYUdH0O7PsDcX1IR6fNQIonm2xHllSB wU5LPB6ITTm5emor4hFXfOYibGkKpFZ09w2dLYd/vt4X5wz4UQ7pEG7xw61px3eYFrvx IXqofGpvWCHQBdqnyE6GN824cusn9vRtGe3pQNtKlgUDPgu9WAAeDcvVRwsAATY1ycfp 1g6ZmW1FoQjeP5HpNr3iVPIR4BtjpIPHloDV8ubT/QhpwxCgHxxg4eUL+EpZuH29MBwc 55U8ZlmaZpYY5GZbV9eejNLlJIGfmiPdoH/5IlRmQ1qpSXEGlpjWynu9wjFlXwLvED+w RAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=m46C5PVYJ9C5nLF0UntS7sy3TLdD3dqbq5WgjOjXMLI=; b=FdYHzLQloWkYEyzZXWhDoAUj3Zg3sdq5LFfxTqhmejeBOlKwSlZG7NYfReDunT8XEs wCuVkyMnW1maSXmtjlhjyqt5fUvj5LE5QDsoRv8QiR7PejMfU/KBsH5xfAD6xTlDl/Ty az+7qDsxEbldfIwfj25/dd+joQTvWgrHDKMnTMcbQSWXzMqyNIgcIggXObhY+dWtRB8j 2gySUHgedbQKleQiiJ2o4hAm1dthQIJU0Y11vCufcE8dWRoN9J9mx3vOP3+r3Fik24MS GG3m+8c4kwMSoZaZV1wy6tT0dHwu6HC2llHE86ivbIiik7JK0T+4cAQSZCBrMmIBVEiz ZLTw== X-Gm-Message-State: AOAM530kenkUQVkf2zx6Q6PHHsqverL1Z133u0TtJxaPBx52LxCrUzyA qiQynk+Q9XdyEOSr+FYKGSzFBJsdQli5Rw== X-Google-Smtp-Source: ABdhPJyli+pcaGtlUO6TJSy5iOSvImn7py1uqAvnRXN+EPzQh+dzPiKuuJFdeVcFkfEwxcJe7f73xg== X-Received: by 2002:a7b:c305:: with SMTP id k5mr20296328wmj.57.1614005390130; Mon, 22 Feb 2021 06:49:50 -0800 (PST) Received: from rltb (91-175-207-237.subs.proxad.net. [91.175.207.237]) by smtp.gmail.com with ESMTPSA id m4sm13415485wrb.87.2021.02.22.06.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 06:49:49 -0800 (PST) From: Robert Pluim References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> <87k0r1k07c.fsf@gnus.org> <87pn0tqtq7.fsf@gmail.com> <87blcdgyja.fsf@gmail.com> <87mtvxgtl2.fsf@gnus.org> Date: Mon, 22 Feb 2021 15:49:16 +0100 In-Reply-To: <87mtvxgtl2.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 21 Feb 2021 19:32:25 +0100") Message-ID: <87zgzwf98z.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 46641 fixed close 46641 28.1 quit >>>>> On Sun, 21 Feb 2021 19:32:25 +0100, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> Ah, the wonders of running diff when you haven't tested the result >> from a clean emacs. This one actually works. Lars> Haven't tested the patch, but it makes sense to me. Pushed as 934dcc2157 And the requisite changes to the test suite I pushed as a728135a2b Robert