From sl392@cam.ac.uk Wed Oct 7 04:15:36 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 7 Oct 2009 11:15:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.2 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n97BFY1G030784 for ; Wed, 7 Oct 2009 04:15:36 -0700 Received: from mx10.gnu.org ([199.232.76.166]:60893) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MvUUX-00074h-8d for emacs-pretest-bug@gnu.org; Wed, 07 Oct 2009 07:15:33 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MvUUW-0007nx-0Z for emacs-pretest-bug@gnu.org; Wed, 07 Oct 2009 07:15:32 -0400 Received: from ppsw-5.csi.cam.ac.uk ([131.111.8.135]:47106) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvUUV-0007nb-Ji for emacs-pretest-bug@gnu.org; Wed, 07 Oct 2009 07:15:31 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from lapwing-gw-1.csx.cam.ac.uk ([131.111.1.66]:56202 helo=victoria.local) by ppsw-5.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.155]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MvUUT-0004O4-JK (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Wed, 07 Oct 2009 12:15:30 +0100 From: Leo To: emacs-pretest-bug@gnu.org Subject: 23.1.50; local variables completions Date: Wed, 07 Oct 2009 12:15:27 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Please describe exactly what actions triggered the bug and the precise symptoms of the bug: For example, completions in add-file-local-variable do not include local variables such as auto-fill-function. Could this be improved? Leo From monnier@iro.umontreal.ca Wed Oct 7 07:34:08 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 7 Oct 2009 14:34:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n97EY7qV028509 for ; Wed, 7 Oct 2009 07:34:08 -0700 Received: from mail.gnu.org ([199.232.76.166]:40186 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MvXag-0003Dw-Ux for emacs-pretest-bug@gnu.org; Wed, 07 Oct 2009 10:34:07 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MvXaf-0007Ny-Na for emacs-pretest-bug@gnu.org; Wed, 07 Oct 2009 10:34:06 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:40285 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvXaf-0007Nq-CX for emacs-pretest-bug@gnu.org; Wed, 07 Oct 2009 10:34:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlMFAC9EzEpMCqug/2dsb2JhbACBUtUthCoEhzQ X-IronPort-AV: E=Sophos;i="4.44,519,1249272000"; d="scan'208";a="47235256" Received: from 76-10-171-160.dsl.teksavvy.com (HELO pastel.home) ([76.10.171.160]) by ironport2-out.pppoe.ca with ESMTP; 07 Oct 2009 10:34:04 -0400 Received: by pastel.home (Postfix, from userid 20848) id EFB6E81F0; Wed, 7 Oct 2009 10:34:03 -0400 (EDT) From: Stefan Monnier To: Leo Cc: 4664@debbugs.gnu.org, emacs-pretest-bug@gnu.org Subject: Re: bug#4664: 23.1.50; local variables completions Message-ID: References: Date: Wed, 07 Oct 2009 10:34:03 -0400 In-Reply-To: (Leo's message of "Wed, 07 Oct 2009 12:15:27 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. > For example, completions in add-file-local-variable do not include local > variables such as auto-fill-function. Could this be improved? Thanks, I installed the patch below which should help, Stefan === modified file 'lisp/files-x.el' --- lisp/files-x.el 2009-10-04 07:44:39 +0000 +++ lisp/files-x.el 2009-10-07 14:30:53 +0000 @@ -49,6 +49,7 @@ obarray (lambda (sym) (or (user-variable-p sym) + (get sym 'safe-local-variable) (memq sym '(mode eval coding unibyte)))) nil nil nil default nil)) (and (stringp variable) (intern variable)))) From sl392@hermes.cam.ac.uk Wed Oct 7 14:06:39 2009 Received: (at 4664-done) by emacsbugs.donarmstrong.com; 7 Oct 2009 21:06:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-7.csi.cam.ac.uk (ppsw-7.csi.cam.ac.uk [131.111.8.137]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n97L6bd4028345 for <4664-done@emacsbugs.donarmstrong.com>; Wed, 7 Oct 2009 14:06:39 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:45787) by ppsw-7.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MvdiW-0003nu-Nm (Exim 4.70) (return-path ); Wed, 07 Oct 2009 22:06:36 +0100 From: Leo To: Stefan Monnier Cc: 4664-done@debbugs.gnu.org Subject: Re: bug#4664: 23.1.50; local variables completions References: Date: Wed, 07 Oct 2009 22:06:34 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 07 Oct 2009 10:34:03 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-10-07 15:34 +0100, Stefan Monnier wrote: >> For example, completions in add-file-local-variable do not include local >> variables such as auto-fill-function. Could this be improved? > > Thanks, I installed the patch below which should help, [-patch-] Thank you. Leo From juri@jurta.org Wed Oct 7 15:03:27 2009 Received: (at 4664-done) by emacsbugs.donarmstrong.com; 7 Oct 2009 22:03:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n97M3PlL007648 for <4664-done@emacsbugs.donarmstrong.com>; Wed, 7 Oct 2009 15:03:27 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.99.10.cable.starman.ee [82.131.99.10]) by mx2.starman.ee (Postfix) with ESMTP id 6C7623F4148; Thu, 8 Oct 2009 01:03:19 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Cc: 4664-done@debbugs.gnu.org, Leo Subject: Re: bug#4664: 23.1.50; local variables completions Organization: JURTA References: Date: Thu, 08 Oct 2009 00:45:59 +0300 In-Reply-To: (Stefan Monnier's message of "Wed, 07 Oct 2009 10:34:03 -0400") Message-ID: <87pr8yanj1.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > obarray > (lambda (sym) > (or (user-variable-p sym) > + (get sym 'safe-local-variable) > (memq sym '(mode eval coding unibyte)))) > nil nil nil default nil)) > (and (stringp variable) (intern variable)))) Thanks, this also added usually unbound symbols like `generated-autoload-file'. -- Juri Linkov http://www.jurta.org/emacs/ From monnier@iro.umontreal.ca Wed Oct 7 18:10:30 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 8 Oct 2009 01:10:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n981ASPx015914 for <4664@emacsbugs.donarmstrong.com>; Wed, 7 Oct 2009 18:10:30 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq0EAALZzEpMCqug/2dsb2JhbACBUtZMhCoEhzg X-IronPort-AV: E=Sophos;i="4.44,522,1249272000"; d="scan'208";a="47273541" Received: from 76-10-171-160.dsl.teksavvy.com (HELO ceviche.home) ([76.10.171.160]) by ironport2-out.pppoe.ca with ESMTP; 07 Oct 2009 21:10:23 -0400 Received: by ceviche.home (Postfix, from userid 20848) id DF5E5B41E9; Wed, 7 Oct 2009 21:10:22 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: 4664@debbugs.gnu.org, Leo Subject: Re: bug#4664: 23.1.50; local variables completions Message-ID: References: <87pr8yanj1.fsf@mail.jurta.org> Date: Wed, 07 Oct 2009 21:10:22 -0400 In-Reply-To: <87pr8yanj1.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 08 Oct 2009 00:45:59 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Thanks, this also added usually unbound symbols > like `generated-autoload-file'. Is that a problem? Stefan From sl392@hermes.cam.ac.uk Wed Oct 7 23:54:55 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 8 Oct 2009 06:54:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-0.csi.cam.ac.uk (ppsw-0.csi.cam.ac.uk [131.111.8.130]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n986srcJ012081 for <4664@emacsbugs.donarmstrong.com>; Wed, 7 Oct 2009 23:54:55 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:50126) by ppsw-0.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.150]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Mvmto-0004VY-0v (Exim 4.70) (return-path ); Thu, 08 Oct 2009 07:54:52 +0100 From: Leo To: Stefan Monnier Cc: 4664@debbugs.gnu.org, Juri Linkov Subject: Re: bug#4664: 23.1.50; local variables completions References: <87pr8yanj1.fsf@mail.jurta.org> Date: Thu, 08 Oct 2009 07:54:51 +0100 In-Reply-To: (Stefan Monnier's message of "Wed, 07 Oct 2009 21:10:22 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-10-08 02:10 +0100, Stefan Monnier wrote: >> Thanks, this also added usually unbound symbols >> like `generated-autoload-file'. > > Is that a problem? > > > Stefan When trying to add generated-autoload-file it produces an error. So I wonder if the following is more suitable? (or (user-variable-sym) (and (boundp sym) (get sym 'safe-local-variable)) (memq sym '(mode eval coding unibyte))) -- Leo's Emacs uptime: 3 minutes, 20 seconds From juri@jurta.org Thu Oct 8 04:27:54 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 8 Oct 2009 11:27:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n98BRqMK029779 for <4664@emacsbugs.donarmstrong.com>; Thu, 8 Oct 2009 04:27:54 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.99.140.cable.starman.ee [82.131.99.140]) by mx2.starman.ee (Postfix) with ESMTP id E433C3F4189; Thu, 8 Oct 2009 14:27:46 +0300 (EEST) From: Juri Linkov To: Leo Cc: Stefan Monnier , 4664@debbugs.gnu.org Subject: Re: bug#4664: 23.1.50; local variables completions Organization: JURTA References: <87pr8yanj1.fsf@mail.jurta.org> Date: Thu, 08 Oct 2009 12:22:43 +0300 In-Reply-To: (Leo's message of "Thu, 08 Oct 2009 07:54:51 +0100") Message-ID: <87fx9u2kqk.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >>> Thanks, this also added usually unbound symbols >>> like `generated-autoload-file'. >> >> Is that a problem? No, no. Some time ago I noticed that there are some unbound symbols valid for inclusion to the Local Variables section but unavailable for completion. So far I had no idea about the correct way to add them. Your change fixed that. > When trying to add generated-autoload-file it produces an error. So I > wonder if the following is more suitable? > > (or (user-variable-sym) > (and (boundp sym) (get sym 'safe-local-variable)) > (memq sym '(mode eval coding unibyte))) This is a wrong fix. It again removes valid local variables like `generated-autoload-file' from completion. The right fix would be just to avoid trying to provide their current value as the default value: Index: lisp/files-x.el =================================================================== RCS file: /sources/emacs/emacs/lisp/files-x.el,v retrieving revision 1.4 diff -c -r1.4 files-x.el *** lisp/files-x.el 7 Oct 2009 14:33:37 -0000 1.4 --- lisp/files-x.el 8 Oct 2009 09:21:22 -0000 *************** *** 92,98 **** nil 'set-variable-value-history (format "%S" (cond ((eq variable 'unibyte) t) ! (t (symbol-value variable)))))))))) (defun read-file-local-variable-mode () "Read per-directory file-local variable's mode using completion. --- 92,99 ---- nil 'set-variable-value-history (format "%S" (cond ((eq variable 'unibyte) t) ! ((boundp variable) ! (symbol-value variable)))))))))) (defun read-file-local-variable-mode () "Read per-directory file-local variable's mode using completion. -- Juri Linkov http://www.jurta.org/emacs/ From sl392@hermes.cam.ac.uk Thu Oct 8 04:58:32 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 8 Oct 2009 11:58:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-7.csi.cam.ac.uk (ppsw-7.csi.cam.ac.uk [131.111.8.137]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n98BwUlN002326 for <4664@emacsbugs.donarmstrong.com>; Thu, 8 Oct 2009 04:58:31 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:46780) by ppsw-7.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Mvrdd-00042e-Nr (Exim 4.70) (return-path ); Thu, 08 Oct 2009 12:58:29 +0100 From: Leo To: Juri Linkov Cc: 4664@debbugs.gnu.org Subject: Re: bug#4664: 23.1.50; local variables completions References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> Date: Thu, 08 Oct 2009 12:58:28 +0100 In-Reply-To: <87fx9u2kqk.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 08 Oct 2009 12:22:43 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-10-08 10:22 +0100, Juri Linkov wrote: > This is a wrong fix. It again removes valid local variables like > `generated-autoload-file' from completion. The right fix would be > just to avoid trying to provide their current value as the default > value: [-patch-] Thank you for the patch. Leo From monnier@IRO.UMontreal.CA Fri Oct 9 12:26:59 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 9 Oct 2009 19:27:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n99JQvF9030823 for <4664@emacsbugs.donarmstrong.com>; Fri, 9 Oct 2009 12:26:59 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n99JQuYR026840; Fri, 9 Oct 2009 15:26:56 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 96C033A1AC; Fri, 9 Oct 2009 15:26:56 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Cc: Leo , 4664@debbugs.gnu.org Subject: Re: bug#4664: 23.1.50; local variables completions Message-ID: References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> Date: Fri, 09 Oct 2009 15:26:56 -0400 In-Reply-To: <87fx9u2kqk.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 08 Oct 2009 12:22:43 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3381=0 > This is a wrong fix. It again removes valid local variables like > `generated-autoload-file' from completion. The right fix would be > just to avoid trying to provide their current value as the default > value: Agreed. Actually even if a symbol is not known to be safe and not completable, it should be possible for the user to use it, since it may simply not be loaded yet. Stefan From juri@jurta.org Sun Oct 11 16:59:03 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 11 Oct 2009 23:59:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.4 required=4.0 tests=AWL,HAS_BUG_NUMBER,URIBL_CNKR autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9BNx2rf013471 for <4664@emacsbugs.donarmstrong.com>; Sun, 11 Oct 2009 16:59:03 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.52.99.cable.starman.ee [82.131.52.99]) by mx1.starman.ee (Postfix) with ESMTP id 213E43F40FC; Mon, 12 Oct 2009 02:58:56 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Cc: Leo , 4664@debbugs.gnu.org Subject: Re: bug#4664: 23.1.50; local variables completions Organization: JURTA References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> Date: Mon, 12 Oct 2009 02:54:55 +0300 In-Reply-To: (Stefan Monnier's message of "Fri, 09 Oct 2009 15:26:56 -0400") Message-ID: <87my3xo59s.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> This is a wrong fix. It again removes valid local variables like >> `generated-autoload-file' from completion. The right fix would be >> just to avoid trying to provide their current value as the default >> value: > > Agreed. Actually even if a symbol is not known to be safe and not > completable, it should be possible for the user to use it, since it may > simply not be loaded yet. Yes, this is already the case: the user is free to enter any variable. It is only completion with require-match=nil that provides a list of known variable names. -- Juri Linkov http://www.jurta.org/emacs/ From sl392@hermes.cam.ac.uk Mon Oct 12 08:49:41 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 12 Oct 2009 15:49:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-7.csi.cam.ac.uk (ppsw-7.csi.cam.ac.uk [131.111.8.137]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9CFndDN030285 for <4664@emacsbugs.donarmstrong.com>; Mon, 12 Oct 2009 08:49:41 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:43919) by ppsw-7.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MxN9W-0001Ps-Nt (Exim 4.70) (return-path ); Mon, 12 Oct 2009 16:49:38 +0100 From: Leo To: Juri Linkov Cc: 4664@debbugs.gnu.org, Stefan Monnier Subject: Re: bug#4664: 23.1.50; local variables completions References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> <87my3xo59s.fsf@mail.jurta.org> Date: Mon, 12 Oct 2009 16:49:37 +0100 In-Reply-To: <87my3xo59s.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 12 Oct 2009 02:54:55 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-10-12 00:54 +0100, Juri Linkov wrote: >>> This is a wrong fix. It again removes valid local variables like >>> `generated-autoload-file' from completion. The right fix would be >>> just to avoid trying to provide their current value as the default >>> value: >> >> Agreed. Actually even if a symbol is not known to be safe and not >> completable, it should be possible for the user to use it, since it may >> simply not be loaded yet. > > Yes, this is already the case: the user is free to enter any variable. > It is only completion with require-match=nil that provides a list > of known variable names. The completion of 'mode' does not include modes like outline-minor-mode. Is this an oversight? Leo From juri@jurta.org Mon Oct 12 13:36:58 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 12 Oct 2009 20:36:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9CKauXC009955 for <4664@emacsbugs.donarmstrong.com>; Mon, 12 Oct 2009 13:36:58 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.68.196.cable.starman.ee [82.131.68.196]) by mx2.starman.ee (Postfix) with ESMTP id 061F63F40CA; Mon, 12 Oct 2009 23:36:50 +0300 (EEST) From: Juri Linkov To: Leo Cc: 4664@debbugs.gnu.org, Stefan Monnier Subject: Re: bug#4664: 23.1.50; local variables completions Organization: JURTA References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> <87my3xo59s.fsf@mail.jurta.org> Date: Mon, 12 Oct 2009 23:31:38 +0300 In-Reply-To: (Leo's message of "Mon, 12 Oct 2009 16:49:37 +0100") Message-ID: <87fx9ovaj9.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >>>> This is a wrong fix. It again removes valid local variables like >>>> `generated-autoload-file' from completion. The right fix would be >>>> just to avoid trying to provide their current value as the default >>>> value: >>> >>> Agreed. Actually even if a symbol is not known to be safe and not >>> completable, it should be possible for the user to use it, since it may >>> simply not be loaded yet. >> >> Yes, this is already the case: the user is free to enter any variable. >> It is only completion with require-match=nil that provides a list >> of known variable names. > > The completion of 'mode' does not include modes like outline-minor-mode. > Is this an oversight? I've excluded minor modes from completion intentionally because the manual says in (info "(emacs) Specifying File Variables"): You can use the `mode' "variable" to set minor modes as well as the major modes; in fact, you can use it more than once, first to set the major mode and then to set minor modes which are specific to particular buffers. But most minor modes should not be specified in the file at all, because they represent user preferences. I'm not sure about a list of minor modes that represent user preferences. Where can I see a complete list of their names? Since this is too vague, perhaps we should include minor modes to the completion of 'mode'. -- Juri Linkov http://www.jurta.org/emacs/ From sl392@hermes.cam.ac.uk Tue Oct 13 04:17:30 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 13 Oct 2009 11:17:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-1.csi.cam.ac.uk (ppsw-1.csi.cam.ac.uk [131.111.8.131]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9DBHS0Y005062 for <4664@emacsbugs.donarmstrong.com>; Tue, 13 Oct 2009 04:17:30 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:48422) by ppsw-1.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.151]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MxfNg-0001Lw-3O (Exim 4.70) (return-path ); Tue, 13 Oct 2009 12:17:28 +0100 From: Leo To: Juri Linkov Cc: 4664@debbugs.gnu.org, Stefan Monnier Subject: Re: bug#4664: 23.1.50; local variables completions References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> <87my3xo59s.fsf@mail.jurta.org> <87fx9ovaj9.fsf@mail.jurta.org> Date: Tue, 13 Oct 2009 12:17:27 +0100 In-Reply-To: <87fx9ovaj9.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 12 Oct 2009 23:31:38 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-10-12 21:31 +0100, Juri Linkov wrote: [...] >> The completion of 'mode' does not include modes like outline-minor-mode. >> Is this an oversight? > > I've excluded minor modes from completion intentionally because the manual > says in (info "(emacs) Specifying File Variables"): > > You can use the `mode' "variable" to set minor modes as well as the > major modes; in fact, you can use it more than once, first to set the > major mode and then to set minor modes which are specific to particular > buffers. But most minor modes should not be specified in the file at > all, because they represent user preferences. I wonder if this is a bit silly. Whether it is user preferences should be left for the users who are editing that file to decide. For example, if Will Smith and I are editing the same file and I want to enable outline-minor-mode in the local variables, I will consult him before enabling it. > I'm not sure about a list of minor modes that represent user preferences. > Where can I see a complete list of their names? Since this is too vague, > perhaps we should include minor modes to the completion of 'mode'. -- Leo's Emacs uptime: 17 minutes, 0 seconds From monnier@IRO.UMontreal.CA Tue Oct 13 12:52:50 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 13 Oct 2009 19:52:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9DJqhMq000509 for <4664@emacsbugs.donarmstrong.com>; Tue, 13 Oct 2009 12:52:45 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n9DJqbIg012262; Tue, 13 Oct 2009 15:52:37 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id E4FAD3A07F; Tue, 13 Oct 2009 15:52:36 -0400 (EDT) From: Stefan Monnier To: Leo Cc: Juri Linkov , 4664@debbugs.gnu.org Subject: Re: bug#4664: 23.1.50; local variables completions Message-ID: References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> <87my3xo59s.fsf@mail.jurta.org> <87fx9ovaj9.fsf@mail.jurta.org> Date: Tue, 13 Oct 2009 15:52:36 -0400 In-Reply-To: (Leo's message of "Tue, 13 Oct 2009 12:17:27 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3383=0 >> I've excluded minor modes from completion intentionally because the manual >> says in (info "(emacs) Specifying File Variables"): I'm not sure it's a good idea to remove them from completions. >> You can use the `mode' "variable" to set minor modes as well as the >> major modes; in fact, you can use it more than once, first to set the >> major mode and then to set minor modes which are specific to particular >> buffers. But most minor modes should not be specified in the file at >> all, because they represent user preferences. > I wonder if this is a bit silly. Which part is silly? The above text simply describes things as they stand, without forcing any particular choice. > Whether it is user preferences should be left for the users who are > editing that file to decide. Which it is. We simply added the note about minor modes (which is actually not specific to minor modes, it also holds for many plain variables), because it has been found to be a common misuse. > For example, if Will Smith and I are editing the same file and I want > to enable outline-minor-mode in the local variables, I will consult > him before enabling it. That's fine. A very common situation is a file that you're the sole author, so you put any random personal setting in there without having to worry about asking Will. And then you publish it on the web (e.g. it could be an Elisp package), so anybody who opens it in Emacs gets your preferences imposed on himself while viewing your file. > Leo's Emacs uptime: 17 minutes, 0 seconds 17 minutes and counting... how's that for impressive?! Stefan From juri@jurta.org Tue Oct 13 15:37:40 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 13 Oct 2009 22:37:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.4 required=4.0 tests=AWL,HAS_BUG_NUMBER,URIBL_CNKR autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out2.starman.ee [85.253.0.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9DMbc1L029682 for <4664@emacsbugs.donarmstrong.com>; Tue, 13 Oct 2009 15:37:40 -0700 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.28.50.cable.starman.ee [82.131.28.50]) by mx2.starman.ee (Postfix) with ESMTP id E4AFC3F40D1; Wed, 14 Oct 2009 01:37:30 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Cc: Leo , 4664@debbugs.gnu.org Subject: Re: bug#4664: 23.1.50; local variables completions Organization: JURTA References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> <87my3xo59s.fsf@mail.jurta.org> <87fx9ovaj9.fsf@mail.jurta.org> Date: Wed, 14 Oct 2009 01:35:56 +0300 In-Reply-To: (Stefan Monnier's message of "Tue, 13 Oct 2009 15:52:36 -0400") Message-ID: <87k4yyyl9v.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >>> I've excluded minor modes from completion intentionally because the >>> manual says in (info "(emacs) Specifying File Variables"): > > I'm not sure it's a good idea to remove them from completions. Actually not a good idea. I've lifted this restriction. -- Juri Linkov http://www.jurta.org/emacs/ From sl392@hermes.cam.ac.uk Tue Oct 13 18:16:56 2009 Received: (at 4664) by emacsbugs.donarmstrong.com; 14 Oct 2009 01:16:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ppsw-0.csi.cam.ac.uk (ppsw-0.csi.cam.ac.uk [131.111.8.130]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9E1Gs2f021661 for <4664@emacsbugs.donarmstrong.com>; Tue, 13 Oct 2009 18:16:55 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:53605) by ppsw-0.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.150]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MxsU1-0005fu-0c (Exim 4.70) (return-path ); Wed, 14 Oct 2009 02:16:53 +0100 From: Leo To: Juri Linkov Cc: 4664@debbugs.gnu.org, Stefan Monnier Subject: Re: bug#4664: 23.1.50; local variables completions References: <87pr8yanj1.fsf@mail.jurta.org> <87fx9u2kqk.fsf@mail.jurta.org> <87my3xo59s.fsf@mail.jurta.org> <87fx9ovaj9.fsf@mail.jurta.org> <87k4yyyl9v.fsf@mail.jurta.org> Date: Wed, 14 Oct 2009 02:16:52 +0100 In-Reply-To: <87k4yyyl9v.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 14 Oct 2009 01:35:56 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" On 2009-10-13 23:35 +0100, Juri Linkov wrote: >>>> I've excluded minor modes from completion intentionally because the >>>> manual says in (info "(emacs) Specifying File Variables"): >> >> I'm not sure it's a good idea to remove them from completions. > > Actually not a good idea. I've lifted this restriction. Thank you. Leo From unknown Mon Aug 18 11:26:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 Nov 2009 15:24:15 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator