GNU bug report logs - #4664
23.1.50; local variables completions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4664 in the body.
You can then email your comments to 4664 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; local variables completions
Date: Wed, 07 Oct 2009 12:15:27 +0100

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

For example, completions in add-file-local-variable do not include local
variables such as auto-fill-function. Could this be improved?

Leo

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: 4664 <at> debbugs.gnu.org, emacs-pretest-bug <at> gnu.org
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Wed, 07 Oct 2009 10:34:03 -0400

> For example, completions in add-file-local-variable do not include local
> variables such as auto-fill-function. Could this be improved?

Thanks, I installed the patch below which should help,


        Stefan


=== modified file 'lisp/files-x.el'
--- lisp/files-x.el	2009-10-04 07:44:39 +0000
+++ lisp/files-x.el	2009-10-07 14:30:53 +0000
@@ -49,6 +49,7 @@
 	   obarray
 	   (lambda (sym)
 	     (or (user-variable-p sym)
+                 (get sym 'safe-local-variable)
 		 (memq sym '(mode eval coding unibyte))))
 	   nil nil nil default nil))
     (and (stringp variable) (intern variable))))

Message #20 received at 4664-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 4664-done <at> debbugs.gnu.org
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Wed, 07 Oct 2009 22:06:34 +0100

On 2009-10-07 15:34 +0100, Stefan Monnier wrote:
>> For example, completions in add-file-local-variable do not include local
>> variables such as auto-fill-function. Could this be improved?
>
> Thanks, I installed the patch below which should help,
[-patch-]

Thank you.

Leo

Message #21 received at 4664-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 4664-done <at> debbugs.gnu.org, Leo <sdl.web <at> gmail.com>
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Thu, 08 Oct 2009 00:45:59 +0300

>  	   obarray
>  	   (lambda (sym)
>  	     (or (user-variable-p sym)
> +                 (get sym 'safe-local-variable)
>  		 (memq sym '(mode eval coding unibyte))))
>  	   nil nil nil default nil))
>      (and (stringp variable) (intern variable))))

Thanks, this also added usually unbound symbols
like `generated-autoload-file'.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #26 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> jurta.org>
Cc: 4664 <at> debbugs.gnu.org, Leo <sdl.web <at> gmail.com>
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Wed, 07 Oct 2009 21:10:22 -0400

> Thanks, this also added usually unbound symbols
> like `generated-autoload-file'.

Is that a problem?


        Stefan

Message #31 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 4664 <at> debbugs.gnu.org, Juri Linkov <juri <at> jurta.org>
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Thu, 08 Oct 2009 07:54:51 +0100

On 2009-10-08 02:10 +0100, Stefan Monnier wrote:
>> Thanks, this also added usually unbound symbols
>> like `generated-autoload-file'.
>
> Is that a problem?
>
>
>         Stefan

When trying to add generated-autoload-file it produces an error. So I
wonder if the following is more suitable?

(or (user-variable-sym)
    (and (boundp sym) (get sym 'safe-local-variable))
    (memq sym '(mode eval coding unibyte)))

-- 
Leo's Emacs uptime: 3 minutes, 20 seconds

Message #36 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Leo <sdl.web <at> gmail.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 4664 <at> debbugs.gnu.org
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Thu, 08 Oct 2009 12:22:43 +0300

>>> Thanks, this also added usually unbound symbols
>>> like `generated-autoload-file'.
>>
>> Is that a problem?

No, no.  Some time ago I noticed that there are some unbound symbols
valid for inclusion to the Local Variables section but unavailable
for completion.  So far I had no idea about the correct way
to add them.  Your change fixed that.

> When trying to add generated-autoload-file it produces an error. So I
> wonder if the following is more suitable?
>
> (or (user-variable-sym)
>     (and (boundp sym) (get sym 'safe-local-variable))
>     (memq sym '(mode eval coding unibyte)))

This is a wrong fix.  It again removes valid local variables like
`generated-autoload-file' from completion.  The right fix would be
just to avoid trying to provide their current value as the default
value:

Index: lisp/files-x.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/files-x.el,v
retrieving revision 1.4
diff -c -r1.4 files-x.el
*** lisp/files-x.el	7 Oct 2009 14:33:37 -0000	1.4
--- lisp/files-x.el	8 Oct 2009 09:21:22 -0000
***************
*** 92,98 ****
  			 nil 'set-variable-value-history
  			 (format "%S"
  				 (cond ((eq variable 'unibyte) t)
! 				       (t (symbol-value variable))))))))))
  
  (defun read-file-local-variable-mode ()
    "Read per-directory file-local variable's mode using completion.
--- 92,99 ----
  			 nil 'set-variable-value-history
  			 (format "%S"
  				 (cond ((eq variable 'unibyte) t)
! 				       ((boundp variable)
! 					(symbol-value variable))))))))))
  
  (defun read-file-local-variable-mode ()
    "Read per-directory file-local variable's mode using completion.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #41 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 4664 <at> debbugs.gnu.org
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Thu, 08 Oct 2009 12:58:28 +0100

On 2009-10-08 10:22 +0100, Juri Linkov wrote:
> This is a wrong fix.  It again removes valid local variables like
> `generated-autoload-file' from completion.  The right fix would be
> just to avoid trying to provide their current value as the default
> value:
[-patch-]

Thank you for the patch.

Leo

Message #46 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juri Linkov <juri <at> jurta.org>
Cc: Leo <sdl.web <at> gmail.com>, 4664 <at> debbugs.gnu.org
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Fri, 09 Oct 2009 15:26:56 -0400

> This is a wrong fix.  It again removes valid local variables like
> `generated-autoload-file' from completion.  The right fix would be
> just to avoid trying to provide their current value as the default
> value:

Agreed.  Actually even if a symbol is not known to be safe and not
completable, it should be possible for the user to use it, since it may
simply not be loaded yet.


        Stefan

Message #51 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Leo <sdl.web <at> gmail.com>, 4664 <at> debbugs.gnu.org
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Mon, 12 Oct 2009 02:54:55 +0300

>> This is a wrong fix.  It again removes valid local variables like
>> `generated-autoload-file' from completion.  The right fix would be
>> just to avoid trying to provide their current value as the default
>> value:
>
> Agreed.  Actually even if a symbol is not known to be safe and not
> completable, it should be possible for the user to use it, since it may
> simply not be loaded yet.

Yes, this is already the case: the user is free to enter any variable.
It is only completion with require-match=nil that provides a list
of known variable names.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #56 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 4664 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Mon, 12 Oct 2009 16:49:37 +0100

On 2009-10-12 00:54 +0100, Juri Linkov wrote:
>>> This is a wrong fix.  It again removes valid local variables like
>>> `generated-autoload-file' from completion.  The right fix would be
>>> just to avoid trying to provide their current value as the default
>>> value:
>>
>> Agreed.  Actually even if a symbol is not known to be safe and not
>> completable, it should be possible for the user to use it, since it may
>> simply not be loaded yet.
>
> Yes, this is already the case: the user is free to enter any variable.
> It is only completion with require-match=nil that provides a list
> of known variable names.

The completion of 'mode' does not include modes like outline-minor-mode.
Is this an oversight?

Leo

Message #61 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 4664 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Mon, 12 Oct 2009 23:31:38 +0300

>>>> This is a wrong fix.  It again removes valid local variables like
>>>> `generated-autoload-file' from completion.  The right fix would be
>>>> just to avoid trying to provide their current value as the default
>>>> value:
>>>
>>> Agreed.  Actually even if a symbol is not known to be safe and not
>>> completable, it should be possible for the user to use it, since it may
>>> simply not be loaded yet.
>>
>> Yes, this is already the case: the user is free to enter any variable.
>> It is only completion with require-match=nil that provides a list
>> of known variable names.
>
> The completion of 'mode' does not include modes like outline-minor-mode.
> Is this an oversight?

I've excluded minor modes from completion intentionally because the manual
says in (info "(emacs) Specifying File Variables"):

     You can use the `mode' "variable" to set minor modes as well as the
  major modes; in fact, you can use it more than once, first to set the
  major mode and then to set minor modes which are specific to particular
  buffers.  But most minor modes should not be specified in the file at
  all, because they represent user preferences.

I'm not sure about a list of minor modes that represent user preferences.
Where can I see a complete list of their names?  Since this is too vague,
perhaps we should include minor modes to the completion of 'mode'.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #66 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 4664 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Tue, 13 Oct 2009 12:17:27 +0100

On 2009-10-12 21:31 +0100, Juri Linkov wrote:
[...]
>> The completion of 'mode' does not include modes like outline-minor-mode.
>> Is this an oversight?
>
> I've excluded minor modes from completion intentionally because the manual
> says in (info "(emacs) Specifying File Variables"):
>
>      You can use the `mode' "variable" to set minor modes as well as the
>   major modes; in fact, you can use it more than once, first to set the
>   major mode and then to set minor modes which are specific to particular
>   buffers.  But most minor modes should not be specified in the file at
>   all, because they represent user preferences.

I wonder if this is a bit silly. Whether it is user preferences should
be left for the users who are editing that file to decide. For example,
if Will Smith and I are editing the same file and I want to enable
outline-minor-mode in the local variables, I will consult him before
enabling it.

> I'm not sure about a list of minor modes that represent user preferences.
> Where can I see a complete list of their names?  Since this is too vague,
> perhaps we should include minor modes to the completion of 'mode'.

-- 
Leo's Emacs uptime: 17 minutes, 0 seconds

Message #71 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Leo <sdl.web <at> gmail.com>
Cc: Juri Linkov <juri <at> jurta.org>, 4664 <at> debbugs.gnu.org
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Tue, 13 Oct 2009 15:52:36 -0400

>> I've excluded minor modes from completion intentionally because the manual
>> says in (info "(emacs) Specifying File Variables"):

I'm not sure it's a good idea to remove them from completions.

>> You can use the `mode' "variable" to set minor modes as well as the
>> major modes; in fact, you can use it more than once, first to set the
>> major mode and then to set minor modes which are specific to particular
>> buffers.  But most minor modes should not be specified in the file at
>> all, because they represent user preferences.

> I wonder if this is a bit silly.

Which part is silly?  The above text simply describes things as they
stand, without forcing any particular choice.

> Whether it is user preferences should be left for the users who are
> editing that file to decide.

Which it is.  We simply added the note about minor modes (which is
actually not specific to minor modes, it also holds for many plain
variables), because it has been found to be a common misuse.

> For example, if Will Smith and I are editing the same file and I want
> to enable outline-minor-mode in the local variables, I will consult
> him before enabling it.

That's fine.  A very common situation is a file that you're the sole
author, so you put any random personal setting in there without having
to worry about asking Will.  And then you publish it on the web (e.g. it
could be an Elisp package), so anybody who opens it in Emacs gets your
preferences imposed on himself while viewing your file.

> Leo's Emacs uptime: 17 minutes, 0 seconds

17 minutes and counting... how's that for impressive?!


        Stefan

Message #76 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Leo <sdl.web <at> gmail.com>, 4664 <at> debbugs.gnu.org
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Wed, 14 Oct 2009 01:35:56 +0300

>>> I've excluded minor modes from completion intentionally because the
>>> manual says in (info "(emacs) Specifying File Variables"):
>
> I'm not sure it's a good idea to remove them from completions.

Actually not a good idea.  I've lifted this restriction.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #81 received at 4664 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 4664 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#4664: 23.1.50; local variables completions
Date: Wed, 14 Oct 2009 02:16:52 +0100

On 2009-10-13 23:35 +0100, Juri Linkov wrote:
>>>> I've excluded minor modes from completion intentionally because the
>>>> manual says in (info "(emacs) Specifying File Variables"):
>>
>> I'm not sure it's a good idea to remove them from completions.
>
> Actually not a good idea.  I've lifted this restriction.

Thank you.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.