GNU bug report logs - #46587
[PATCH] gnu: Add libretro-lowresnx.

Previous Next

Package: guix-patches;

Reported by: iyzsong <at> outlook.com

Date: Wed, 17 Feb 2021 11:02:02 UTC

Severity: normal

Tags: patch

Done: 宋文武 <iyzsong <at> outlook.com>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 46587 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: iyzsong <at> outlook.com
Cc: 宋文武 <iyzsong <at> member.fsf.org>, 46587 <at> debbugs.gnu.org
Subject: Re: [bug#46587] [PATCH] gnu: Add libretro-lowresnx.
Date: Thu, 18 Feb 2021 13:52:36 -0500
On Wed, Feb 17, 2021 at 06:47:56PM +0800, iyzsong <at> outlook.com wrote:
> From: 宋文武 <iyzsong <at> member.fsf.org>
> 
> * gnu/packages/emulators.scm (libretro-lowresnx): New variable.

Thanks for the patch!

> +           (replace 'build
> +             (lambda _
> +               (invoke "make" "-C" "platform/LibRetro"
> +                       (string-append "CC=" ,(cc-for-target)))))

I think it's more idiomatic for Guix to use #:make-flags, maybe like
this (untested!):

(#:make-flags
  (list "-C" "platform/LibRetro"
        (string-append "CC=" ,(cc-for-target))))

... but either way is fine.




This bug report was last modified 4 years and 87 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.