GNU bug report logs - #4657
23.1.50; duplicate entries in file-name-history from read-file-name

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4657 in the body.
You can then email your comments to 4657 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Roland Winkler" <Roland.Winkler <at> physik.uni-erlangen.de>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; duplicate entries in file-name-history from read-file-name
Date: Wed, 07 Oct 2009 00:26:39 +0200

In a fresh emacs -q load and execute the command foo in order to
read the file name ~/foo/bar

(defun foo ()
  (interactive)
  (read-file-name "File: (default ~/foo/bar) " "~/foo/" "~/foo/bar")
  (message "%s" file-name-history))

If I explicitly enter ~/foo/bar in the minibuffer, multiple
executions of this command add this file to file-name-history only
once. If I am lazy and just use the default value, each execution
will add one more entry ~/foo/bar to file-name-history. I would
expect that multiple equal entries in succession should always be
avoided in file-name-history.



In GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2009-08-03 on foo

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: en_GB.utf8
  value of $LANG: en_US.ISO-8859-15
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-9-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Message #12 received at 4657-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Roland Winkler" <Roland.Winkler <at> physik.uni-erlangen.de>
Cc: 4657-done <at> debbugs.gnu.org
Subject: Re: 23.1.50; duplicate entries in file-name-history from read-file-name
Date: Sun, 18 Oct 2009 18:26:50 -0400

> (defun foo ()
>   (interactive)
>   (read-file-name "File: (default ~/foo/bar) " "~/foo/" "~/foo/bar")
>   (message "%s" file-name-history))

> If I explicitly enter ~/foo/bar in the minibuffer, multiple
> executions of this command add this file to file-name-history only
> once. If I am lazy and just use the default value, each execution
> will add one more entry ~/foo/bar to file-name-history. I would
> expect that multiple equal entries in succession should always be
> avoided in file-name-history.

I've checked in a fix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.