GNU bug report logs - #46564
[PATCH core-updates]: Use autoconf-wrapper instead of autoconf

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46564: closed ([PATCH core-updates]: Use autoconf-wrapper
 instead of autoconf)
Date: Wed, 17 Mar 2021 22:13:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 17 Mar 2021 23:12:32 +0100
with message-id <874kh9xwdr.fsf_-_ <at> gnu.org>
and subject line Re: bug#46564: [PATCH core-updates]: Use autoconf-wrapper instead of autoconf
has caused the debbugs.gnu.org bug report #46564,
regarding [PATCH core-updates]: Use autoconf-wrapper instead of autoconf
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46564: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46564
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates]: Use autoconf-wrapper instead of autoconf
Date: Tue, 16 Feb 2021 19:10:17 +0100

[Message part 3 (text/plain, inline)]

Hi Guix,

This patch replaces autoconf with autoconf-wrapped in the native-inputs
almost everywhere (except for some packages in
gnu/packages/autotools.scm).  As this would cause many rebuilds, this
patch targets the "core-updates" branch and not "master".

A wine package has autoconf in the inputs instead of native-inputs,
I wonder if that's intentional or a bug?  I left that package untouched
for now.

Why this change?

* consistency / reducing confusion: some packages use autoconf, some use
  autoconf-wrapper, and there's no (to me) obvious reason why two variants
  of autoconf should be used.

* <whatever pro's nckx had in mind on #guix>

* some progress towards booting without /bin/sh

  Scenario I have in mind (untested):

  1. boot a system that doesn't have /bin/sh
  2. decide to hack on guix (run git clone ...., cd $REPO)
  3. guix environment guix
  4. sh ./bootstrap (calls autoreconf -vfi)
  5. ./configure --localstatedir=/var
  6. more stuff

  Without this patch, step (5.) will fail without this patch because
  the generated ./configure script refers to /bin/sh, which doesn't
  exist.

  That said, there are some #!/bin/sh shebangs in the source code,
  so there are some problems in (6.).

Why not?

* ‘make dist’ will produce unusable tarballs
  when in an environment from ‘guix environment PACKAGE’.
  This should now be replaced with ‘guix environment PACKAGE --ad-hoc
  autoconf'.

[0001-Use-autoconf-wrapper-instead-of-autoconf.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 46564-done <at> debbugs.gnu.org
Subject: Re: bug#46564: [PATCH core-updates]: Use autoconf-wrapper instead
 of autoconf
Date: Wed, 17 Mar 2021 23:12:32 +0100

Ludovic Courtès <ludo <at> gnu.org> skribis:

>> From d42be9473bac6b8bcfe17a37c92f2481cb2198fb Mon Sep 17 00:00:00 2001
>> From: Maxime Devos <maximedevos <at> telenet.be>
>> Date: Mon, 22 Feb 2021 16:43:10 +0100
>> Subject: [PATCH] gnu: Use autoconf instead of autoconf-wrapper when possible.
>>
>> This should reduce confusion on when to use the "autoconf"
>> package and when to use "autoconf-wrapper" instead in
>> package definitions.
>>
>> Fixes: <https://issues.guix.gnu.org/46564>
>>
>> * gnu/packages/autotools.scm (autoconf-wrapper):
>>   advise to use the "autoconf" package instead where
>>   possible.
>> * gnu/packages/game-development.scm (tsukundere)[native-inputs]:
>>   use "autoconf" instead of "autoconf-wrapper".
>> * gnu/packages/gimp.scm
>>   (glimpse)[native-inputs]: likewise.
>>   (gimp-resynthesizer)[native-inputs]: add comment on why
>>   "autoconf-wrapper" is used.
>> * gnu/packages/gnunet.scm (gnunet)[native-inputs]:
>>   use "autoconf" instead of "autoconf-wrapper".
>> * gnu/packages/gnupg.scm (signing-party)[native-inputs]:
>>   add comment on why "autoconf-wrapper" is used.
>> * gnu/packages/guile-xyz.scm
>>   (guile-bash,guile-filesystem,guile-ics,guile-udev)[native-inputs]:
>>   use "autoconf" instead of "autoconf-wrapper".
>> * gnu/packages/libevent.scm (libuv)[native-inputs]: indicates
>>   "autoconf-wrapper" needs to be replaced with "autoconf"
>>   on core-updates.
>> * gnu/packages/logging.scm (glog)[native-inputs]: use "autoconf"
>>   instead of "autoconf-wrapper".
>> * gnu/packages/mail.scm (libetpan)[native-inputs]: likewise.
>> * gnu/packages/mate.scm
>>   (mate-icon-theme-faenza)[native-inputs]: add comment on why
>>   "autoconf-wrapper" is used.
>>   (mate-screensaver)[native-inputs]: use "autoconf" instead of
>>   "autoconf-wrapper".
>> * gnu/packages/package-management.scm (guix)[native-inputs]: likewise.
>> * gnu/packages/sawfish.scm (librep)[native-inputs]: likewise.
>> * gnu/packages/video.scm (motion)[native-inputs]: likewise.
>> * gnu/packages/zile.scm (zile)[native-inputs]: likewise.
>
> At first sight it should rebuild much so LGTM!

And I’ve now pushed it.

Thanks, and apologies for forgetting to push it right away!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.