GNU bug report logs - #46536
Fix build of materialdecoration.

Previous Next

Full log

View this message in rfc822 format

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>, 46536 <at> debbugs.gnu.org
Subject: [bug#46536] Fix build of materialdecoration.
Date: Mon, 15 Feb 2021 12:41:07 -0500

[Message part 1 (text/plain, inline)]

Hi Leo!

>> * gnu/packages/cmake.scm (cmake-shared) [git-version]: Update to
>> 1.1.0-32.
> The git-version field doesn't actually change.  You could annotate
> [commit] and [revision] separately, but it usually makes sense to just
> say "update to <commit hash>".
> 
> * gnu/packages/qt.scm (materialdecoration) [git-version]: Update to
>> 1.1.0-9.
> Same here.
> 
>> [arguments]<#:phases>['remove-3rdparty]: New phase.
> Should that be a snippet instead?
> 
>> <#:phases>['remove-3rdparty]: New phase.
> As above.
> 
>> [arguments]<#:configure-flags>[-DCMAKE_CXX_FLAGS]: New flag.
> That's a bit too much nesting.
> "[arguments]<#:configure-flags: Add -DCMAKE_CXX_FLAGS"
> is probably a better choice.
> 
> Otherwise LGTM.

Thanks for the review. I have attached revised patches.

Regards,
RG.

[0001-gnu-cmake-shared-Update-to-1.1.0-32.patch (text/x-patch, attachment)]

[0002-gnu-materialdecoration-Update-to-1.1.0-9.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.