GNU bug report logs - #46534
Lexical change in bindat breaks weechat.el

Previous Next

Package: emacs;

Reported by: Tony Olagbaiye <me <at> fron.io>

Date: Mon, 15 Feb 2021 15:07:01 UTC

Severity: normal

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kim Storm <storm <at> cua.dk>
Cc: 46534 <at> debbugs.gnu.org, Tony Olagbaiye <me <at> fron.io>
Subject: bug#46534: Lexical change in bindat breaks weechat.el
Date: Thu, 18 Feb 2021 11:09:53 -0500

>> [ Hi Kim, long time no see.
>>    I'd appreciate your opinion on this issue with bindat.el.  ]
> Indeed, it's been a while since I wrote that code :-)

As you can see, it's still alive and kicking.

> Your change seems to be the simplest way to solve the "not last field"
> issue with "eval".

Thanks for confirming.

> BTW, the following line seems wrong:
>
> ;;    (length       u16r)  ;; little endian order
>
> Since the C struct specifies "unsigned long", it should be u32r rather
> than u16r.

Good catch.

> Also the C code samples should use uint8_t uint16_t and uint32_t
>  for clarity.

Oh, yes, thanks,


        Stefan
This bug report was last modified 4 years and 90 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.