GNU bug report logs - #4653
23.1.50; ordering of bookmark-jump menu

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4653 in the body.
You can then email your comments to 4653 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Markus Rost <rost <at> math.uni-bielefeld.de>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; ordering of bookmark-jump menu
Date: Tue,  6 Oct 2009 16:29:40 +0200 (CEST)

If you call

C-x r l  (bookmark-bmenu-list)

the list of bookmarks is ordered by name.  Similarly with C-x r b RET.
That is fine.

However, if you call bookmark-jump through the menu, with

<menu-bar> <edit> <bookmark> <jump>

the shown list (in a pop up window) has the order from .emacs.bmk.
That wasn't the case with Emacs 22.

Message #10 received at 4653 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Markus Rost <rost <at> math.uni-bielefeld.de>
To: 4653 <at> debbugs.gnu.org
Subject: bug#4653: 23.1.50; ordering of bookmark-jump menu
Date: Tue,  6 Oct 2009 16:57:23 +0200 (CEST)

Sorry, that *was* the case with Emacs 22 as well.  In my private copy
of Emacs 22 I had applied the patch below (I have added 'bookmark-jump
to the tool-bar and I use the menu very often).

A change like in the patch seems to be more consistent with the
documentation of bookmark-sort-flag:

Non-nil means that bookmarks will be displayed sorted by bookmark name.


*** lisp/bookmark.el.~1~	2008-01-07 03:45:03.000000000 +0100
--- lisp/bookmark.el	2009-01-22 02:28:54.000000000 +0100
***************
*** 460,466 ****
  the empty string."
    (bookmark-maybe-load-default-file) ; paranoia
    (if (listp last-nonmenu-event)
!       (bookmark-menu-popup-paned-menu t prompt (bookmark-all-names))
      (let* ((completion-ignore-case bookmark-completion-ignore-case)
  	   (default default)
  	   (prompt (if default
--- 460,470 ----
  the empty string."
    (bookmark-maybe-load-default-file) ; paranoia
    (if (listp last-nonmenu-event)
!       (bookmark-menu-popup-paned-menu t prompt
! 				      (if bookmark-sort-flag
! 					  (sort (bookmark-all-names)
! 						'string-lessp)
! 					(bookmark-all-names)))
      (let* ((completion-ignore-case bookmark-completion-ignore-case)
  	   (default default)
  	   (prompt (if default

Message #17 received at 4653-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Markus Rost <rost <at> math.uni-bielefeld.de>
Cc: 4653-done <at> debbugs.gnu.org
Subject: Re: bug#4653: 23.1.50; ordering of bookmark-jump menu
Date: Sun, 08 Nov 2009 18:02:30 -0500

> Sorry, that *was* the case with Emacs 22 as well.  In my private copy
> of Emacs 22 I had applied the patch below (I have added 'bookmark-jump
> to the tool-bar and I use the menu very often).
>
> A change like in the patch seems to be more consistent with the
> documentation of bookmark-sort-flag

Look reasonable.  I've checked the patch in, thank you.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.