GNU bug report logs - #46493
[feature/pgtk] Low contrast region face

Previous Next

Package: emacs;

Reported by: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Date: Sat, 13 Feb 2021 16:57:01 UTC

Severity: wishlist

Tags: moreinfo

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #64 received at 46493 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: contovob <at> tcd.ie, 46493 <at> debbugs.gnu.org, Yuuki Harano <masm+emacs <at> masm11.me>
Subject: Re: bug#46493: [feature/pgtk] Low contrast region face
Date: Mon, 20 Jun 2022 08:59:45 +0800
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> It's nonsensical of Emacs to use the Gtk theme for just one colour here.
> It should either use the Gtk theme for the background/foreground
> colours, too, or not use it at all.

It does for the foreground color too, if the contrast is too low.
Otherwise, why would we have a `distant-foreground' specification for
the region face on GTK?

> Emacs composes the colours we use here, and we choose colours that have
> the mixture we want.

We choose the colors specified by the user in his system-wide
preferences by default.

> Our current approach leads to two bugs: With a dark theme, we get a
> nonsensically dramatic region face, and with a light theme, we get a
> region face that has too low contrast.  That's an Emacs bug, and not
> something the user should have to deal with.

I disagree that the contrast is either too low or "dramatic".  And
anyway, I don't think we should be changing long-standing defaults for
personal preferences in this area.




This bug report was last modified 2 years and 307 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.