GNU bug report logs - #46491
[feature/pgtk] Unused macro warning in image.c without ImageMagick

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46491: closed ([feature/pgtk] Unused macro warning in image.c
 without ImageMagick)
Date: Sun, 14 Feb 2021 12:34:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 14 Feb 2021 12:33:10 +0000
with message-id <87r1lix20p.fsf <at> tcd.ie>
and subject line Re: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick
has caused the debbugs.gnu.org bug report #46491,
regarding [feature/pgtk] Unused macro warning in image.c without ImageMagick
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46491: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46491
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: [feature/pgtk] Unused macro warning in image.c without ImageMagick
Date: Sat, 13 Feb 2021 16:34:22 +0000

[Message part 3 (text/plain, inline)]

X-Debbugs-Cc: Yuuki Harano <masm+emacs <at> masm11.me>
Severity: minor
Tags: patch

The following is the only build warning I currently get on feature/pgtk:

  image.c:110: warning: macro "DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE"
    is not used [-Wunused-macros]
    110 | # define DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE

Is the attached patch the right fix?  If so, I can push it after adding
the bug#number to it.

Thanks,

-- 
Basil

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2021-02-13 built on tia
Repository revision: 175ebb010477ff0e174fe5145154397f43dee2d2
Repository branch: feature/pgtk
Windowing system distributor 'System Description: Debian GNU/Linux bullseye/sid

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --program-suffix=-pgtk
 --enable-checking=structs --with-file-notification=yes --with-pgtk
 --with-xwidgets'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY
PDUMPER PGTK PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XIM
XWIDGETS GTK3 ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

[0001-Fix-unused-macro-build-warning-in-image.c.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Yuuki Harano <masm+emacs <at> masm11.me>
Cc: 46491-done <at> debbugs.gnu.org
Subject: Re: bug#46491: [feature/pgtk] Unused macro warning in image.c
 without ImageMagick
Date: Sun, 14 Feb 2021 12:33:10 +0000

Yuuki Harano <masm+emacs <at> masm11.me> writes:

> On Sat, 13 Feb 2021 16:34:22 +0000,
> 	"Basil L. Contovounesios" <contovob <at> tcd.ie> wrote:
>> Is the attached patch the right fix?  If so, I can push it after adding
>> the bug#number to it.
>
> Thanks, confirmed.  Please push it.

Thanks, done.

Fix unused macro build warning in image.c
c4cc80e1fb 2021-02-14 12:29:25 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c4cc80e1fbbfb50486c6ce360f2d68e96fc45887

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.