From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 13 11:34:36 2021 Received: (at submit) by debbugs.gnu.org; 13 Feb 2021 16:34:36 +0000 Received: from localhost ([127.0.0.1]:34932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAxsQ-0007Gw-9G for submit@debbugs.gnu.org; Sat, 13 Feb 2021 11:34:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:41604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAxsL-0007Gl-Ko for submit@debbugs.gnu.org; Sat, 13 Feb 2021 11:34:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAxsL-0003YM-69 for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 11:34:29 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:39378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAxsI-00074M-Sk for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 11:34:29 -0500 Received: by mail-wm1-x32a.google.com with SMTP id u14so2981009wmq.4 for ; Sat, 13 Feb 2021 08:34:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:mime-version; bh=jCSfRiE2Odulk1sUmHdHh5aKeySxKly7pzsgQLESOKI=; b=gxEBnLPz1SlbrXcYrQqji6y7mB5zcR/63NZSS1UCd9LxlV6kP3PodcCWTtrSoS8SJc FjCvzoWwU2v4rOUhP2WV7YLrEqoLz5OKJCmLsCaMz3BFpzkPFQegjsxbldbh2z0KTc8S xnFuY4vv5cpyQVqHqpzKy/Zt3n5OWY987pPDRQFCO39AvamGv5E1uNFNZ+PF/JKvEefI mZSFmnNw3Z7MIalDV5ShYOf4RahipWii12cNBbH5wWmwyx7keZhALsU0HxSXpudQSUXX SLd6Scq9rwVGwLvt1T/nH7LWCrcFoCxYoJUJTARLFkRZ5gzwiRPdGbNKKblOBfj4Lf4q /x8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=jCSfRiE2Odulk1sUmHdHh5aKeySxKly7pzsgQLESOKI=; b=N/OLNcgItZHjKUiDj7m9SzwCUdbei5qZUPeVwk155dLyBjtBbIrQ24tyEHC8Waxj9j 3L4xw7T0dAfxf9jlrWuIiUjrwa1aY667gR+/fydA2ba1eblzmueBUOLoOe5o+oKyJGrE Is2OoMEZS9puL/+3bReCQ5kpCiVbZ/g1R7xJyDr8haxKYgNGr7raMt1BogCyLw59wIwM UlZ1FuswPz5uo7J0i9r31Ejeayz0f59DJwjzrF6A/kX0oWiv8Ue08A2KLRf+9KyUIzBX zV5MSboUc6IGyPery/WfO1IcyZHprMBMUOusLw/LbpY5OVHTXFMPV/JuzqTft0XVjhDi BOjw== X-Gm-Message-State: AOAM530m80JN6PK5fEdhrVauDmRJyVAPYFttyXDTrhm1wLwb4Kagz/hI IWtKTXoSqD8uQBhG2aziHvM5KddvhQtWneGZ X-Google-Smtp-Source: ABdhPJzBQoKwtij+VaxllwpI4MKf2DUyN1bQ1Kk9IiD58vra5/tW2bClNQqew74isIkRHXLQ1BBQ8A== X-Received: by 2002:a1c:5f82:: with SMTP id t124mr7035763wmb.55.1613234064245; Sat, 13 Feb 2021 08:34:24 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id j4sm16987176wrx.23.2021.02.13.08.34.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Feb 2021 08:34:23 -0800 (PST) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: [feature/pgtk] Unused macro warning in image.c without ImageMagick Date: Sat, 13 Feb 2021 16:34:22 +0000 Message-ID: <871rdksz8x.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=2a00:1450:4864:20::32a; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain X-Debbugs-Cc: Yuuki Harano Severity: minor Tags: patch The following is the only build warning I currently get on feature/pgtk: image.c:110: warning: macro "DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE" is not used [-Wunused-macros] 110 | # define DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE Is the attached patch the right fix? If so, I can push it after adding the bug#number to it. Thanks, -- Basil In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-02-13 built on tia Repository revision: 175ebb010477ff0e174fe5145154397f43dee2d2 Repository branch: feature/pgtk Windowing system distributor 'System Description: Debian GNU/Linux bullseye/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --program-suffix=-pgtk --enable-checking=structs --with-file-notification=yes --with-pgtk --with-xwidgets' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XIM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-unused-macro-build-warning-in-image.c.patch >From d60bc973c8ac840e02297931f86ebb05b50b20e6 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 13 Feb 2021 14:51:48 +0000 Subject: [PATCH] Fix unused macro build warning in image.c * src/image.c [HAVE_PGTK] (DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE): Define only if HAVE_IMAGEMAGICK is also defined, as it is otherwise unused. (image_set_transform): Reduce nesting of preprocessor conditionals. --- src/image.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/image.c b/src/image.c index cc97ca4d7c..09370fa833 100644 --- a/src/image.c +++ b/src/image.c @@ -99,7 +99,7 @@ #define BLUE16_FROM_ULONG(color) (BLUE_FROM_ULONG (color) * 0x101) Lisp_Object, unsigned long); #endif /* USE_CAIRO */ -#ifdef HAVE_PGTK +#if defined HAVE_PGTK && defined HAVE_IMAGEMAGICK /* On pgtk, we don't want to create scaled image. * If we create scaled image on scale=2.0 environment, * the created image is half size and Gdk scales it back, @@ -2307,12 +2307,11 @@ compute_image_rotation (struct image *img, double *rotation) static void image_set_transform (struct frame *f, struct image *img) { -# ifdef HAVE_IMAGEMAGICK -# ifndef DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE +# if (defined HAVE_IMAGEMAGICK \ + && !defined DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE) /* ImageMagick images already have the correct transform. */ if (EQ (image_spec_value (img->spec, QCtype, NULL), Qimagemagick)) return; -# endif # endif # if !defined USE_CAIRO && defined HAVE_XRENDER -- 2.30.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 13 18:05:58 2021 Received: (at 46491) by debbugs.gnu.org; 13 Feb 2021 23:05:58 +0000 Received: from localhost ([127.0.0.1]:35205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB3zC-0008GW-Io for submit@debbugs.gnu.org; Sat, 13 Feb 2021 18:05:58 -0500 Received: from outbound.soverin.net ([116.202.65.218]:49971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB3z9-0008GI-7E for 46491@debbugs.gnu.org; Sat, 13 Feb 2021 18:05:57 -0500 Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 0BE8E600D0; Sat, 13 Feb 2021 23:05:49 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1613257548; bh=HgioaTr4FAl7GTt/0pkHUdP9i/ZdFNQ58/F3S8HAumo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OZWAKutDDNQYU2eE+0At9CPpTUhioyu1Sb3ImVDiFa3iomi2SfejzNAoPKBWUe9pj JI7Aq9iXzPgKiJjgCPkaDzpqdZsG48mC0aJE4afPwenJN03C7rNgVfJFBuUdntasjd PZ/o13HZOQMcatrE6DKSrzL5eVrlBy/NKLq5pn7PZGq/ctmcYJdsPTeJHcqsF0fxVV J1Bmjo3w9TN9bej8a53gDp8AhG+vMm4R2jaoK7qdedQiDa4rQzm0jrVuBIm9u+7Lxp DsGMAHNOwPxeIwZj1jQY/0X13v7CTrwZLY2+PxhI8uCF5vqOBtIClw8rK2o1qXtwnC hvmGYi/sB0DXQ== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id B558B202A6D446; Sat, 13 Feb 2021 23:05:45 +0000 (GMT) Date: Sat, 13 Feb 2021 23:05:45 +0000 From: Alan Third To: "Basil L. Contovounesios" Subject: Re: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick Message-ID: Mail-Followup-To: Alan Third , "Basil L. Contovounesios" , 46491@debbugs.gnu.org, yuuki harano References: <871rdksz8x.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871rdksz8x.fsf@tcd.ie> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46491 Cc: yuuki harano , 46491@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Feb 13, 2021 at 04:34:22PM +0000, Basil L. Contovounesios wrote: > X-Debbugs-Cc: Yuuki Harano > Severity: minor > Tags: patch > > The following is the only build warning I currently get on feature/pgtk: > > image.c:110: warning: macro "DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE" > is not used [-Wunused-macros] > 110 | # define DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE > > Is the attached patch the right fix? If so, I can push it after adding > the bug#number to it. I think your patch looks right, but I'm confused as to why this is in the PGTK branch at all. The imagemagick transforms are intentionally excluded from the native transforms, but this disables the imagemagick transforms completely and, presumably, replaces them with native transforms. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 13 21:02:58 2021 Received: (at 46491) by debbugs.gnu.org; 14 Feb 2021 02:02:59 +0000 Received: from localhost ([127.0.0.1]:35286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB6kU-0003zQ-OE for submit@debbugs.gnu.org; Sat, 13 Feb 2021 21:02:58 -0500 Received: from shiro.masm11.me ([150.95.182.25]:57296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB6kR-0003zD-EZ for 46491@debbugs.gnu.org; Sat, 13 Feb 2021 21:02:57 -0500 Received: from luna.pink.masm11.me (KD111239255141.au-net.ne.jp [111.239.255.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shiro.masm11.me (Postfix) with ESMTPSA id E5294C013D; Sun, 14 Feb 2021 11:02:51 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=masm11.me; s=202002; t=1613268172; bh=fhizTrh+0zj7QIz8Ng9jJe6m7sTE4nDoyyy205oqNTk=; h=Date:To:Cc:Subject:From:In-Reply-To:References; b=RxpPCwF6zQWgrqiPRU4l+cgNS4PlCFzpiqVzKp+ScPUUTGqa3es1SQK6V7HfS8xIP jRV9L944CwBJFStK2UUOkNL4PVA+0XBTib2y5ZaCKFn3o3IdRslASWnj7th8qEaik2 c/3SFFrc2TxW7I4xdX6/sj30anffoXStmEnfubdQ= Date: Sun, 14 Feb 2021 11:02:50 +0900 (JST) Message-Id: <20210214.110250.815338716237405080.masm@luna.pink.masm11.me> To: contovob@tcd.ie Subject: Re: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick From: Yuuki Harano In-Reply-To: <871rdksz8x.fsf@tcd.ie> References: <871rdksz8x.fsf@tcd.ie> Organization: Ingage Inc. X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46491 Cc: 46491@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 13 Feb 2021 16:34:22 +0000, "Basil L. Contovounesios" wrote: > Is the attached patch the right fix? If so, I can push it after adding > the bug#number to it. Thanks, confirmed. Please push it. -- Yuuki Harano From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 13 21:20:27 2021 Received: (at 46491) by debbugs.gnu.org; 14 Feb 2021 02:20:27 +0000 Received: from localhost ([127.0.0.1]:35301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB71P-0004Py-2k for submit@debbugs.gnu.org; Sat, 13 Feb 2021 21:20:27 -0500 Received: from shiro.masm11.me ([150.95.182.25]:57328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB71M-0004Pn-8k for 46491@debbugs.gnu.org; Sat, 13 Feb 2021 21:20:25 -0500 Received: from luna.pink.masm11.me (KD111239255141.au-net.ne.jp [111.239.255.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shiro.masm11.me (Postfix) with ESMTPSA id 90AAAC013D; Sun, 14 Feb 2021 11:20:20 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=masm11.me; s=202002; t=1613269220; bh=qjwGP59AybFNBc2u+8Gjv/6iXf3wypuvsTeChe2UOUE=; h=Date:To:Cc:Subject:From:In-Reply-To:References; b=psnCAcHKKHlybFvolIOd9QO//Sl31vQBWcmKP7y+LvfR1e8+b0dg2gO1iLm3eeT3n MFvX/qmbQIfaK8yiiff8CtYstbo8EdtbQmoWwVI62ohJf215g6vT4xLTQevyOajQ1U KoPtUudrAPwkyOgN/8djDUYvEFvf4Sskl2M70fIg= Date: Sun, 14 Feb 2021 11:20:19 +0900 (JST) Message-Id: <20210214.112019.308581254652492325.masm@luna.pink.masm11.me> To: alan@idiocy.org Subject: Re: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick From: Yuuki Harano In-Reply-To: References: <871rdksz8x.fsf@tcd.ie> Organization: Ingage Inc. X-Mailer: Mew version 6.8 on Emacs 28.0 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46491 Cc: contovob@tcd.ie, 46491@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 13 Feb 2021 23:05:45 +0000, Alan Third wrote: > I think your patch looks right, but I'm confused as to why this is in > the PGTK branch at all. The imagemagick transforms are intentionally > excluded from the native transforms, but this disables the imagemagick > transforms completely and, presumably, replaces them with native > transforms. I wanted to make imagemagick images not blurry in image-mode on scale x2.0 monitor. With the exclusion, imagemagick generates scaled image pixel data, and the image is rendered twice in size, so it is blurry. Without the exclusion, imagemagick generates original image pixel data, and the image may not be enlarged (but shrinked), so it may not be blurry. For other than imagemagick, like png, original image pixel data is generated, and it is not blurry on scale x2.0 monitor. So I disabled it. -- Yuuki Harano From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 14 05:03:37 2021 Received: (at 46491) by debbugs.gnu.org; 14 Feb 2021 10:03:37 +0000 Received: from localhost ([127.0.0.1]:35448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBEFd-0007I1-1G for submit@debbugs.gnu.org; Sun, 14 Feb 2021 05:03:37 -0500 Received: from outbound.soverin.net ([116.202.65.218]:55161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBEFa-0007Hm-El for 46491@debbugs.gnu.org; Sun, 14 Feb 2021 05:03:35 -0500 Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 5A375600D0; Sun, 14 Feb 2021 10:03:28 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1613297007; bh=/I3jpSGK+RuuvOekVTVaxAx9pdhD32/aJ30R/fp25SU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fufVePoNNUpDphTMDhNmmEuekz0YHeb9lBqC10jj+qYrKgNG3yyx4L7v3PjeKMU1X UnAITA6haLDicGhpuiU6KeqluwVpM7d8uFn+3RSGOmrqXLg2qgJb+0UGr1uWCyt3oR +2TvNGeOgyfd5R3smjrPfvza6aEwmy2dpocVQ1lkwUdQqb/p7mDZ/SweizcjrOGWfU CNcLPV4ICEwduR2fW9L4LhyOlJ3ZK/v6CnnTjECOIINSglLC+8+BF62+4ZBauYeHzl X03IoELe93enxpupeYnj0GbrCk4uxmw+pzzf6h/Utq3kRY3n8mT4kqzGpI0MQSNDln JZeug44dMLuZQ== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id A8C67202A6E2FF; Sun, 14 Feb 2021 10:03:25 +0000 (GMT) Date: Sun, 14 Feb 2021 10:03:25 +0000 From: Alan Third To: Yuuki Harano Subject: Re: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick Message-ID: Mail-Followup-To: Alan Third , Yuuki Harano , contovob@tcd.ie, 46491@debbugs.gnu.org References: <871rdksz8x.fsf@tcd.ie> <20210214.112019.308581254652492325.masm@luna.pink.masm11.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210214.112019.308581254652492325.masm@luna.pink.masm11.me> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46491 Cc: contovob@tcd.ie, 46491@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Feb 14, 2021 at 11:20:19AM +0900, Yuuki Harano wrote: > > On Sat, 13 Feb 2021 23:05:45 +0000, > Alan Third wrote: > > I think your patch looks right, but I'm confused as to why this is in > > the PGTK branch at all. The imagemagick transforms are intentionally > > excluded from the native transforms, but this disables the imagemagick > > transforms completely and, presumably, replaces them with native > > transforms. > > I wanted to make imagemagick images not blurry in image-mode on > scale x2.0 monitor. > > With the exclusion, imagemagick generates scaled image pixel data, > and the image is rendered twice in size, so it is blurry. > Without the exclusion, imagemagick generates original image pixel data, > and the image may not be enlarged (but shrinked), so it may not be blurry. > > For other than imagemagick, like png, original image pixel data is generated, > and it is not blurry on scale x2.0 monitor. I am aware of this, I see the same thing on NS, but when native transforms were introduced we decided that when a user asks imagemagick to modify an image, imagemagick should actually do the modifications and Emacs will just display the results. I don't know that it's important, though. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 14 07:33:20 2021 Received: (at 46491-done) by debbugs.gnu.org; 14 Feb 2021 12:33:20 +0000 Received: from localhost ([127.0.0.1]:35550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBGaW-0006w5-Hf for submit@debbugs.gnu.org; Sun, 14 Feb 2021 07:33:20 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:55388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBGaU-0006vs-Cx for 46491-done@debbugs.gnu.org; Sun, 14 Feb 2021 07:33:19 -0500 Received: by mail-wm1-f44.google.com with SMTP id o15so3760296wmq.5 for <46491-done@debbugs.gnu.org>; Sun, 14 Feb 2021 04:33:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ysIulJB9Jh2c7XASk3E7FerPlJpDm+T5PuxuocrJWps=; b=O0tjM0h2x6Uk1fMre97jKB6FV9bf8ar/K3P6iAu7DCU/VO4c22WnF8hTs3I/xRzvX3 tFenDUBMpMrMb9VLq/HYeSZ0wR/50B54vjsgqWeqIkBDY8k+biavhYIAD3K1rKvUChJQ s3oSjTi0xY2g55ZZ5bp6rUdo331odWAGSTZdmW/FG4OnDFU0X0Buwdx2PxssRPFDOCdF rux9amRPEpNknj+VxT8ixYiU7OZWCkS1p2/V2OOYDC9Iy7fpk+OfO42FtwYJtqyrdHIk Wp5b7yQpWudRf9LS/3EEHT5G9u57IkqfUnK7MQxPpB2vx9/pl0Vbh5fKsBFplcz7gYgj 0DLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ysIulJB9Jh2c7XASk3E7FerPlJpDm+T5PuxuocrJWps=; b=kP/B7peBCA7O1k+0sBB0Y5O3Fj52oCRsUhcFBqrEqiv4G+JUjOJ4ST83DD+XwzPiDk Uxk0eiIBGICS4EoL4Avve8W4/hylbK/Ybdkrpq+FbJkeViLFnWzPypU9CuaAX7pBCkKw fwwZdw/kvQTlATwwoFeOWTfJ5HYAi59Ek/2jiusAFphyBgW8AFpYRNQz6UdR242oxG1J DV6poRkdhXsMwJpfEh1wAakHbp6gF4QDxX/6zPOEygPrkjx+Iwcjwd0viRzjzw6ry83v 2FTaArhSPEJpqd4oBDoGT4t7KohHOD/AOAIriVGQAe6fJlC+jkacLx+I2ITV0hB7SNcd ZEng== X-Gm-Message-State: AOAM532wVv4+5S5i8aX5MX5JQ2ZAGtmtiHMREknavlrBvRFuOzW884M5 5L8TR3fX5kJAD4J7BqC+SI3rTNPjiYTj+A== X-Google-Smtp-Source: ABdhPJyTDcYE4Z+Tw1oVT8EQ65ZrCq4aFL3HmqDYx1KhwOt+Z/TtrrhGApmcoDkNB3O9tbC+uYTxWA== X-Received: by 2002:a7b:ca52:: with SMTP id m18mr10021858wml.3.1613305992415; Sun, 14 Feb 2021 04:33:12 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id d20sm19785734wrc.12.2021.02.14.04.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Feb 2021 04:33:11 -0800 (PST) From: "Basil L. Contovounesios" To: Yuuki Harano Subject: Re: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick References: <871rdksz8x.fsf@tcd.ie> <20210214.110250.815338716237405080.masm@luna.pink.masm11.me> Date: Sun, 14 Feb 2021 12:33:10 +0000 In-Reply-To: <20210214.110250.815338716237405080.masm@luna.pink.masm11.me> (Yuuki Harano's message of "Sun, 14 Feb 2021 11:02:50 +0900 (JST)") Message-ID: <87r1lix20p.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46491-done Cc: 46491-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuuki Harano writes: > On Sat, 13 Feb 2021 16:34:22 +0000, > "Basil L. Contovounesios" wrote: >> Is the attached patch the right fix? If so, I can push it after adding >> the bug#number to it. > > Thanks, confirmed. Please push it. Thanks, done. Fix unused macro build warning in image.c c4cc80e1fb 2021-02-14 12:29:25 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c4cc80e1fbbfb50486c6ce360f2d68e96fc45887 -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 14 10:38:17 2021 Received: (at 46491) by debbugs.gnu.org; 14 Feb 2021 15:38:17 +0000 Received: from localhost ([127.0.0.1]:36579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBJTV-0005HX-4d for submit@debbugs.gnu.org; Sun, 14 Feb 2021 10:38:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBJTT-0005HL-2x for 46491@debbugs.gnu.org; Sun, 14 Feb 2021 10:38:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40114) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBJTL-0006VV-CE; Sun, 14 Feb 2021 10:38:07 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4200 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lBJTK-0006dM-RI; Sun, 14 Feb 2021 10:38:07 -0500 Date: Sun, 14 Feb 2021 17:38:06 +0200 Message-Id: <83r1libqxt.fsf@gnu.org> From: Eli Zaretskii To: Alan Third In-Reply-To: (message from Alan Third on Sun, 14 Feb 2021 10:03:25 +0000) Subject: Re: bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick References: <871rdksz8x.fsf@tcd.ie> <20210214.112019.308581254652492325.masm@luna.pink.masm11.me> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46491 Cc: contovob@tcd.ie, masm+emacs@masm11.me, 46491@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Date: Sun, 14 Feb 2021 10:03:25 +0000 > From: Alan Third > Cc: contovob@tcd.ie, 46491@debbugs.gnu.org > > > I wanted to make imagemagick images not blurry in image-mode on > > scale x2.0 monitor. > > > > With the exclusion, imagemagick generates scaled image pixel data, > > and the image is rendered twice in size, so it is blurry. > > Without the exclusion, imagemagick generates original image pixel data, > > and the image may not be enlarged (but shrinked), so it may not be blurry. > > > > For other than imagemagick, like png, original image pixel data is generated, > > and it is not blurry on scale x2.0 monitor. > > I am aware of this, I see the same thing on NS, but when native > transforms were introduced we decided that when a user asks > imagemagick to modify an image, imagemagick should actually do the > modifications and Emacs will just display the results. > > I don't know that it's important, though. I think it's quite important to have Emacs behave the same on all platforms. While we no longer recommend to build Emacs with ImageMagick, those who do build with it should be able to use its transforms, and disabling that is not necessarily a good idea. Instead of disabling ImageMagick transforms, why not tell users to build Emacs without ImageMagick? From unknown Mon Aug 18 11:18:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 15 Mar 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator