Subject: bug#46472: Make lisp/mail/uce.el obsolete

From: Eli Zaretskii <[email-masked]>
Date: Fri, 15 Oct 2021 13:46:59 +0300

> From: Stefan Kangas <[email-masked]>
> Date: Fri, 15 Oct 2021 03:50:17 -0500
> Cc: [email-masked], [email-masked], [email-masked]
> 
> > I'd like to see the patch for master, please.
> 
> Please see the attached.
> 
> * lisp/mail/uce.el: Recommend against its use.  (Bug#46472)

This should mention the function in which you make the change.

> Do not merge to master.

???

> --- a/lisp/mail/uce.el
> +++ b/lisp/mail/uce.el
> @@ -358,7 +358,30 @@ uce-reply-to-uce
>        ;; Run hooks before we leave buffer for editing.  Reasonable usage
>        ;; might be to set up special key bindings, replace standard
>        ;; functions in mail-mode, etc.
> -      (run-hooks 'mail-setup-hook 'uce-setup-hook))))
> +      (run-hooks 'mail-setup-hook 'uce-setup-hook)))
> +  (pop-to-buffer (get-buffer-create "uce-reply-to-uce warning"))
> +  (insert "\
> +-- !!! NOTE !!! ---------------------------------------------

This should pop only once per Emacs session, not each time the command
is invoked.

I also think we should have in the Commentary section something like
this:

  ;; We don't recommend using this feature; see the message in
  ;; 'uce-reply-to-uce' for the reasons.

Thanks.