GNU bug report logs - #46445
[PATCH] tests: Make the STORE test more robust in a "pure" environment.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46445: closed ([PATCH] tests: Make the STORE test more robust
 in a "pure" environment.)
Date: Thu, 18 Mar 2021 19:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 18 Mar 2021 15:16:43 -0400
with message-id <YFOnG484R3IVz1jP <at> jasmine.lan>
and subject line Re: bug#46445: [PATCH] tests: Make the STORE test more robust in a "pure" environment.
has caused the debbugs.gnu.org bug report #46445,
regarding [PATCH] tests: Make the STORE test more robust in a "pure" environment.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46445: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46445
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] tests: Make the STORE test more robust in a "pure"
 environment.
Date: Thu, 11 Feb 2021 15:25:42 -0500

Otherwise, the test crashes (not fails) when run in `guix environment --pure guix`.

I'm not sure this is the right approach, when I look at commit
3d43017026f9995ad128915db8ca5eafe061bf75, which added this variable.

* tests/store.scm (%shell): Fallback to "/bin/sh".
---
 tests/store.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/store.scm b/tests/store.scm
index cda0e0302f..9c25adf5e9 100644
--- a/tests/store.scm
+++ b/tests/store.scm
@@ -50,7 +50,7 @@
   (open-connection-for-tests))
 
 (define %shell
-  (or (getenv "SHELL") (getenv "CONFIG_SHELL")))
+  (or (getenv "SHELL") (getenv "CONFIG_SHELL") "/bin/sh"))
 
 
 (test-begin "store")
-- 
2.30.0

[Message part 3 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46445-done <at> debbugs.gnu.org
Subject: Re: bug#46445: [PATCH] tests: Make the STORE test more robust in a
 "pure" environment.
Date: Thu, 18 Mar 2021 15:16:43 -0400

On Wed, Mar 17, 2021 at 10:36:16PM +0100, Ludovic Courtès wrote:
> LGTM, thanks!

Thanks for your review! Pushed as
0d8d499036f632e03f63bdaf36b02861ea52b3e6

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.