From unknown Sat Jun 14 19:38:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Feb 2021 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46445 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46445@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161307515920728 (code B ref -1); Thu, 11 Feb 2021 20:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2021 20:25:59 +0000 Received: from localhost ([127.0.0.1]:59383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAIXG-0005OG-Pf for submit@debbugs.gnu.org; Thu, 11 Feb 2021 15:25:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:41142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAIXD-0005O7-K2 for submit@debbugs.gnu.org; Thu, 11 Feb 2021 15:25:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAIXD-0007Im-CD for guix-patches@gnu.org; Thu, 11 Feb 2021 15:25:55 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:33195) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAIX9-0004y5-8w for guix-patches@gnu.org; Thu, 11 Feb 2021 15:25:55 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E9DB4A1F; Thu, 11 Feb 2021 15:25:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 11 Feb 2021 15:25:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=/QtrP6xzwzNCl/ZON6IV0lr 8ZvrERT5NcR3odCVA1bY=; b=nZ11L35M/lEbbHTMBhVgnQUd+m1Rue2xMWzRNgF dIcAOdard0+U5LknTjMRTSeTg0h0sOkN/YE81sxWStFqVrEl3lQpDKaZ024QNEEg jrGcqQ309FTrjpb31J8+DeoH0JtoA/y8yJ6rpWPh5ixoQ2iRseItLPYGufk8QvNw eXDs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/QtrP6xzwzNCl/ZON 6IV0lr8ZvrERT5NcR3odCVA1bY=; b=Ds4OEhSw/cBu2jSAjScrhyZI9iDarqVT4 jjwMexXfqe/d/3yJjsDY/UYEwlQhZB+2DPeB53MoSqWidqAlCw3RzSLJ1Aq/8grr s0TjKCuOdVlPP2Z8Dcq4p/S+byvw3HGWC4XmNBzn/obboOIbgXJyqMrQJyhPLNa0 gwr4+LyUlZCaKmIXF4KpTB3cGl0ZV7a4v9dSORcFssD2mEeeNG2tPNFjArr2Hb5f op+GMH4EPvaVGAL0KJZ7+JiaOhiT4TZD67YnXmiKulVxszZ2aoGrumCbzeqwM3Ja ZBmdgMctYc6JDecBArxj0WXEfZikq7jpi5cWl9AxivjkdtAD6Xb7A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheelgddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepteeuiefgleehkeevffevteffueegueduvd egieffveekuefffeetuddvhffhudfhnecukfhppedutddtrdduuddrudeiledruddukeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghose hfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from jasmine.lan (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 574BA108005F for ; Thu, 11 Feb 2021 15:25:48 -0500 (EST) From: Leo Famulari Date: Thu, 11 Feb 2021 15:25:42 -0500 Message-Id: <2cd34bbd26f480faeb89f38af590d10339303f8f.1613075074.git.leo@famulari.name> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.19; envelope-from=leo@famulari.name; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Otherwise, the test crashes (not fails) when run in `guix environment --pure guix`. I'm not sure this is the right approach, when I look at commit 3d43017026f9995ad128915db8ca5eafe061bf75, which added this variable. * tests/store.scm (%shell): Fallback to "/bin/sh". --- tests/store.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/store.scm b/tests/store.scm index cda0e0302f..9c25adf5e9 100644 --- a/tests/store.scm +++ b/tests/store.scm @@ -50,7 +50,7 @@ (open-connection-for-tests)) (define %shell - (or (getenv "SHELL") (getenv "CONFIG_SHELL"))) + (or (getenv "SHELL") (getenv "CONFIG_SHELL") "/bin/sh")) (test-begin "store") -- 2.30.0 From unknown Sat Jun 14 19:38:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment. References: <2cd34bbd26f480faeb89f38af590d10339303f8f.1613075074.git.leo@famulari.name> In-Reply-To: <2cd34bbd26f480faeb89f38af590d10339303f8f.1613075074.git.leo@famulari.name> Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Feb 2021 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46445 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46445@debbugs.gnu.org Received: via spool by 46445-submit@debbugs.gnu.org id=B46445.161428402921257 (code B ref 46445); Thu, 25 Feb 2021 20:14:01 +0000 Received: (at 46445) by debbugs.gnu.org; 25 Feb 2021 20:13:49 +0000 Received: from localhost ([127.0.0.1]:39433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFN1B-0005Wn-7J for submit@debbugs.gnu.org; Thu, 25 Feb 2021 15:13:49 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFN17-0005WX-3Q for 46445@debbugs.gnu.org; Thu, 25 Feb 2021 15:13:48 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A5B5B5C012B; Thu, 25 Feb 2021 15:13:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 25 Feb 2021 15:13:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:mime-version:content-type; s= mesmtp; bh=Dn+6lVBxqqgzCCvKizIYIdcvsmzIf2fOkSN9NalpAXg=; b=TQUeL oOQ54L547aVUgzDVqDLdcLT1uFattA2nDy8fppGsC+w6xyXOxQEbBchjti7vZya2 bEEnzNM4hOCO32sq1xV5HXvmtrhWpxctvZi2lMWhctW4Sp0PZ+bl6TaLm6sgmh0H twOhWn+Vzc/Qcnut4Tmtsw6+nrdRBvVuNQPGuk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=Dn+6lVBxqqgzCCvKizIYIdcvsmzIf 2fOkSN9NalpAXg=; b=nBcIIp/gYwGJhSFF9o3/eu48VBASP8/+yIoaVR7439eQm xfgVSA69GSOCdU+0RcraF2Ei+Y9l2swHHS+OMdpfGf2ZdBGODWnPrzEJnLPlz9nX 7JwJFzTTgMtwfKWFPTnhW5w13fTpzhfaUk8vQoCFc+GQAFO1K5klMqdLtnNj6dkF FvwOGk1G2KXSbqWtTRG1MVraqnB8tY+72qeb5m3yuG1XYknLmStPN8wICvQCMh5+ lIPgJ9jjXRInf6DEMWSUWqTPeNo/RvsIOBWyej5t0N7EBy9SSg+KwHf6K4gSRQfj bBP7nWNy8NjaGhvu7DbcktduflClhp9MkiZQq9STg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeelgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesthdtredttd dtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepffehtdeffedtvdeuieefudeujedvkeehff euieejgfdvteelgeehgeefheehuddunecukfhppedutddtrdduuddrudeiledruddukeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghose hfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 276361080068 for <46445@debbugs.gnu.org>; Thu, 25 Feb 2021 15:13:39 -0500 (EST) Date: Thu, 25 Feb 2021 15:13:37 -0500 From: Leo Famulari Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ping! Is this change correct? From unknown Sat Jun 14 19:38:24 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Mar 2021 21:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46445 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 46445@debbugs.gnu.org Received: via spool by 46445-submit@debbugs.gnu.org id=B46445.161601698618606 (code B ref 46445); Wed, 17 Mar 2021 21:37:02 +0000 Received: (at 46445) by debbugs.gnu.org; 17 Mar 2021 21:36:26 +0000 Received: from localhost ([127.0.0.1]:44342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMdq6-0004q2-9v for submit@debbugs.gnu.org; Wed, 17 Mar 2021 17:36:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMdq3-0004pn-KP for 46445@debbugs.gnu.org; Wed, 17 Mar 2021 17:36:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44229) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMdpy-0006OX-9N; Wed, 17 Mar 2021 17:36:18 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48810 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMdpx-00036n-T2; Wed, 17 Mar 2021 17:36:18 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <2cd34bbd26f480faeb89f38af590d10339303f8f.1613075074.git.leo@famulari.name> Date: Wed, 17 Mar 2021 22:36:16 +0100 In-Reply-To: <2cd34bbd26f480faeb89f38af590d10339303f8f.1613075074.git.leo@famulari.name> (Leo Famulari's message of "Thu, 11 Feb 2021 15:25:42 -0500") Message-ID: <87a6r1xy27.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Leo Famulari skribis: > Otherwise, the test crashes (not fails) when run in `guix environment --pure guix`. > > I'm not sure this is the right approach, when I look at commit > 3d43017026f9995ad128915db8ca5eafe061bf75, which added this variable. > > * tests/store.scm (%shell): Fallback to "/bin/sh". LGTM, thanks! Ludo'. From unknown Sat Jun 14 19:38:24 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Famulari Subject: bug#46445: closed (Re: bug#46445: [PATCH] tests: Make the STORE test more robust in a "pure" environment.) Message-ID: References: <2cd34bbd26f480faeb89f38af590d10339303f8f.1613075074.git.leo@famulari.name> X-Gnu-PR-Message: they-closed 46445 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 46445@debbugs.gnu.org Date: Thu, 18 Mar 2021 19:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1616095022-10736-1" This is a multi-part message in MIME format... ------------=_1616095022-10736-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #46445: [PATCH] tests: Make the STORE test more robust in a "pure" environm= ent. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 46445@debbugs.gnu.org. --=20 46445: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D46445 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1616095022-10736-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 46445-done) by debbugs.gnu.org; 18 Mar 2021 19:16:54 +0000 Received: from localhost ([127.0.0.1]:48103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMy8c-0002mW-Ix for submit@debbugs.gnu.org; Thu, 18 Mar 2021 15:16:54 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:48011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMy8b-0002mI-Hm for 46445-done@debbugs.gnu.org; Thu, 18 Mar 2021 15:16:53 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 8B3161032; Thu, 18 Mar 2021 15:16:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 18 Mar 2021 15:16:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=ZKh9Mg1fxf+bS5DRLqlKXB98Xu188SiRhokhyqqA7NQ=; b=wM9YAwncwUBA k6jT5RG/xTkEpVa36F2ZwC8bMh0y+Hbxn4G/r1TMJ+yv2K9OosfdFSkWUmKThoZh j7nXazJn3bc2oGvCpRLkahodwqoVIhJquzq9GTlDVmMmn+vYB8OZoOu7zYYhc7oF 82tXBchaSiETO7w2aBUS7uKy//1GAb4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZKh9Mg1fxf+bS5DRLqlKXB98Xu188SiRhokhyqqA7 NQ=; b=AJT/ybZxqd0ClWBPDt8TDZmOhcOULaYzRhEze4SodWSEi/J7YYAk2KybZ wJ8o5WFHeuboeyOKuuE0Zf21xkeHTEfoT4N7Evx1MKBK/00mvz5fC9uQbzGnMPQp KZ1sc8ML7vF3x3gZa2ErFxSKMXYPWtaA46kligqOjLVDg1Dix/Esq88km1CQdqSc X2lw+xeKb2CROaO8eDEV0cAg8+zeQfp29SJVMYAtNl6zbJrWmGqrVJnrxuxVECWI VeEanhH4BkW5+ZrWImmIy8Akh5IKjCdexoha1Mr9u1SPPZ+3hlJEMX3Yu2k1E6yf zL0+qrH6PH3dSRZmYPSxfmjfvlG6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefiedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeeuueegudfgvdfgveeuvdeludelfeejhfeggfejtefggeekudekhfdvfeel jeehgfenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghm vg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id A8127240054; Thu, 18 Mar 2021 15:16:46 -0400 (EDT) Date: Thu, 18 Mar 2021 15:16:43 -0400 From: Leo Famulari To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#46445: [PATCH] tests: Make the STORE test more robust in a "pure" environment. Message-ID: References: <2cd34bbd26f480faeb89f38af590d10339303f8f.1613075074.git.leo@famulari.name> <87a6r1xy27.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a6r1xy27.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46445-done Cc: 46445-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, Mar 17, 2021 at 10:36:16PM +0100, Ludovic Courtès wrote: > LGTM, thanks! Thanks for your review! Pushed as 0d8d499036f632e03f63bdaf36b02861ea52b3e6 ------------=_1616095022-10736-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Feb 2021 20:25:59 +0000 Received: from localhost ([127.0.0.1]:59383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAIXG-0005OG-Pf for submit@debbugs.gnu.org; Thu, 11 Feb 2021 15:25:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:41142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAIXD-0005O7-K2 for submit@debbugs.gnu.org; Thu, 11 Feb 2021 15:25:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAIXD-0007Im-CD for guix-patches@gnu.org; Thu, 11 Feb 2021 15:25:55 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:33195) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAIX9-0004y5-8w for guix-patches@gnu.org; Thu, 11 Feb 2021 15:25:55 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E9DB4A1F; Thu, 11 Feb 2021 15:25:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 11 Feb 2021 15:25:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=mesmtp; bh=/QtrP6xzwzNCl/ZON6IV0lr 8ZvrERT5NcR3odCVA1bY=; b=nZ11L35M/lEbbHTMBhVgnQUd+m1Rue2xMWzRNgF dIcAOdard0+U5LknTjMRTSeTg0h0sOkN/YE81sxWStFqVrEl3lQpDKaZ024QNEEg jrGcqQ309FTrjpb31J8+DeoH0JtoA/y8yJ6rpWPh5ixoQ2iRseItLPYGufk8QvNw eXDs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/QtrP6xzwzNCl/ZON 6IV0lr8ZvrERT5NcR3odCVA1bY=; b=Ds4OEhSw/cBu2jSAjScrhyZI9iDarqVT4 jjwMexXfqe/d/3yJjsDY/UYEwlQhZB+2DPeB53MoSqWidqAlCw3RzSLJ1Aq/8grr s0TjKCuOdVlPP2Z8Dcq4p/S+byvw3HGWC4XmNBzn/obboOIbgXJyqMrQJyhPLNa0 gwr4+LyUlZCaKmIXF4KpTB3cGl0ZV7a4v9dSORcFssD2mEeeNG2tPNFjArr2Hb5f op+GMH4EPvaVGAL0KJZ7+JiaOhiT4TZD67YnXmiKulVxszZ2aoGrumCbzeqwM3Ja ZBmdgMctYc6JDecBArxj0WXEfZikq7jpi5cWl9AxivjkdtAD6Xb7A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheelgddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepteeuiefgleehkeevffevteffueegueduvd egieffveekuefffeetuddvhffhudfhnecukfhppedutddtrdduuddrudeiledruddukeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghose hfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from jasmine.lan (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 574BA108005F for ; Thu, 11 Feb 2021 15:25:48 -0500 (EST) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] tests: Make the STORE test more robust in a "pure" environment. Date: Thu, 11 Feb 2021 15:25:42 -0500 Message-Id: <2cd34bbd26f480faeb89f38af590d10339303f8f.1613075074.git.leo@famulari.name> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.19; envelope-from=leo@famulari.name; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Otherwise, the test crashes (not fails) when run in `guix environment --pure guix`. I'm not sure this is the right approach, when I look at commit 3d43017026f9995ad128915db8ca5eafe061bf75, which added this variable. * tests/store.scm (%shell): Fallback to "/bin/sh". --- tests/store.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/store.scm b/tests/store.scm index cda0e0302f..9c25adf5e9 100644 --- a/tests/store.scm +++ b/tests/store.scm @@ -50,7 +50,7 @@ (open-connection-for-tests)) (define %shell - (or (getenv "SHELL") (getenv "CONFIG_SHELL"))) + (or (getenv "SHELL") (getenv "CONFIG_SHELL") "/bin/sh")) (test-begin "store") -- 2.30.0 ------------=_1616095022-10736-1--