From unknown Tue Sep 09 17:03:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#4643 <4643@debbugs.gnu.org> To: bug#4643 <4643@debbugs.gnu.org> Subject: Status: two different definitions for handlerlist and catchlist in eval.c and alloc.c Reply-To: bug#4643 <4643@debbugs.gnu.org> Date: Wed, 10 Sep 2025 00:03:14 +0000 retitle 4643 two different definitions for handlerlist and catchlist in eva= l.c and alloc.c reassign 4643 emacs submitter 4643 Dan Nicolaescu severity 4643 normal thanks From dann@godzilla.ics.uci.edu Mon Oct 5 09:20:28 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 5 Oct 2009 16:20:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n95GKQxV030747 for ; Mon, 5 Oct 2009 09:20:28 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MuqIT-0005hG-DY for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2009 12:20:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MuqIM-0005fT-GZ for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2009 12:20:23 -0400 Received: from [199.232.76.173] (port=43525 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MuqIL-0005f3-WF for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2009 12:20:18 -0400 Received: from paul-mcgann-v0.ics.uci.edu ([128.195.1.147]:36179) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MuqIL-00047W-Kd for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2009 12:20:17 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n95GIXMH008891 for ; Mon, 5 Oct 2009 09:18:33 -0700 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n95GIX0i012545; Mon, 5 Oct 2009 09:18:33 -0700 (PDT) Date: Mon, 5 Oct 2009 09:18:33 -0700 (PDT) Message-Id: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: two different definitions for handlerlist and catchlist in eval.c and alloc.c X-Debbugs-No-Ack: yes Lines: 6 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: n95GIXMH008891 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) struct handlerlist and struct catchlist have different definitions in eval.c and alloc.c. This generates and error when using doing link time optimizations with gcc. From dann@godzilla.ics.uci.edu Wed Oct 7 01:32:14 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 7 Oct 2009 08:32:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.8 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, IMPRONONCABLE_1,MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD2,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from paul-mcgann-v0.ics.uci.edu (paul-mcgann-v0.ics.uci.edu [128.195.1.147]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n978WDwk001096 for <4643@emacsbugs.donarmstrong.com>; Wed, 7 Oct 2009 01:32:14 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n978W0Km013267 for <4643@emacsbugs.donarmstrong.com>; Wed, 7 Oct 2009 01:32:00 -0700 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n978W0Zi003116; Wed, 7 Oct 2009 01:32:00 -0700 (PDT) Date: Wed, 7 Oct 2009 01:32:00 -0700 (PDT) Message-Id: <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> From: Dan Nicolaescu To: 4643@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c References: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 5 Oct 2009 09:18:33 -0700 (PDT)") Lines: 176 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: n978W0Km013267 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_GC 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Here's a patch that fixes this problem by moving the definition in a separate file included in both places. OK to check in? Index: src/Makefile.in =================================================================== RCS file: /cvsroot/emacs/emacs/src/Makefile.in,v retrieving revision 1.450 diff -u -3 -p -r1.450 Makefile.in --- src/Makefile.in 26 Sep 2009 19:49:17 -0000 1.450 +++ src/Makefile.in 7 Oct 2009 08:26:06 -0000 @@ -1231,14 +1231,14 @@ xsmfns.o: xsmfns.c $(config_h) systime.h /* The files of Lisp proper */ alloc.o: alloc.c process.h frame.h window.h buffer.h puresize.h syssignal.h keyboard.h \ - blockinput.h atimer.h systime.h character.h dispextern.h $(config_h) \ + blockinput.h atimer.h systime.h character.h dispextern.h catchtag.h $(config_h) \ $(INTERVALS_H) bytecode.o: bytecode.c buffer.h syntax.h character.h window.h dispextern.h \ frame.h xterm.h $(config_h) data.o: data.c buffer.h puresize.h character.h syssignal.h keyboard.h frame.h \ termhooks.h $(config_h) eval.o: eval.c commands.h keyboard.h blockinput.h atimer.h systime.h \ - dispextern.h $(config_h) + dispextern.h catchtag.h $(config_h) floatfns.o: floatfns.c syssignal.h $(config_h) fns.o: fns.c commands.h $(config_h) frame.h buffer.h character.h keyboard.h \ keymap.h frame.h window.h dispextern.h $(INTERVALS_H) coding.h md5.h \ Index: src/alloc.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/alloc.c,v retrieving revision 1.449 diff -u -3 -p -r1.449 alloc.c --- src/alloc.c 25 Aug 2009 06:03:09 -0000 1.449 +++ src/alloc.c 7 Oct 2009 08:26:08 -0000 @@ -56,6 +56,7 @@ along with GNU Emacs. If not, see +#include "catchtag.h" /* GC_MALLOC_CHECK defined means perform validity checks of malloc'd memory. Can do this only if using gmalloc.c. */ @@ -4939,13 +4940,6 @@ staticpro (varaddress) abort (); } -struct catchtag -{ - Lisp_Object tag; - Lisp_Object val; - struct catchtag *next; -}; - /*********************************************************************** Protection from GC Index: src/eval.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/eval.c,v retrieving revision 1.315 diff -u -3 -p -r1.315 eval.c --- src/eval.c 1 Oct 2009 17:47:44 -0000 1.315 +++ src/eval.c 7 Oct 2009 08:26:08 -0000 @@ -26,6 +26,7 @@ along with GNU Emacs. If not, see +#include "catchtag.h" #if HAVE_X_WINDOWS #include "xterm.h" @@ -49,41 +50,6 @@ struct backtrace struct backtrace *backtrace_list; -/* This structure helps implement the `catch' and `throw' control - structure. A struct catchtag contains all the information needed - to restore the state of the interpreter after a non-local jump. - - Handlers for error conditions (represented by `struct handler' - structures) just point to a catch tag to do the cleanup required - for their jumps. - - catchtag structures are chained together in the C calling stack; - the `next' member points to the next outer catchtag. - - A call like (throw TAG VAL) searches for a catchtag whose `tag' - member is TAG, and then unbinds to it. The `val' member is used to - hold VAL while the stack is unwound; `val' is returned as the value - of the catch form. - - All the other members are concerned with restoring the interpreter - state. */ - -struct catchtag -{ - Lisp_Object tag; - Lisp_Object val; - struct catchtag *next; - struct gcpro *gcpro; - jmp_buf jmp; - struct backtrace *backlist; - struct handler *handlerlist; - int lisp_eval_depth; - int pdlcount; - int poll_suppress_count; - int interrupt_input_blocked; - struct byte_stack *byte_stack; -}; - struct catchtag *catchlist; #ifdef DEBUG_GCPRO --- /dev/null 2009-08-21 19:23:04.524086726 -0700 +++ src/catchtag.h 2009-10-07 01:11:39.784950000 -0700 @@ -0,0 +1,57 @@ +/* Structure for implementing the `catch' and `throw' control structure. + Copyright (C) 2009 Free Software Foundation, Inc. + +This file is part of GNU Emacs. + +GNU Emacs is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 3 of the License, or +(at your option) any later version. + +GNU Emacs is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with GNU Emacs. If not, see . */ + +#ifndef CATCHTAG_H +#define CATCHTAG_H + +/* This structure helps implement the `catch' and `throw' control + structure. A struct catchtag contains all the information needed + to restore the state of the interpreter after a non-local jump. + + Handlers for error conditions (represented by `struct handler' + structures) just point to a catch tag to do the cleanup required + for their jumps. + + catchtag structures are chained together in the C calling stack; + the `next' member points to the next outer catchtag. + + A call like (throw TAG VAL) searches for a catchtag whose `tag' + member is TAG, and then unbinds to it. The `val' member is used to + hold VAL while the stack is unwound; `val' is returned as the value + of the catch form. + + All the other members are concerned with restoring the interpreter + state. */ + +struct catchtag +{ + Lisp_Object tag; + Lisp_Object val; + struct catchtag *next; + struct gcpro *gcpro; + jmp_buf jmp; + struct backtrace *backlist; + struct handler *handlerlist; + int lisp_eval_depth; + int pdlcount; + int poll_suppress_count; + int interrupt_input_blocked; + struct byte_stack *byte_stack; +}; + +#endif /* CATCHTAG_H */ From dann@godzilla.ics.uci.edu Tue Oct 13 23:38:36 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 14 Oct 2009 06:38:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.5 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, IMPRONONCABLE_1,MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD2,URIBL_CNKR, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from paul-mcgann-v0.ics.uci.edu (paul-mcgann-v0.ics.uci.edu [128.195.1.147]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9E6cZQs005544 for <4643@emacsbugs.donarmstrong.com>; Tue, 13 Oct 2009 23:38:36 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n9E6cOLn000639 for <4643@emacsbugs.donarmstrong.com>; Tue, 13 Oct 2009 23:38:24 -0700 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n9E6cOJi019664; Tue, 13 Oct 2009 23:38:24 -0700 (PDT) Date: Tue, 13 Oct 2009 23:38:24 -0700 (PDT) Message-Id: <200910140638.n9E6cOJi019664@godzilla.ics.uci.edu> From: Dan Nicolaescu To: 4643@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c References: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 7 Oct 2009 01:32:00 -0700 (PDT)") Lines: 182 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: n9E6cOLn000639 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_GC 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Dan Nicolaescu writes: > Here's a patch that fixes this problem by moving the definition in a > separate file included in both places. > > OK to check in? Ping. Without a change like this emacs cannot be compiled using gcc-4.5 -flto > Index: src/Makefile.in > =================================================================== > RCS file: /cvsroot/emacs/emacs/src/Makefile.in,v > retrieving revision 1.450 > diff -u -3 -p -r1.450 Makefile.in > --- src/Makefile.in 26 Sep 2009 19:49:17 -0000 1.450 > +++ src/Makefile.in 7 Oct 2009 08:26:06 -0000 > @@ -1231,14 +1231,14 @@ xsmfns.o: xsmfns.c $(config_h) systime.h > /* The files of Lisp proper */ > > alloc.o: alloc.c process.h frame.h window.h buffer.h puresize.h syssignal.h keyboard.h \ > - blockinput.h atimer.h systime.h character.h dispextern.h $(config_h) \ > + blockinput.h atimer.h systime.h character.h dispextern.h catchtag.h $(config_h) \ > $(INTERVALS_H) > bytecode.o: bytecode.c buffer.h syntax.h character.h window.h dispextern.h \ > frame.h xterm.h $(config_h) > data.o: data.c buffer.h puresize.h character.h syssignal.h keyboard.h frame.h \ > termhooks.h $(config_h) > eval.o: eval.c commands.h keyboard.h blockinput.h atimer.h systime.h \ > - dispextern.h $(config_h) > + dispextern.h catchtag.h $(config_h) > floatfns.o: floatfns.c syssignal.h $(config_h) > fns.o: fns.c commands.h $(config_h) frame.h buffer.h character.h keyboard.h \ > keymap.h frame.h window.h dispextern.h $(INTERVALS_H) coding.h md5.h \ > Index: src/alloc.c > =================================================================== > RCS file: /cvsroot/emacs/emacs/src/alloc.c,v > retrieving revision 1.449 > diff -u -3 -p -r1.449 alloc.c > --- src/alloc.c 25 Aug 2009 06:03:09 -0000 1.449 > +++ src/alloc.c 7 Oct 2009 08:26:08 -0000 > @@ -56,6 +56,7 @@ along with GNU Emacs. If not, see #include "syssignal.h" > #include "termhooks.h" /* For struct terminal. */ > #include > +#include "catchtag.h" > > /* GC_MALLOC_CHECK defined means perform validity checks of malloc'd > memory. Can do this only if using gmalloc.c. */ > @@ -4939,13 +4940,6 @@ staticpro (varaddress) > abort (); > } > > -struct catchtag > -{ > - Lisp_Object tag; > - Lisp_Object val; > - struct catchtag *next; > -}; > - > > /*********************************************************************** > Protection from GC > Index: src/eval.c > =================================================================== > RCS file: /cvsroot/emacs/emacs/src/eval.c,v > retrieving revision 1.315 > diff -u -3 -p -r1.315 eval.c > --- src/eval.c 1 Oct 2009 17:47:44 -0000 1.315 > +++ src/eval.c 7 Oct 2009 08:26:08 -0000 > @@ -26,6 +26,7 @@ along with GNU Emacs. If not, see #include "keyboard.h" > #include "dispextern.h" > #include > +#include "catchtag.h" > > #if HAVE_X_WINDOWS > #include "xterm.h" > @@ -49,41 +50,6 @@ struct backtrace > > struct backtrace *backtrace_list; > > -/* This structure helps implement the `catch' and `throw' control > - structure. A struct catchtag contains all the information needed > - to restore the state of the interpreter after a non-local jump. > - > - Handlers for error conditions (represented by `struct handler' > - structures) just point to a catch tag to do the cleanup required > - for their jumps. > - > - catchtag structures are chained together in the C calling stack; > - the `next' member points to the next outer catchtag. > - > - A call like (throw TAG VAL) searches for a catchtag whose `tag' > - member is TAG, and then unbinds to it. The `val' member is used to > - hold VAL while the stack is unwound; `val' is returned as the value > - of the catch form. > - > - All the other members are concerned with restoring the interpreter > - state. */ > - > -struct catchtag > -{ > - Lisp_Object tag; > - Lisp_Object val; > - struct catchtag *next; > - struct gcpro *gcpro; > - jmp_buf jmp; > - struct backtrace *backlist; > - struct handler *handlerlist; > - int lisp_eval_depth; > - int pdlcount; > - int poll_suppress_count; > - int interrupt_input_blocked; > - struct byte_stack *byte_stack; > -}; > - > struct catchtag *catchlist; > > #ifdef DEBUG_GCPRO > --- /dev/null 2009-08-21 19:23:04.524086726 -0700 > +++ src/catchtag.h 2009-10-07 01:11:39.784950000 -0700 > @@ -0,0 +1,57 @@ > +/* Structure for implementing the `catch' and `throw' control structure. > + Copyright (C) 2009 Free Software Foundation, Inc. > + > +This file is part of GNU Emacs. > + > +GNU Emacs is free software: you can redistribute it and/or modify > +it under the terms of the GNU General Public License as published by > +the Free Software Foundation, either version 3 of the License, or > +(at your option) any later version. > + > +GNU Emacs is distributed in the hope that it will be useful, > +but WITHOUT ANY WARRANTY; without even the implied warranty of > +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +GNU General Public License for more details. > + > +You should have received a copy of the GNU General Public License > +along with GNU Emacs. If not, see . */ > + > +#ifndef CATCHTAG_H > +#define CATCHTAG_H > + > +/* This structure helps implement the `catch' and `throw' control > + structure. A struct catchtag contains all the information needed > + to restore the state of the interpreter after a non-local jump. > + > + Handlers for error conditions (represented by `struct handler' > + structures) just point to a catch tag to do the cleanup required > + for their jumps. > + > + catchtag structures are chained together in the C calling stack; > + the `next' member points to the next outer catchtag. > + > + A call like (throw TAG VAL) searches for a catchtag whose `tag' > + member is TAG, and then unbinds to it. The `val' member is used to > + hold VAL while the stack is unwound; `val' is returned as the value > + of the catch form. > + > + All the other members are concerned with restoring the interpreter > + state. */ > + > +struct catchtag > +{ > + Lisp_Object tag; > + Lisp_Object val; > + struct catchtag *next; > + struct gcpro *gcpro; > + jmp_buf jmp; > + struct backtrace *backlist; > + struct handler *handlerlist; > + int lisp_eval_depth; > + int pdlcount; > + int poll_suppress_count; > + int interrupt_input_blocked; > + struct byte_stack *byte_stack; > +}; > + > +#endif /* CATCHTAG_H */ From monnier@iro.umontreal.ca Wed Oct 14 06:45:37 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 14 Oct 2009 13:45:37 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9EDjZbx003642 for <4643@emacsbugs.donarmstrong.com>; Wed, 14 Oct 2009 06:45:37 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqYEADNz1UpMCqsb/2dsb2JhbACBUddbhC4Eh3WCeA X-IronPort-AV: E=Sophos;i="4.44,557,1249272000"; d="scan'208";a="47538808" Received: from 76-10-171-27.dsl.teksavvy.com (HELO pastel.home) ([76.10.171.27]) by ironport2-out.pppoe.ca with ESMTP; 14 Oct 2009 09:45:30 -0400 Received: by pastel.home (Postfix, from userid 20848) id 661B07F5B; Wed, 14 Oct 2009 09:45:30 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 4643@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c Message-ID: References: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> <200910140638.n9E6cOJi019664@godzilla.ics.uci.edu> Date: Wed, 14 Oct 2009 09:45:30 -0400 In-Reply-To: <200910140638.n9E6cOJi019664@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 13 Oct 2009 23:38:24 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> Here's a patch that fixes this problem by moving the definition in a >> separate file included in both places. >> >> OK to check in? > Ping. I agree on the idea, but I don't want a new file just for that declaration, so please move it to some existing file instead. Stefan From dann@godzilla.ics.uci.edu Wed Oct 14 11:09:26 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 14 Oct 2009 18:09:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.4 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9EI9PLK009614 for <4643@emacsbugs.donarmstrong.com>; Wed, 14 Oct 2009 11:09:26 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n9EI97HC016402; Wed, 14 Oct 2009 11:09:07 -0700 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n9EI964P024771; Wed, 14 Oct 2009 11:09:06 -0700 (PDT) Date: Wed, 14 Oct 2009 11:09:06 -0700 (PDT) Message-Id: <200910141809.n9EI964P024771@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 4643@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c References: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> <200910140638.n9E6cOJi019664@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Wed, 14 Oct 2009 09:45:30 -0400") Lines: 17 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: n9EI97HC016402 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > >> Here's a patch that fixes this problem by moving the definition in a > >> separate file included in both places. > >> > >> OK to check in? > > > Ping. > > I agree on the idea, but I don't want a new file just for that > declaration, so please move it to some existing file instead. The catchtag structure definition needs a #include to precede it. We don't include setjmp.h in many places, so it will need to be added... I don't see any existing header that would be a good match (other than lisp.h). So please suggest where to add it. From monnier@iro.umontreal.ca Wed Oct 14 20:14:51 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 15 Oct 2009 03:14:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9F3Eoj5029822 for <4643@emacsbugs.donarmstrong.com>; Wed, 14 Oct 2009 20:14:51 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqYEAAsx1kpMCqsb/2dsb2JhbACBUdgDhC4Eh3WCeA X-IronPort-AV: E=Sophos;i="4.44,563,1249272000"; d="scan'208";a="47597309" Received: from 76-10-171-27.dsl.teksavvy.com (HELO ceviche.home) ([76.10.171.27]) by ironport2-out.pppoe.ca with ESMTP; 14 Oct 2009 23:14:44 -0400 Received: by ceviche.home (Postfix, from userid 20848) id AF60DB4100; Wed, 14 Oct 2009 23:14:44 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 4643@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c Message-ID: References: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> <200910140638.n9E6cOJi019664@godzilla.ics.uci.edu> <200910141809.n9EI964P024771@godzilla.ics.uci.edu> Date: Wed, 14 Oct 2009 23:14:44 -0400 In-Reply-To: <200910141809.n9EI964P024771@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 14 Oct 2009 11:09:06 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> >> Here's a patch that fixes this problem by moving the definition in a >> >> separate file included in both places. >> >> >> >> OK to check in? >> >> > Ping. >> >> I agree on the idea, but I don't want a new file just for that >> declaration, so please move it to some existing file instead. > The catchtag structure definition needs a #include to > precede it. We don't include setjmp.h in many places, so it will need > to be added... I don't see any existing header that would be a good > match (other than lisp.h). So please suggest where to add it. Huh.... lisp.h? Stefan From dann@godzilla.ics.uci.edu Wed Oct 14 20:45:03 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 15 Oct 2009 03:45:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.4 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from paul-mcgann-v0.ics.uci.edu (paul-mcgann-v0.ics.uci.edu [128.195.1.147]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9F3j2BH002168 for <4643@emacsbugs.donarmstrong.com>; Wed, 14 Oct 2009 20:45:03 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n9F3ipw0012114; Wed, 14 Oct 2009 20:44:51 -0700 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n9F3ipRk029264; Wed, 14 Oct 2009 20:44:51 -0700 (PDT) Date: Wed, 14 Oct 2009 20:44:51 -0700 (PDT) Message-Id: <200910150344.n9F3ipRk029264@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 4643@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c References: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> <200910140638.n9E6cOJi019664@godzilla.ics.uci.edu> <200910141809.n9EI964P024771@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Wed, 14 Oct 2009 23:14:44 -0400") Lines: 20 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: n9F3ipw0012114 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > >> >> Here's a patch that fixes this problem by moving the definition in a > >> >> separate file included in both places. > >> >> > >> >> OK to check in? > >> > >> > Ping. > >> > >> I agree on the idea, but I don't want a new file just for that > >> declaration, so please move it to some existing file instead. > > > The catchtag structure definition needs a #include to > > precede it. We don't include setjmp.h in many places, so it will need > > to be added... I don't see any existing header that would be a good > > match (other than lisp.h). So please suggest where to add it. > > Huh.... lisp.h? If you don't mind setjmp.h being included everywhere, fine with me. From monnier@iro.umontreal.ca Thu Oct 15 05:59:57 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 15 Oct 2009 12:59:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9FCxtHb032161 for <4643@emacsbugs.donarmstrong.com>; Thu, 15 Oct 2009 05:59:57 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqoEACe61kpMCqsb/2dsb2JhbACBUthXhDAEh3aCeA X-IronPort-AV: E=Sophos;i="4.44,566,1249272000"; d="scan'208";a="47608965" Received: from 76-10-171-27.dsl.teksavvy.com (HELO pastel.home) ([76.10.171.27]) by ironport2-out.pppoe.ca with ESMTP; 15 Oct 2009 08:59:49 -0400 Received: by pastel.home (Postfix, from userid 20848) id 8CA507F87; Thu, 15 Oct 2009 08:59:49 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 4643@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c Message-ID: References: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> <200910140638.n9E6cOJi019664@godzilla.ics.uci.edu> <200910141809.n9EI964P024771@godzilla.ics.uci.edu> <200910150344.n9F3ipRk029264@godzilla.ics.uci.edu> Date: Thu, 15 Oct 2009 08:59:49 -0400 In-Reply-To: <200910150344.n9F3ipRk029264@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 14 Oct 2009 20:44:51 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > If you don't mind setjmp.h being included everywhere, fine with me. Indeed, I don't mind. Stefan From dann@godzilla.ics.uci.edu Sun Oct 18 21:30:25 2009 Received: (at 4643-done) by emacsbugs.donarmstrong.com; 19 Oct 2009 04:30:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.4 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9J4UOi1026256 for <4643-done@emacsbugs.donarmstrong.com>; Sun, 18 Oct 2009 21:30:25 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n9J4UGL0010287; Sun, 18 Oct 2009 21:30:16 -0700 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n9J4UFNE012243; Sun, 18 Oct 2009 21:30:15 -0700 (PDT) Date: Sun, 18 Oct 2009 21:30:15 -0700 (PDT) Message-Id: <200910190430.n9J4UFNE012243@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 4643-done@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c References: <200910051618.n95GIX0i012545@godzilla.ics.uci.edu> <200910070832.n978W0Zi003116@godzilla.ics.uci.edu> <200910140638.n9E6cOJi019664@godzilla.ics.uci.edu> <200910141809.n9EI964P024771@godzilla.ics.uci.edu> <200910150344.n9F3ipRk029264@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Thu, 15 Oct 2009 08:59:49 -0400") Lines: 7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: n9J4UGL0010287 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > > If you don't mind setjmp.h being included everywhere, fine with me. > > Indeed, I don't mind. Thanks. Done. From adrian.b.robert@gmail.com Mon Oct 19 08:55:50 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 19 Oct 2009 15:55:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.5 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.155]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9JFtmcx031304 for <4643@emacsbugs.donarmstrong.com>; Mon, 19 Oct 2009 08:55:49 -0700 Received: by fg-out-1718.google.com with SMTP id d23so1948229fga.13 for <4643@emacsbugs.donarmstrong.com>; Mon, 19 Oct 2009 08:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:content-type :content-transfer-encoding:subject:date:message-id:to:mime-version :x-mailer; bh=JGFa5+0CgUHoWtUIYdlxoxPRGkY7YcRKXAzKFi6lIgw=; b=xiBCWpTvNOO4iwg5hme2+2eWPdpjgbK+tMvBjvwDlMeV6UWWv3WHoiVvCyvrSH//hL YXgHRYeZ2mFoC5yQXwWskb9Lxd4AmeT4mhG+nK7yfVyNre3zn6iGFsNiOGKyLXlWW0RM okO85KlNjKvgL5JetW7BLIQ9f2XgfhqTsKRV0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:content-type:content-transfer-encoding:subject:date:message-id :to:mime-version:x-mailer; b=gqK37+jdENAZ1H7hiQYC2HwraGwRi7UWTSelIJYjWmT8e+BxjSFXzoGXmNRvBK1uzv WhlktYpKHLSOkfvXl+f4R/EGJP45QpjsHsVR9C75Dn71+vuJyhbx7mYqFhwdMe/mAuq8 iQxrdwJQ3JYwCGMUywLw1lrIHDU40PEModlDs= Received: by 10.86.22.12 with SMTP id 12mr3442440fgv.69.1255967747392; Mon, 19 Oct 2009 08:55:47 -0700 (PDT) Received: from ?192.168.2.13? (165.sub-75-223-82.myvzw.com [75.223.82.165]) by mx.google.com with ESMTPS id e20sm71080fga.15.2009.10.19.08.55.45 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 19 Oct 2009 08:55:46 -0700 (PDT) From: Adrian Robert Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c Date: Mon, 19 Oct 2009 11:55:41 -0400 Message-Id: To: 4643@debbugs.gnu.org Mime-Version: 1.0 (Apple Message framework v1076) X-Mailer: Apple Mail (2.1076) Just out of curiosity, is this new #include definitely not needed in the ns*.m files? I don't understand the actual issue, but it seems like every other source file has been touched. While gcc-4.5 will probably never be used on OS X (moving to clang), it might be in GNUstep compilations. From dann@godzilla.ics.uci.edu Mon Oct 19 09:58:51 2009 Received: (at 4643) by emacsbugs.donarmstrong.com; 19 Oct 2009 16:58:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.9 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9JGwnts008546 for <4643@emacsbugs.donarmstrong.com>; Mon, 19 Oct 2009 09:58:50 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n9JGwYWM016706; Mon, 19 Oct 2009 09:58:35 -0700 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n9JGwYHm017732; Mon, 19 Oct 2009 09:58:34 -0700 (PDT) Date: Mon, 19 Oct 2009 09:58:34 -0700 (PDT) Message-Id: <200910191658.n9JGwYHm017732@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Adrian Robert Cc: 4643@debbugs.gnu.org Subject: Re: bug#4643: two different definitions for catchlist in eval.c and alloc.c References: X-Debbugs-No-Ack: yes In-Reply-To: (Adrian Robert's message of "Mon, 19 Oct 2009 11:55:41 -0400") Lines: 13 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: n9JGwYWM016706 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Adrian Robert writes: > Just out of curiosity, is this new #include definitely not needed in > the ns*.m files? I don't understand the actual issue, but it seems I think I grepped for *.[ch], so *.m where accidentally left out. Fixed now. > like every other source file has been touched. While gcc-4.5 will > probably never be used on OS X (moving to clang), it might be in > GNUstep compilations. This would affect any compiler that does IPA. From unknown Tue Sep 09 17:03:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Nov 2009 15:24:13 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator