From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 16:39:19 2021 Received: (at submit) by debbugs.gnu.org; 10 Feb 2021 21:39:19 +0000 Received: from localhost ([127.0.0.1]:57316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9xCh-0003dP-2p for submit@debbugs.gnu.org; Wed, 10 Feb 2021 16:39:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:46148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9xCc-0003dE-CA for submit@debbugs.gnu.org; Wed, 10 Feb 2021 16:39:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9xCc-0007KT-5K for guix-patches@gnu.org; Wed, 10 Feb 2021 16:39:14 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:35679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9xCX-0007oN-2F for guix-patches@gnu.org; Wed, 10 Feb 2021 16:39:10 -0500 Received: by mail-wm1-x330.google.com with SMTP id n10so1372212wmq.0 for ; Wed, 10 Feb 2021 13:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qy9/DeigjIvqLSiTbY4IfKNDPN7woZ33sI7plQyY7Ok=; b=sPQiJYC2feLIFQMZt2Bf/9Zp8de5Qp32YzEPm2cNzYV0zs7L/UvzaNNBTU/AoWcEkJ Vg46sStDobtRaigjccEMbDYuhJh1lFtMcAu2OxTGJ+lf0avPpeRKzMqEJPA7iLUqX3pY UplvklTtwigNZaAfXoP31z4QWkpfweMFuwcr5Xu98LKP1gjhGLcMeCWhIaq8LRQ2+tBB djHjM6sFrMQDtOaXZXc2b8zq653Wa5+0jsacbueXu//4sl0GcXlwb2fCDgbuqvNwsTTl KWnhpo9tTTM5WOkQA/AogT5rj7HvL5w9jXsliP2Kgx11CUeWWUjJ/9zWnZM/7HyDUMi/ lSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qy9/DeigjIvqLSiTbY4IfKNDPN7woZ33sI7plQyY7Ok=; b=cg3f5q/MX9UCsF1lB2ULQd9GrT2cvAOCi7EqgG0mou06ysGWeqyV0gSTBuvqOPwYWi di9VtgOWnD/glOOcB7ftKP/+14V550/VgkgXxPZK1l/PEZ86/0g2rLCT4GJIXUKvcDun cXQi+mE1eMWkfJuvR8I861XwkkoUtDO3zX8GZq/hQ6V8j4Aennuu1HumI9totse0UFzO YRpfF/fTxaf7Y+LVrncUofaD3RzcriyNgSpyE1bW/87RjiRreeUtUmPuF48QU61x5MWS VFPeKTwsPTlQjVv5ZSiSWBwrKvfyZHvExUFaQTczfYVOqGsRatmvihnp1r/NwG4vDbcJ dOAg== X-Gm-Message-State: AOAM532gg9Vo7F0DRVYROtbYzTCcN9xqKUUDiR91FEJSMqcil1MXDzKI WUreJDl4URxqcV3kLgJ3snuyTy3nqLA= X-Google-Smtp-Source: ABdhPJy5Nw3KhZ3sGOqegbLpGX8WKlKJvUyW/fLDwyI5Io2XigR4NwQkzjD/a/ZYB+9KRv3mJ325vQ== X-Received: by 2002:a05:600c:19cc:: with SMTP id u12mr1056789wmq.26.1612993146715; Wed, 10 Feb 2021 13:39:06 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id n193sm4533552wmb.0.2021.02.10.13.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 13:39:05 -0800 (PST) From: zimoun To: guix-patches@gnu.org Subject: [PATCH 0/1] guix time-machine: fail when unrecognized option Date: Wed, 10 Feb 2021 22:38:50 +0100 Message-Id: <20210210213850.44577-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, Currently, the command line: --8<---------------cut here---------------start------------->8--- $ guix time-machine kikoo -- --version guix (GNU Guix) 8f8a1485b80de707caecf6e7e29b520cd8cf611e Copyright © 2021 les auteurs de Guix Licence GPLv3+ : GNU GPL version 3 ou ultérieure Ceci est un logiciel libre : vous êtes libre de le modifier et de le redistribuer. Il n'y a AUCUNE GARANTIE, dans les limites permises par la loi. --8<---------------cut here---------------end--------------->8--- does not fail but uses the current commit. This leads to confusing behaviour as described in , for instance: $ guix time-machine 8e7e414aa998fe8c0de8a491c91aab8b8d9c58f4 -- graph maven which had failed with: --8<---------------cut here---------------start------------->8--- "453f18db343cbad1892186b85c7eb07f364b399e"; system: "x86_64-linux"; host version: "838347207cdd96de1ad0127aaf4b2c378c7c2148"; pull-version: 1). --8<---------------cut here---------------end--------------->8--- The failure is another reason. However the backtrace is not informative about the real issue which is a misuse of the command line. This trivial patch fixes it by gracefully failing. All the best, simon zimoun (1): scripts: time-machine: Fail when unrecognized option. guix/scripts/time-machine.scm | 3 +++ 1 file changed, 3 insertions(+) base-commit: 8f8a1485b80de707caecf6e7e29b520cd8cf611e -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 10 16:48:22 2021 Received: (at 46429) by debbugs.gnu.org; 10 Feb 2021 21:48:22 +0000 Received: from localhost ([127.0.0.1]:57321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9xLS-0003qY-5N for submit@debbugs.gnu.org; Wed, 10 Feb 2021 16:48:22 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:39735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9xLP-0003qJ-22 for 46429@debbugs.gnu.org; Wed, 10 Feb 2021 16:48:21 -0500 Received: by mail-wm1-f49.google.com with SMTP id u14so3249373wmq.4 for <46429@debbugs.gnu.org>; Wed, 10 Feb 2021 13:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4o30hsiJu1p8ABGHUEO4vRJWPK8xQrxfjGqjfU6hQpU=; b=U3tmkc9kBwScE87jArUT5rTEGA4pPOjzCRwvQ9qcpeRSSDCsFtn/+Nqig2TOH6Jqij O0dQpcI0mEUlPIt7iOCtpCgRZ27xNiMRBE+2v1JaYbLwoz6RGazrxC5a5VAjF1v8fgJH pvXZT+HwC00hS5y6arP79jqJBPzRqCLGhv7utkbUwKNMLHWz0trGIsV/kPKtoTxBeZWL WTNLr2n1nG3hoRRleKWsAGdC2KjcOGX73H7WEYC1xK2xqFbft1Sw6lPi6W/le71UP/Wr p6MlCExp8DXEslIqTlzN5bz54fw5aJ8VFLJXNNntK+apU33KZ1rrgkRqBlTxK7sK08Yn eSvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4o30hsiJu1p8ABGHUEO4vRJWPK8xQrxfjGqjfU6hQpU=; b=hL5adHi+y73ZfwgJWWEKDhe5P4Jrd+i0FhDpxv6FExI722kfSkXyqaqS0daIA0n6U3 i+5ePQUKxZykoUzxKeOzZzDFPBOnuU7ZStdPcyPXGmLERjl67ft7YzAvh6xk9XebhakG oM8lD7/bWpTwswy7JLNS9/yxB0niu9ABz4UaJjFNrjFOB8itoUzp2+9ozNRt0KB1V2Ae PS+qsqLO4p5nlJP3Pchx/Q5kYS+Hk00unWibLwMHnb6jm4vlsNiCRxiUxWr9PVrd0hPf yC7btI7FD9TZqPayjQ35sE5SH2YkCUnqxpXUTA20Gl6E+Bes2WOnqDGA4x+XL9Yxl5sQ BIqg== X-Gm-Message-State: AOAM531Ce9vv9EwEHReoAmINWJ8+wnVcmcSoRkYs+YpBEBcoK8m/hde6 jcm6Rl9K4iHdmRdU8T74CCDnNIp+Tzw= X-Google-Smtp-Source: ABdhPJy6V+SycQ75ZyabllwOHdGeUCBizjFdgGDZH2otqRCItZpv1xkc1Bj4OsA8z5bEsGk7U3umXg== X-Received: by 2002:a7b:c1ce:: with SMTP id a14mr1178360wmj.24.1612993693107; Wed, 10 Feb 2021 13:48:13 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id w4sm4381007wmc.13.2021.02.10.13.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 13:48:12 -0800 (PST) From: zimoun To: 46429@debbugs.gnu.org Subject: [PATCH 1/1] scripts: time-machine: Fail when unrecognized option. Date: Wed, 10 Feb 2021 22:48:04 +0100 Message-Id: <20210210214804.44637-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46429 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/scripts/time-machine (parse-args): Fail when unrecognized option. --- guix/scripts/time-machine.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/guix/scripts/time-machine.scm b/guix/scripts/time-machine.scm index 0d27414702..c6ab30e132 100644 --- a/guix/scripts/time-machine.scm +++ b/guix/scripts/time-machine.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2019 Konrad Hinsen ;;; Copyright © 2019, 2020 Ludovic Courtès +;;; Copyright © 2021 Simon Tournier ;;; ;;; This file is part of GNU Guix. ;;; @@ -118,6 +119,8 @@ Execute COMMAND ARGS... in an older version of Guix.\n")) (let-values (((args command) (break (cut string=? "--" <>) args))) (let ((opts (parse-command-line args %options (list %default-options)))) + (when (assoc-ref opts 'argument) + (leave (G_ "unrecognized option~%"))) (match command (() opts) (("--") opts) -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 11 17:25:55 2021 Received: (at 46429-done) by debbugs.gnu.org; 11 Mar 2021 22:25:55 +0000 Received: from localhost ([127.0.0.1]:55301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKTkg-0008Om-U4 for submit@debbugs.gnu.org; Thu, 11 Mar 2021 17:25:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKTkf-0008Oa-FM for 46429-done@debbugs.gnu.org; Thu, 11 Mar 2021 17:25:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33428) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKTka-0007hY-1t; Thu, 11 Mar 2021 17:25:48 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57036 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lKTkX-000153-7D; Thu, 11 Mar 2021 17:25:46 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: bug#46429: [PATCH 0/1] guix time-machine: fail when unrecognized option References: <20210210213850.44577-1-zimon.toutoune@gmail.com> <20210210214804.44637-1-zimon.toutoune@gmail.com> Date: Thu, 11 Mar 2021 23:25:41 +0100 In-Reply-To: <20210210214804.44637-1-zimon.toutoune@gmail.com> (zimoun's message of "Wed, 10 Feb 2021 22:48:04 +0100") Message-ID: <875z1xwcnu.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46429-done Cc: 46429-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi! zimoun skribis: > * guix/scripts/time-machine (parse-args): Fail when unrecognized option. I tweaked the error message to be consistent with the other commands and pushed as f1c4df15c31a81cca03a748a21ec38774e8114c0. Thanks, Ludo=E2=80=99. From unknown Sun Jun 15 08:35:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Apr 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator