GNU bug report logs - #46414
27.1; remove-hook doesn't remove entries from hook--depth-alist

Previous Next

Package: emacs;

Reported by: jakanakaevangeli <jakanakaevangeli <at> chiru.no>

Date: Tue, 9 Feb 2021 23:53:01 UTC

Severity: normal

Tags: moreinfo

Found in version 27.1

Done: <jakanakaevangeli <at> chiru.no>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: jakanakaevangeli <jakanakaevangeli <at> chiru.no>
To: 46414 <at> debbugs.gnu.org
Subject: bug#46414: 27.1; remove-hook doesn't remove entries from hook--depth-alist
Date: Wed, 10 Feb 2021 00:56:14 +0100

add-hook can add an entry to the hook symbol's hook--depth-alist
property and remove-hook doesn't remove it. This means that for each
call to eval-after-load, after-load-functions' hook--depth-alist gets a
new element when the feature is loaded, which can hinder performance.

This can also cause problems if your completing-read-function uses

    (minibuffer-with-setup-hook (:append generated-function-symbol)
      (read-from-minibuffer ...))

This will add a new element to minibuffer-setup-hook's the depth alist
for each completing-read session (such is the case when using
selectrum.el [1] completion function).

[1] https://github.com/raxod502/selectrum/
This bug report was last modified 2 years and 334 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.