GNU bug report logs - #46401
Typo in commit 0cc35e1431

Previous Next

Package: emacs;

Reported by: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>

Date: Tue, 9 Feb 2021 13:00:02 UTC

Severity: normal

Tags: fixed

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Typo in commit 0cc35e1431
Date: Tue, 09 Feb 2021 13:59:42 +0100
Hi,

There is a typo in commit 0cc35e1431:

    $ git show --oneline 0cc35e1431 lisp/progmodes/elisp-mode.el
    0cc35e1431 Move all usages of `values' to `values--store-value'
    diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
    index 9a36206bfd..0325d4ea75 100644
    --- a/lisp/progmodes/elisp-mode.el
    +++ b/lisp/progmodes/elisp-mode.el
    @@ -1268,9 +1268,8 @@ If `eval-expression-debug-on-error' is non-nil, which is the default,
     this command arranges for all errors to enter the debugger."
       (interactive "P")
       (if (null eval-expression-debug-on-error)
    -      (let ((value (elisp--eval-last-sexp eval-last-sexp-arg-internal)))
    -        (push value values)
    -        value)
    +      (values--store-values
    +       (elisp--eval-last-sexp eval-last-sexp-arg-internal))
         (let ((value
               (let ((debug-on-error elisp--eval-last-sexp-fake-value))
                 (cons (elisp--eval-last-sexp eval-last-sexp-arg-internal)

Instead of values--store-values, it should say values--store-value.

Best regards,
Dario

-- 
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid




This bug report was last modified 4 years and 101 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.