GNU bug report logs - #46369
28.0.50; Bind clone-buffer into the new C-x x keymap

Previous Next

Package: emacs;

Reported by: Sean Whitton <spwhitton <at> spwhitton.name>

Date: Sun, 7 Feb 2021 18:26:02 UTC

Severity: normal

Tags: fixed

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46369 in the body.
You can then email your comments to 46369 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#46369; Package emacs. (Sun, 07 Feb 2021 18:26:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Sean Whitton <spwhitton <at> spwhitton.name>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 07 Feb 2021 18:26:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Bind clone-buffer into the new C-x x keymap
Date: Sun, 07 Feb 2021 11:26:25 -0700
[Message part 1 (text/plain, inline)]
Hello,

I noticed that Lars has bound rename-uniquely to C-x x u.

I find that clone-buffer is a useful companion command to
rename-uniquely so would like to request binding C-x x n to that (the
letter 'n' follows Info-mode binding it to M-n).

Patch attached in case that makes this easier.

-- 
Sean Whitton
[0001-Bind-clone-buffer-to-C-x-x-n.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46369; Package emacs. (Sun, 07 Feb 2021 18:43:02 GMT) Full text and rfc822 format available.

Message #8 received at 46369 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Sean Whitton <spwhitton <at> spwhitton.name>, 46369 <at> debbugs.gnu.org
Subject: Re: bug#46369: 28.0.50; Bind clone-buffer into the new C-x x keymap
Date: Sun, 7 Feb 2021 20:42:09 +0200
On 07.02.2021 20:26, Sean Whitton wrote:
> I noticed that Lars has bound rename-uniquely to C-x x u.

Aside: I think this binding is inconsistent with 'vc-revert' (which is 
'C-x v u').

Possible alternatives:

- Not binding rename-uniquely at all.

- Moving its binding to 'C-x x R' (so that two very similar commands 
don't take up different keys). And possibly moving revert-buffer to 'C-x 
x u'.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46369; Package emacs. (Sun, 07 Feb 2021 20:15:01 GMT) Full text and rfc822 format available.

Message #11 received at 46369 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>, "46369 <at> debbugs.gnu.org"
 <46369 <at> debbugs.gnu.org>
Subject: RE: [External] : bug#46369: 28.0.50; Bind clone-buffer into the new
 C-x x keymap
Date: Sun, 7 Feb 2021 20:14:35 +0000
> I noticed that Lars has bound rename-uniquely to C-x x u.
> 
> I find that clone-buffer is a useful companion command to
> rename-uniquely so would like to request binding C-x x n to that (the
> letter 'n' follows Info-mode binding it to M-n).

Please refrain from binding keys by default to
prefix key `C-x x'.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46369; Package emacs. (Sun, 07 Feb 2021 21:20:02 GMT) Full text and rfc822 format available.

Message #14 received at 46369 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 46369 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#46369: 28.0.50; Bind clone-buffer into the new C-x x keymap
Date: Sun, 07 Feb 2021 22:19:36 +0100
Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 07.02.2021 20:26, Sean Whitton wrote:
>> I noticed that Lars has bound rename-uniquely to C-x x u.
>
> Aside: I think this binding is inconsistent with 'vc-revert' (which is
> 'C-x v u').
>
> Possible alternatives:
>
> - Not binding rename-uniquely at all.
>
> - Moving its binding to 'C-x x R' (so that two very similar commands
>   don't take up different keys). And possibly moving revert-buffer to
>   'C-x x u'.

"u" is somewhat mnemonic for VCs, since `vc-revert' "undos" what you've
done, but in non-VC buffers, it's not really -- you're
reloading/regenerating, not undoing.

And `revert-buffer' is `g' in special-mode-map, so keeping it g-ish in
the global map makes more sense, in my opinion.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46369; Package emacs. (Sun, 07 Feb 2021 22:10:02 GMT) Full text and rfc822 format available.

Message #17 received at 46369 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 46369 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#46369: 28.0.50; Bind clone-buffer into the new C-x x keymap
Date: Mon, 8 Feb 2021 00:09:14 +0200
On 07.02.2021 23:19, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
> 
>> On 07.02.2021 20:26, Sean Whitton wrote:
>>> I noticed that Lars has bound rename-uniquely to C-x x u.
>>
>> Aside: I think this binding is inconsistent with 'vc-revert' (which is
>> 'C-x v u').
>>
>> Possible alternatives:
>>
>> - Not binding rename-uniquely at all.
>>
>> - Moving its binding to 'C-x x R' (so that two very similar commands
>>    don't take up different keys). And possibly moving revert-buffer to
>>    'C-x x u'.
> 
> "u" is somewhat mnemonic for VCs, since `vc-revert' "undos" what you've
> done, but in non-VC buffers, it's not really -- you're
> reloading/regenerating, not undoing.

Also undoing, though: when the buffer has some unsaved changes.

> And `revert-buffer' is `g' in special-mode-map, so keeping it g-ish in
> the global map makes more sense, in my opinion.

Right, that too. So I don't really so much have a problem with 
'revert-buffer' being on 'C-x x g' as with 'rename-uniquely' being on 
'C-x x u'.

But if 'revert-buffer' were to move to 'C-x x u', I wouldn't find it 
odd. Because 'revert-buffer' pretty much has two different jobs:

- There are file-visiting buffers, revert-buffer-function is never set, 
and revert-buffer reverts to contents saved to disk as well as 
re-initializes the modes. Up until now this function never had a binding.

- There are non-file-visiting buffers, revert-buffer-function must be 
set, and the command does whatever revert-buffer-function says. This is 
usually bound to 'g', though apparently not always.

If these were two different commands, I don't think much would have 
changed for the vast majority of our users.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46369; Package emacs. (Mon, 08 Feb 2021 06:27:01 GMT) Full text and rfc822 format available.

Message #20 received at 46369 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 46369 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#46369: 28.0.50; Bind clone-buffer into the new C-x x keymap
Date: Mon, 08 Feb 2021 07:26:26 +0100
Dmitry Gutov <dgutov <at> yandex.ru> writes:

> But if 'revert-buffer' were to move to 'C-x x u', I wouldn't find it
> odd. Because 'revert-buffer' pretty much has two different jobs:
>
> - There are file-visiting buffers, revert-buffer-function is never
>   set, and revert-buffer reverts to contents saved to disk as well as
>   re-initializes the modes. Up until now this function never had a
>  binding.
>
> - There are non-file-visiting buffers, revert-buffer-function must be
>   set, and the command does whatever revert-buffer-function says. This
>   is usually bound to 'g', though apparently not always.
>
> If these were two different commands, I don't think much would have
> changed for the vast majority of our users.

Yes, that's true -- they're really quite different things...  but I'm
not sure I feel much enthusiasm for detangling that bit at this point.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46369; Package emacs. (Mon, 08 Feb 2021 06:53:02 GMT) Full text and rfc822 format available.

Message #23 received at 46369 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 46369 <at> debbugs.gnu.org
Subject: Re: bug#46369: 28.0.50; Bind clone-buffer into the new C-x x keymap
Date: Mon, 08 Feb 2021 07:52:35 +0100
Sean Whitton <spwhitton <at> spwhitton.name> writes:

> I find that clone-buffer is a useful companion command to
> rename-uniquely so would like to request binding C-x x n to that (the
> letter 'n' follows Info-mode binding it to M-n).
>
> Patch attached in case that makes this easier.

Makes sense; applied now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 08 Feb 2021 06:53:03 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 46369 <at> debbugs.gnu.org and Sean Whitton <spwhitton <at> spwhitton.name> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 08 Feb 2021 06:53:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#46369; Package emacs. (Mon, 08 Feb 2021 14:45:01 GMT) Full text and rfc822 format available.

Message #30 received at 46369 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 46369 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#46369: 28.0.50; Bind clone-buffer into the new C-x x keymap
Date: Mon, 8 Feb 2021 16:44:34 +0200
On 08.02.2021 08:26, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
> 
>> But if 'revert-buffer' were to move to 'C-x x u', I wouldn't find it
>> odd. Because 'revert-buffer' pretty much has two different jobs:
>>
>> - There are file-visiting buffers, revert-buffer-function is never
>>    set, and revert-buffer reverts to contents saved to disk as well as
>>    re-initializes the modes. Up until now this function never had a
>>   binding.
>>
>> - There are non-file-visiting buffers, revert-buffer-function must be
>>    set, and the command does whatever revert-buffer-function says. This
>>    is usually bound to 'g', though apparently not always.
>>
>> If these were two different commands, I don't think much would have
>> changed for the vast majority of our users.
> 
> Yes, that's true -- they're really quite different things...  but I'm
> not sure I feel much enthusiasm for detangling that bit at this point.

FWIW, I'm not saying we should split them (the benefits are small), but 
that keeping revert-buffer on 'g' in special modes and yet on 'C-x x u' 
otherwise can make sense.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 09 Mar 2021 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 159 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.