Subject: Re: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git

From: Dmitry Gutov <[email-masked]>
Date: Tue, 9 Feb 2021 15:05:39 +0200

On 09.02.2021 07:01, Protesilaos Stavrou wrote:
> I also think that 4 faces should suffice.  Having checked the doc string
> of 'vc-state' this is how I feel they should be organised.
> 
> | status           | face ("?" means suggestion) |
> |------------------+-----------------------------|
> | up-to-date       | vc-dir-status-up-to-date    |
> | edited           | vc-dir-status-edited        |
> | USER             | vc-dir-status-warning?      |
> | needs-update     | vc-dir-status-warning?      |
> | unlocked-changes | vc-dir-status-warning?      |
> | added            | vc-dir-status-edited        |
> | removed          | vc-dir-status-edited        |
> | conflict         | vc-dir-status-warning       |
> | missing          | vc-dir-status-warning       |
> | ignored          | vc-dir-ignored              |
> | unregistered     | vc-dir-status-edited        |

Looks good.

> With regard to 'vc-dir-ignored', do you think we should rename it to
> 'vc-dir-status-ignored' for the sake of consistency?

Yes, probably. Let's see how your discussion with Juri ends up.

But if the only one use of this face is related to stashes, perhaps 
introduce a stash-specific face instead.