GNU bug report logs - #46342
28.0.50; socks-send-command munges IP address bytes to UTF-8

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: "J.P." <jp <at> neverwas.me>
Cc: 46342 <at> debbugs.gnu.org
Subject: bug#46342: 28.0.50; socks-send-command munges IP address bytes to UTF-8
Date: Wed, 10 Feb 2021 18:04:56 +0200

> From: "J.P." <jp <at> neverwas.me>
> Cc: 46342 <at> debbugs.gnu.org
> Date: Wed, 10 Feb 2021 05:16:58 -0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > what kind of string can this ADDRESS be? My reading of RFC 1928 is
> > that it normally is an IP address, in which case encoding is not
> > relevant, as it's an ASCII string. But it can also be a domain, right?
> 
> This patch only affects IP addresses, but I'm happy to look into the
> domain name form as well.

Then I don't understand why we need to worry about encoding.  IP
addresses are pure ASCII strings, so they need no encoding whatsoever.

I guess I will have to ask you to back up and describe what problems
you saw with the original code, and show me the details of the strings
involved in that.

Thanks for the rest of your message, but I suggest that we limit
ourselves to IP addresses for the time being, and only go to non-ASCII
domains when we have the IP address use case figured out.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.