GNU bug report logs - #46313
[PATCH] gnu: Add chiaki.

Previous Next

Full log

Message #8 received at 46313 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Léo Le Bouter <lle-bout <at> zaclys.net>
Cc: 46313 <at> debbugs.gnu.org
Subject: Re: [bug#46313] [PATCH] gnu: Add chiaki.
Date: Sun, 07 Feb 2021 10:43:41 +0100

Hello,

Léo Le Bouter via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/games.scm (chiaki): New variable.

Thank you. Some comments follow.

> +             (recursive? #t)))

Do you know what sub-modules are being pulled? Could we unbundle them
instead?

> +    (synopsis "Free and Open Source PlayStation Remote Play Client")

Please remove "Free" and "Open Source": everything is in Guix. Also,
synopsis should not use titlecase:

    "PlayStation Remote Play client"

> +    (description "Chiaki is a Free and Open Source Software Client for
> +PlayStation 4 and PlayStation 5 Remote Play.")

See above. Also, couldyou expound a bit the description?

> +    (license
> +     (license:fsdg-compatible

It should be fsf-free instead of fsdg-compatible.

> +      "file://LICENSES/AGPL-3.0-only-OpenSSL.txt"
> +      "AGPL-3.0-only-OpenSSL"))))

I think the correct string would be "AGPL-3.0 WITH OpenSSL exception"
but I wonder if Guix cares about the exception.

Could you send an updated patch?


Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.