From unknown Sat Aug 09 12:59:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#46302 <46302@debbugs.gnu.org> To: bug#46302 <46302@debbugs.gnu.org> Subject: Status: 28.0.50; cperl-mode cleanup: Eliminate dead code Reply-To: bug#46302 <46302@debbugs.gnu.org> Date: Sat, 09 Aug 2025 19:59:18 +0000 retitle 46302 28.0.50; cperl-mode cleanup: Eliminate dead code reassign 46302 emacs submitter 46302 haj@posteo.de (Harald J=C3=B6rg) severity 46302 normal tag 46302 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 14:21:58 2021 Received: (at submit) by debbugs.gnu.org; 4 Feb 2021 19:21:58 +0000 Received: from localhost ([127.0.0.1]:42269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7kCT-0008Uo-V8 for submit@debbugs.gnu.org; Thu, 04 Feb 2021 14:21:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:58020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7kCR-0008Ug-Tg for submit@debbugs.gnu.org; Thu, 04 Feb 2021 14:21:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7kCR-0008E0-93 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 14:21:55 -0500 Received: from mout02.posteo.de ([185.67.36.66]:51199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7kCO-00076n-41 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 14:21:54 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 24D832400FB for ; Thu, 4 Feb 2021 20:21:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1612466508; bh=AbXL6/MwLIj1qcN2gMItBqsKCdBhtKaSySZxYc5XY9A=; h=From:To:Subject:Date:From; b=W3AvQhnVo4IG85egEC68UsISK8ctAq74GnXMiKCQ2U0mXM7FomBqADcV9ZHUOhNKS prp/Bf9WqhZBj/5M9S6q8TmuZKYvjnEsEqvR02R+7wKK7wBjxvYos6/RmQLAlc3j7J iKJVfD34ZFvkM50fh5aKfISboggl3Rm/LL1zK8hV2rkxRiTz2E3me9mGFKhmiqZKq0 0qKerH1ewVgwzPAZRyQD4hkIbDXAMU4YM0B9X37UIHjCa5qa+3U0ElBnUF9JER/oFv xltJWFPc7Kp4TpHsSagJxytkg808WESAmQJaUXlELnrU7E1arEvPHVttvC7IcQrmrX WA92gPOveE77Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DWpMH354pz6tmV for ; Thu, 4 Feb 2021 20:21:47 +0100 (CET) From: haj@posteo.de (Harald =?utf-8?Q?J=C3=B6rg?=) To: bug-gnu-emacs@gnu.org Subject: 28.0.50; cperl-mode cleanup: Eliminate dead code User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Thu, 04 Feb 2021 20:21:46 +0100 Message-ID: <87tuqrtz91.fsf@hajtower> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=haj@posteo.de; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain In two places, CPerl mode checks whether `syntax-propertize-rules` is fboundp, which is always true as of today. The attached patch eliminates this check and the corresponding "else"-Branches. Also, an (undocumented) debug trace doesn't work in current Emacs because the function `edebug-backtrace` was eliminated, so this call is removed by the patch. Finally, a workaround to set `font-lock-syntactic-keywords` is no longer needed. This eliminates a warning when compiling cperl-mode.el under current Emacs. -- Cheers, haj --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-cperl-mode-eliminate-dead-code.patch Content-Description: cperl-mode cleanup: Eliminate dead code >From cf9c369726819c1261e06a5f273c11b0a34b8576 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harald=20J=C3=B6rg?= Date: Thu, 4 Feb 2021 20:10:03 +0100 Subject: [PATCH] ; cperl-mode: eliminate dead code * lisp/progmodes/cperl-mode.el (cperl-update-syntaxification): Eliminate check for `syntax-propertize-rules` (always true) and eliminate unused first parameter. (cperl-mode): Eliminate obsolete `font-lock-syntactic-keywords`, Eliminate check for `syntax-propertize-rules` (always true). (cperl-fontify-syntaxically): Eliminate call to no-longer-existing function `edebug-backtrace`. --- lisp/progmodes/cperl-mode.el | 90 ++++++++++++------------------------ 1 file changed, 29 insertions(+), 61 deletions(-) diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index d401513646..a70e8e36c0 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -1157,25 +1157,25 @@ cperl-old-style (get-text-property (point-min) 'in-pod) (< (progn (and cperl-syntaxify-for-menu - (cperl-update-syntaxification (point-max) (point-max))) + (cperl-update-syntaxification (point-max))) (next-single-property-change (point-min) 'in-pod nil (point-max))) (point-max)))] ["Ispell HERE-DOCs" cperl-here-doc-spell (< (progn (and cperl-syntaxify-for-menu - (cperl-update-syntaxification (point-max) (point-max))) + (cperl-update-syntaxification (point-max))) (next-single-property-change (point-min) 'here-doc-group nil (point-max))) (point-max))] ["Narrow to this HERE-DOC" cperl-narrow-to-here-doc (eq 'here-doc (progn (and cperl-syntaxify-for-menu - (cperl-update-syntaxification (point) (point))) + (cperl-update-syntaxification (point))) (get-text-property (point) 'syntax-type)))] ["Select this HERE-DOC or POD section" cperl-select-this-pod-or-here-doc (memq (progn (and cperl-syntaxify-for-menu - (cperl-update-syntaxification (point) (point))) + (cperl-update-syntaxification (point))) (get-text-property (point) 'syntax-type)) '(here-doc pod))] "----" @@ -1659,36 +1659,18 @@ cperl-mode nil nil ((?_ . "w")))) ;; Reset syntaxification cache. (setq-local cperl-syntax-state nil) - (if cperl-use-syntax-table-text-property - (if (eval-when-compile (fboundp 'syntax-propertize-rules)) - (progn - ;; Reset syntaxification cache. - (setq-local cperl-syntax-done-to nil) - (setq-local syntax-propertize-function - (lambda (start end) - (goto-char start) - ;; Even if cperl-fontify-syntaxically has already gone - ;; beyond `start', syntax-propertize has just removed - ;; syntax-table properties between start and end, so we have - ;; to re-apply them. - (setq cperl-syntax-done-to start) - (cperl-fontify-syntaxically end)))) - ;; Do not introduce variable if not needed, we check it! - (setq-local parse-sexp-lookup-properties t) - ;; Our: just a plug for wrong font-lock - (setq-local font-lock-unfontify-region-function - ;; not present with old Emacs - #'cperl-font-lock-unfontify-region-function) - ;; Reset syntaxification cache. - (setq-local cperl-syntax-done-to nil) - (setq-local font-lock-syntactic-keywords - (if cperl-syntaxify-by-font-lock - '((cperl-fontify-syntaxically)) - ;; unless font-lock-syntactic-keywords, font-lock (pre-22.1) - ;; used to ignore syntax-table text-properties. (t) is a hack - ;; to make font-lock think that font-lock-syntactic-keywords - ;; are defined. - '(t))))) + (when cperl-use-syntax-table-text-property + ;; Reset syntaxification cache. + (setq-local cperl-syntax-done-to nil) + (setq-local syntax-propertize-function + (lambda (start end) + (goto-char start) + ;; Even if cperl-fontify-syntaxically has already gone + ;; beyond `start', syntax-propertize has just removed + ;; syntax-table properties between start and end, so we have + ;; to re-apply them. + (setq cperl-syntax-done-to start) + (cperl-fontify-syntaxically end)))) (setq cperl-font-lock-multiline t) ; Not localized... (setq-local font-lock-multiline t) (setq-local font-lock-fontify-region-function @@ -2405,7 +2387,7 @@ cperl-indent-command so that this line becomes properly indented. The relative indentation among the lines of the expression are preserved." (interactive "P") - (cperl-update-syntaxification (point) (point)) + (cperl-update-syntaxification (point)) (if whole-exp ;; If arg, always indent this line as Perl ;; and shift remaining lines of expression the same amount. @@ -2533,7 +2515,7 @@ cperl-beginning-of-property (defun cperl-sniff-for-indent (&optional parse-data) ; was parse-start ;; the sniffer logic to understand what the current line MEANS. - (cperl-update-syntaxification (point) (point)) + (cperl-update-syntaxification (point)) (let ((res (get-text-property (point) 'syntax-type))) (save-excursion (cond @@ -3025,7 +3007,7 @@ cperl-to-comment-or-eol ;; then looks for literal # or end-of-line. (let (state stop-in cpoint (lim (point-at-eol)) pr e) (or cperl-font-locking - (cperl-update-syntaxification lim lim)) + (cperl-update-syntaxification lim)) (beginning-of-line) (if (setq pr (get-text-property (point) 'syntax-type)) (setq e (next-single-property-change (point) 'syntax-type nil (point-max)))) @@ -4640,7 +4622,7 @@ cperl-after-expr-p `}' is treated \"smartly\" if it is not in the list)." (let ((lim (or lim (point-min))) stop p) - (cperl-update-syntaxification (point) (point)) + (cperl-update-syntaxification (point)) (save-excursion (while (and (not stop) (> (point) lim)) (skip-chars-backward " \t\n\f" lim) @@ -5027,7 +5009,7 @@ cperl-indent-region If `cperl-indent-region-fix-constructs', will improve spacing on conditional/loop constructs." (interactive "r") - (cperl-update-syntaxification end end) + (cperl-update-syntaxification end) (save-excursion (let (cperl-update-start cperl-update-end (h-a-c after-change-functions)) (let ((indent-info (list nil nil nil) ; Cannot use '(), since will modify @@ -5233,7 +5215,7 @@ cperl-imenu--create-perl-index packages ends-ranges p marker is-proto is-pack index index1 name (end-range 0) package) (goto-char (point-min)) - (cperl-update-syntaxification (point-max) (point-max)) + (cperl-update-syntaxification (point-max)) ;; Search for the function (progn ;;save-match-data (while (re-search-forward @@ -8209,7 +8191,7 @@ cperl-map-pods-heres (or prop (setq prop 'in-pod)) (or s (setq s (point-min))) (or end (setq end (point-max))) - (cperl-update-syntaxification end end) + (cperl-update-syntaxification end) (save-excursion (goto-char (setq pos s)) (while (and cont (< pos end)) @@ -8225,7 +8207,7 @@ cperl-get-here-doc-region Return nil if the point is not in a HERE document region. If POD is non-nil, will return a POD section if point is in a POD section." (or pos (setq pos (point))) - (cperl-update-syntaxification pos pos) + (cperl-update-syntaxification pos) (if (or (eq 'here-doc (get-text-property pos 'syntax-type)) (and pod (eq 'pod (get-text-property pos 'syntax-type)))) @@ -8295,7 +8277,7 @@ cperl-time-fontification (forward-line step) (setq l (+ l step)) (setq c (1+ c)) - (cperl-update-syntaxification (point) (point)) + (cperl-update-syntaxification (point)) (setq delta (- (- tt (setq tt (funcall timems)))) tot (+ tot delta)) (message "to %s:%6s,%7s" l delta tot)) tot)) @@ -8405,19 +8387,12 @@ cperl-font-lock-fontify-region-function (setq end (point))) (font-lock-default-fontify-region beg end loudly)) -(defvar cperl-d-l nil) -(defvar edebug-backtrace-buffer) ;FIXME: Why? (defun cperl-fontify-syntaxically (end) ;; Some vars for debugging only ;; (message "Syntaxifying...") (let ((dbg (point)) (iend end) (idone cperl-syntax-done-to) (istate (car cperl-syntax-state)) - start from-start edebug-backtrace-buffer) - (if (eq cperl-syntaxify-by-font-lock 'backtrace) - (progn - (require 'edebug) - (let ((f 'edebug-backtrace)) - (funcall f)))) ; Avoid compile-time warning + start from-start) (or cperl-syntax-done-to (setq cperl-syntax-done-to (point-min) from-start t)) @@ -8473,16 +8448,9 @@ cperl-after-change-function (if cperl-syntax-done-to (setq cperl-syntax-done-to (min cperl-syntax-done-to beg)))) -(defun cperl-update-syntaxification (from to) - (cond - ((not cperl-use-syntax-table-text-property) nil) - ((fboundp 'syntax-propertize) (syntax-propertize to)) - ((and cperl-syntaxify-by-font-lock - (or (null cperl-syntax-done-to) - (< cperl-syntax-done-to to))) - (save-excursion - (goto-char from) - (cperl-fontify-syntaxically to))))) +(defun cperl-update-syntaxification (to) + (when cperl-use-syntax-table-text-property + (syntax-propertize to))) (defvar cperl-version (let ((v "Revision: 6.2")) -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 14:53:10 2021 Received: (at 46302) by debbugs.gnu.org; 4 Feb 2021 19:53:10 +0000 Received: from localhost ([127.0.0.1]:42301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7kgg-0000n8-7j for submit@debbugs.gnu.org; Thu, 04 Feb 2021 14:53:10 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7kgd-0000mY-8D for 46302@debbugs.gnu.org; Thu, 04 Feb 2021 14:53:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mjpGW13iBwhE2r2qQSddqpFIwjDE/ODmVkvSR3/1Foc=; b=PkhnwursdZCzVyWvZBA7e5b4LV KQeQkDkSnaWYSuhjYlRLnhgqU72z/E+/svw3SinS7zv/QJCzLAV/LfUjTr+S/NxUvCp9YujqFygz3 HOrgSAuKams86C/H/P6XrnYBNoffT5v71mjC1oFKFQDkTAXjjcjStQSdqza44BAubJTU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7kgS-0002RH-Jm; Thu, 04 Feb 2021 20:53:00 +0100 From: Lars Ingebrigtsen To: haj@posteo.de (Harald =?utf-8?Q?J=C3=B6rg?=) Subject: Re: bug#46302: 28.0.50; cperl-mode cleanup: Eliminate dead code References: <87tuqrtz91.fsf@hajtower> X-Now-Playing: Breathless's _Sonora 1-90_: "I never know where you are" Date: Thu, 04 Feb 2021 20:52:55 +0100 In-Reply-To: <87tuqrtz91.fsf@hajtower> ("Harald =?utf-8?Q?J=C3=B6rg=22's?= message of "Thu, 04 Feb 2021 20:21:46 +0100") Message-ID: <878s83objc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: haj@posteo.de (Harald Jörg) writes: > Finally, a workaround to set `font-lock-syntactic-keywords` is no longer > needed. This eliminates a warning when compiling cperl-mode.el under > current Emacs. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46302 Cc: 46302@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) haj@posteo.de (Harald J=C3=B6rg) writes: > Finally, a workaround to set `font-lock-syntactic-keywords` is no longer > needed. This eliminates a warning when compiling cperl-mode.el under > current Emacs. I don't get any warnings when compiling cperl-mode.el? Anyway, the patch looks good to me, so I've applied it to Emacs 28. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 14:53:14 2021 Received: (at control) by debbugs.gnu.org; 4 Feb 2021 19:53:15 +0000 Received: from localhost ([127.0.0.1]:42306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7kgk-0000nS-Ih for submit@debbugs.gnu.org; Thu, 04 Feb 2021 14:53:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7kgj-0000mz-9K for control@debbugs.gnu.org; Thu, 04 Feb 2021 14:53:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q4SlPJa41+d3lYfv8PIMWhU8xU/s2gffy+6rsmJ5oxY=; b=hW/m7V2SHKlJCnWj7o8jO4KaN4 xyx2aRcuX4KOnaJSXKNJ6pTtfWGE6lqDDVOoRwcQpmhSDofP0gLuS8LbbSGjia7T08FRHBn4q8G6/ wuL0dzMTszrx33VEYJxjwH6Tjuy/P9gdpeFGh6iajpEMQbU1DnLPPUKZx0+Qaxbuc0xY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7kgb-0002RQ-EI for control@debbugs.gnu.org; Thu, 04 Feb 2021 20:53:07 +0100 Date: Thu, 04 Feb 2021 20:53:04 +0100 Message-Id: <877dnnobj3.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #46302 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 46302 fixed close 46302 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 46302 fixed close 46302 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 17:28:40 2021 Received: (at 46302) by debbugs.gnu.org; 4 Feb 2021 22:28:40 +0000 Received: from localhost ([127.0.0.1]:42408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7n79-0006Yv-SG for submit@debbugs.gnu.org; Thu, 04 Feb 2021 17:28:40 -0500 Received: from mout01.posteo.de ([185.67.36.65]:40194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7n76-0006Ye-4J for 46302@debbugs.gnu.org; Thu, 04 Feb 2021 17:28:38 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9914E16005C for <46302@debbugs.gnu.org>; Thu, 4 Feb 2021 23:28:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1612477709; bh=Al6ZTqnhlTt0W0AjeLCZHjacSdWwsj1G1cH6Y803A1w=; h=From:To:Cc:Subject:Date:From; b=Z5jsTYiqC030YabgXUtkRraWeaM3traIUiJj8Xs+VnutrmPphu+bSvmzFdKPcI5Nc tGfJpeTwLWq7JzQIx+V5p8R6XhxG7DWPdx4qqL62XDCYIxlb5GZdXuSMy5lKLyFT5P iNqTB161plRs5Gmj6P5CWVOItfg4ZG+8u9jYGnzl4BR4HVrvlHbScO4R0FDh6FUOdp R3uF76UjwvxxRRso6AGjE/e4tqn1H9T5STVrVo/vJhhBPW0qnwbxx980jWMwO2eC7i 2pUSYUyez7IDlrfN/LGw+pXBgWiL3gstM1H5n6YoDj+8Xf+7mFGOKxOf8QoPdnXi0j U9r4rZngeC4lA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DWtVh6dBsz9rxH; Thu, 4 Feb 2021 23:28:28 +0100 (CET) From: haj@posteo.de (Harald =?utf-8?Q?J=C3=B6rg?=) To: Lars Ingebrigtsen Subject: Re: bug#46302: 28.0.50; cperl-mode cleanup: Eliminate dead code In-Reply-To: <878s83objc.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 04 Feb 2021 20:52:55 +0100") References: <87tuqrtz91.fsf@hajtower> <878s83objc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Thu, 04 Feb 2021 23:28:28 +0100 Message-ID: <87o8gztqlv.fsf@hajtower> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46302 Cc: 46302@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > haj@posteo.de (Harald J=C3=B6rg) writes: > >> Finally, a workaround to set `font-lock-syntactic-keywords` is no longer >> needed. This eliminates a warning when compiling cperl-mode.el under >> current Emacs. > > I don't get any warnings when compiling cperl-mode.el? Ooops... Me neither. I seem to recall a warning in the *Compile-Log* buffer that `font-lock-syntactic.keywords' is an obsolete variable. However, I can't reproduce it :( Did I hallucinate? I had a look: The variable _is_ obsolete as of font-lock.el: (make-obsolete-variable 'font-lock-syntactic-keywords 'syntax-propertize-function "24.1") Isn't `make-obsolete-variable` supposed to generate a compiler warning? Or maybe I found the warning in C-h v font-lock-syntactic-keywords? I'm confused. > Anyway, the patch looks good to me, so I've applied it to Emacs 28. Thanks! --=20 Cheers, haj From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 05 03:57:53 2021 Received: (at 46302) by debbugs.gnu.org; 5 Feb 2021 08:57:53 +0000 Received: from localhost ([127.0.0.1]:42732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ww5-0007Oz-Cl for submit@debbugs.gnu.org; Fri, 05 Feb 2021 03:57:53 -0500 Received: from quimby.gnus.org ([95.216.78.240]:38462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ww3-0007Ok-EU for 46302@debbugs.gnu.org; Fri, 05 Feb 2021 03:57:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=U8vVauVgGDSeXOfWdKVZXQlTDBurt4JMTEO18q/70MA=; b=pIdBWiYC+pwQc00mWYInJ9hMzA I3MEGXHMxr9m60p+X1gjEg4WVRZDmYWCe3RFSbHU3ayzdyFRRQ2ZH8bfut5Gl42kwTpU3B0KRSDHP QMTg2sqidHZyq9Xd/FwgFVrqOr6ap9dTJZMxsxE/6+q67cPwiszXc9hmJsdwhpPAV4G4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7wvt-0000dY-Ea; Fri, 05 Feb 2021 09:57:45 +0100 From: Lars Ingebrigtsen To: haj@posteo.de (Harald =?utf-8?Q?J=C3=B6rg?=) Subject: Re: bug#46302: 28.0.50; cperl-mode cleanup: Eliminate dead code References: <87tuqrtz91.fsf@hajtower> <878s83objc.fsf@gnus.org> <87o8gztqlv.fsf@hajtower> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEVbJYRgJoR8UYKM fm5ROkbY1sf///8tWHUmAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UCBQgeLC/JgUcAAAGqSURBVDjL bZRdloMgDIVh2nkH7bxXOzsgvncOuAKa/W9lkhtQ+5NzaCUfNzei6Nwh/P4fjnkXkQ3O+xjdW0gy duDDMa9EgXev5aIzBRYEW7eHKGaNq4xBxoTZ5BVgHodhGuIwhRjnWd1da/lwC5oxD+fjlgzOdw/r xeILKQMoFOb5djP7UW12xSCWszYwDdNTqT2C+wD6dnxQ+OCDfwLSseSwryYT3/IevwrG9zwVgCwX r6HgnBrIG88AJ81kTK2MzPMVpSj1lQQutf9UkVJaayvRRUEVKdHCdOggZyjGnIiZbCVXU6rHWVZU XlAoG2jmJWVmtiJcCSvuAi7SnZVSwI9SpEmU2jxKWXh5aLcpAJAkagP8QNPN/ADSAxd3eWNOopA8 bm6Fh/St4KKAKTfzouYEQK2Zst1HyXd5qCNAk/T2gseWJFaTDHeT6muouyv7KAMKq6WlvmsDNSe5 D4afbokB+SHuUYpu+w9KMWErLSrAaHUSrbxLDCxVkTxGXqu52BOUa4CV69LtTUFLURsBNfEOhtmi /+M4f/qWtO+JnlXfjoN+UmTYmfoHNuavkJlx2q0AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDIt MDVUMDg6MzA6NDQrMDA6MDCmvUZQAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAyLTA1VDA4OjMw OjQ0KzAwOjAw1+D+7AAAAABJRU5ErkJggg== X-Now-Playing: Shirley & Dolly Collins's _Harking Back_: "Hopping Down In Kent" Date: Fri, 05 Feb 2021 09:57:40 +0100 In-Reply-To: <87o8gztqlv.fsf@hajtower> ("Harald =?utf-8?Q?J=C3=B6rg=22's?= message of "Thu, 04 Feb 2021 23:28:28 +0100") Message-ID: <871rdunb7f.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: haj@posteo.de (Harald Jörg) writes: > Did I hallucinate? I had a look: The variable _is_ obsolete as of > font-lock.el: > > (make-obsolete-variable 'font-lock-syntactic-keywords > 'syntax-propertize-function "24.1") > > Isn't `make-obso [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46302 Cc: 46302@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) haj@posteo.de (Harald J=C3=B6rg) writes: > Did I hallucinate? I had a look: The variable _is_ obsolete as of > font-lock.el: > > (make-obsolete-variable 'font-lock-syntactic-keywords > 'syntax-propertize-function "24.1") > > Isn't `make-obsolete-variable` supposed to generate a compiler warning? It is supposed to, but somehow it didn't... I just tried putting a (setq-local font-lock-syntactic-keywords (if cperl-syntaxify-by-font-lock '((cperl-fontify-syntaxically)) into the function, and I got a=20 cperl-mode.el:1678:15: Warning: =E2=80=98font-lock-syntactic-keywords=E2=80= =99 is an obsolete variable (as of 24.1); use =E2=80=98syntax-propertize-function=E2=80=99= instead. as expected. Hm... perhaps it's because of this? - (if cperl-use-syntax-table-text-property - (if (eval-when-compile (fboundp 'syntax-propertize-rules)) - (progn And the compiler got confused and didn't output a warning (always)? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 05 05:54:49 2021 Received: (at 46302) by debbugs.gnu.org; 5 Feb 2021 10:54:49 +0000 Received: from localhost ([127.0.0.1]:42956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ylF-0008Li-84 for submit@debbugs.gnu.org; Fri, 05 Feb 2021 05:54:49 -0500 Received: from mout02.posteo.de ([185.67.36.66]:56567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ylC-0008LU-3c for 46302@debbugs.gnu.org; Fri, 05 Feb 2021 05:54:47 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id BD3D7240103 for <46302@debbugs.gnu.org>; Fri, 5 Feb 2021 11:54:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1612522478; bh=dTmWvKUmGhiPQ9U3beph6OHxKcFE0pnCDKexu08Em1w=; h=From:To:Cc:Subject:Date:From; b=WZScHoftQK43BfBOzj9D8IHEKBpxzy+fFQVMZw+FQQ953gzxuZ4j2yNH48+0pokVf rU8HzvN6bt05PX8/A2yhjiLJ6yXxTkCtIvrBoPO3b/zZ3v6Q5+grPiB2hNQr/M5kkv WWbo4vFEH7z2OSdO11ZzTZdfUlOEzdMqu+s7rxlaDgBse4My3CmYiCcfWCLVC11rc8 vWiBAxHsxX0BXGhPkbya4m44Rp2SJI3DtEQzgys03DGcPQmQntw7ZhwGJ3WLVFASe/ OUL82Vj3vHOforIvX/yrG7nOo34zUfXz7kEUmXiIJvwhf85DaC3rtW8E8108IL2vHL SNMoE73l6VY+Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DXC3d5dCFz6tmV; Fri, 5 Feb 2021 11:54:37 +0100 (CET) From: haj@posteo.de (Harald =?utf-8?Q?J=C3=B6rg?=) To: Lars Ingebrigtsen Subject: Re: bug#46302: 28.0.50; cperl-mode cleanup: Eliminate dead code In-Reply-To: <871rdunb7f.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 05 Feb 2021 09:57:40 +0100") References: <87tuqrtz91.fsf@hajtower> <878s83objc.fsf@gnus.org> <87o8gztqlv.fsf@hajtower> <871rdunb7f.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Fri, 05 Feb 2021 11:54:37 +0100 Message-ID: <871rdueqdu.fsf@hajtower> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 46302 Cc: 46302@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: >> Isn't `make-obsolete-variable` supposed to generate a compiler warning? > > It is supposed to, but somehow it didn't... [...] > > Hm... perhaps it's because of this? > > - (if cperl-use-syntax-table-text-property > - (if (eval-when-compile (fboundp 'syntax-propertize-rules)) > - (progn > > And the compiler got confused and didn't output a warning (always)? Ah, that reminds me of something... I did the elimination in several steps, and in one of them killed the conditional and the if-branch, but forget to kill the else-branch as well. Apparently I ran the first compilation test with that (bogus) intermediate version, and got the warning. As it turns out, the byte compiler shortcuts the conditional if it eval-when-compiles to a constant and doesn't even touch the else-branch. Digging into the commit logs reveals: commit 4813c453b22ff7b965e31a30d35b70f73d6bcbc7 Author: Stefan Monnier Date: Sun Feb 3 10:47:12 2013 -0500 * lisp/progmodes/cperl-mode.el (cperl-mode): Avoid byte-compile warning. Now it all makes sense :) -- Cheers, haj From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 05 06:03:39 2021 Received: (at 46302) by debbugs.gnu.org; 5 Feb 2021 11:03:39 +0000 Received: from localhost ([127.0.0.1]:42960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ytn-000087-4V for submit@debbugs.gnu.org; Fri, 05 Feb 2021 06:03:39 -0500 Received: from quimby.gnus.org ([95.216.78.240]:39934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7yti-00007p-EK for 46302@debbugs.gnu.org; Fri, 05 Feb 2021 06:03:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bWzuzdwyeueYoDkAfEc65Q287sco2me7Ap7lR4kmskQ=; b=APVvi8zHjSJSwf7orDBsFzBQMk NPDOWM1SQZieq7R80tsTsz8N1SEDTRj7GriT4Zj/FkZK2kRWiz6f+DMF6SFqUEMpyxeDEdcHp6dsL WMRumgHPAPHjqo4CZZLPKJK6s9qE4O9CICKIEUDs1wPG+1lBympCU6fSebBdy/+hDTQM=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7ytW-0001el-Gx; Fri, 05 Feb 2021 12:03:28 +0100 From: Lars Ingebrigtsen To: haj@posteo.de (Harald =?utf-8?Q?J=C3=B6rg?=) Subject: Re: bug#46302: 28.0.50; cperl-mode cleanup: Eliminate dead code References: <87tuqrtz91.fsf@hajtower> <878s83objc.fsf@gnus.org> <87o8gztqlv.fsf@hajtower> <871rdunb7f.fsf@gnus.org> <871rdueqdu.fsf@hajtower> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUkGRdVIxxoSSek Rh7////0Jn+1AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UCBQsDEP2ML4UAAAGqSURBVDjLjVOBjcMw CIR0AcALGLJAHe+/2x+4SfrSV1+kuNRnDBxnoo+myuQqrKZ9I+YOv4DwDd9gD3hdNcK89wphEsIp FqHOLJp/6X9j25zc/0AKiC+uQPLN3DMpknMW/yqXgs0DXUQ3lLoxFjurqjOKKoVRdvBXmb6wu2t+ 31TVG7jc2nwDhq4wfPx8p2kMLGITDe7z2pV1A7c5n/SYU+5rsee2zzmH7HOorPSoYp52wEW+E5iD saGxzwDYsuKkCIDKpmLhHHOYPi8AkUZmmzUAxEcCWgR4RhvpfmRJjUZOhmo67MLCyIykDx2OoeUU uPoQ9JA9boFAX904JxzT90yCwEd0quugSyYLHXMWYLMvzpMXMlSgOwuASNqqSxSOss2tiBjtZAzU OkQNS2A/Lo41HwEmxJxhDZ2eI8QQOSnIpeGhxAncJtoe2o9TAzeQsWt0UgAYyVFK/VyKwDnsjCI6 D4K7FyApdtyi9c6yFl2Cg5f0AuN6jJe4as45OD1VqUtoda/Kegt1mhdX8hrxLWldrpSA26VzJv2l +tt9U/aHh8IlDCq1/GM/Y+AwNiS2qcAAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDItMDVUMTE6 MDM6MTUrMDA6MDAgZXUcAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAyLTA1VDExOjAzOjE1KzAw OjAwUTjNoAAAAABJRU5ErkJggg== X-Now-Playing: Mia Doi Todd & Company's _Music for A Midsummer Night's Dream_: "Philomel with Melody" Date: Fri, 05 Feb 2021 12:03:21 +0100 In-Reply-To: <871rdueqdu.fsf@hajtower> ("Harald =?utf-8?Q?J=C3=B6rg=22's?= message of "Fri, 05 Feb 2021 11:54:37 +0100") Message-ID: <87a6sikc92.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: haj@posteo.de (Harald Jörg) writes: > Now it all makes sense :) Yup. :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46302 Cc: 46302@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) haj@posteo.de (Harald J=C3=B6rg) writes: > Now it all makes sense :) Yup. :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Aug 09 12:59:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Mar 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator