GNU bug report logs - #46299
28.0.50; Value of tab-bar-show not respected in new frames.

Previous Next

Full log

Message #32 received at 46299 <at> debbugs.gnu.org (full text, mbox):

From: Bastian Beranek <bastian.beischer <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 46299 <at> debbugs.gnu.org
Subject: Re: bug#46299: 28.0.50;
 Value of tab-bar-show not respected in new frames.
Date: Mon, 8 Feb 2021 20:04:59 +0100

[Message part 1 (text/plain, inline)]

Hello Juri,

On Mon, Feb 8, 2021 at 7:23 PM Juri Linkov <juri <at> linkov.net> wrote:
>
> Hello Bastian,
>
> > I have tried to clean up my patch a bit more, please see the attached version 3.
>
> Thanks, everything looks right, except one thing that you removed
> the most important rule:
>
> > -    (cond
> > -     ((eq tab-bar-show t)
> > -      (tab-bar-mode 1))
>
> This is the core reason of existence of tab-bar-show separate from tab-bar-mode:
> when the user creates a new tab, the tab-bar should be activated,
> unless the user has customized tab-bar-show to nil.
>
> Actually, a more proper condition should be:
>
>   (when tab-bar-show
>     (tab-bar-mode 1))
>
> and then after that you can use the remaining code:
>
> > +    ;; Recalculate tab-bar-lines and update frames
> > +    (tab-bar--update-tab-bar-lines (selected-frame))
> > +    (when tab-bar-mode
> > +      (tab-bar--load-buttons)
> > +      (tab-bar--define-keys))
>
> In tab-bar-close-other-tabs:
>
> > +      ;; Recalculate tab-bar-lines and update frames
> > +      (tab-bar--update-tab-bar-lines)
>
> It could affect only the selected frame too, i.e.:
> (tab-bar--update-tab-bar-lines (selected-frame))

Thank you for your comments. I have updated the patch according to
your suggestions. If it looks fine to you now, could you install it
for me?

Best
Bastian

[tab-bar_v4.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.