GNU bug report logs - #46290
28.0.50; repeat's ability to repeat complex commands is broken

Previous Next

Full log

View this message in rfc822 format

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Gregory Heytings <gregory <at> heytings.org>, 46290 <at> debbugs.gnu.org
Subject: bug#46290: 28.0.50; repeat's ability to repeat complex commands is broken
Date: Thu, 04 Feb 2021 10:47:22 -0700

[Message part 1 (text/plain, inline)]

On Thu 04 Feb 2021 at 08:30AM GMT, Gregory Heytings wrote:

>>
>> But secondly, it doesn't seem like the "Repeating %S" branch works at 
>> all.  For if you type M-! date RET C-x z then you get prompted for a 
>> shell command, rather than date(1) just getting executed again right 
>> away.
>>
>> I added some debug printing to `repeat' and found that after M-! date 
>> RET, last-repeatable-command is set to shell-command, not 
>> exit-minibuffer.  So perhaps the way that last-repeatable-command gets 
>> set has changed since this code in repeat.el was written?
>>
>
> FWIW, the answer to that question seems to be positive.  In Emacs 21 M-! 
> date RET C-x z repeats "date" without prompting again, in later Emacsen 
> you get prompted again for a shell command.

Ah, thanks for testing.

One possible fix is attached.  It has the advantage of removing the list
which needs to be kept updated, so it works immediately for repeating
M-z and M-:

-- 
Sean Whitton

[0001-lisp-repeat.el-repeat-Fix-repeating-complex-commands.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.