From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 02:55:38 2021 Received: (at submit) by debbugs.gnu.org; 4 Feb 2021 07:55:38 +0000 Received: from localhost ([127.0.0.1]:39572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ZUH-00084Y-92 for submit@debbugs.gnu.org; Thu, 04 Feb 2021 02:55:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:40980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ZUF-00084P-44 for submit@debbugs.gnu.org; Thu, 04 Feb 2021 02:55:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7ZUD-0004SO-Jj for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 02:55:34 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:54787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7ZU7-0002oz-Sm for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 02:55:33 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7BB96DF3 for ; Thu, 4 Feb 2021 02:55:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 04 Feb 2021 02:55:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:subject:date:message-id:mime-version:content-type; s= fm2; bh=zZfuIhV/WRMw1kRTqamXQU81YAwOuGlAWCq2DoyTMmQ=; b=wqRWn5Vp pftoZDTjoZizHLE/J+n5KyQ3mHbzaMaI7nSAj/1yNlFSg28mxii4+Xm0rwH4E6jr LxoIkqeo00LhaCDHkP3dB0PVtgOzIWyyjWFjASvQJpOWKGV+TbLX3IIiQafKLzu5 5udONb7L4RkhaqXZ+1NB2r/JVtFDNCEpkReFOhEBMFfltX6wf2XIGDyY7JYu73si qhXjW5VngrlHr45HyzT7wI0ktziGw0FOokMy4NVD6oo+XL6JuUSeufhLDPV+whzb dpic1rZX4yFM32vTMGHvb2gGf5bsr7CX07cLg2q1gmyMa7Em8PZVpo13z2Xq2Yei 8unAUNoRVYWjuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=zZfuIhV/WRMw1kRTqamXQU81YAwOu GlAWCq2DoyTMmQ=; b=sTIH/46txVCzXACgNXvLHUVBAymwGFaX8aZVoDXGrhCYH sm0ps6VmxAmmpOnN5jnciAwMycjN2fTKigW9qZRkCnmuhjPPF2qIvvqAWMJTuSZT rcR7WTaVwagJRTkj8XIf2XVIMJiUjXnDJSPH68HXDxnu/3DzwURufDOph5PqhPVa v+9o9w/uLbwswXFqD1PG19Ss8ovwnvLcDQPe0A6kB6h3blQolchH/aPRicF7Mmni dWjHNaCZT08UVGjkbR0dPwuMNND7Y0642IdLndwfThj5QgH3bAsVuksuAY2Ay2OI nDvZJMJFFyeVxOH6doGXEIKN/nWlv9O9Jx7i50xdQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeefgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehttdertddttd dtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphif hhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepleelgeejhedvheeghefgfe egvdfhvdefffefheejtdegfeehffeitdefteejueehnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtth honhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 28.0.50; repeat's ability to repeat complex commands is broken Date: Thu, 04 Feb 2021 00:56:14 -0700 Message-ID: <878s844675.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.20; envelope-from=spwhitton@spwhitton.name; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, In the definition of `repeat' there is (if (memq last-repeatable-command '(exit-minibuffer minibuffer-complete-and-exit self-insert-and-exit) (let ((repeat-command (car command-history))) (repeat-message "Repeating %S" repeat-command) (eval repeat-command)) (if (null repeat-arg) (repeat-message "Repeating command %S" last-repeatable-command) (setq current-prefix-arg repeat-arg) (repeat-message "Repeating command %S %S" repeat-arg last-repeatable-command)) ...) In the "Repeating %S" branch, the idea seems to be that if the previous command took minibuffer input, then repeat it again without prompting for input by looking at command-history -- like typing C-x M-: RET. Otherwise, in the "Repeating command %S" branch, just repeat what's in last-repeatable-command. Firstly, I note that there are some additional functions that ought to go into the list of minibuffer-exiting functions -- read-char-from-minibuffer-insert-char and read--expression-try-read are two I've found so far. It's suggested in bug#5264 that this be a defvar. But secondly, it doesn't seem like the "Repeating %S" branch works at all. For if you type M-! date RET C-x z then you get prompted for a shell command, rather than date(1) just getting executed again right away. I added some debug printing to `repeat' and found that after M-! date RET, last-repeatable-command is set to shell-command, not exit-minibuffer. So perhaps the way that last-repeatable-command gets set has changed since this code in repeat.el was written? Or does the "Repeating %S" branch have some completely different purpose? Thanks! -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 03:31:33 2021 Received: (at submit) by debbugs.gnu.org; 4 Feb 2021 08:31:34 +0000 Received: from localhost ([127.0.0.1]:39634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7a33-0004CN-H7 for submit@debbugs.gnu.org; Thu, 04 Feb 2021 03:31:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:46712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7a25-0003LJ-5H for submit@debbugs.gnu.org; Thu, 04 Feb 2021 03:30:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7a24-0004nJ-TK for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 03:30:32 -0500 Received: from heytings.org ([95.142.160.155]:36044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7a22-0002Q9-T0 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 03:30:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1612427428; bh=GwBiWXxPPuETARwFbA5nz39G3ZHEin4xCCKzzo6fMhQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=hx8+Fny3O5jNKtfqKdA1Xnye/ycenzQGAQRIyXs8sKAUAb5p9vv886zIWBUJd8CM0 f7DBbaUrurvDdE5eR1nxvGLajl6yd/2pJAukX6eHkDo4yPIay4v7aEOeb8Tj0Tn2M6 jAf0G8tZ2fAz1OGWA/YKZSh7YXNhcbCNCqJ/6qdhgq5hFi4yiLtiBDmg0QrtnC2wwj pq2QSlt9DaF+SCQBysZzP69I6uSokSkVVy29uIjeUYyNBzlK+0iSycG95FgVCo4IiN uSuT0KAUTiYn0Q22+iVRjlsB/UErXuO0bz6qJutj32mENliF7A4nikPliNVdWtT0tS jdXAAp6vNCf3w== Date: Thu, 04 Feb 2021 08:30:28 +0000 From: Gregory Heytings To: 46290@debbugs.gnu.org Subject: Re: bug#46290: 28.0.50; repeat's ability to repeat complex commands is broken In-Reply-To: <878s844675.fsf@melete.silentflame.com> Message-ID: References: <878s844675.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 04 Feb 2021 03:31:32 -0500 Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > But secondly, it doesn't seem like the "Repeating %S" branch works at > all. For if you type M-! date RET C-x z then you get prompted for a > shell command, rather than date(1) just getting executed again right > away. > > I added some debug printing to `repeat' and found that after M-! date > RET, last-repeatable-command is set to shell-command, not > exit-minibuffer. So perhaps the way that last-repeatable-command gets > set has changed since this code in repeat.el was written? > FWIW, the answer to that question seems to be positive. In Emacs 21 M-! date RET C-x z repeats "date" without prompting again, in later Emacsen you get prompted again for a shell command. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 12:46:43 2021 Received: (at 46290) by debbugs.gnu.org; 4 Feb 2021 17:46:43 +0000 Received: from localhost ([127.0.0.1]:42180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7iiI-00042N-7s for submit@debbugs.gnu.org; Thu, 04 Feb 2021 12:46:43 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:49819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7iiE-000428-Gn for 46290@debbugs.gnu.org; Thu, 04 Feb 2021 12:46:40 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 283825C0060; Thu, 4 Feb 2021 12:46:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 04 Feb 2021 12:46:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=UC37cGE7cunr71SSnrC6RYS8QN 5qBW2p93WnJW429gs=; b=j17vKHiiV6hSRM079mNKb9sxQGVe5TMyfPH+Juv9zT ncQo7ctEWHvAH7zdwn4l6WLEli41i1gU4HMtr+I14cUNtVZ5H8Q9PUPYu9EzJ7S2 l4QWK7jTH8Y7ianJQhBEJscrd2FE17BukegNQCNb0I+2j0n0vCBww/Iw5b0EJORc Qbu+pA2itGuykLOpwvUedm+SEtEZyuhbUESS9yh7ZcVj4Xey/7XuOSiJZHqHg8ZD a7G9sjageZsWcI9C5LI1hgyyPaGLJ1OmMtnlvCoomLePTW0v7q/HStxgWnqaBH3C Sd7e9KHf0dsLJR8Cxv0IizKt9gt1EhoeP63dqbYycMcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=UC37cG E7cunr71SSnrC6RYS8QN5qBW2p93WnJW429gs=; b=Gx95LYDXCOHiQ7J9JwLb0u qXXZ2UR4BFz+piXM1jgRvWaEOobBa809Sax5Pu7QvQWb6I8RWbJHnhTdg0C/3DHl N+shTk+0zzzAj3fx8KFxHgU0J29PL9/nAHbrHqsY0FgGUWZnFBcVNk25Jxb81Q2C c4Yk/sFDadvik+tXAlNBUgdq1ha4Ncx+NXnzlo350mwHjQng/r4na1Ufd7Il5QQ2 Oljvu+aYEiTPMFialo/JYq8ECuf+bcJFFgvRi2MZSqlIRpQoqER/hfxdS0QOGqPO RExsZzdaqs8U/6tjYNRPfNNgtqbiPwFM9dF6J1yMpRNxK8HnrT6QOqxfBHg3VlYQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeggdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehmtderredttddtnecuhfhrohhmpefuvggrnhcuhghh ihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepieffhfffudfhjefgfeeuleeutdevtdektdehiefgieetleevveek geduhedtudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: From: Sean Whitton To: Gregory Heytings , 46290@debbugs.gnu.org Subject: Re: bug#46290: 28.0.50; repeat's ability to repeat complex commands is broken In-Reply-To: References: <878s844675.fsf@melete.silentflame.com> Date: Thu, 04 Feb 2021 10:47:22 -0700 Message-ID: <875z374ted.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 46290 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain On Thu 04 Feb 2021 at 08:30AM GMT, Gregory Heytings wrote: >> >> But secondly, it doesn't seem like the "Repeating %S" branch works at >> all. For if you type M-! date RET C-x z then you get prompted for a >> shell command, rather than date(1) just getting executed again right >> away. >> >> I added some debug printing to `repeat' and found that after M-! date >> RET, last-repeatable-command is set to shell-command, not >> exit-minibuffer. So perhaps the way that last-repeatable-command gets >> set has changed since this code in repeat.el was written? >> > > FWIW, the answer to that question seems to be positive. In Emacs 21 M-! > date RET C-x z repeats "date" without prompting again, in later Emacsen > you get prompted again for a shell command. Ah, thanks for testing. One possible fix is attached. It has the advantage of removing the list which needs to be kept updated, so it works immediately for repeating M-z and M-: -- Sean Whitton --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-repeat.el-repeat-Fix-repeating-complex-commands.patch >From 60bde7beb317601c00d075f356a1b89877ad6104 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Thu, 4 Feb 2021 10:42:21 -0700 Subject: [PATCH] * lisp/repeat.el (repeat): Fix repeating complex commands (bug#46290) --- lisp/repeat.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/repeat.el b/lisp/repeat.el index d488889348..795577c93f 100644 --- a/lisp/repeat.el +++ b/lisp/repeat.el @@ -239,9 +239,7 @@ recently executed command not bound to an input event\"." (car (memq last-command-event (listify-key-sequence repeat-on-final-keystroke)))))) - (if (memq last-repeatable-command '(exit-minibuffer - minibuffer-complete-and-exit - self-insert-and-exit)) + (if (eq last-repeatable-command (caar command-history)) (let ((repeat-command (car command-history))) (repeat-message "Repeating %S" repeat-command) (eval repeat-command)) -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 04 12:53:06 2021 Received: (at control) by debbugs.gnu.org; 4 Feb 2021 17:53:06 +0000 Received: from localhost ([127.0.0.1]:42186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ioR-0004BE-M1 for submit@debbugs.gnu.org; Thu, 04 Feb 2021 12:53:06 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:48047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7ioN-0004Ai-C5 for control@debbugs.gnu.org; Thu, 04 Feb 2021 12:53:02 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 014465C00D1 for ; Thu, 4 Feb 2021 12:52:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 04 Feb 2021 12:52:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=from:to:subject:date:message-id:mime-version:content-type; s= fm2; bh=hFa0JWYmaEumbeGAVxFxNzDiJbmG4wXGt4cItAP+HDQ=; b=SRaD85iC FP6bFHpCuBwj7ynjzH0keRn0AnIcPmx2YCWNqdRsKlfIgLUN/prEKqe3QZU168U6 JQAkqytLwHfnY0hVAHzhXNJcfx4Z+nUdipJy0paf/X1WRCV4b1ymiH1RnFJjySMx 4YbE09R8lxBL2fC4uN0dTA14kNkkFIXE0faoz1QhrbWdzoSoNofMhrqB1+bhuBH2 WjPmBwyMGTqXjZxzybgp1HYEMbc/DGgE70kIy4saXbXeTLDVLNV2o2IwsGLFmspz qsgDn5Xx+V8bAnwfINaArLteoLaR0v4H/GYXT+jNB1DkUaGK4iXQwg5h0DeNboyb LvdYapMF/Jzrkg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=hFa0JWYmaEumbeGAVxFxNzDiJbmG4 wXGt4cItAP+HDQ=; b=giYsfJVN2r3YE7FcmOApcXR55t2OR9W9RJWsG2KYoGYi7 lQFbt3uIyJ8y6UIGvC+2DNW63DVn4+hyOoG1rmAfp4U/FBR8FH/bZJiL2TBQ3fQ6 VSvx8k0/whBvLStFuadKnNsoHocxJTOSK7S2Btkzw2MMqxPXeEPmHe7D2PfBbiEQ 6OBKam00K1oVujX39H7ZfdcZW9xsgHZF9nUy4hJ9EUe18oG1ZY2txVE/W6fInAfz cT3Y1HRKOE+1EG23w08LLwfDA2i6sMbNIob8/ovQ9eVb570J84Ud+rbHaebKrygq 3G6oytR4dbIZBLUb9PPBpGk5PI0Q2p7l8ziV5txZw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeggdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecugfhmphhthicushhusghjvggtthculddutddmnecujf gurhephffvufffkfggtgesthdtredttddttdenucfhrhhomhepufgvrghnucghhhhithht ohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeelleegjeehvdehgeehgfefgedvhfdvfefffeehjedtgeefheffiedtfeet jeeuheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: From: Sean Whitton To: control@debbugs.gnu.org Subject: Date: Thu, 04 Feb 2021 10:53:43 -0700 Message-ID: <871rdv4t3s.fsf@melete.silentflame.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tag 46290 + patch thanks -- Sean Whitton Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.29 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [66.111.4.29 listed in wl.mailspike.net] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) tag 46290 + patch thanks -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 05 04:07:13 2021 Received: (at 46290) by debbugs.gnu.org; 5 Feb 2021 09:07:13 +0000 Received: from localhost ([127.0.0.1]:42759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7x56-0001KF-5O for submit@debbugs.gnu.org; Fri, 05 Feb 2021 04:07:13 -0500 Received: from quimby.gnus.org ([95.216.78.240]:38636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7x53-0001Jp-E9 for 46290@debbugs.gnu.org; Fri, 05 Feb 2021 04:07:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ev0tlpHWCkgE3qjK2HYgFTPtoSBioDFUlIcuLBRe0lk=; b=YJfOir44yjviJWugyed7k9dc0j PKBPxXnLwViGO7KWbGJLgbNdvlU1kYrFQFPHHTjxSnKaD23OPj9bnF2HDVnfRYws5KtInDgRTz+e2 e/CjqKVnCbEHVGGfljUaNUY2vJAbrgwgXYLEkXK7IJAo3SuoSTffU8x6LbEm58wc77kk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7x4u-0000i0-Ek; Fri, 05 Feb 2021 10:07:02 +0100 From: Lars Ingebrigtsen To: Sean Whitton Subject: Re: bug#46290: 28.0.50; repeat's ability to repeat complex commands is broken References: <878s844675.fsf@melete.silentflame.com> <875z374ted.fsf@melete.silentflame.com> X-Now-Playing: Shirley & Dolly Collins's _Harking Back_: "The Bonny Labouring Boy" Date: Fri, 05 Feb 2021 10:06:58 +0100 In-Reply-To: <875z374ted.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 04 Feb 2021 10:47:22 -0700") Message-ID: <87o8gylw7h.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Sean Whitton writes: > One possible fix is attached. It has the advantage of removing the list > which needs to be kept updated, so it works immediately for repeating > M-z and M-: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 46290 Cc: 46290@debbugs.gnu.org, Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > One possible fix is attached. It has the advantage of removing the list > which needs to be kept updated, so it works immediately for repeating > M-z and M-: Seems to work fine here for the test cases, so I've pushed it to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 05 04:07:19 2021 Received: (at control) by debbugs.gnu.org; 5 Feb 2021 09:07:19 +0000 Received: from localhost ([127.0.0.1]:42762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7x5D-0001Kb-6n for submit@debbugs.gnu.org; Fri, 05 Feb 2021 04:07:19 -0500 Received: from quimby.gnus.org ([95.216.78.240]:38652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7x5A-0001KE-4r for control@debbugs.gnu.org; Fri, 05 Feb 2021 04:07:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZmYX+qLk0d2WJi08gxHCQE8vwgUsDu5nwsTY4k1MQls=; b=N/ebp6CCOCS/IM3VybY/3Uqd66 jebCisRQnDbY/IuLfzsCX5P9esFxAO5FLj56KNMmZisYTLX7GthLvkBGr5BX1HIQ+IpEIyejfAP/k ErlQmp4qHtlXQdpZPcanntlIQIl1UsfZs61+P0XKjjHTRqRg2zX7hCKjQlk5fEw2onNA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7x52-0000iB-L1 for control@debbugs.gnu.org; Fri, 05 Feb 2021 10:07:10 +0100 Date: Fri, 05 Feb 2021 10:07:07 +0100 Message-Id: <87mtwilw78.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #46290 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 46290 fixed close 46290 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 46290 fixed close 46290 28.1 quit From unknown Fri Jun 20 20:00:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Mar 2021 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator