GNU bug report logs - #46235
[PATCH] gnu: emacs-rg: Fix use on remote systems.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Clément Lassieur <clement <at> lassieur.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#46235: closed ([PATCH] gnu: emacs-rg: Fix use on remote systems.)
Date: Tue, 02 Feb 2021 08:57:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 02 Feb 2021 09:56:04 +0100
with message-id <87v9ba6e6z.fsf <at> lassieur.org>
and subject line Re: [bug#46235] [PATCH] gnu: emacs-rg: Fix use on remote systems.
has caused the debbugs.gnu.org bug report #46235,
regarding [PATCH] gnu: emacs-rg: Fix use on remote systems.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
46235: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46235
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Clément Lassieur <clement <at> lassieur.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-rg: Fix use on remote systems.
Date: Mon,  1 Feb 2021 13:47:21 +0100

* gnu/packages/emacs-xyz.scm (emacs-rg)[inputs]: Remove.  Move ripgrep to...
[propagated-inputs]: ... here.  This also gives access to ripgrep's manual.
[arguments]: Replace the full path with the executable name.
---
 gnu/packages/emacs-xyz.scm | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 28c7b41d79..ba1865d05f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19,7 +19,7 @@
 ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2017 Christopher Baines <mail <at> cbaines.net>
 ;;; Copyright © 2017, 2018, 2019, 2020 Mathieu Othacehe <m.othacehe <at> gmail.com>
-;;; Copyright © 2017, 2018, 2019, 2020 Clément Lassieur <clement <at> lassieur.org>
+;;; Copyright © 2017, 2018, 2019, 2020, 2021 Clément Lassieur <clement <at> lassieur.org>
 ;;; Copyright © 2017 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;; Copyright © 2017, 2018 Kyle Meyer <kyle <at> kyleam.com>
 ;;; Copyright © 2017 Kei Kebreau <kkebreau <at> posteo.net>
@@ -3848,19 +3848,18 @@ result.")
     (arguments
      '(#:phases
        (modify-phases %standard-phases
-         (add-after 'unpack 'hardcode-rg-path
-           ;; Hardcode the path to ripgrep.
+         (add-after 'unpack 'remove-rg-path
+           ;; Remove the path to ripgrep so that it works on remote systems.
            (lambda _
              (let ((file "rg.el"))
                (chmod file #o644)
                (emacs-substitute-sexps file
-                 ("(defcustom rg-executable" (which "rg")))))))))
+                 ("(defcustom rg-executable" "rg"))))))))
     (propagated-inputs
      `(("emacs-s" ,emacs-s)
        ("emacs-transient" ,emacs-transient)
-       ("emacs-wgrep" ,emacs-wgrep)))
-    (inputs
-     `(("ripgrep" ,ripgrep)))
+       ("emacs-wgrep" ,emacs-wgrep)
+       ("ripgrep" ,ripgrep)))
     (home-page "https://rgel.readthedocs.io/en/latest/")
     (synopsis "Search tool based on @code{ripgrep}")
     (description
-- 
2.30.0

[Message part 3 (message/rfc822, inline)]

From: Clément Lassieur <clement <at> lassieur.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 46235-done <at> debbugs.gnu.org
Subject: Re: [bug#46235] [PATCH] gnu: emacs-rg: Fix use on remote systems.
Date: Tue, 02 Feb 2021 09:56:04 +0100

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,
>
> Clément Lassieur <clement <at> lassieur.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-rg)[inputs]: Remove.  Move ripgrep to...
>> [propagated-inputs]: ... here.  This also gives access to ripgrep's manual.
>> [arguments]: Replace the full path with the executable name.
>
> LGTM!
>
> Regards,

Thanks!  Pushed

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.