GNU bug report logs - #46234
[PATCH] Add new gopkg.in/yaml.v3

Previous Next

Full log

View this message in rfc822 format

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 46234 <at> debbugs.gnu.org
Subject: [bug#46234] [PATCH] Add new gopkg.in/yaml.v3
Date: Fri, 18 Jun 2021 19:29:38 +0000

[Message part 1 (text/plain, inline)]

Hi Xinglu,

I've reviewed your comments and updated the patch, thanks for your time!

On Fri, 18 Jun 2021 at 14:42, Xinglu Chen <public <at> yoctocell.xyz> wrote:
>
> On Mon, Feb 01 2021, Sharlatan Hellseher wrote:
>
> > +(define-public go-gopkg-in-yaml-v3
> > +  (package
> > +    (name "go-gopkg-in-yaml-v3")
> > +    (version "3")
> > +    (source
> > +      (origin
> > +        (method git-fetch)
> > +        (uri (git-reference
> > +               (url "https://gopkg.in/yaml.v3.git")
> > +               (commit (string-append "v" version))))
> > +        (file-name (git-file-name name version))
> > +        (sha256
> > +         (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
> > +    (build-system go-build-system)
> > +    (arguments
> > +     '(#:import-path "gopkg.in/yaml.v3"))
> > +    (native-inputs
> > +     `(("go-gopkg-in-check-v1" ,go-gopkg-in-check-v1)))
> > +    (home-page "https://gopkg.in/yaml.v2")
>                                          ^^
> Shouldn’t this be “https://gopkg.in/yaml.v3”?
>
> > +    (synopsis "YAML reader and writer for the Go language")
> > +    (description
> > +     "This package provides a Go library for encode and decode YAML
> > +values.
> > +
> > +v3 specification difference:
> > +@itemize
> > +@item YAML 1.1 bools (yes/no, on/off) are supported as long as they are
> > +being decoded into a typed bool value.  Otherwise they behave as a string.
> > +Booleans in YAML 1.2 are true/false only.
> > +
> > +@item Octals encode and decode as 0777 per YAML 1.1, rather than 0o777 as
> > +specified in YAML 1.2, because most parsers still use the old format.  Octals in
> > +the 0o777 format are supported though, so new files work.
> > +
> > +@item Does not support base-60 floats.  These are gone from YAML 1.2, and were
> > +actually never supported by this package as it's clearly a poor choice.
> > +@end itemize\n")
> > +
> > +@end itemize\n")
>
> Duplicate lines/syntax error.  I don’t think \n is needed either.
>
> Otherwise, LGTM.



-- 

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[0001-gnu-Add-gopkg.in-yaml.v3.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.