From unknown Sun Jun 22 07:53:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46218: 28.0.50; find-dired errors with non-directory output Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Jan 2021 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 46218@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161212011613147 (code B ref -1); Sun, 31 Jan 2021 19:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jan 2021 19:08:36 +0000 Received: from localhost ([127.0.0.1]:58038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6I5I-0003Pw-HP for submit@debbugs.gnu.org; Sun, 31 Jan 2021 14:08:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:39366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6I5F-0003Pm-On for submit@debbugs.gnu.org; Sun, 31 Jan 2021 14:08:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6I5F-0007t7-G6 for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2021 14:08:29 -0500 Received: from mout.gmx.net ([212.227.17.22]:58583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6I5B-0007hO-R6 for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2021 14:08:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1612120102; bh=gY5N6qxhQ7kxPuAgmHzIny7u/S//zlCN7r92qKobC3Y=; h=X-UI-Sender-Class:From:To:Subject:Date; b=ekSoLuEoNgYFL8pPTodvhnlbQ+RcAkbPJpi+8V6/avgFUIhV9NmU8KNPJrs++13Ug mPdFvna/Gsj0T9o1HAevTfSPhJNshvfSgtcIPYyy4DTEXNBUKgpE7wqrcOSkRWGgsb 4RXs6dHAz3OwoZEHdBagR5AgJh2qzdLForfIDArQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([84.61.246.207]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4Qwg-1m4U6K0PQs-011Sk9 for ; Sun, 31 Jan 2021 20:08:22 +0100 From: Stephen Berman Date: Sun, 31 Jan 2021 20:08:18 +0100 Message-ID: <874kiwylel.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:WUSfyS/qIdGHTTnW7RKiDqj4zTv/vta2TgI1cmE9aPDa5f/3yec ggzvXHpoT+YtXBv0ZL5I6pWRkKuFHqv10RBSDDws19NtaMiZ9B0MBV4RtLapQOC3zIY2f0U LL+U8nPuSsR4TlieIhgDgEzjrzivf7oAdW5ayM/zUFjvkC9kikw82jWaCfwb6DJXKo1de+W wRTj4NmUG5H+ns8gB3QPQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Che+6qtUa7g=:SGuP+YsXtLsswZna/VFmxz FJVgdkKAOergDfgoQfzT3NDVr/2L1v8Gwe5BM9RhbUx6Ul84cAEEGxJDKBXQscQtyV32P2N8V csC5ofxcFswgwpqKlfD5GWN9ofDZ/ky92UE+AwD1ZNZ/V5LaB36faUfK2kS+k8uK+X8ES7SKF YnwSetbvK015UdG6j+UvfIbqqpx2iYxtrEHHWBMzcXHS4s4CCy+8aS3sZ4lmtoo6ZapiPdDfw IQR77cmAyZIh9UaklFtFg5FZUFqe24zVOObMTIGRHn3MeM4MpaI9E3PX6THSV4O2lkL/TX2cx 86jezkfv8hVAh8hVnu5/yuB9qpxK0JWZsXcsMSElWjJg+nost8p1ctY6XJ/smsB4cdl3Yl7F1 1+evYDgPe5Du2mWbD4uAHcUgqVYasWoTVO5NKP1GSJkXcSkwd8eJKPoHPzc4/Hk+GYr6FQ4Js WZHbP1UalsnRaD2/MWWykC2OaA6PPDBix/c9xNiLbbz+QuUru/HOdhZ3KsC3zMvmgxMI54twb tZh8/7nk9gSk5/7KtYctHPq1IXcDU9RuT0vmUuTPnnaTj/DRWOtHjRQvQ6AFf/jL62EQrTFjl X2FCv0e25NqGlbedbIYIN7As/u+cK2Uu800a75OGelr9q9MZhIAQZWpJNb56n3VFEq534A/Bn PzyUZroMiNyFP1v55nhjJepYCVsI7XSlp8Y2+sMhTkhIuzjmTv0TnUvyW0biS+2JZVKYr1oWT IobQwwGLQkVQi0/zHTuVnKdB6uUFSHgVwz7vkUhN6JdHEBCdexUwIwHjcyyDsgc4kTYJjpNeV 7BoLEXOc7ahltPwh8s3vKD2MUSaF7CLzdelPTl8t6QsKsZPT97x+aWjpKRD+6+hvBS0zwAuG3 +ASBmuTHQqiGio1FieRw== Received-SPF: pass client-ip=212.227.17.22; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable 0. emacs -Q 1. In the following find-dired invocation adjust `' to the emacs lisp source directory and then evaluate the sexp: (find-dired "" "-name \"*.el\" -exec grep 'const' {} \";\"") =3D> error in process filter: Invalid use of =E2=80=98\=E2=80=99 in replace= ment text This also happens with Emacs 27 but not with Emacs 26. TL;DR: see the attached patch, justification of which follows. AFAICT this error (which is signalled repeatedly with the above invocation) happens when the find-dired output includes a line containing escaped characters that also matches the regexp for the first five columns of the standard Dired display of directory entries used by find-dired-filter. This function calls replace-match to add spaces to the output, and if the matches contain escaped characters, replace-match raises an error. While escaped characters don't occur in the first five columns of the standard Dired display, they could well occur in non-directory output such as that produced by the above find-dired invocation. It seems that find-dired-filter does not expect such output. (Indeed, by default find-dired does not handle such output well, cf. https://stat.ethz.ch/pipermail/ess-help/2021-January/012868.html, which points out issues with the above find-dired invocation; this prompted me to submit this bug report.) This problem was exposed, or at least made much easier to encounter, by this change: commit fb20043b2fec8e8aff6354ec1396fd5ba688b76b Author: Sebastian Reu=C3=9Fe AuthorDate: Sat Dec 30 12:41:23 2017 +0200 Commit: Eli Zaretskii CommitDate: Sat Dec 30 12:41:23 2017 +0200 Fix output alignment in 'find-dired' for "ls -h" =20=20=20=20 * lisp/find-dired.el (find-dired-filter): Fix alignment of the file size column when the -h ls option is used in 'find-ls-option'. (Bug#29803) index 3b0613b280..bf815d500d 100644 --- a/lisp/find-dired.el +++ b/lisp/find-dired.el @@ -295,7 +295,7 @@ find-dired-filter (l-opt (and (consp find-ls-option) (string-match "l" (cdr find-ls-option)))) (ls-regexp (concat "^ +[^ \t\r\n]+\\( +[^ \t\r\n]+\\) +" - "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9]+\\)"))) + "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[^[:space:]]+\\)"))) (goto-char beg) (insert string) (goto-char beg) When I revert this change, I don't get the error with the above find-dired invocation anymore. But since the change fixed a bug, it can't just be reverted. One alternative is to replace `[^[:space:]]' by something less permissive. In fact, in the bug thread the author of the patch first proposed the more restrictive `[0-9.,]+[kMGT]?' to match the file size column, and indeed, with this the above error does not occur. But he noted that file size could be displayed in various ways, e.g. with the `ls' option `--si', and thus chose the most permissive regexp. But since that can result in the above error, a better alternative would be a compromise between too permissive and possibly too restrictive, e.g.: `[0-9.,]+[[:alpha:]]?'. With this the above error also does not occur and there is also no misalignment, as can be verified by evaluating the following (suitably adjusted) sexp after making this compromise change in find-dired-filter: (let ((find-ls-option '("-exec ls -ldh {} +" . "-ldh"))) (find-dired "" "-type f")) The Dired fields are aligned just as with the permissive regexp and in contrast to the output when using `[0-9]'. But in fact, it appears possible to return to the simple `[0-9]', i.e. reverting the above commit. It turns out that there are cases of misaligned directory lines with find-dired even with the current permissive regexp added by that commit (but also with the above compromise, and of course also with the simple `[0-9]'). Evaluating the following code illustrates this with the output attached below it: (let ((find-ls-option '("-exec ls -ldh {} +" . "-ldh"))) (find-dired "/tmp" "-type f")) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable Content-Description: find-dired output /tmp/: find . \( -type f \) -exec ls -ldh \{\} + find: =E2=80=98./tmp.YhFgsj7n1h=E2=80=99: Permission denied -r--r--r-- 1 root root 11 Jan 31 09:48 .X0-lock -rw------- 1 steve steve 434 Jan 31 09:48 .xfsm-ICE-GF8VX0 -rw------- 1 steve steve 1.3M Jan 31 10:01 Temp-2ef70396-223f-4fd3-= b201-609f73a0034a/mesa_shader_cache/index =20=20 find exited abnormally with code 1 at Sun Jan 31 18:08:37 --=-=-= Content-Type: text/plain (The above code was actually used by the author of the above commit to argue that a more permissive regexp was needed, but in his test run the file owner and group fields were the same for each entry and there was no misalignment.) The misalignment here can be repaired by evaluating `(dired--align-all-files)' in the find-dired output buffer. But it also works to add this sexp to find-dired-sentinel. Doing that thus obviates using the current permissive regexp in find-dired-filter to avoid the misalignment reported in Bug#29803, and also avoids (or rather: repairs) the misalignment just illustrated, but in addition also avoids the replace-match error of the current bug report. In short I propose the following patch: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: find-dired patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/find-dired.el b/lisp/find-dired.el index adc5672eca..7f4d8c0bcd 100644 =2D-- a/lisp/find-dired.el +++ b/lisp/find-dired.el @@ -327,7 +327,7 @@ find-dired-filter (l-opt (and (consp find-ls-option) (string-match "l" (cdr find-ls-option)))) (ls-regexp (concat "^ +[^ \t\r\n]+\\( +[^ \t\r\n]+\\) +" - "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[^[:space:]]+\\)"))) + "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[0-9]+\\)"))) (goto-char beg) (insert string) (goto-char beg) @@ -392,6 +392,7 @@ find-dired-sentinel ;; process is dead, we can delete it now. Otherwise it ;; will stay around until M-x `list-processes'. (delete-process proc) + (dired--align-all-files) (force-mode-line-update)))) (message "find-dired %s finished." buf)))) --=-=-= Content-Type: text/plain Since the current permissive regexp that leads to the error reported here first appeared in Emacs 27, i.e. that change introduced a regression against Emacs 26, the proposed fix (or a better one) should probably be applied to the emacs-27 branch. In GNU Emacs 28.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, cairo version 1.17.3) of 2021-01-29 built on strobe-jhalfs Repository revision: 47147db9b0f40c77657aff625048bbef5d32fb05 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Linux From Scratch SVN-20200401 Configured using: 'configure --with-xwidgets 'CFLAGS=-Og -g3' PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix --=-=-=-- From unknown Sun Jun 22 07:53:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46218: 28.0.50; find-dired errors with non-directory output Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Feb 2021 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 46218@debbugs.gnu.org Received: via spool by 46218-submit@debbugs.gnu.org id=B46218.161219721710177 (code B ref 46218); Mon, 01 Feb 2021 16:34:01 +0000 Received: (at 46218) by debbugs.gnu.org; 1 Feb 2021 16:33:37 +0000 Received: from localhost ([127.0.0.1]:32972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6c8u-0002e4-MX for submit@debbugs.gnu.org; Mon, 01 Feb 2021 11:33:36 -0500 Received: from mout.gmx.net ([212.227.17.22]:34775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6c8r-0002dl-Ai for 46218@debbugs.gnu.org; Mon, 01 Feb 2021 11:33:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1612197207; bh=I2QuBhF7SfiZY5z82l3BxkOrXZOi5nGkitpBl19ZMrw=; h=X-UI-Sender-Class:From:To:Subject:References:Date:In-Reply-To; b=kMhqK7s2dLaE+IeGRrZ1ie22YGDS0hhnSPf08IsbcxxKvj5BVm5VrC7p9HIHcJEkW ei94bd0L78n2BiZ7VQpM8iE5XHR6GLF7psZ0CG8FHmp8K+lqoVAcx602Dtyj2+P33m LEd9ERBlwGAWjQkU9eqhAs7CRRtX/adjtGFyTYpE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([92.73.66.79]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mdvqg-1lhb7I3Eco-00b1ku for <46218@debbugs.gnu.org>; Mon, 01 Feb 2021 17:33:26 +0100 From: Stephen Berman References: <874kiwylel.fsf@rub.de> Date: Mon, 01 Feb 2021 17:33:23 +0100 In-Reply-To: <874kiwylel.fsf@rub.de> (Stephen Berman's message of "Sun, 31 Jan 2021 20:08:18 +0100") Message-ID: <87v9bb694c.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:ny4UME2wXMBpWavpot1oRMm1cje1Fvw6Y47jF5otmUxy7S0dkhK omB9J7Cti/y22ujDBgZ0Zkl3YWgRGc+Z+tl8EaGvj8+QsDKBoEl7cttgzUXrU468Hi+IJzO LwDZU1gMhiqMpwFcoyav8xeQSDwgtoLgs8XExrwaqUQh9Xu1FJlXp9qWykduNfIyK+74AMe axi7Weju5n6uCJWLxtgvA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:SlP3G94gIOQ=:t/rCuZsFiKOwFwvgiuVdu1 bH3RNOW4cyOHDr1Fp+fTxzxd3zozq3emCbKmJkBIFfA1qCSZ2LzbHoB2PxsbnWV0WHpzZqjfe Vh263qNhkDihXxAfNlXeAys/wzJkPb4DfDuwiRAmfFfNeEAVKp/baYyJYAF+2X3Dc13S/WaCG herP2eQ++HmllyqL8yBg7Dmk9w9BsuB7iDD+QpYmNDtnSM7nnODievEDmYWlgt58WDlz0cM3w LNPWAPHvngfRg467GhVbG6DKCmocD8+hdCv4Lzngey9xqInAxTmRcgOj++BI5f8dYIbfgotcj /jIZ+HdE0y8bEHRc6+S9pP1jO9fJ2IvQ+jP7vMF3bDuhdMxpueZeRTnAJkyOMn73tIReEkd44 LhH9s97xCXRhibiWHuxDQ1ZcFpWdRUaAVfxcQ8wGCpFtHCg0LmMlcj2wmChj9jzr5Y0s2587l p+dV4kpQvhbpOedAQJUELyg+/mCUKBpOfNjpxBvexeJaCVbQuRk6j5C8icA/MX/GbJQi3L6qd PpuXJjxM4mDqliBS2kiJoyNP2C8YbGmZY2VTi2CfyJlxCd59HEJgFo8dnEbSItauY2brwmMwa ws4t3+d2s9+k3oqhQ1rLsdnA3Xphwxxh5OnSa5hG+f+FfHun3xn/lIE31lW5YSPtF1eDbbGsK dV3IYGE781evScODZeIYiuzL7ila0Wi9d8/Qxk7pquJOxToY/elpDQeEZdxuO1wB1HaTYKEmV WShGwobDxrheK/fOPlh027smZ0N1P+fnRm28Z1L2Bph+bMZdtbEj29ioR4FKPZIDWcCEcSZmU tKahDWfJbM98yeiKsIf87mkIYsfawFC/IE+0brkOqMIZZXT23HJUJ3wRz+LEuN/DMeRpbpWMU 1+4uqPv5XMoobw7/GNeA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, 31 Jan 2021 20:08:18 +0100 Stephen Berman = wrote: > 0. emacs -Q > 1. In the following find-dired invocation adjust `' to the > emacs lisp source directory and then evaluate the sexp: > (find-dired "" "-name \"*.el\" -exec grep 'const' {} \";\"") > =3D> error in process filter: Invalid use of =E2=80=98\=E2=80=99 in repla= cement text > > This also happens with Emacs 27 but not with Emacs 26. [...] It occurred to me that invoking `(dired--align-all-files)' in find-dired-sentinel might render the realigning code in find-dired-filter superfluous. But it turns out -- if I didn't make a mistake or overlook something in testing -- that simply removing the realigning code in find-dired-filter, without adding `(dired--align-all-files)' to find-dired-sentinel, fixes all the problems reported in this bug as well as in Bug#29803. That is, I am now proposing the following patch instead of the one in my previous post: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: find-dired-filter patch diff --git a/lisp/find-dired.el b/lisp/find-dired.el index adc5672eca..68f7752110 100644 --- a/lisp/find-dired.el +++ b/lisp/find-dired.el @@ -323,11 +323,7 @@ find-dired-filter (save-restriction (widen) (let ((buffer-read-only nil) - (beg (point-max)) - (l-opt (and (consp find-ls-option) - (string-match "l" (cdr find-ls-option)))) - (ls-regexp (concat "^ +[^ \t\r\n]+\\( +[^ \t\r\n]+\\) +" - "[^ \t\r\n]+ +[^ \t\r\n]+\\( +[^[:space:]]+\\)"))) + (beg (point-max))) (goto-char beg) (insert string) (goto-char beg) @@ -342,18 +338,6 @@ find-dired-filter (goto-char (- beg 3)) ; no error if < 0 (while (search-forward " ./" nil t) (delete-region (point) (- (point) 2))) - ;; Pad the number of links and file size. This is a - ;; quick and dirty way of getting the columns to line up - ;; most of the time, but it's not foolproof. - (when l-opt - (goto-char beg) - (goto-char (line-beginning-position)) - (while (re-search-forward ls-regexp nil t) - (replace-match (format "%4s" (match-string 1)) - nil nil nil 1) - (replace-match (format "%9s" (match-string 2)) - nil nil nil 2) - (forward-line 1))) ;; Find all the complete lines in the unprocessed ;; output and process it to add text properties. (goto-char (point-max)) --=-=-=-- From unknown Sun Jun 22 07:53:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#46218: 28.0.50; find-dired errors with non-directory output Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2022 13:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: 46218@debbugs.gnu.org Received: via spool by 46218-submit@debbugs.gnu.org id=B46218.165521396210787 (code B ref 46218); Tue, 14 Jun 2022 13:40:01 +0000 Received: (at 46218) by debbugs.gnu.org; 14 Jun 2022 13:39:22 +0000 Received: from localhost ([127.0.0.1]:33515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o16lN-0002nv-Ot for submit@debbugs.gnu.org; Tue, 14 Jun 2022 09:39:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o16lM-0002ne-J0 for 46218@debbugs.gnu.org; Tue, 14 Jun 2022 09:39:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ps0l8zOC3svbSYRmnVPjwfV3wtzXMqj0XMVo9C2uVvU=; b=Wj78BhHY0/tivvbTB/f74OqKe2 Db/VeiSvtK+C4H6Gr9UsDsMef7GH8/Z2VvAciqT5h2PXO8Vv45htStrGa+j6ZgPweOwJF3eftUZp/ HOQ7eOBBNPwKBMoijisY3k2ZQCmxLBNLK8P8BvqbRB3td+ehd0D7nH60saDtKUMyZJpk=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o16lC-0006yq-M6; Tue, 14 Jun 2022 15:39:13 +0200 From: Lars Ingebrigtsen References: <874kiwylel.fsf@rub.de> <87v9bb694c.fsf@rub.de> X-Now-Playing: Jeanne Moreau's _From Brussels With Love (1)_: "Un Entretien Avec Jeanne Moreau" Date: Tue, 14 Jun 2022 15:39:07 +0200 In-Reply-To: <87v9bb694c.fsf@rub.de> (Stephen Berman's message of "Mon, 01 Feb 2021 17:33:23 +0100") Message-ID: <87ilp3l5z8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > It occurred to me that invoking `(dired--align-all-files)' in > find-dired-sentinel might render the realigning code in > find-dired-filter superfluous. But it turns out -- if I didn't make a > mist [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stephen Berman writes: > It occurred to me that invoking `(dired--align-all-files)' in > find-dired-sentinel might render the realigning code in > find-dired-filter superfluous. But it turns out -- if I didn't make a > mistake or overlook something in testing -- that simply removing the > realigning code in find-dired-filter, without adding > `(dired--align-all-files)' to find-dired-sentinel, fixes all the > problems reported in this bug as well as in Bug#29803. That is, I am > now proposing the following patch instead of the one in my previous > post: Thanks; pushed to Emacs 29 (since it fixes the backtrace), but I have to admit I've never understood what find-dired is supposed to be good for, anyway. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 14 09:39:29 2022 Received: (at control) by debbugs.gnu.org; 14 Jun 2022 13:39:29 +0000 Received: from localhost ([127.0.0.1]:33518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o16lR-0002oC-Vj for submit@debbugs.gnu.org; Tue, 14 Jun 2022 09:39:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o16lR-0002nn-2M for control@debbugs.gnu.org; Tue, 14 Jun 2022 09:39:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bne2a1siB7Xclii/WvIpZSwopwhLvvUwbWit8ZJkl+s=; b=lP0myum8NRSWjdFiiNv222G7QO gHe07EMX5uLShyWU89zxInKtAFPKZC9N7tXki0/aMKzGc3x3dsrxwjUaCGep8IbeOdni1sskCBQUl /EBK2BR1z3jeq8ii8a3ZyxmNwSE0ip1v+Xs6YmFUdUiEf6jAyr4u/fx8El+Ct7RfFTUs=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o16lJ-0006zD-0Q for control@debbugs.gnu.org; Tue, 14 Jun 2022 15:39:19 +0200 Date: Tue, 14 Jun 2022 15:39:16 +0200 Message-Id: <87h74nl5yz.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #46218 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 46218 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 46218 29.1 quit