GNU bug report logs - #46216
[PATCH] Remove duplication in tests/publish.scm

Previous Next

Package: guix-patches;

Reported by: Maxime Devos <maximedevos <at> telenet.be>

Date: Sun, 31 Jan 2021 18:47:01 UTC

Severity: normal

Tags: patch

Full log


View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: 46216 <at> debbugs.gnu.org
Subject: [bug#46216] [PATCH] Remove duplication in tests/publish.scm
Date: Sun, 31 Jan 2021 19:46:02 +0100
[Message part 1 (text/plain, inline)]
Hi Guix!

In https://issues.guix.gnu.org/46214, I proposed
a draft patch for adding a ‘hook’ mechanism to
guix publish.  Now I would like to write some tests.

However, it seems the following construct is duplicated
for many tests:

   (call-with-new-thread
    (lambda ()
      (guix-publish "--port=PORT" et cetera)))
			
This patch series introduces some abstraction.
Currently, there is only one patch yet, but more
will follow.

"make check TESTS=tests/publish.scm" still succeeds.
(Guix version: 23a5dcce1d893b8f5c5301ae3c1af863776ed3cf
with some not-yet-upstreamed changes).

Maxime
-- 
Maxime Devos <maximedevos <at> telenet.be>
PGP Key: C1F3 3EE2 0C52 8FDB 7DD7  011F 49E3 EE22 1917 25EE
Freenode handle: mdevos
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 4 years and 135 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.