GNU bug report logs - #46210
[PATCH] Add drumgizmo

Previous Next

Package: guix-patches;

Reported by: Nicolò Balzarotti <anothersms <at> gmail.com>

Date: Sun, 31 Jan 2021 13:16:02 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 46210 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#46210; Package guix-patches. (Sun, 31 Jan 2021 13:16:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolò Balzarotti <anothersms <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 31 Jan 2021 13:16:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add drumgizmo
Date: Sun, 31 Jan 2021 14:15:23 +0100
[Message part 1 (text/plain, inline)]
Hi guix!

For folks into music production, this patch set adds drumgizmo, an high
quality MIDI drum.  It comes with a standalone application and an LV2
plugin (VST should also be there, but I could not build it).  I tested
both the cli and the lv2 plugin (inside carla) and they work fine.

Along with it, I added dgedit, a drumkit kit editor.

I also added three drumkits.  Those are big (2 to 5Gb), and the build is
just extract+copy, so I don't know if I should add #:substitutable? #f.
There's no standard path for those, so I'm placing them under
share/drumkits/DRUMKIT_NAME.

guix lint does not complain and they all build fine

Thanks!

[0001-gnu-Add-dgedit.patch (text/x-patch, attachment)]
[0002-gnu-Add-drumgizmo.patch (text/x-patch, attachment)]
[0003-gnu-Add-drumgizmo-crocellkit.patch (text/x-patch, attachment)]
[0004-gnu-Add-drumgizmo-dsrkit.patch (text/x-patch, attachment)]
[0005-gnu-Add-drumgizmo-muldjordkit.patch (text/x-patch, attachment)]
[0006-gnu-Add-drumgizmo-aasimonster.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#46210; Package guix-patches. (Sat, 23 Apr 2022 12:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 46210 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Nathan Dehnel <ncdehnel <at> gmail.com>, 55069 <at> debbugs.gnu.org, 
 51395 <at> debbugs.gnu.org, 49008 <at> debbugs.gnu.org, 49028 <at> debbugs.gnu.org, 
 46210 <at> debbugs.gnu.org
Subject: Re: bug#55069: Add some means to find LV2 plugins
Date: Sat, 23 Apr 2022 14:45:54 +0200
[Message part 1 (text/plain, inline)]
> [PATCH] gnu: mda-lv2: Remove unnecessary search-path-specification.

Isn't it currently necessary?  Because lv2 doesn't have a LV2_PATH
search path yet.

Nathan Dehnel schreef op vr 22-04-2022 om 17:13 [-0500]:
> It seems DAWs and plugins can't find each other because there is no
> way to find the plugins outside of the store because there is no
> directory where the plugins are aggregated, and $LV2_PATH isn't set.

I think this would be resolved by adding the search path to the 'lv2'
package (and removing it from lv2-mda-piano, mda-lv2 and calf).

> [PATCH] gnu: Add invada-studio-plugins-lv2.
> [PATCH] gnu: Add distrho-ports-lv2.
> [PATCH] gnu: Add omins-lv2.
> [PATCH] Add drumgizmo

The convention is to add the search paths to the users of the plugins,
not the plugins theirselves.  Cf. GUILE_LOAD_PATH, LIBRARY_PATH,
MINETEST_MOD_PATH, EMACSLOADPATH, INFOPATH ...  See
<https://issues.guix.gnu.org/49533#5>.

The benefit is that this avoids forgetting LV2_PATH for some plugins,
as it only needs to be added to relatively few places (lv2 itself,
maybe guitarix, maybe ir, arour ...).

Greetings,
Maxime
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 51 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.