Subject: Re: [bug#46192] [PATCH 08/22] gnu: Add rust-automod-0.1.

From: Nicolas Goaziou <[email-masked]>
Date: Sat, 30 Jan 2021 18:46:49 +0100

Hello,

aecepoglu <[email-masked]> writes:

> * gnu/packages/crates-io.scm (rust-automod-0.1): New variable

Thank you.

> +(define-public rust-automod-0.1
> +  (package
> +    (name "rust-automod")

It should inherit from rust-automod-1.
> +    (version "0.1.2")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (crate-uri "automod" version))
> +        (file-name
> +          (string-append name "-" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "17am5i7z7jpsrq9bm0wyhf4q9850g2kqvzl3ik900x5gc7brwv2a"))))
> +    (build-system cargo-build-system)
> +    (arguments
> +      `(#:skip-build? #t
> +        #:cargo-inputs
> +        (("rust-proc-macro2" ,rust-proc-macro2-1)
> +         ("rust-quote" ,rust-quote-1)
> +         ("rust-syn" ,rust-syn-1))))
> +    (home-page "https://github.com/dtolnay/automod")
> +    (synopsis "Pull in every source file in a directory as a module.")

The synopsis should not end with a period. I think "guix lint" warns you
about this.

> +    (description "Pull in every source file in a directory as
> a module.")

Could you turn this into a complete sentence, even with the simple
transformation:

  This package pulls in every ...

Regards,
-- 
Nicolas Goaziou