Subject: bug#46192: closed (Re: [bug#46192] [PATCH 21/21] gnu: Add kak-lsp.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 04 Feb 2021 15:14:02 +0000

Your bug report

#46192: [PATCH 01/22] gnu: Add rust-boxfnonce-0.1.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
46192: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46192
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#46192] [PATCH 21/21] gnu: Add kak-lsp.
From: Nicolas Goaziou <[email-masked]>
To: aecepoglu <[email-masked]>
Cc: [email-masked]
Date: Thu, 04 Feb 2021 16:12:57 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

aecepoglu <[email-masked]> writes:

> * gnu/packages/crates-io.scm (kak-lsp): New variable.

Applied, along with all the Rust crates. Thank you!

I add a few notes here, for future contributions:

- Indentation was off in every package. After using the crate importer,
  you need to fix it.

- Some packages had an empty home-page field. The crate importer is not
  always able to extract this information. In that case, you need to get
  it on your own, e.g., by visiting crates.io.

- Non-terminal packages should have #:skip-build? set to #t. In this
  patch set, every package except `kak-lsp' should have this flag on.

- You made `rust-arc-swap-1' inherit from `rust-arc-swap-0.4' but it is
  the other way around. Older packages inherit from recent ones.

- `rust-slog-scope-4' crate was added before its inputs (e.g.,
  `rust-arc-swap').

- `rust-sloggers-1' crate needed to be packaged since it is a Cargo
  input from `kak-lsp'.

- `kak-lsp' would not build because the "text-editors.scm" file was
  missing some #:use-module statements. I suggest to check build using
  "./pre-inst-env" script from the repositiory. See manual for details.

I added a copyright line for you in both "crates-io.scm" and
"text-editors.scm". Let me know if I used a wrong name, I'll change it.

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH 01/22] gnu: Add rust-boxfnonce-0.1.
From: aecepoglu <[email-masked]>
To: [email-masked]
Date: Sat, 30 Jan 2021 17:13:47 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/crates-io.scm (rust-boxfnonce-0.1): New variable.
---
 gnu/packages/crates-io.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 36f0b98112..1729929215 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -4207,6 +4207,29 @@ programs.")
         ("rust-parking" ,rust-parking-1)
         ("rust-waker-fn" ,rust-waker-fn-1))))))
 
+(define-public rust-boxfnonce-0.1
+  (package
+    (name "rust-boxfnonce")
+    (version "0.1.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (crate-uri "boxfnonce" version))
+        (file-name
+          (string-append name "-" version ".tar.gz"))
+        (sha256
+          (base32
+            "09ilf4zyx92hyhkxlsxksfyprzr9iwq5gqqb22aaqr32c8fwp22r"))))
+    (build-system cargo-build-system)
+    (arguments `(#:skip-build? #t))
+    (home-page
+      "https://github.com/stbuehler/rust-boxfnonce")
+    (synopsis "safe FnOnce boxing for rust < 1.35.0")
+    (description
+      "FnOnce boxing for rust. Obsolete since rust 1.35.0 in favour of
+@code{Box<dyn FnOnce(...) -> ...>}")
+    (license license:expat)))
+
 (define-public rust-bresenham-0.1
   (package
     (name "rust-bresenham")
-- 
2.30.0