Subject: Re: bug#46182: [PATCH] lint: Add 'check-git-protocol' checker.

From: Maxim Cournoyer <[email-masked]>
Date: Sun, 22 May 2022 00:15:21 -0400

tags 46182 +moreinfo
thanks

Hello,

Ludovic Courtès <[email-masked]> writes:

> Hi!
>
> Leo Famulari <[email-masked]> skribis:
>
>> We could also make it warn about use of the HTTP protocol (as opposed to
>> HTTPS). Your thoughts?
>>
>> * guix/lint.scm (check-git-protocol): New procedure.
>> (%local-checkers): Add 'git-protocol' checker.
>> * doc/guix.texi (Invoking guix lint): Document it.
>
> Nice!  I think it’s OK to use ‘eqv?’ here (‘eq?’, even).
>
> One nit: it would be nice to add a positive and a negative test in
> tests/lint.scm.  You can run “make check TESTS=tests/lint.scm” then.
>
> Otherwise LGTM!

Gentle ping to Leo :-).

It looks near ready.

Thank you!

Maxim